Commits · 2da03e54a99527ec502620bdd98f4fff88719f02 · abdullh.alsoleman / Front-End

10 Sep, 2023 4 commits

Roll Flutter Engine from 47d1a045d140 to a2af0c6965be (1 revision) (#134375) · 2da03e54

engine-flutter-autoroll authored Sep 10, 2023

https://github.com/flutter/engine/compare/47d1a045d140...a2af0c6965be

2023-09-10 skia-flutter-autoroll@skia.org Roll Skia from 1bb0f15f2cff to 4eea73a072d3 (1 revision) (flutter/engine#45623)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

2da03e54

Native assets support for MacOS and iOS (#130494) · aa36db1d

Daco Harkes authored Sep 10, 2023

Support for FFI calls with `@Native external` functions through Native assets on MacOS and iOS. This enables bundling native code without any build-system boilerplate code.

For more info see:

* https://github.com/flutter/flutter/issues/129757

### Implementation details for MacOS and iOS.

Dylibs are bundled by (1) making them fat binaries if multiple architectures are targeted, (2) code signing these, and (3) copying them to the frameworks folder. These steps are done manual rather than via CocoaPods. CocoaPods would have done the same steps, but (a) needs the dylibs to be there before the `xcodebuild` invocation (we could trick it, by having a minimal dylib in the place and replace it during the build process, that works), and (b) can't deal with having no dylibs to be bundled (we'd have to bundle a dummy dylib or include some dummy C code in the build file).

The dylibs are build as a new target inside flutter assemble, as that is the moment we know what build-mode and architecture to target.

The mapping from asset id to dylib-path is passed in to every kernel compilation path. The interesting case is hot-restart where the initial kernel file is compiled by the "inner" flutter assemble, while after hot restart the "outer" flutter run compiled kernel file is pushed to the device. Both kernel files need to contain the mapping. The "inner" flutter assemble gets its mapping from the NativeAssets target which builds the native assets. The "outer" flutter run get its mapping from a dry-run invocation. Since this hot restart can be used for multiple target devices (`flutter run -d all`) it contains the mapping for all known targets.

### Example vs template

The PR includes a new template that uses the new native assets in a package and has an app importing that. Separate discussion in: https://github.com/flutter/flutter/issues/131209.

### Tests

This PR adds new tests to cover the various use cases.

* dev/devicelab/bin/tasks/native_assets_ios.dart
* Runs an example app with native assets in all build modes, doing hot reload and hot restart in debug mode.
* dev/devicelab/bin/tasks/native_assets_ios_simulator.dart
* Runs an example app with native assets, doing hot reload and hot restart.
* packages/flutter_tools/test/integration.shard/native_assets_test.dart
* Runs (incl hot reload/hot restart), builds, builds frameworks for iOS, MacOS and flutter-tester.
* packages/flutter_tools/test/general.shard/build_system/targets/native_assets_test.dart
* Unit tests the new Target in the backend.
* packages/flutter_tools/test/general.shard/ios/native_assets_test.dart
* packages/flutter_tools/test/general.shard/macos/native_assets_test.dart
* Unit tests the native assets being packaged on a iOS/MacOS build.

It also extends various existing tests:

* dev/devicelab/bin/tasks/module_test_ios.dart
* Exercises the add2app scenario.
* packages/flutter_tools/test/general.shard/features_test.dart
* Unit test the new feature flag.

aa36db1d

Roll Flutter Engine from feea98d6d0ae to 47d1a045d140 (1 revision) (#134368) · 690800bc

engine-flutter-autoroll authored Sep 10, 2023

https://github.com/flutter/engine/compare/feea98d6d0ae...47d1a045d140

2023-09-10 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from 51fG0shrG6fW64BtN... to VciXahwZgiusifyh8... (flutter/engine#45620)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from 51fG0shrG6fW to VciXahwZgius

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

690800bc

Roll Flutter Engine from 4edbefa5e8f7 to feea98d6d0ae (1 revision) (#134365) · 8919140c

engine-flutter-autoroll authored Sep 10, 2023

https://github.com/flutter/engine/compare/4edbefa5e8f7...feea98d6d0ae

2023-09-10 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from i9IPFS-XpkPjlH235... to U70-bvYinYjKdGGSt... (flutter/engine#45618)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from i9IPFS-XpkPj to U70-bvYinYjK

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

8919140c

09 Sep, 2023 12 commits

SelectableRegion onSelectionChange should be called when the selection changes (#134215) · 2c477b18

Renzo Olivares authored Sep 09, 2023

This change makes sure to call `onSelectionChange` in all cases when selection might change including:
* Dragging selection handles
* Mouse drag to select
* Keyboard actions
* Long press drag to select

2c477b18

Roll Flutter Engine from b8afb6deacf3 to 4edbefa5e8f7 (1 revision) (#134360) · c7665ff8

engine-flutter-autoroll authored Sep 09, 2023

https://github.com/flutter/engine/compare/b8afb6deacf3...4edbefa5e8f7

2023-09-09 skia-flutter-autoroll@skia.org Roll Skia from 386c7a6a56fd to 1bb0f15f2cff (1 revision) (flutter/engine#45615)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

c7665ff8

Roll Flutter Engine from d1913cb6a276 to b8afb6deacf3 (1 revision) (#134356) · cc317dff

engine-flutter-autoroll authored Sep 09, 2023

https://github.com/flutter/engine/compare/d1913cb6a276...b8afb6deacf3

2023-09-09 skia-flutter-autoroll@skia.org Roll Skia from 58e39bd84ab2 to 386c7a6a56fd (1 revision) (flutter/engine#45614)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

cc317dff

Roll Flutter Engine from 4e3231af6efc to d1913cb6a276 (1 revision) (#134355) · 7c28e8eb

engine-flutter-autoroll authored Sep 09, 2023

https://github.com/flutter/engine/compare/4e3231af6efc...d1913cb6a276

2023-09-09 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from RbgNQ_B-mcwvmNSq3... to 51fG0shrG6fW64BtN... (flutter/engine#45612)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from RbgNQ_B-mcwv to 51fG0shrG6fW

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

7c28e8eb

Roll Flutter Engine from 348e3a376807 to 4e3231af6efc (1 revision) (#134353) · 6660cc98

engine-flutter-autoroll authored Sep 09, 2023

https://github.com/flutter/engine/compare/348e3a376807...4e3231af6efc

2023-09-09 skia-flutter-autoroll@skia.org Roll Skia from 3dfd4316b80d to 58e39bd84ab2 (1 revision) (flutter/engine#45610)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

6660cc98

Day picker should dispose created MaterialStatesController's. (#133884) · 55558367
Polina Cherkasova authored Sep 09, 2023
```
Fixes https://github.com/flutter/flutter/issues/133862
```
55558367

Roll Flutter Engine from 00ef109b845e to 348e3a376807 (1 revision) (#134349) · 3f4ee3fb

engine-flutter-autoroll authored Sep 09, 2023

https://github.com/flutter/engine/compare/00ef109b845e...348e3a376807

2023-09-09 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from jYqYNRum5gWGFyoHR... to i9IPFS-XpkPjlH235... (flutter/engine#45609)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from jYqYNRum5gWG to i9IPFS-XpkPj

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

3f4ee3fb

Roll Flutter Engine from 7af8a5d8d556 to 00ef109b845e (1 revision) (#134336) · 2b642822

engine-flutter-autoroll authored Sep 09, 2023

https://github.com/flutter/engine/compare/7af8a5d8d556...00ef109b845e

2023-09-09 skia-flutter-autoroll@skia.org Roll Skia from e5987e341cfd to 3dfd4316b80d (1 revision) (flutter/engine#45607)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

2b642822

Roll Flutter Engine from 1f2da3d69da7 to 7af8a5d8d556 (2 revisions) (#134332) · 12ce42b7

engine-flutter-autoroll authored Sep 09, 2023

https://github.com/flutter/engine/compare/1f2da3d69da7...7af8a5d8d556

2023-09-09 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from h_bQLstuirD8blCZW... to RbgNQ_B-mcwvmNSq3... (flutter/engine#45603)
2023-09-09 skia-flutter-autoroll@skia.org Roll ANGLE from fce1e57401bf to 48e2c605adcd (2 revisions) (flutter/engine#45602)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from h_bQLstuirD8 to RbgNQ_B-mcwv

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

12ce42b7

Roll Flutter Engine from 3a5f3ad1d054 to 1f2da3d69da7 (1 revision) (#134328) · e5d919ca

engine-flutter-autoroll authored Sep 09, 2023

https://github.com/flutter/engine/compare/3a5f3ad1d054...1f2da3d69da7

2023-09-09 30870216+gaaclarke@users.noreply.github.com Makes Skia's vkQueueSubmit threadsafe. (flutter/engine#45459)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

e5d919ca

Roll Flutter Engine from d6aa2d9061c1 to 3a5f3ad1d054 (3 revisions) (#134327) · 0c2f1af0

engine-flutter-autoroll authored Sep 09, 2023

https://github.com/flutter/engine/compare/d6aa2d9061c1...3a5f3ad1d054

2023-09-09 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from KvtLknmg3f23uqWVm... to jYqYNRum5gWGFyoHR... (flutter/engine#45599)
2023-09-09 skia-flutter-autoroll@skia.org Roll Skia from 7f1d86d81d41 to e5987e341cfd (1 revision) (flutter/engine#45597)
2023-09-08 skia-flutter-autoroll@skia.org Roll ANGLE from 98b0855b9a71 to fce1e57401bf (3 revisions) (flutter/engine#45596)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from KvtLknmg3f23 to jYqYNRum5gWG

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

0c2f1af0

Roll Flutter Engine from 66bec85d5005 to d6aa2d9061c1 (1 revision) (#134324) · 996eb112

engine-flutter-autoroll authored Sep 09, 2023

https://github.com/flutter/engine/compare/66bec85d5005...d6aa2d9061c1

2023-09-08 skia-flutter-autoroll@skia.org Roll Skia from 1012ef8349ba to 7f1d86d81d41 (1 revision) (flutter/engine#45594)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

996eb112

08 Sep, 2023 24 commits

Roll Flutter Engine from 8d2892211366 to 66bec85d5005 (3 revisions) (#134321) · 9c210237

engine-flutter-autoroll authored Sep 08, 2023

https://github.com/flutter/engine/compare/8d2892211366...66bec85d5005

2023-09-08 skia-flutter-autoroll@skia.org Roll ANGLE from 765bca2f810a to 98b0855b9a71 (1 revision) (flutter/engine#45589)
2023-09-08 skia-flutter-autoroll@skia.org Roll Skia from 4996cc1ef9ba to 1012ef8349ba (1 revision) (flutter/engine#45588)
2023-09-08 skia-flutter-autoroll@skia.org Roll ANGLE from a507f31285b8 to 765bca2f810a (1 revision) (flutter/engine#45587)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

9c210237

Roll Flutter Engine from 2da727e23518 to 8d2892211366 (1 revision) (#134316) · 9dde2166

engine-flutter-autoroll authored Sep 08, 2023

https://github.com/flutter/engine/compare/2da727e23518...8d2892211366

2023-09-08 skia-flutter-autoroll@skia.org Roll Skia from 244c9ba5d0d7 to 4996cc1ef9ba (2 revisions) (flutter/engine#45586)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

9dde2166

Fix memory leak in _DraggableScrollableSheetState (#134212) · 5d5da388
Kostia Sokolovskyi authored Sep 08, 2023

5d5da388
RestorationManager should dispatch creation in constructor. (#133911) · 834f5dc2
Polina Cherkasova authored Sep 08, 2023

834f5dc2
Remove TextPainter migration flag from the framework (#134274) · 621ad987
LongCatIsLooong authored Sep 08, 2023
```
The migration flag in `ParagraphBuilder` will be removed next.
```
621ad987

InputDecoration.error should activate error state (#134001) · 97cdc0ec

Renzo Olivares authored Sep 08, 2023

When passed an `error` widget, `InputDecoration` should activate its error state. Before this change the `errorBorder` would only activate if an `errorText` was provided. This change solves this issue by accounting for a provided `error` widget.

97cdc0ec

Roll Flutter Engine from b2cb1d271a88 to 2da727e23518 (1 revision) (#134314) · fa9c301a

engine-flutter-autoroll authored Sep 08, 2023

https://github.com/flutter/engine/compare/b2cb1d271a88...2da727e23518

2023-09-08 skia-flutter-autoroll@skia.org Roll Skia from 948959b6b53e to 244c9ba5d0d7 (2 revisions) (flutter/engine#45584)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

fa9c301a

Update chip docs to clarify how to specify a shape with no border & explain... · 90c524dc

Taha Tesser authored Sep 08, 2023

Update chip docs to clarify how to specify a shape with no border & explain default values for Material 3 (#134298)

fixes [Update chip docs for Material 3 defaults.](https://github.com/flutter/flutter/issues/134296)

Addresses a [comment](https://github.com/flutter/flutter/pull/133856#discussion_r1313513284) from @HansMuller as well

90c524dc

Add ios analyzer command for universal links (#134155) · f851e7fa
chunhtai authored Sep 08, 2023
```
ios version of https://github.com/flutter/flutter/pull/131009/files
```
f851e7fa

Roll Flutter Engine from 47a79306eed3 to b2cb1d271a88 (5 revisions) (#134313) · 2f66f25f

engine-flutter-autoroll authored Sep 08, 2023

https://github.com/flutter/engine/compare/47a79306eed3...b2cb1d271a88

2023-09-08 skia-flutter-autoroll@skia.org Roll Skia from 5181fcf6184e to 948959b6b53e (4 revisions) (flutter/engine#45583)
2023-09-08 gspencergoog@users.noreply.github.com Remove usage of the Jazzy document formatter for Objective C, in favor of Doxygen. (flutter/engine#45561)
2023-09-08 skia-flutter-autoroll@skia.org Roll ANGLE from 83030fed595b to a507f31285b8 (1 revision) (flutter/engine#45582)
2023-09-08 skia-flutter-autoroll@skia.org Roll Skia from 5b1e40fc0548 to 5181fcf6184e (2 revisions) (flutter/engine#45580)
2023-09-08 matanlurey@users.noreply.github.com Document and provide small cleanups to `CommandPoolVk`. (flutter/engine#45558)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

2f66f25f

Roll Flutter Engine from 6d6b44886175 to 47a79306eed3 (2 revisions) (#134310) · d73e1b69

engine-flutter-autoroll authored Sep 08, 2023

https://github.com/flutter/engine/compare/6d6b44886175...47a79306eed3

2023-09-08 skia-flutter-autoroll@skia.org Roll Skia from c5e67d222f46 to 5b1e40fc0548 (5 revisions) (flutter/engine#45578)
2023-09-08 skia-flutter-autoroll@skia.org Roll ANGLE from 65ec697f4183 to 83030fed595b (1 revision) (flutter/engine#45577)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

d73e1b69

Marks Linux_android very_long_picture_scrolling_perf__e2e_summary to be unflaky (#134116) · da676f79

Flutter GitHub Bot authored Sep 08, 2023

<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Linux_android very_long_picture_scrolling_perf__e2e_summary"
}
-->
The test has been passing for [50 consecutive
runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Linux_android%20very_long_picture_scrolling_perf__e2e_summary%22).
This test can be marked as unflaky.

da676f79

Make `CupertinoTextField` at least as tall as its first line of placeholder (#134198) · 804a7b28
LongCatIsLooong authored Sep 08, 2023
```
Fixes https://github.com/flutter/flutter/issues/133241
and some CupertinoTextField cleanup.
```
804a7b28

Roll Flutter Engine from f09a139101c3 to 6d6b44886175 (3 revisions) (#134306) · fc671188

engine-flutter-autoroll authored Sep 08, 2023

https://github.com/flutter/engine/compare/f09a139101c3...6d6b44886175

2023-09-08 skia-flutter-autoroll@skia.org Roll Skia from 71e40cc0faf6 to c5e67d222f46 (4 revisions) (flutter/engine#45576)
2023-09-08 rmolivares@renzo-olivares.dev [Web] Fix insertions/deletions at inverted selection for TextEditingDeltas (flutter/engine#44693)
2023-09-08 skia-flutter-autoroll@skia.org Roll Skia from ece9f3a15b08 to 71e40cc0faf6 (1 revision) (flutter/engine#45575)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

fc671188

Update links to iOS embedder docs to point to new Doxygen docs (#134246) · 3ce6174e

Greg Spencer authored Sep 08, 2023

## Description

Now that we are using Doxygen for building docs for the embedders, this updates the links to point to the correct URLs.

## Related Issues
 - https://github.com/flutter/flutter/issues/124833

## Related PRs
 - https://github.com/flutter/engine/pull/45561

3ce6174e

Roll Packages from 22d475491502 to aaae5ef97a45 (7 revisions) (#134301) · 53017f85

engine-flutter-autoroll authored Sep 08, 2023

https://github.com/flutter/packages/compare/22d475491502...aaae5ef97a45

2023-09-08 43054281+camsim99@users.noreply.github.com [tool] Add Android dependency (gradle) option to update dependencies command (flutter/packages#4757)
2023-09-08 43054281+camsim99@users.noreply.github.com [camerax] Implement resolution configuration (flutter/packages#3799)
2023-09-07 engine-flutter-autoroll@skia.org Manual roll Flutter from 685ce14b to aea4552a (64 revisions) (flutter/packages#4870)
2023-09-07 ditman@gmail.com [rfw, ci] Regenerate goldens, manually roll #4835 (flutter/packages#4862)
2023-09-07 49699333+dependabot[bot]@users.noreply.github.com Bump actions/checkout from 3.6.0 to 4.0.0 (flutter/packages#4845)
2023-09-07 defuncart@gmail.com [video_player] Add optional web options [web] (flutter/packages#4551)
2023-09-07 me@nils.re [flutter_markdown] Remove `ignore: avoid_init_to_null` since the package uses Dart 3 (flutter/packages#4852)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

53017f85

Roll Flutter Engine from c38feb382e96 to f09a139101c3 (1 revision) (#134299) · 7b06874e

engine-flutter-autoroll authored Sep 08, 2023

https://github.com/flutter/engine/compare/c38feb382e96...f09a139101c3

2023-09-08 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 33DToYd0jNpWX1jNv... to KvtLknmg3f23uqWVm... (flutter/engine#45573)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from 33DToYd0jNpW to KvtLknmg3f23

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

7b06874e

Roll Flutter Engine from f146d4bf244b to c38feb382e96 (1 revision) (#134293) · 2681e873

engine-flutter-autoroll authored Sep 08, 2023

https://github.com/flutter/engine/compare/f146d4bf244b...c38feb382e96

2023-09-08 skia-flutter-autoroll@skia.org Roll ANGLE from e60556f75b68 to 65ec697f4183 (1 revision) (flutter/engine#45572)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

2681e873

Roll Flutter Engine from a140ab4a4ec6 to f146d4bf244b (1 revision) (#134290) · 2d9680ba

engine-flutter-autoroll authored Sep 08, 2023

https://github.com/flutter/engine/compare/a140ab4a4ec6...f146d4bf244b

2023-09-08 whesse@google.com Add dart2wasm dependency to flutter_frontend_server (flutter/engine#45570)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

2d9680ba

Roll Flutter Engine from ea1d0d28e26f to a140ab4a4ec6 (5 revisions) (#134288) · 0ddfe909

engine-flutter-autoroll authored Sep 08, 2023

https://github.com/flutter/engine/compare/ea1d0d28e26f...a140ab4a4ec6

2023-09-08 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from EuBfOtm5TZIdgNaQe... to h_bQLstuirD8blCZW... (flutter/engine#45571)
2023-09-08 skia-flutter-autoroll@skia.org Roll ANGLE from 99d39241ad4d to e60556f75b68 (1 revision) (flutter/engine#45569)
2023-09-08 bdero@google.com [Impeller] Aiks image filters; allow setting effect transforms after FilterContents instantiation. (flutter/engine#45530)
2023-09-08 skia-flutter-autoroll@skia.org Roll Skia from ce3ec572ae77 to ece9f3a15b08 (1 revision) (flutter/engine#45568)
2023-09-08 skia-flutter-autoroll@skia.org Roll Skia from fb4faa8646f8 to ce3ec572ae77 (1 revision) (flutter/engine#45567)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from EuBfOtm5TZId to h_bQLstuirD8

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

0ddfe909

fix a Scrollbar example crash (#127925) · f4707c2b

xubaolin authored Sep 08, 2023

Fix a scrollbar example crash.
https://api.flutter.dev/flutter/material/Scrollbar-class.html#material.Scrollbar.1

f4707c2b

Fix `Drawer` examples are missing `dartpad` tag (#134219) · bb8de216

Taha Tesser authored Sep 08, 2023

fixes [`Drawer` examples are misssing `dartpad` tag]( https://github.com/flutter/flutter/issues/134217)

these examples were updated in https://github.com/flutter/flutter/pull/130523

bb8de216

Roll Flutter Engine from 4ac4429a206b to ea1d0d28e26f (1 revision) (#134270) · fa113358

engine-flutter-autoroll authored Sep 08, 2023

https://github.com/flutter/engine/compare/4ac4429a206b...ea1d0d28e26f

2023-09-08 skia-flutter-autoroll@skia.org Roll Skia from 658025e9efdd to fb4faa8646f8 (1 revision) (flutter/engine#45564)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

fa113358

Roll Flutter Engine from df3965a55fd8 to 4ac4429a206b (1 revision) (#134267) · 1c3c0f8a

engine-flutter-autoroll authored Sep 08, 2023

https://github.com/flutter/engine/compare/df3965a55fd8...4ac4429a206b

2023-09-08 skia-flutter-autoroll@skia.org Roll Skia from 1b8a25d05c45 to 658025e9efdd (1 revision) (flutter/engine#45563)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

1c3c0f8a