Commits · 2cedd559bb9798ac1ba09f0ee959a2dcb1388644 · abdullh.alsoleman / Front-End

29 Oct, 2019 7 commits

419f5d594 Roll src/third_party/skia 1beb8ae9a2f5..f22dda960136 (11 commits)... · 2cedd559

engine-flutter-autoroll authored Oct 29, 2019

419f5d594 Roll src/third_party/skia 1beb8ae9a2f5..f22dda960136 (11 commits) (flutter/engine#13409) (#43698)

git@github.com:flutter/engine.git/compare/25563a12cab1...419f5d594afc

git log 25563a12cab1..419f5d594afc --no-merges --oneline
2019-10-29 skia-flutter-autoroll@skia.org Roll src/third_party/skia 1beb8ae9a2f5..f22dda960136 (11 commits) (flutter/engine#13409)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

2cedd559

Roll engine 49971e21402e..25563a12cab1 (7 commits) (#43695) · 4a0401ff

engine-flutter-autoroll authored Oct 29, 2019

git@github.com:flutter/engine.git/compare/49971e21402e...25563a12cab1

git log 49971e21402e..25563a12cab1 --no-merges --oneline
2019-10-29 iska.kaushik@gmail.com Update recipe_changelog to account for dart_aot runner and clobbering
2019-10-28 iska.kaushik@gmail.com Revert "[flutter_runner] Don't build far files twice (#13397)" (flutter/engine#13400)
2019-10-28 matthew-carroll@users.noreply.github.com Remove multiplexed Flutter Android Lifecycle. (#43663) (flutter/engine#13394)
2019-10-28 iska.kaushik@gmail.com [flutter_runner] Don't build far files twice (flutter/engine#13397)
2019-10-28 chinmaygarde@google.com Delay metal drawable acquisition till frame submission. (flutter/engine#13367)
2019-10-28 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from 9MM-e... to mc3jR... (flutter/engine#13390)
2019-10-28 bkonyi@google.com Roll src/third_party/dart 5e39817ec7..e1fce75301 (2 commits)

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

4a0401ff

Pass environment variables through to xcodebuild (#43553) · 01dc19b9
Jenn Magder authored Oct 29, 2019

01dc19b9
Remove Poller class from flutter_tools (#43685) · 19e551c7
Jonah Williams authored Oct 29, 2019

19e551c7
Revert: Migrate examples to the new embedding (#43689) · ea4da39f
Emmanuel Garcia authored Oct 29, 2019

ea4da39f

Roll engine c3b63d610b07..49971e21402e (3 commits) (#43673) · f41becf5

engine-flutter-autoroll authored Oct 29, 2019

git@github.com:flutter/engine.git/compare/c3b63d610b07...49971e21402e

git log c3b63d610b07..49971e21402e --no-merges --oneline
2019-10-28 yjbanov@google.com Implement basic Picture.toImage via BitmapCanvas (flutter/engine#13391)
2019-10-28 chinmaygarde@google.com Switch the MacOS Desktop embedder to using a thread configuration where the platform and render task runners are the same. (flutter/engine#13300)
2019-10-28 skia-flutter-autoroll@skia.org Roll src/third_party/skia 18f5b1a6dd77..1beb8ae9a2f5 (9 commits) (flutter/engine#13392)

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

f41becf5

Fix device lab tests (#43675) · 910b8ee1
Emmanuel Garcia authored Oct 29, 2019

910b8ee1

28 Oct, 2019 29 commits

Add missing import (#43674) · 5bec33f4
Emmanuel Garcia authored Oct 28, 2019

5bec33f4
Added note about design doc template. (#43658) · 56e3c0c6
gaaclarke authored Oct 28, 2019
```
* Added note about design doc template.

* switched "our" to "flutter"

* updated link
```
56e3c0c6
Catch failed startup error from build_daemon (#43598) · e25cd84a
Jonah Williams authored Oct 28, 2019

e25cd84a
Support platform-specific test lines (#43458) · 7de800c4
Ian Hickson authored Oct 28, 2019

7de800c4
CupertinoTheme & CupertinoTextTheme dark mode updates (#41859) · 4ac2daf3
LongCatIsLooong authored Oct 28, 2019

4ac2daf3
Reland: Migrate examples new embedding (#43643) · 20e015ff
Emmanuel Garcia authored Oct 28, 2019
```
* Fix device lab tests

* Migrate examples to the Android embedding v2 (#43221)
```
20e015ff
Use PRODUCT_BUNDLE_IDENTIFIER from buildSettings to find correct bundle id on... · ccfdf95c
knaeckeKami authored Oct 28, 2019
```
Use PRODUCT_BUNDLE_IDENTIFIER from buildSettings to find correct bundle id on iOS when using flavors (#42964)
```
ccfdf95c
Alias upgrade-packages => update-packages (#43546) · f7d78d5b
Jenn Magder authored Oct 28, 2019
```
* Alias upgrade-packages => update-packages

* Trailing whitespace
```
f7d78d5b
Add enableSuggestions flag to TextField and TextFormField (#42550) · 6e888dac
Justin McCandless authored Oct 28, 2019
```
This flag controls Android's keyboard suggestions on/off
```
6e888dac

Roll engine 728e473f1a4b..c3b63d610b07 (2 commits) (#43661) · 98bc378d

engine-flutter-autoroll authored Oct 28, 2019

git@github.com:flutter/engine.git/compare/728e473f1a4b...c3b63d610b07

git log 728e473f1a4b..c3b63d610b07 --no-merges --oneline
2019-10-28 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from urhvj... to sLCwg... (flutter/engine#13389)
2019-10-28 bkonyi@google.com Roll src/third_party/dart 5b7c981086..5e39817ec7 (2 commits)

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

98bc378d

Change PopupMenuButton.icon type to Widget (#43526) · e903485d
creativecreatorormaybenot authored Oct 28, 2019

e903485d

Implement AlertDialog title/content overflow scroll (#43226) · c461ff9d

Shi-Hao Hong authored Oct 28, 2019

* Wrap alert dialog title and content in single child scroll view

* Scrollable alert dialog title and content tests

* Remove unnecessary comment

* Fix mainAxisSize and crossAxisAlignment issue

c461ff9d

Improve DropdownButton assert message (#43511) · 036c102c
Shi-Hao Hong authored Oct 28, 2019
```
- Adds an assert message checking for exactly one unique value for `DropdownItem`s
```
036c102c

Roll engine 869b74eb4eca..728e473f1a4b (2 commits) (#43652) · c08de65b

engine-flutter-autoroll authored Oct 28, 2019

git@github.com:flutter/engine.git/compare/869b74eb4eca...728e473f1a4b

git log 869b74eb4eca..728e473f1a4b --no-merges --oneline
2019-10-28 garyq@google.com Pass LinearTextFlat to SkFont - iOS13 letter spacing (flutter/engine#13321)
2019-10-28 skia-flutter-autoroll@skia.org Roll src/third_party/skia 428b5de64a08..18f5b1a6dd77 (1 commits) (flutter/engine#13387)

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

c08de65b

Enable tests that failed due to CupertinoDynamicColor (#43636) · f5f24a6c
Yegor authored Oct 28, 2019

f5f24a6c

Revert "Re-Land: Add focus nodes, hover, and shortcuts to switches,... · 38f2d276

Greg Spencer authored Oct 28, 2019

Revert "Re-Land: Add focus nodes, hover, and shortcuts to switches, checkboxes, and radio buttons. (#43384)" (#43647)

This reverts commit 8017f63b, since it breaks web tests.

38f2d276

Add more structure to errors (continuation of #34684) (#42640) · b31ca1aa

Albertus Angga Raharja authored Oct 28, 2019

* Add structured errors in Animations, TabView, ChangeNotifier

* Add structured error on MaterialPageRoute, BoxBorder, DecorationImagePainter, TextSpan

* Add structured errors in Debug

* Fix test errors

* Add structured errors in Scaffold and Stepper

* Add structured errors in part of Rendering Layer

* Fix failing test due to FloatingPoint precision

* Fix failing tests due to precision error and not using final

* Fix failing test due to floating precision error with RegEx instead

* Add structured error in CustomLayout and increase test coverage

* Add structured error & its test in ListBody

* Add structured error in ProxyBox and increase test coverage

* Add structured error message in Viewport

* Fix styles and add more assertions on ErrorHint and DiagnosticProperty

* Add structured error in scheduler/binding and scheduler/ticker
Signed-off-by: Albertus Angga Raharja <albertusangga@google.com>

* Add structured error in AssetBundle and TextInput
Signed-off-by: Albertus Angga Raharja <albertusangga@google.com>

* Add structured errors in several widgets #1
Signed-off-by: Albertus Angga Raharja <albertusangga@google.com>

* Remove unused import
Signed-off-by: Albertus Angga Raharja <albertusangga@google.com>

* Add assertions on hint messages
Signed-off-by: Albertus Angga Raharja <albertusangga@google.com>

* Fix catch spacing
Signed-off-by: Albertus Angga Raharja <albertusangga@google.com>

* Add structured error in several widgets part 2 and increase code coverage
Signed-off-by: Albertus Angga Raharja <albertusangga@google.com>

* Add structured error in flutter_test/widget_tester

* Fix floating precision accuracy by using RegExp
Signed-off-by: Albertus Angga Raharja <albertusangga@google.com>

* Remove todo to add tests in Scaffold showBottomSheet
Signed-off-by: Albertus Angga Raharja <albertusangga@google.com>

* Fix reviews by indenting lines and fixing the assertion orders
Signed-off-by: Albertus Angga Raharja <albertusangga@google.com>

* Fix failing tests due to renaming class
Signed-off-by: Albertus Angga Raharja <albertusangga@google.com>

* Try skipping the NetworkBundleTest
Signed-off-by: Albertus Angga Raharja <albertusangga@google.com>

* Remove leading space in material/debug error hint
Signed-off-by: Albertus Angga Raharja <albertusangga@google.com>

b31ca1aa

Make DropdownButton's disabledHint and hint behavior consistent (#42479) · 734ddd31

Shi-Hao Hong authored Oct 28, 2019

* Fix DropdownButton disabledHint behavior

* Fix hint behavior when selectedItemBuilder is null

* Improve variable names, some formatting updates

* Create _DropdownMenuItemContainer widget

* Improve API docs to be consistent with hint/disabledHint actual behavior

734ddd31

No multiline password fields (#42470) · 109f2558
Justin McCandless authored Oct 28, 2019
```
Use assertions to prevent multiline password fields from being created
```
109f2558

Re-Land: Add focus nodes, hover, and shortcuts to switches, checkboxes, and radio buttons. (#43384) · 8017f63b

Greg Spencer authored Oct 28, 2019

This re-lands the change that adds focus nodes, hover, and shortcuts to switches, checkboxes, and radio buttons. (#43213)

No changes from original, except for finding the right RenderBox in dev/integration_tests/android_semantics_testing/test_driver/main_test.dart.

8017f63b

catch failure to parse FLUTTER_STORAGE_BASE_URL (#43599) · b142c9bb
Jonah Williams authored Oct 28, 2019

b142c9bb
set trace to true for desktop builds (#43577) · 450a7248
Jonah Williams authored Oct 28, 2019

450a7248
Catch MissingPortFile exception (#43573) · 36d50a48
Jonah Williams authored Oct 28, 2019

36d50a48
Ensure Chrome is closed on tab close (#43586) · d983c1d1
Jonah Williams authored Oct 28, 2019

d983c1d1

Roll engine 6c257df8e7b9..869b74eb4eca (15 commits) (#43637) · c31cd071

engine-flutter-autoroll authored Oct 28, 2019

git@github.com:flutter/engine.git/compare/6c257df8e7b9...869b74eb4eca

git log 6c257df8e7b9..869b74eb4eca --no-merges --oneline
2019-10-28 bkonyi@google.com Roll src/third_party/dart 207082714c..5b7c981086 (2 commits)
2019-10-28 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from eUAUP... to urhvj... (flutter/engine#13385)
2019-10-28 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from x1rDE... to 9MM-e... (flutter/engine#13383)
2019-10-28 skia-flutter-autoroll@skia.org Roll src/third_party/skia 01b1f63d641b..428b5de64a08 (1 commits) (flutter/engine#13382)
2019-10-28 bkonyi@google.com Roll src/third_party/dart d166b0be1c..207082714c (7 commits)
2019-10-28 skia-flutter-autoroll@skia.org Roll src/third_party/skia 62160f2f358a..01b1f63d641b (1 commits) (flutter/engine#13380)
2019-10-27 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from 1SdS3... to eUAUP... (flutter/engine#13379)
2019-10-27 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from SbuUq... to x1rDE... (flutter/engine#13378)
2019-10-27 skia-flutter-autoroll@skia.org Roll src/third_party/skia ff82e15d014a..62160f2f358a (1 commits) (flutter/engine#13377)
2019-10-27 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from zvXL3... to 1SdS3... (flutter/engine#13376)
2019-10-27 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from qmqw-... to SbuUq... (flutter/engine#13375)
2019-10-26 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from eUB9h... to zvXL3... (flutter/engine#13373)
2019-10-26 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from oeFc8... to qmqw-... (flutter/engine#13372)
2019-10-26 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from fHxWy... to eUB9h... (flutter/engine#13371)
2019-10-26 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from Tbg2V... to oeFc8... (flutter/engine#13370)

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

c31cd071

[flutter_tool] Use engine flutter_runner prebuilts (#43381) · 0dfabb2a

Zachary Anderson authored Oct 28, 2019

* [flutter_tool] Use engine flutter_runner prebuilts

* Update packages/flutter_tools/lib/src/fuchsia/fuchsia_build.dart
Co-Authored-By: Jonah Williams <jonahwilliams@google.com>

0dfabb2a

Refactor BuildMode into class, add jit_release configuration (#42476) · ab260bac
Jonah Williams authored Oct 28, 2019

ab260bac

6c257df8e Roll src/third_party/dart 6354b0b97d..d166b0be1c (4 commits) (#43563) · 84299aeb

engine-flutter-autoroll authored Oct 28, 2019


git@github.com:flutter/engine.git/compare/3ebf00690418...6c257df8e7b9

git log 3ebf00690418..6c257df8e7b9 --no-merges --oneline
2019-10-26 bkonyi@google.com Roll src/third_party/dart 6354b0b97d..d166b0be1c (4 commits)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

84299aeb

Revert "Migrate examples to the Android embedding v2 (#43221)" (#43611) · 5bc7fb68
Emmanuel Garcia authored Oct 28, 2019
```
This reverts commit b49ffa81.
```
5bc7fb68

26 Oct, 2019 4 commits

3ebf00690 Deprecated DartExecutor as BinaryMessenger and added a... · 80b526ea

engine-flutter-autoroll authored Oct 26, 2019

3ebf00690 Deprecated DartExecutor as BinaryMessenger and added a getBinaryMessenger() method. (#43202) (flutter/engine#13349) (#43562)

git@github.com:flutter/engine.git/compare/1c104d435994...3ebf00690418

git log 1c104d435994..3ebf00690418 --no-merges --oneline
2019-10-26 matthew-carroll@users.noreply.github.com Deprecated DartExecutor as BinaryMessenger and added a getBinaryMessenger() method. (#43202) (flutter/engine#13349)

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

80b526ea

Migrate examples to the Android embedding v2 (#43221) · b49ffa81
Emmanuel Garcia authored Oct 26, 2019

b49ffa81

1c104d435 Roll src/third_party/dart 5e44c0b016..6354b0b97d (8 commits) (#43560) · 66d81bf2

engine-flutter-autoroll authored Oct 26, 2019


git@github.com:flutter/engine.git/compare/d41e33dbe447...1c104d435994

git log d41e33dbe447..1c104d435994 --no-merges --oneline
2019-10-26 bkonyi@google.com Roll src/third_party/dart 5e44c0b016..6354b0b97d (8 commits)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

66d81bf2

Catch AppConnectionException from dwds (#43544) · 553662d1
Jonah Williams authored Oct 26, 2019

553662d1