Commits · 2c3db435a8a80dbdee5f6cb6f0e3a7a2395bc512 · abdullh.alsoleman / Front-End

14 Oct, 2023 5 commits

_RouterState should dispose created _RestorableRouteInformation. (#136556) · 2c3db435

Kostia Sokolovskyi authored Oct 14, 2023

### Description
- Fixes https://github.com/flutter/flutter/issues/134205.

### Tests
- Removes ignoring the `_RestorableRouteInformation` leak from `cupertino/app_test.dart`;
- Removes ignoring the `_RestorableRouteInformation` leak from `material/app_test.dart`;
- Removes ignoring the `_RestorableRouteInformation` leak from `widgets/app_test.dart`;
- Removes ignoring the `_RestorableRouteInformation` leak from `widgets/route_notification_messages_test.dart`;
- Removes ignoring the `_RestorableRouteInformation` leak from `widgets/router_restoration_test.dart`;
- Updates `widgets/router_test.dart` to use `testWidgetsWithLeakTracking`.

2c3db435

Roll Flutter Engine from cd1a5ed6f961 to 9149a427ef98 (1 revision) (#136571) · 5b7e9d60

engine-flutter-autoroll authored Oct 14, 2023

https://github.com/flutter/engine/compare/cd1a5ed6f961...9149a427ef98

2023-10-14 skia-flutter-autoroll@skia.org Roll Dart SDK from 5844b34768ce to 02e6d943f1a7 (1 revision) (flutter/engine#46917)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

5b7e9d60

increase windows build test sharding, revert timeout 30 mins (#136474) · bcc795a0

Christopher Fujino authored Oct 14, 2023

In https://github.com/flutter/flutter/pull/136300 I increased the timeout. This is a revert of that, which also adds an additional shard.

bcc795a0

Roll Flutter Engine from a4e62581525c to cd1a5ed6f961 (2 revisions) (#136566) · f2ea7754

engine-flutter-autoroll authored Oct 14, 2023

https://github.com/flutter/engine/compare/a4e62581525c...cd1a5ed6f961

2023-10-13 skia-flutter-autoroll@skia.org Roll Skia from 4bc4b4d22866 to 9affbebb459a (2 revisions) (flutter/engine#46913)
2023-10-13 jonahwilliams@google.com [Impeller] Add GPU frame time to Vulkan backend using timestamp queries. (flutter/engine#46796)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

f2ea7754

Change some usage of RawKeyEvent to KeyEvent in preparation for deprecation (#136420) · 3ef32f04

Greg Spencer authored Oct 14, 2023

## Description

This converts some usages of `RawKeyEvent` to `KeyEvent` to prepare the repo for deprecation of `RawKeyEvent`, and swaps out the `raw_keyboard.dart` manual test for `hardware_keyboard.dart`.

## Related Issues
 - https://github.com/flutter/flutter/issues/136419

## Tests
 - Just refactoring code, no semantic changes.

3ef32f04

13 Oct, 2023 26 commits

Manual roll Flutter Engine from 6605151b4d0a to a4e62581525c (9 revisions) (#136564) · 33db5d7a

engine-flutter-autoroll authored Oct 13, 2023

Manual roll requested by jacksongardner@google.com

Cannot build log URL because revision "a4e62581525c" is invalid: Luci builds of "Mac mac_ios_engine" for a4e62581525c1864a3cd23a67539a3615717eb98 was STARTED

2023-10-13 skia-flutter-autoroll@skia.org Manual roll Dart SDK from c8143a7c026f to 5844b34768ce (1 revision) (flutter/engine#46909)
2023-10-13 skia-flutter-autoroll@skia.org Roll Skia from c9601553b0f3 to 4bc4b4d22866 (1 revision) (flutter/engine#46908)
2023-10-13 skia-flutter-autoroll@skia.org Roll Skia from 8dc8e21a4dec to c9601553b0f3 (3 revisions) (flutter/engine#46907)
2023-10-13 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from SDPa6SfaKvRRSUCij... to 4DwpR2CMJECZJ8EKz... (flutter/engine#46903)
2023-10-13 skia-flutter-autoroll@skia.org Roll Skia from b50d7f9aa743 to 8dc8e21a4dec (4 revisions) (flutter/engine#46902)
2023-10-13 jonahwilliams@google.com [Impeller] fix clear color optimization for large subpasses. (flutter/engine#46887)
2023-10-13 matanlurey@users.noreply.github.com Oops, allow files in opted-in third_party directories. (flutter/engine#46897)
2023-10-13 skia-flutter-autoroll@skia.org Roll Skia from e10e6765480a to b50d7f9aa743 (1 revision) (flutter/engine#46899)
2023-10-13 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from pI1BVH08V0eG0M7sw... to wBb32R567S1alWbfn... (flutter/engine#46898)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from pI1BVH08V0eG to wBb32R567S1a
fuchsia/sdk/core/mac-amd64 from SDPa6SfaKvRR to 4DwpR2CMJECZ

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

33db5d7a

Bump github/codeql-action from 2.22.0 to 2.22.3 (#136563) · 5f9965cf

dependabot[bot] authored Oct 13, 2023

Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2.22.0 to 2.22.3.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/github/codeql-action/blob/main/CHANGELOG.md">github/codeql-action's changelog</a>.</em></p>
<blockquote>
<h1>CodeQL Action Changelog</h1>
<p>See the <a href="https://github.com/github/codeql-action/releases">releases page</a> for the relevant changes to the CodeQL CLI and language packs.</p>
<h2>[UNRELEASED]</h2>
<p>No user facing changes.</p>
<h2>2.22.3 - 13 Oct 2023</h2>
<ul>
<li>Provide an authentication token when downloading the CodeQL Bundle from the API of a GitHub Enterprise Server instance. <a href="https://redirect.github.com/github/codeql-action/pull/1945">#1945</a></li>
</ul>
<h2>2.22.2 - 12 Oct 2023</h2>
<ul>
<li>Update default CodeQL bundle version to 2.15.0. <a href="https://redirect.github.com/github/codeql-action/pull/1938">#1938</a></li>
<li>Improve the log output when an error occurs in an invocation of the CodeQL CLI. <a href="https://redirect.github.com/github/codeql-action/pull/1927">#1927</a></li>
</ul>
<h2>2.22.1 - 09 Oct 2023</h2>
<ul>
<li>Add a workaround for Python 3.12, which is not supported in CodeQL CLI version 2.14.6 or earlier. If you are running an analysis on Windows and using Python 3.12 or later, the CodeQL Action will switch to running Python 3.11. In this case, if Python 3.11 is not found, then the workflow will fail. <a href="https://redirect.github.com/github/codeql-action/pull/1928">#1928</a></li>
</ul>
<h2>2.22.0 - 06 Oct 2023</h2>
<ul>
<li>The CodeQL Action now requires CodeQL version 2.10.5 or later. For more information, see the corresponding changelog entry for CodeQL Action version 2.21.8. <a href="https://redirect.github.com/github/codeql-action/pull/1907">#1907</a></li>
<li>The CodeQL Action no longer runs ML-powered queries. For more information, including details on our investment in AI-powered security technology, see <a href="https://github.blog/changelog/2023-09-29-codeql-code-scanning-deprecates-ml-powered-alerts/">&quot;CodeQL code scanning deprecates ML-powered alerts.&quot;</a> <a href="https://redirect.github.com/github/codeql-action/pull/1910">#1910</a></li>
<li>Fix a bug which prevented tracing of projects using Go 1.21 and above on Linux. <a href="https://redirect.github.com/github/codeql-action/pull/1909">#1909</a></li>
</ul>
<h2>2.21.9 - 27 Sep 2023</h2>
<ul>
<li>Update default CodeQL bundle version to 2.14.6. <a href="https://redirect.github.com/github/codeql-action/pull/1897">#1897</a></li>
<li>We are rolling out a feature in October 2023 that will improve the success rate of C/C++ autobuild. <a href="https://redirect.github.com/github/codeql-action/pull/1889">#1889</a></li>
<li>We are rolling out a feature in October 2023 that will provide specific file coverage information for C and C++, Java and Kotlin, and JavaScript and TypeScript. Currently file coverage information for each of these pairs of languages is grouped together. <a href="https://redirect.github.com/github/codeql-action/pull/1903">#1903</a></li>
<li>Add a warning to help customers avoid inadvertently analyzing the same CodeQL language in multiple matrix jobs. <a href="https://redirect.github.com/github/codeql-action/pull/1901">#1901</a></li>
</ul>
<h2>2.21.8 - 19 Sep 2023</h2>
<ul>
<li>Add a deprecation warning for customers using CodeQL version 2.10.4 and earlier. These versions of CodeQL were discontinued on 12 September 2023 alongside GitHub Enterprise Server 3.6, and will be unsupported by the next minor release of the CodeQL Action. <a href="https://redirect.github.com/github/codeql-action/pull/1884">#1884</a>
<ul>
<li>If you are using one of these versions, please update to CodeQL CLI version 2.10.5 or later. For instance, if you have specified a custom version of the CLI using the 'tools' input to the 'init' Action, you can remove this input to use the default version.</li>
<li>Alternatively, if you want to continue using a version of the CodeQL CLI between 2.9.5 and 2.10.4, you can replace <code>github/codeql-action/*@v2</code> by <code>github/codeql-action/*@v2.21.7</code> in your code scanning workflow to ensure you continue using this version of the CodeQL Action.</li>
</ul>
</li>
<li>Enable the following language aliases when using CodeQL 2.14.4 and later: <code>c-cpp</code> for C/C++ analysis, <code>java-kotlin</code> for Java/Kotlin analysis, and <code>javascript-typescript</code> for JavaScript/TypeScript analysis. <a href="https://redirect.github.com/github/codeql-action/pull/1883">#1883</a></li>
</ul>
<h2>2.21.7 - 14 Sep 2023</h2>
<ul>
<li>Update default CodeQL bundle version to 2.14.5. <a href="https://redirect.github.com/github/codeql-action/pull/1882">#1882</a></li>
</ul>
<h2>2.21.6 - 13 Sep 2023</h2>
<ul>
<li>Better error message when there is a failure to determine the merge base of the code to analysis. <a href="https://redirect.github.com/github/codeql-action/pull/1860">#1860</a></li>
<li>Improve the calculation of default amount of RAM used for query execution on GitHub Enterprise Server. This now reduces in proportion to the runner's total memory to better account for system memory usage, helping to avoid out-of-memory failures on larger runners. This feature is already available to GitHub.com users. <a href="https://redirect.github.com/github/codeql-action/pull/1866">#1866</a></li>
<li>Enable improved file coverage information for GitHub Enterprise Server users. This feature is already available to GitHub.com users. <a href="https://redirect.github.com/github/codeql-action/pull/1867">#1867</a></li>
</ul>
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/github/codeql-action/commit/0116bc2df50751f9724a2e35ef1f24d22f90e4e1"><code>0116bc2</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/1947">#1947</a> from github/update-v2.22.3-82ba90b1d</li>
<li><a href="https://github.com/github/codeql-action/commit/f5a984b113c807e0268ddec39920f7e3253e29c8"><code>f5a984b</code></a> Update changelog for v2.22.3</li>
<li><a href="https://github.com/github/codeql-action/commit/82ba90b1d9944fe69c9c84e08d0cbd03406bf856"><code>82ba90b</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/1945">#1945</a> from github/henrymercer/authenticate-api-url</li>
<li><a href="https://github.com/github/codeql-action/commit/34f97d7a16e031c81946105d8e6a417ebc334b22"><code>34f97d7</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/1944">#1944</a> from github/henrymercer/sublanguage-file-coverage-fixes</li>
<li><a href="https://github.com/github/codeql-action/commit/74442e0a95c10585aa3b69d6f8f1901eabd8b499"><code>74442e0</code></a> Add changelog note</li>
<li><a href="https://github.com/github/codeql-action/commit/bd32fab74f8e9b5477f2256d657f4287be42d2c7"><code>bd32fab</code></a> Provide token when downloading from GHES API</li>
<li><a href="https://github.com/github/codeql-action/commit/b584cf832147a691d8f264a6c0ac67d5db0d54cd"><code>b584cf8</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/1922">#1922</a> from github/nora/add-commit-sha-to-database-upload</li>
<li><a href="https://github.com/github/codeql-action/commit/761255a4a36028ea92a1378192d2aad042274e63"><code>761255a</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/1943">#1943</a> from github/mergeback/v2.22.2-to-main-d90b8d79</li>
<li><a href="https://github.com/github/codeql-action/commit/346d5c4b07cc4c12623714ee29f8e285903be4e5"><code>346d5c4</code></a> Test sub-language file coverage in file baseline information check</li>
<li><a href="https://github.com/github/codeql-action/commit/5950d135647787ae14e7332d9f0d0d07cefa117a"><code>5950d13</code></a> Enable sub-language file coverage in <code>interpret-results</code> too</li>
<li>Additional commits viewable in <a href="https://github.com/github/codeql-action/compare/2cb752a87e96af96708ab57187ab6372ee1973ab...0116bc2df50751f9724a2e35ef1f24d22f90e4e1">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=github/codeql-action&package-manager=github_actions&previous-version=2.22.0&new-version=2.22.3)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

5f9965cf

[Impeller] GPU frame timings summarization. (#136408) · ec12ba28

Jonah Williams authored Oct 13, 2023

Allow processing GPU start and end events to get processed by flutter driver. To figure out whether or not this works we'll ship in on CI :)

ec12ba28

Changes WidgetInspector to use valuenotifier instead of a force rebuild for (#131634) · ac095ed3

Daniel Chevalier authored Oct 13, 2023

![](https://media.giphy.com/media/qriH9W51oLsL6/giphy.gif)
Fixes https://github.com/flutter/devtools/issues/6014

Change the forceRebuild behaviour of the WidgetInspector to use
ValueListenableBuilders instead. This should help resolve heavy rebuilds
when the widgetInspectorOverride value changes.

ac095ed3

Roll Flutter Engine from 799e8de11c12 to 6605151b4d0a (3 revisions) (#136558) · be45c4ca

engine-flutter-autoroll authored Oct 13, 2023

https://github.com/flutter/engine/compare/799e8de11c12...6605151b4d0a

2023-10-13 dnfield@google.com [Impeller] Only allow Impeller in flutter_tester if vulkan is enabled. (flutter/engine#46895)
2023-10-13 skia-flutter-autoroll@skia.org Roll Skia from 4783e1146146 to e10e6765480a (1 revision) (flutter/engine#46893)
2023-10-13 233583+mossmana@users.noreply.github.com Replace deprecated [UIScreen mainScreen] in FlutterView.mm (flutter/engine#46802)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

be45c4ca

Roll Flutter Engine from 93f02f7237db to 799e8de11c12 (6 revisions) (#136553) · cff36c99

engine-flutter-autoroll authored Oct 13, 2023

https://github.com/flutter/engine/compare/93f02f7237db...799e8de11c12

2023-10-13 skia-flutter-autoroll@skia.org Roll Skia from 643d74cf4e0b to 4783e1146146 (2 revisions) (flutter/engine#46890)
2023-10-13 skia-flutter-autoroll@skia.org Roll Dart SDK from 95e2ecee106a to c8143a7c026f (1 revision) (flutter/engine#46889)
2023-10-13 skia-flutter-autoroll@skia.org Roll Skia from 77e73bb2744b to 643d74cf4e0b (2 revisions) (flutter/engine#46888)
2023-10-13 derekx@google.com Use --timeline_recorder=systrace instead of --systrace_timeline (flutter/engine#46884)
2023-10-13 erikgerman917@gmail.com fixed AutofillHints.middleName tanslation for web. (flutter/engine#46429)
2023-10-13 skia-flutter-autoroll@skia.org Roll Skia from 3acf82dcc479 to 77e73bb2744b (2 revisions) (flutter/engine#46886)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

cff36c99

Mark leak in NativeCodec.getNextFrame. (#136514) · 9f512d70
Polina Cherkasova authored Oct 13, 2023

9f512d70
Stop skipping leaks in the test. (#136512) · 2ea541ac
Polina Cherkasova authored Oct 13, 2023

2ea541ac

run tests under dev/tools as part of framework-misc and get them passing (#136501) · c353e641

Christopher Fujino authored Oct 13, 2023

part of https://github.com/flutter/flutter/issues/136500

this should not affect any production code, it merely runs the tests on CI and makes the changes needed to get them passing.

c353e641

Roll Flutter Engine from 60968c892649 to 93f02f7237db (5 revisions) (#136546) · 7d3b7d14

engine-flutter-autoroll authored Oct 13, 2023

https://github.com/flutter/engine/compare/60968c892649...93f02f7237db

2023-10-13 30870216+gaaclarke@users.noreply.github.com [Impeller] Started throwing errors if dart:ui/Image.toByteData fails (flutter/engine#46738)
2023-10-13 skia-flutter-autoroll@skia.org Roll Skia from e566db061ce8 to 3acf82dcc479 (2 revisions) (flutter/engine#46883)
2023-10-13 kjlubick@users.noreply.github.com Fix forward declare and some deprecated enums (flutter/engine#46882)
2023-10-13 skia-flutter-autoroll@skia.org Roll Skia from c640eeed2695 to e566db061ce8 (1 revision) (flutter/engine#46881)
2023-10-13 kjlubick@users.noreply.github.com Update to use GrDirectContexts::MakeVulkan (flutter/engine#46878)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

7d3b7d14

Remove bringup from tests and move some back to presubmit. Reorganize TESTOWNERS. (#136498) · 9c791f46

Victoria Ashworth authored Oct 13, 2023

We renamed a few tests and therefore had to run them in bringup first
(https://github.com/flutter/flutter/pull/136463). This removes bringup
and moves some of them back to presubmit. Also, reorganize TESTOWNERS
since they're running on hostonly now.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat

9c791f46

[leak-tracking] Add leak tracking in test/rendering -2 (#136310) · 86c9b8ea
droidbg authored Oct 13, 2023

86c9b8ea
[leak-tracking] Add leak tracking in test/rendering -3 (#136308) · 8f14104c
droidbg authored Oct 13, 2023

8f14104c

Roll Packages from 93c3f69fa6c6 to fd84e6545a45 (3 revisions) (#136538) · b808e5c2

engine-flutter-autoroll authored Oct 13, 2023

https://github.com/flutter/packages/compare/93c3f69fa6c6...fd84e6545a45

2023-10-12 48316647+yamhoresh@users.noreply.github.com [go_router] Fix missing build parameter in type-safe routes topic documentation (flutter/packages#5040)
2023-10-12 engine-flutter-autoroll@skia.org Roll Flutter (stable) from ead455963c12 to 2f708eb8396e (1 revision) (flutter/packages#5134)
2023-10-12 goderbauer@google.com [web_benchmarks] Bump process version constraints (flutter/packages#5122)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

b808e5c2

Roll Flutter Engine from f9aed0267352 to 60968c892649 (1 revision) (#136539) · e88bbfbc

engine-flutter-autoroll authored Oct 13, 2023

https://github.com/flutter/engine/compare/f9aed0267352...60968c892649

2023-10-13 zanderso@users.noreply.github.com Don't use objcopy to embed Android icudtl (flutter/engine#46862)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

e88bbfbc

Roll Flutter Engine from e94f191d0ba4 to f9aed0267352 (2 revisions) (#136537) · 3865e49a

engine-flutter-autoroll authored Oct 13, 2023

https://github.com/flutter/engine/compare/e94f191d0ba4...f9aed0267352

2023-10-13 skia-flutter-autoroll@skia.org Roll Dart SDK from 54ef02480719 to 95e2ecee106a (1 revision) (flutter/engine#46877)
2023-10-13 skia-flutter-autoroll@skia.org Roll Skia from f27c0f222320 to c640eeed2695 (1 revision) (flutter/engine#46874)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

3865e49a

Roll Flutter Engine from 40ddc30b9d6c to e94f191d0ba4 (1 revision) (#136532) · b4a67ce6

engine-flutter-autoroll authored Oct 13, 2023

https://github.com/flutter/engine/compare/40ddc30b9d6c...e94f191d0ba4

2023-10-13 skia-flutter-autoroll@skia.org Roll ICU from 995db880cff2 to a622de35ac31 (1 revision) (flutter/engine#46873)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

b4a67ce6

Roll Flutter Engine from 5acdac549034 to 40ddc30b9d6c (1 revision) (#136526) · 0b15c3e0

engine-flutter-autoroll authored Oct 13, 2023

https://github.com/flutter/engine/compare/5acdac549034...40ddc30b9d6c

2023-10-13 skia-flutter-autoroll@skia.org Roll Dart SDK from 849253fd69b6 to 54ef02480719 (2 revisions) (flutter/engine#46871)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

0b15c3e0

Roll Flutter Engine from b59d779d4f7f to 5acdac549034 (2 revisions) (#136523) · 4603314c

engine-flutter-autoroll authored Oct 13, 2023

https://github.com/flutter/engine/compare/b59d779d4f7f...5acdac549034

2023-10-13 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from XnH2CtqEH7byTHna7... to SDPa6SfaKvRRSUCij... (flutter/engine#46868)
2023-10-13 skia-flutter-autoroll@skia.org Roll Skia from faad330e7120 to f27c0f222320 (1 revision) (flutter/engine#46869)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from XnH2CtqEH7by to SDPa6SfaKvRR

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

4603314c

Roll Flutter Engine from dc30b4cd0239 to b59d779d4f7f (2 revisions) (#136521) · d479b5e2

engine-flutter-autoroll authored Oct 13, 2023

https://github.com/flutter/engine/compare/dc30b4cd0239...b59d779d4f7f

2023-10-13 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from QLiomHC9D-GWh_gyK... to pI1BVH08V0eG0M7sw... (flutter/engine#46867)
2023-10-13 skia-flutter-autoroll@skia.org Roll Skia from aee708412bec to faad330e7120 (1 revision) (flutter/engine#46866)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from QLiomHC9D-GW to pI1BVH08V0eG

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

d479b5e2

Roll Flutter Engine from 31ec5e31a914 to dc30b4cd0239 (1 revision) (#136518) · 962fcd62

engine-flutter-autoroll authored Oct 13, 2023

https://github.com/flutter/engine/compare/31ec5e31a914...dc30b4cd0239

2023-10-13 skia-flutter-autoroll@skia.org Roll Skia from bf557aeaaef8 to aee708412bec (1 revision) (flutter/engine#46865)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

962fcd62

Roll Flutter Engine from 7a6172e9d34c to 31ec5e31a914 (1 revision) (#136516) · bae67d96

engine-flutter-autoroll authored Oct 13, 2023

https://github.com/flutter/engine/compare/7a6172e9d34c...31ec5e31a914

2023-10-13 skia-flutter-autoroll@skia.org Roll Dart SDK from b0d65ad14354 to 849253fd69b6 (1 revision) (flutter/engine#46864)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

bae67d96

Roll Flutter Engine from ffb3b5b67f61 to 7a6172e9d34c (1 revision) (#136515) · 43d8a133

engine-flutter-autoroll authored Oct 13, 2023

https://github.com/flutter/engine/compare/ffb3b5b67f61...7a6172e9d34c

2023-10-13 zanderso@users.noreply.github.com Revert "Remove the frontend server wrapper" (flutter/engine#46863)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

43d8a133

SearchAnchor should dispose created FocusNode and SearchController. (#136120) · 7d794725
Kostia Sokolovskyi authored Oct 13, 2023

7d794725

Roll Flutter Engine from dee90f16aacd to ffb3b5b67f61 (2 revisions) (#136506) · e0b8ec07

engine-flutter-autoroll authored Oct 13, 2023

https://github.com/flutter/engine/compare/dee90f16aacd...ffb3b5b67f61

2023-10-13 skia-flutter-autoroll@skia.org Roll Dart SDK from 34c06f0bcb29 to b0d65ad14354 (3 revisions) (flutter/engine#46859)
2023-10-12 jason-simmons@users.noreply.github.com Temporarily remove the runs of the engine Dart tests with Impeller enabled (flutter/engine#46854)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

e0b8ec07

Make constraints a covariant argument in RenderBox.computeDryLayout() (#136432) · bc688cf0

Todd Volkert authored Oct 13, 2023

Some render box subclasses have a specific layout contract that is tightly coupled with other render box subclasses (e.g. two private classes in a local project file). In these cases, it is also possible that they use a constraints object that is a subclass of `BoxConstraints`. To allow for this, this change makes the `constraints` argument to `RenderBox.computeDryLayout()` a covariant argument.

For completeness' sake, this updates the other render objects in the rendering package to also use the covariant keyword for this argument.

bc688cf0

12 Oct, 2023 9 commits

[web] remove loading indicator in -d web-server builds (#136482) · 0f082889
Yegor authored Oct 12, 2023
```
Fixes https://github.com/flutter/flutter/issues/135226
```
0f082889

Roll Flutter Engine from cb37ebc81939 to dee90f16aacd (3 revisions) (#136502) · 5f796b29

engine-flutter-autoroll authored Oct 12, 2023

https://github.com/flutter/engine/compare/cb37ebc81939...dee90f16aacd

2023-10-12 skia-flutter-autoroll@skia.org Roll Skia from 8b110fd65de9 to bf557aeaaef8 (1 revision) (flutter/engine#46853)
2023-10-12 uysalere@gmail.com [fuchsia] Add fatal error for Vulkan failure (flutter/engine#46831)
2023-10-12 mdebbar@google.com [web] Stop using `flutterViewEmbedder` for platform views (flutter/engine#46046)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

5f796b29

Roll Flutter Engine from 7eb20a09073e to cb37ebc81939 (2 revisions) (#136492) · 856475c0

engine-flutter-autoroll authored Oct 12, 2023

https://github.com/flutter/engine/compare/7eb20a09073e...cb37ebc81939

2023-10-12 skia-flutter-autoroll@skia.org Roll Skia from 222fe6b9b0eb to 8b110fd65de9 (1 revision) (flutter/engine#46852)
2023-10-12 skia-flutter-autoroll@skia.org Roll Skia from fdcbbc4d5c25 to 222fe6b9b0eb (2 revisions) (flutter/engine#46849)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

856475c0

[SingleChildScrollView] Correct the offset pixels if it is out of range during layout (#136239) · 3f722c14

xubaolin authored Oct 12, 2023

Fixes https://github.com/flutter/flutter/issues/105733
FIxes https://github.com/flutter/flutter/issues/135865

The above two issues will not occur on the `ListView` widget, so after analyzing their differences, it was found that the `SingleChildScrollView` pixels were not corrected according to the content dimensions during layout.

### ListView correct the pixels codes
https://github.com/flutter/flutter/blob/5dfd78c2e30483a9a8668ba6b754d089b1e132c8/packages/flutter/lib/src/rendering/viewport.dart#L1462-L1465

We should correct the pixels to prevent the physics ballistic simulations.

This change makes them have the same behavior.

3f722c14

Allow `TapRegion` to consume tap events (#136305) · 22b0a62a

Greg Spencer authored Oct 12, 2023

## Description

In order for `MenuAnchor` menus to be able to not pass on the taps that close their menus, `TapRegion` needed a way to consume them.  This change adds a flag to the `TapRegion`, `consumeOutsideTap` that will consume taps that occur outside of the region if the flag is set (it is false by default). The same flag is added to `MenuAnchor` to allow selecting the behavior for menus.

`TapRegion` consumes the tap event by registering with the gesture arena and immediately resolving the tap as accepted if any regions in a group have `consumeOutsideTap` set to true.

This PR also deprecates `MenuAnchor.anchorTapClosesMenu`, since it is a much more limited version of the same feature that only applied to the anchor itself, and even then only applied to closing the menu, not passing along the tap.  The same functionality can now be implemented by handling a tap on the anchor widget and checking to see if the menu is open before closing it.

## Related Issues
 - https://github.com/flutter/flutter/issues/135327

## Tests
 - Added tests for `TapRegion` to make sure taps are consumed properly.

22b0a62a

Fix doc TODO (#136485) · 7ea5536f

Michael Goderbauer authored Oct 12, 2023

Underlying bug (https://github.com/dart-lang/dartdoc/issues/2276) has been fixed a while ago.

7ea5536f

Roll Flutter Engine from f02006736390 to 7eb20a09073e (4 revisions) (#136478) · 1b797baf

engine-flutter-autoroll authored Oct 12, 2023

https://github.com/flutter/engine/compare/f02006736390...7eb20a09073e

2023-10-12 skia-flutter-autoroll@skia.org Roll Skia from 1d134a8f3ae2 to fdcbbc4d5c25 (7 revisions) (flutter/engine#46844)
2023-10-12 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from 8AXhoo-MMME8NMKt0... to XnH2CtqEH7byTHna7... (flutter/engine#46843)
2023-10-12 chinmaygarde@google.com [Impeller] Specify default border color for texture wrap mode that clamps. (flutter/engine#46806)
2023-10-12 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from giQtXxdSj6NdIViCw... to QLiomHC9D-GWh_gyK... (flutter/engine#46838)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from giQtXxdSj6Nd to QLiomHC9D-GW
fuchsia/sdk/core/mac-amd64 from 8AXhoo-MMME8 to XnH2CtqEH7by

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

1b797baf

Bump file,process,process_runner (#136418) · 43736132
Michael Goderbauer authored Oct 12, 2023

43736132

Roll Flutter Engine from 664657d32992 to f02006736390 (3 revisions) (#136467) · 90b24fb5

engine-flutter-autoroll authored Oct 12, 2023

https://github.com/flutter/engine/compare/664657d32992...f02006736390

2023-10-12 zanderso@users.noreply.github.com Remove the frontend server wrapper (flutter/engine#46440)
2023-10-12 jason-simmons@users.noreply.github.com Roll SwiftShader to include a fix required by the latest Clang toolchain (flutter/engine#46803)
2023-10-12 skia-flutter-autoroll@skia.org Roll Skia from 2dd1579c6921 to 1d134a8f3ae2 (5 revisions) (flutter/engine#46824)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

90b24fb5