Commits · 2b1f882e20a153249b70b2f712b0a3297b7d9d2f · abdullh.alsoleman / Front-End

11 Jun, 2023 10 commits

Roll Flutter Engine from 788437e41ee0 to 9bb0a5907403 (1 revision) (#128673) · 2b1f882e

engine-flutter-autoroll authored Jun 11, 2023

https://github.com/flutter/engine/compare/788437e41ee0...9bb0a5907403

2023-06-11 flar@google.com Reland "add non-rendering operation culling to DisplayListBuilder" (#41463) (flutter/engine#42584)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

2b1f882e

Roll Flutter Engine from 5da44b9aafdd to 788437e41ee0 (2 revisions) (#128672) · 1fccad1b

engine-flutter-autoroll authored Jun 11, 2023

https://github.com/flutter/engine/compare/5da44b9aafdd...788437e41ee0

2023-06-11 skia-flutter-autoroll@skia.org Roll Dart SDK from 46f3e816d30d to 0c4f3ae7464c (1 revision) (flutter/engine#42745)
2023-06-11 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from E7gwQ9L15jziMUKha... to UxuMYdEq-rI5WqUKJ... (flutter/engine#42744)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from E7gwQ9L15jzi to UxuMYdEq-rI5

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

1fccad1b

Roll Flutter Engine from 6e2c71adccad to 5da44b9aafdd (1 revision) (#128669) · 08e595c1

engine-flutter-autoroll authored Jun 11, 2023

https://github.com/flutter/engine/compare/6e2c71adccad...5da44b9aafdd

2023-06-11 dkwingsmt@users.noreply.github.com Use ShellTest::Config struct to create Shell (flutter/engine#42332)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

08e595c1

Roll Flutter Engine from 1cca9cc6dbd1 to 6e2c71adccad (1 revision) (#128662) · d2c1cf89

engine-flutter-autoroll authored Jun 11, 2023

https://github.com/flutter/engine/compare/1cca9cc6dbd1...6e2c71adccad

2023-06-11 skia-flutter-autoroll@skia.org Roll Skia from 00cb34edb01c to c4624cc7135a (1 revision) (flutter/engine#42741)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

d2c1cf89

Roll Flutter Engine from 73a7af805472 to 1cca9cc6dbd1 (1 revision) (#128658) · 3df163ff

engine-flutter-autoroll authored Jun 11, 2023

https://github.com/flutter/engine/compare/73a7af805472...1cca9cc6dbd1

2023-06-11 skia-flutter-autoroll@skia.org Roll Skia from 2bab3a2a2953 to 00cb34edb01c (1 revision) (flutter/engine#42737)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

3df163ff

Roll Flutter Engine from 7c6770083e5c to 73a7af805472 (2 revisions) (#128654) · 90b1151d

engine-flutter-autoroll authored Jun 11, 2023

https://github.com/flutter/engine/compare/7c6770083e5c...73a7af805472

2023-06-11 skia-flutter-autoroll@skia.org Roll Dart SDK from ffb5a1502051 to 46f3e816d30d (1 revision) (flutter/engine#42733)
2023-06-11 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from Otfnr8SATDVN_7BuI... to E7gwQ9L15jziMUKha... (flutter/engine#42732)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from Otfnr8SATDVN to E7gwQ9L15jzi

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

90b1151d

Roll Flutter Engine from 6d615bbcfccf to 7c6770083e5c (2 revisions) (#128653) · cf2ce22f

engine-flutter-autoroll authored Jun 11, 2023

https://github.com/flutter/engine/compare/6d615bbcfccf...7c6770083e5c

2023-06-11 skia-flutter-autoroll@skia.org Roll Skia from 5c9cdc4e0b61 to 2bab3a2a2953 (57 revisions) (flutter/engine#42731)
2023-06-11 zhangzhijian.123@bytedance.com [Impeller] Improved numerical stability in cubic path boundary calculations (flutter/engine#42720)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

cf2ce22f

Roll Flutter Engine from b19b93de5b0a to 6d615bbcfccf (1 revision) (#128650) · 2276b547

engine-flutter-autoroll authored Jun 11, 2023

https://github.com/flutter/engine/compare/b19b93de5b0a...6d615bbcfccf

2023-06-11 skia-flutter-autoroll@skia.org Roll Skia from 8fdbbca7d35d to 5c9cdc4e0b61 (1 revision) (flutter/engine#42650)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

2276b547

Roll Flutter Engine from 3d76ba6d6d5f to b19b93de5b0a (2 revisions) (#128649) · 1ff9ba64

engine-flutter-autoroll authored Jun 11, 2023

https://github.com/flutter/engine/compare/3d76ba6d6d5f...b19b93de5b0a

2023-06-11 skia-flutter-autoroll@skia.org Roll Dart SDK from ba6736de40d2 to ffb5a1502051 (1 revision) (flutter/engine#42728)
2023-06-11 skia-flutter-autoroll@skia.org Roll Dart SDK from 9d705a5391b2 to ba6736de40d2 (4 revisions) (flutter/engine#42725)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

1ff9ba64

Roll Flutter Engine from 962d78e0ae9c to 3d76ba6d6d5f (1 revision) (#128645) · 6c471d3e

engine-flutter-autoroll authored Jun 11, 2023

https://github.com/flutter/engine/compare/962d78e0ae9c...3d76ba6d6d5f

2023-06-10 jonahwilliams@google.com [Impeller] Fix vulkan gradient nan issue. (flutter/engine#42715)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

6c471d3e

10 Jun, 2023 5 commits

migrate `Tooltip` to use `OverlayPortal` (#127728) · e1fdb1aa

LongCatIsLooong authored Jun 10, 2023

https://github.com/flutter/flutter/issues/7151 isn't a problem with OverlayPortal so the test is removed.
Also removed some `mounted` checks since they're no longer needed.

e1fdb1aa

Roll Flutter Engine from b037db26037f to 962d78e0ae9c (10 revisions) (#128643) · 9e8143a0

engine-flutter-autoroll authored Jun 10, 2023

https://github.com/flutter/engine/compare/b037db26037f...962d78e0ae9c

2023-06-10 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 1ODZdNPvGxBrgnCzf... to pd1VfyK_WEW6tu8WI... (flutter/engine#42723)
2023-06-10 skia-flutter-autoroll@skia.org Roll ANGLE from acdf872299ba to 10380f4ba473 (1 revision) (flutter/engine#42722)
2023-06-10 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from EInl_eQkJekqc-gfW... to Otfnr8SATDVN_7BuI... (flutter/engine#42721)
2023-06-10 skia-flutter-autoroll@skia.org Roll ANGLE from a01a566c489b to acdf872299ba (1 revision) (flutter/engine#42719)
2023-06-10 skia-flutter-autoroll@skia.org Roll Clang from 6d667d4b261e to 7f374b6902fa (flutter/engine#42718)
2023-06-10 skia-flutter-autoroll@skia.org Manual roll Dart SDK from d5b39a8385f9 to 9d705a5391b2 (7 revisions) (flutter/engine#42716)
2023-06-09 30870216+gaaclarke@users.noreply.github.com [Impeller] Added helper messaging around validation usage (flutter/engine#42708)
2023-06-09 54558023+keyonghan@users.noreply.github.com Fix an archive name in windows_host_engine config (flutter/engine#42709)
2023-06-09 skia-flutter-autoroll@skia.org Roll ANGLE from 72df42832ee4 to a01a566c489b (3 revisions) (flutter/engine#42712)
2023-06-09 dnfield@google.com Delete WeakPtrFactory from GPUSurfaceVulkanImpeller (flutter/engine#42710)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from 1ODZdNPvGxBr to pd1VfyK_WEW6
fuchsia/sdk/core/mac-amd64 from EInl_eQkJekq to Otfnr8SATDVN

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

9e8143a0

Bump actions/checkout from 3.5.2 to 3.5.3 (#128625) · e39ed8e8

dependabot[bot] authored Jun 10, 2023

Bumps [actions/checkout](https://github.com/actions/checkout) from 3.5.2 to 3.5.3.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/actions/checkout/releases">actions/checkout's releases</a>.</em></p>
<blockquote>
<h2>v3.5.3</h2>
<h2>What's Changed</h2>
<ul>
<li>Fix: Checkout Issue in self hosted runner due to faulty submodule check-ins by <a href="https://github.com/megamanics"><code>@âmegamanics</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1196">actions/checkout#1196</a></li>
<li>Fix typos found by codespell by <a href="https://github.com/DimitriPapadopoulos"><code>@âDimitriPapadopoulos</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1287">actions/checkout#1287</a></li>
<li>Add support for sparse checkouts by <a href="https://github.com/dscho"><code>@âdscho</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1369">actions/checkout#1369</a></li>
<li>Release v3.5.3 by <a href="https://github.com/TingluoHuang"><code>@âTingluoHuang</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1376">actions/checkout#1376</a></li>
</ul>
<h2>New Contributors</h2>
<ul>
<li><a href="https://github.com/megamanics"><code>@âmegamanics</code></a> made their first contribution in <a href="https://redirect.github.com/actions/checkout/pull/1196">actions/checkout#1196</a></li>
<li><a href="https://github.com/DimitriPapadopoulos"><code>@âDimitriPapadopoulos</code></a> made their first contribution in <a href="https://redirect.github.com/actions/checkout/pull/1287">actions/checkout#1287</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/actions/checkout/compare/v3...v3.5.3">https://github.com/actions/checkout/compare/v3...v3.5.3</a></p>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/actions/checkout/blob/main/CHANGELOG.md">actions/checkout's changelog</a>.</em></p>
<blockquote>
<h1>Changelog</h1>
<h2>v3.5.3</h2>
<ul>
<li><a href="https://redirect.github.com/actions/checkout/pull/1196">Fix: Checkout fail in self-hosted runners when faulty submodule are checked-in</a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/1287">Fix typos found by codespell</a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/1369">Add support for sparse checkouts</a></li>
</ul>
<h2>v3.5.2</h2>
<ul>
<li><a href="https://redirect.github.com/actions/checkout/pull/1289">Fix api endpoint for GHES</a></li>
</ul>
<h2>v3.5.1</h2>
<ul>
<li><a href="https://redirect.github.com/actions/checkout/pull/1246">Fix slow checkout on Windows</a></li>
</ul>
<h2>v3.5.0</h2>
<ul>
<li><a href="https://redirect.github.com/actions/checkout/pull/1237">Add new public key for known_hosts</a></li>
</ul>
<h2>v3.4.0</h2>
<ul>
<li><a href="https://redirect.github.com/actions/checkout/pull/1209">Upgrade codeql actions to v2</a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/1210">Upgrade dependencies</a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/1225">Upgrade <code>@âactions/io</code></a></li>
</ul>
<h2>v3.3.0</h2>
<ul>
<li><a href="https://redirect.github.com/actions/checkout/pull/1045">Implement branch list using callbacks from exec function</a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/1050">Add in explicit reference to private checkout options</a></li>
<li>[Fix comment typos (that got added in <a href="https://redirect.github.com/actions/checkout/issues/770">#770</a>)](<a href="https://redirect.github.com/actions/checkout/pull/1057">actions/checkout#1057</a>)</li>
</ul>
<h2>v3.2.0</h2>
<ul>
<li><a href="https://redirect.github.com/actions/checkout/pull/942">Add GitHub Action to perform release</a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/967">Fix status badge</a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/1002">Replace datadog/squid with ubuntu/squid Docker image</a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/964">Wrap pipeline commands for submoduleForeach in quotes</a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/1029">Update <code>@âactions/io</code> to 1.1.2</a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/1039">Upgrading version to 3.2.0</a></li>
</ul>
<h2>v3.1.0</h2>
<ul>
<li><a href="https://redirect.github.com/actions/checkout/pull/939">Use <code>@âactions/core</code> <code>saveState</code> and <code>getState</code></a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/922">Add <code>github-server-url</code> input</a></li>
</ul>
<h2>v3.0.2</h2>
<ul>
<li><a href="https://redirect.github.com/actions/checkout/pull/770">Add input <code>set-safe-directory</code></a></li>
</ul>
<h2>v3.0.1</h2>
<ul>
<li><a href="https://redirect.github.com/actions/checkout/pull/762">Fixed an issue where checkout failed to run in container jobs due to the new git setting <code>safe.directory</code></a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/744">Bumped various npm package versions</a></li>
</ul>
<h2>v3.0.0</h2>
<ul>
<li><a href="https://redirect.github.com/actions/checkout/pull/689">Update to node 16</a></li>
</ul>
<h2>v2.3.1</h2>
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/actions/checkout/commit/c85c95e3d7251135ab7dc9ce3241c5835cc595a9"><code>c85c95e</code></a> Release v3.5.3 (<a href="https://redirect.github.com/actions/checkout/issues/1376">#1376</a>)</li>
<li><a href="https://github.com/actions/checkout/commit/d106d4669b3bfcb17f11f83f98e1cab478e9f635"><code>d106d46</code></a> Add support for sparse checkouts (<a href="https://redirect.github.com/actions/checkout/issues/1369">#1369</a>)</li>
<li><a href="https://github.com/actions/checkout/commit/f095bcc56b7c2baf48f3ac70d6d6782f4f553222"><code>f095bcc</code></a> Fix typos found by codespell (<a href="https://redirect.github.com/actions/checkout/issues/1287">#1287</a>)</li>
<li><a href="https://github.com/actions/checkout/commit/47fbe2df0ad0e27efb67a70beac3555f192b062f"><code>47fbe2d</code></a> Fix: Checkout fail in self-hosted runners when faulty submodule are checked-i...</li>
<li>See full diff in <a href="https://github.com/actions/checkout/compare/8e5e7e5ab8b370d6c329ec480221332ada57f0ab...c85c95e3d7251135ab7dc9ce3241c5835cc595a9">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=actions/checkout&package-manager=github_actions&previous-version=3.5.2&new-version=3.5.3)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

e39ed8e8

Roll Flutter Engine from 3e90345cdca7 to b037db26037f (1 revision) (#128627) · 94a40d0a

engine-flutter-autoroll authored Jun 10, 2023

https://github.com/flutter/engine/compare/3e90345cdca7...b037db26037f

2023-06-09 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from
xqQPG9jnWgD1Dj3FL... to 1ODZdNPvGxBrgnCzf... (flutter/engine#42707)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from xqQPG9jnWgD1 to 1ODZdNPvGxBr

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on
the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

94a40d0a

Remove unnecessary parentheses (#128620) · 65e1cb19
ZhulanovAA authored Jun 10, 2023
```
Fix unnecessary parentheses introduced in #128501

@chunhtai @HansMuller
```
65e1cb19

09 Jun, 2023 25 commits

Roll Flutter Engine from 488876ed26c6 to 3e90345cdca7 (3 revisions) (#128617) · ca11492b

engine-flutter-autoroll authored Jun 09, 2023

https://github.com/flutter/engine/compare/488876ed26c6...3e90345cdca7

2023-06-09 skia-flutter-autoroll@skia.org Roll ANGLE from 3e4f4caebcb0 to 72df42832ee4 (2 revisions) (flutter/engine#42703)
2023-06-09 skia-flutter-autoroll@skia.org Manual roll Dart SDK from bbce07ad3944 to d5b39a8385f9 (2 revisions) (flutter/engine#42702)
2023-06-09 30870216+gaaclarke@users.noreply.github.com [Impeller] Reland: Added a switch to turn on vulkan (flutter/engine#42669)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

ca11492b

rename generated asset manifest file back to `AssetManifest.bin` (from... · cfe4fedc

Andrew Kolos authored Jun 09, 2023

rename generated asset manifest file back to `AssetManifest.bin` (from `AssetManifest.smcbin`) (#128529)

Closes https://github.com/flutter/flutter/issues/128456, which is now linked to in a code comment in this change.
Reopens https://github.com/flutter/flutter/issues/124883.

This effectively reverts https://github.com/flutter/flutter/pull/126077 and is intended to be cherry-picked into stable.

cfe4fedc

Add Selected semantics to IconButton (#128547) · af7a8f6b

hangyu authored Jun 09, 2023

fixes: #127145

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat

---------
Co-authored-by: Qun Cheng <36861262+QuncCccccc@users.noreply.github.com>

af7a8f6b

Roll Flutter Engine from 071e1fb21c7a to 488876ed26c6 (5 revisions) (#128612) · 9c0c611e

engine-flutter-autoroll authored Jun 09, 2023

https://github.com/flutter/engine/compare/071e1fb21c7a...488876ed26c6

2023-06-09 skia-flutter-autoroll@skia.org Roll ANGLE from a185cb8c8924 to 3e4f4caebcb0 (2 revisions) (flutter/engine#42701)
2023-06-09 bdero@google.com [Impeller] Add CPU implementations for all color filters (flutter/engine#42692)
2023-06-09 jonahwilliams@google.com [Impeller] add explicit VMA flush to device memory writes. (flutter/engine#42685)
2023-06-09 30870216+gaaclarke@users.noreply.github.com [Impeller] Makes validation layers flag work for android (flutter/engine#42625)
2023-06-09 jmccandless@google.com Platform channel for predictive back (flutter/engine#39208)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

9c0c611e

Clarifies semantics long press and semantics on tap documentation (#128599) · cc6f86e6
chunhtai authored Jun 09, 2023
```
fixes https://github.com/flutter/flutter/issues/35112
```
cc6f86e6

Roll Flutter Engine from bc6e047570f6 to 071e1fb21c7a (1 revision) (#128602) · a35ae601

engine-flutter-autoroll authored Jun 09, 2023

https://github.com/flutter/engine/compare/bc6e047570f6...071e1fb21c7a

2023-06-09 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from romfKfKwgjzAXQSxt... to EInl_eQkJekqc-gfW... (flutter/engine#42698)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from romfKfKwgjzA to EInl_eQkJekq

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

a35ae601

Revert "Update `chip.dart` to use set of `MaterialState`" (#128607) · d5a8fa62

Hans Muller authored Jun 09, 2023

Reverts flutter/flutter#128507

This PR caused some internal failures (Google internal link b/286503764). Will need to investigate before we can re-land these changes.

d5a8fa62

Add tooltips for `SegmentedButton` (#128501) · e84fa2ce
ZhulanovAA authored Jun 09, 2023

e84fa2ce

Ignore app.stop events received before the app.detach response in attach... · a08a2110

Jason Simmons authored Jun 09, 2023

Ignore app.stop events received before the app.detach response in attach integration tests (#128593)

The app.detach command will close the VM service connection, which yields an app.stop event in the daemon protocol. The daemon does not guarantee any ordering between this event and the response to the app.detach.

See https://github.com/flutter/flutter/issues/128546

a08a2110

ExpansionPanel isExpanded callback parameter (Ticket 74114) (#128082) · 5047690b

Devin authored Jun 09, 2023

Fixes https://github.com/flutter/flutter/issues/74114

This PR addresses the issue detailed here: https://github.com/flutter/flutter/issues/74114 . The boolean isExpanded returned by the expansion panel callback now reflects the state of the panel that the user is seeing. If it's expanded on screen then the callback returns true. When you close the panel the callback returns false. When another panel is open and you open a different one, the callback executes twice. It returns isExpanded == false for the panel you are closing and true for the panel that is being opened.
I had to change the code in a couple existing tests because some tests are using the old behavior of the callback. This PR addresses feedback listed in closed PR -> https://github.com/flutter/flutter/pull/127876 . The reasone the original PR is closed is that I was having some struggles with git. A couple of the commits in this PR are just reverts of commits I meant not to happen.
Pre-launch Checklist

    [ X] I read the [Contributor Guide](https://github.com/flutter/flutter/wiki/Tree-hygiene#overview) and followed the process outlined there for submitting PRs.
    [ X] I read the [Tree Hygiene](https://github.com/flutter/flutter/wiki/Tree-hygiene) wiki page, which explains my responsibilities.
    [ X] I read and followed the [Flutter Style Guide](https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo), including [Features we expect every widget to implement](https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement).
    [ X] I signed the [CLA](https://cla.developers.google.com/).
    [ X] I listed at least one issue that this PR fixes in the description above.
    I updated/added relevant documentation (doc comments with ///).
    [ X] I added new tests to check the change I am making, or this PR is [test-exempt](https://github.com/flutter/flutter/wiki/Tree-hygiene#tests).
    [ X] All existing and new tests are passing.

5047690b

Roll Flutter Engine from 93afba901b3b to bc6e047570f6 (3 revisions) (#128594) · 38406ff8

engine-flutter-autoroll authored Jun 09, 2023

https://github.com/flutter/engine/compare/93afba901b3b...bc6e047570f6

2023-06-09 jonahwilliams@google.com [Impeller] disable buffer to texture blit for Vulkan. (flutter/engine#42686)
2023-06-09 skia-flutter-autoroll@skia.org Roll ANGLE from 980896406d12 to a185cb8c8924 (1 revision) (flutter/engine#42697)
2023-06-09 skia-flutter-autoroll@skia.org Roll ANGLE from e9493542672c to 980896406d12 (1 revision) (flutter/engine#42696)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

38406ff8

Updated flutter_localizations tests for Material3; (#128521) · 9c3bfde5

Hans Muller authored Jun 09, 2023

Updated the localization tests so that they'll DTRT when useMaterial3:true becomes the default for ThemeData. In a few cases there are M2 and M3 tests now, to check features that are significantly different in Material3, notably the double ring for the 24  hour input dial. 

| Material 2 | Material 3|
|---------|---------|
|   <img width="250" alt="Screenshot 2023-06-08 at 10 47 37 AM" src="https://github.com/flutter/flutter/assets/1377460/6ca95e22-b3f1-4f6b-9e39-79c888ba58f1"> | <img width="257" alt="Screenshot 2023-06-08 at 10 47 13 AM" src="https://github.com/flutter/flutter/assets/1377460/19b685bf-c812-4c87-baed-70fa56efaad8"> | 

In M3, most aspects of the ideographic text styles are the same as for alphabetic styles, so there are some tweaks here to account for that.

9c3bfde5

Paint SelectableFragments before text (#128375) · 63f41746
hangyu authored Jun 09, 2023
```
fixes: #104703
```
63f41746

Roll Packages from e13b8c43386a to afe2f05c1adb (7 revisions) (#128582) · f6558431

engine-flutter-autoroll authored Jun 09, 2023

https://github.com/flutter/packages/compare/e13b8c43386a...afe2f05c1adb

2023-06-08 stuartmorgan@google.com [image_picker] Add desktop support - platform interface (flutter/packages#4161)
2023-06-08 nils@reichardt.io [go_router] Update link to example for query and path parameters (flutter/packages#3994)
2023-06-08 49699333+dependabot[bot]@users.noreply.github.com [in_app_pur]: Bump org.jetbrains.kotlin:kotlin-bom from 1.8.0 to 1.8.21 in /packages/in_app_purchase/in_app_purchase_android/android (flutter/packages#3839)
2023-06-08 49699333+dependabot[bot]@users.noreply.github.com [image_picker]: Bump androidx.activity:activity from 1.7.0 to 1.7.1 in /packages/image_picker/image_picker_android/android (flutter/packages#3768)
2023-06-08 stuartmorgan@google.com [webview_flutter] Explicitly disable ATS in example apps (flutter/packages#4166)
2023-06-08 engine-flutter-autoroll@skia.org Roll Flutter from 8a5c22e2 to 6e254a3f (12 revisions) (flutter/packages#4165)
2023-06-08 banasco@gmail.com Fix stale ignore: prefer_const_constructors from flutter/packages (flutter/packages#4154)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

f6558431

Updated material button theme tests for Material3 (#128543) · da127f15
Hans Muller authored Jun 09, 2023

da127f15

Roll Flutter Engine from cb93477008d6 to 93afba901b3b (2 revisions) (#128573) · befd86d6

engine-flutter-autoroll authored Jun 09, 2023

https://github.com/flutter/engine/compare/cb93477008d6...93afba901b3b

2023-06-09 skia-flutter-autoroll@skia.org Roll ANGLE from 8a62b4c44fc9 to e9493542672c (1 revision) (flutter/engine#42695)
2023-06-09 leroux_bruno@yahoo.fr [Linux] Return keyboard pressed state (flutter/engine#42346)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

befd86d6

Improve defaults generation with logging, stats, and token validation (#128244) · 66cda591

Pierre-Louis authored Jun 09, 2023

## Description

This improves defaults generation with logging, stats, and token validation. 

This PR includes these changes:
* introduce `TokenLogger`, with a verbose mode
  * prints versions and tokens usage to the console
  * outputs `generated/used_tokens.csv`, a list of all used tokens, for use by Google
* find token files in `data` automatically
* hide tokens `Map`
  * tokens can be obtained using existing resolvers (e.g. `color`, `shape`), or directly through `getToken`.
  * tokens can be checked for existence with `tokenAvailable`
* remove version from template, since the tokens are aggregated and multiple versions are possible (as is the case currently), it does not make sense to attribute a single version
* improve documentation

## Related Issues
 - Fixes https://github.com/flutter/flutter/issues/122602

## Tests
 - Added tests for `TokenLogger`
 - Regenerated tokens, no-op except version removal

## Future work
A future PR should replace or remove the following invalid tokens usages

<img width="578" alt="image" src="https://github.com/flutter/flutter/assets/6655696/b6f9e5a7-523f-4f72-94f9-1b0bf4cc9f00">

66cda591

[testing] Make the FLUTTER_STORAGE_BASE_URL warning non-fatal (#128335) · 0d39f646

William Hesse authored Jun 09, 2023

Presubmit testing and CI testing of Flutter using a custom storage location for engine artifacts must be able to use the --fatal-warnings flag without failing due to the custom artifact location.

This change adds an option that makes this warning non-fatal. The new --no-fatal-storage-url-warning flag makes the --fatal-warnings flag ignore the warning that a custom artifact download URL is being used by setting the environment variable FLUTTER_STORAGE_BASE_URL.

Bug: #127683

- [X ] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
- [X ] I read the [Tree Hygiene] wiki page, which explains my responsibilities.
- [X ] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
- [X ] I signed the [CLA].
- [X ] I listed at least one issue that this PR fixes in the description above.
- [X ] I updated/added relevant documentation (doc comments with `///`).

0d39f646

[flutter_tools] [DAP] Don't try to restart/reload if app hasn't started yet (#128267) · 46007d61

Danny Tuppeny authored Jun 09, 2023

The editor is set to hot-reload-on-save by default so saving while the debug session is starting currently prints an error:

Failed to Hot Reload: app 'null' not found

![image](https://github.com/flutter/flutter/assets/1078012/a125b455-a46d-4993-98d8-5d8ae7237a00)

This change skips the call to `app.restart` if the app hasn't started yet to avoid printing an error.

46007d61

Roll Flutter Engine from 8f9e608d39ab to cb93477008d6 (3 revisions) (#128568) · 6d4c4d75

engine-flutter-autoroll authored Jun 09, 2023

https://github.com/flutter/engine/compare/8f9e608d39ab...cb93477008d6

2023-06-09 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from lPCv1NshK-tvjtLgC... to xqQPG9jnWgD1Dj3FL... (flutter/engine#42694)
2023-06-09 skia-flutter-autoroll@skia.org Roll ANGLE from d8339e78db54 to 8a62b4c44fc9 (1 revision) (flutter/engine#42691)
2023-06-09 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from ukXXOXtI7uRIukzF5... to romfKfKwgjzAXQSxt... (flutter/engine#42689)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from lPCv1NshK-tv to xqQPG9jnWgD1
fuchsia/sdk/core/mac-amd64 from ukXXOXtI7uRI to romfKfKwgjzA

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

6d4c4d75

Replace `MaterialButton` from test classes (#128466) · 192b0640
Taha Tesser authored Jun 09, 2023
```
fixes https://github.com/flutter/flutter/issues/128465
```
192b0640

Fix `showBottomSheet` doesn't remove scrim when draggable sheet is dismissed (#128455) · 8600eb12

Taha Tesser authored Jun 09, 2023

fixes https://github.com/flutter/flutter/issues/128367

<details> 
<summary>code sample</summary> 

```dart
import 'package:flutter/material.dart';

void main() => runApp(const MyApp());

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      debugShowCheckedModeBanner: false,
      theme: ThemeData(useMaterial3: true),
      home: Scaffold(
        floatingActionButton: Builder(
          builder: (BuildContext context) => FloatingActionButton(
            child: const Icon(Icons.add),
            onPressed: () {
              Scaffold.of(context).showBottomSheet<void>(
                (_) {
                  return DraggableScrollableSheet(
                    expand: false,
                    builder: (_, ScrollController scrollController) =>
                        ListView.builder(
                      controller: scrollController,
                      itemCount: 25,
                      itemBuilder: (BuildContext context, int index) {
                        return ListTile(
                          title: Text('Item $index - tap to close'),
                          onTap: () {
                            Navigator.of(context).pop();
                          },
                        );
                      },
                    ),
                  );
                },
              );
            },
          ),
        ),
      ),
    );
  }
}
``` 
	
</details>

### Before

https://github.com/flutter/flutter/assets/48603081/fa87feb9-54f2-4e50-bf71-c81d9e54ff61

### After 

https://github.com/flutter/flutter/assets/48603081/7d192059-7600-4d65-ae84-6321f3598133

8600eb12

Manual roll Flutter Engine from a5f7d5d75ff2 to 8f9e608d39ab (31 revisions) (#128554) · 80b9ac2c

engine-flutter-autoroll authored Jun 09, 2023

Manual roll Flutter Engine from a5f7d5d75ff2 to 8f9e608d39ab (31 revisions)

Manual roll requested by zra@google.com

https://github.com/flutter/engine/compare/a5f7d5d75ff2...8f9e608d39ab

2023-06-09 zanderso@users.noreply.github.com Revert Dart to 3.1.0-180.0.dev (flutter/engine#42688)
2023-06-09 mk12360@gmail.com [fuchsia] Bump the target API level to 12, and pass it to fidlc (flutter/engine#42667)
2023-06-09 bdero@google.com [Impeller] Add tests for foreground blends with mask blurs (flutter/engine#42687)
2023-06-09 godofredoc@google.com Document the use of realm in archives. (flutter/engine#42682)
2023-06-09 skia-flutter-autoroll@skia.org Roll ANGLE from 76b0e7f38b44 to d8339e78db54 (1 revision) (flutter/engine#42684)
2023-06-08 godofredoc@google.com Prevent double upload of benchmarks. (flutter/engine#42683)
2023-06-08 skia-flutter-autoroll@skia.org Roll ANGLE from 5215293366f0 to 76b0e7f38b44 (2 revisions) (flutter/engine#42680)
2023-06-08 godofredoc@google.com Remove all the uses of master branch in the .ci.yaml file. (flutter/engine#42679)
2023-06-08 godofredoc@google.com Replace benchmarks with its v2 version. (flutter/engine#42677)
2023-06-08 bdero@google.com [Impeller] Reorder blend filter checks to avoid unnecessary destination snapshot (flutter/engine#42678)
2023-06-08 bdero@google.com [Impeller] Specify blend mode on blend filter commands (flutter/engine#42676)
2023-06-08 skia-flutter-autoroll@skia.org Roll ANGLE from c49674d1565c to 5215293366f0 (1 revision) (flutter/engine#42673)
2023-06-08 rmolivares@renzo-olivares.dev [Linux] composing delta fixes (flutter/engine#42648)
2023-06-08 jinhe.zjh@alibaba-inc.com Fix: invalid time-point comparison between each from different clock source (flutter/engine#42409)
2023-06-08 zanderso@users.noreply.github.com Fix license hash (flutter/engine#42675)
2023-06-08 zanderso@users.noreply.github.com Revert Dart to 3.1.0-184.0.dev (flutter/engine#42671)
2023-06-08 skia-flutter-autoroll@skia.org Roll ANGLE from b5d261ac5c5b to c49674d1565c (2 revisions) (flutter/engine#42670)
2023-06-08 skia-flutter-autoroll@skia.org Roll Dart SDK from b7fe6e0c274c to 3a9145a57432 (1 revision) (flutter/engine#42668)
2023-06-08 jonahwilliams@google.com [Impeller] sort all vertex inputs by location. (flutter/engine#42664)
2023-06-08 skia-flutter-autoroll@skia.org Roll ANGLE from 05e087658b10 to b5d261ac5c5b (1 revision) (flutter/engine#42662)
2023-06-08 zanderso@users.noreply.github.com Revert "[Impeller] Added a switch to turn on vulkan" (flutter/engine#42660)
2023-06-08 skia-flutter-autoroll@skia.org Roll ANGLE from 15a29438b099 to 05e087658b10 (6 revisions) (flutter/engine#42659)
2023-06-08 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from aMTaMP0DdKdJnxSbc... to lPCv1NshK-tvjtLgC... (flutter/engine#42658)
2023-06-08 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from DL1QQ5eZRVNARqLx-... to ukXXOXtI7uRIukzF5... (flutter/engine#42655)
2023-06-08 skia-flutter-autoroll@skia.org Roll Dart SDK from f0ae96d202ca to b7fe6e0c274c (1 revision) (flutter/engine#42657)
2023-06-08 skia-flutter-autoroll@skia.org Roll Dart SDK from 9e633e463902 to f0ae96d202ca (1 revision) (flutter/engine#42651)
2023-06-08 godofredoc@google.com Benchmarks configurations for engine v2. (flutter/engine#42622)
2023-06-08 skia-flutter-autoroll@skia.org Roll Skia from 1a3adf848e61 to 8fdbbca7d35d (1 revision) (flutter/engine#42645)
2023-06-08 skia-flutter-autoroll@skia.org Roll Dart SDK from bbce07ad3944 to 9e633e463902 (3 revisions) (flutter/engine#42646)
2023-06-07 aam@google.com Roll dart to 3.1.0-180.0.dev (flutter/engine#42638)
2023-06-07 skia-flutter-autoroll@skia.org Roll Skia from 156542f8bf13 to 1a3adf848e61 (1 revision) (flutter/engine#42644)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from aMTaMP0DdKdJ to lPCv1NshK-tv
fuchsia/sdk/core/mac-amd64 from DL1QQ5eZRVNA to ukXXOXtI7uRI

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

...

80b9ac2c

Revert "test owners: cyanglaz -> vashworth" (#128462) · e25eabd2
Chris Yang authored Jun 09, 2023
```
Reverts flutter/flutter#127391

I'm back from OOO so change the test owners back.
```
e25eabd2
[Android] Bump integration tests using `compileSdkVersion` 31 to 33 (#128072) · 0a696980
Camille Simon authored Jun 09, 2023
```
Bumps integration tests (that are not run manually only) using `compileSdkVersion` 31 to 33.
```
0a696980