- 20 Mar, 2024 19 commits
-
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/fe6927c79dc3...98cfd9213332 2024-03-20 skia-flutter-autoroll@skia.org Roll Skia from 715a74e907d7 to 3ffa395f8fbc (3 revisions) (flutter/engine#51563) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/d1fe8994dedf...fe6927c79dc3 2024-03-20 jason-simmons@users.noreply.github.com Add the platform isolate API to the files included in the sky_engine package (flutter/engine#51538) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Vatsal Bhesaniya authored
This pull request introduces a new field named `helper` to the InputDecoration class. This field allows for specifying a widget containing contextual information about the InputDecorator.child's value. Unlike `helperText`, which accepts a plain string, `helper` supports widgets, enabling functionalities like tappable links for further explanation. This change aligns with the established pattern of `error`, `label`, `prefix`, and `suffix`. fixes [#145163](https://github.com/flutter/flutter/issues/145163)
-
Gray Mackall authored
Pre work for https://github.com/flutter/engine/pull/51229. Removes a lot of code referencing v1 of the android embedding, though not necessarily all of it (I may have missed some, it is hard to know). Will hopefully make landing that PR less painful (or maybe painless?)
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/1b52f57ca07c...d1fe8994dedf 2024-03-20 skia-flutter-autoroll@skia.org Roll Skia from ecfbdc3df797 to 715a74e907d7 (2 revisions) (flutter/engine#51557) 2024-03-20 kjlubick@users.noreply.github.com Migrate use of deprecated GrDirectContext::MakeMetal (flutter/engine#51537) 2024-03-20 skia-flutter-autoroll@skia.org Roll Dart SDK from 1fec62355504 to 0f00e7188e0e (1 revision) (flutter/engine#51556) 2024-03-20 jonahwilliams@google.com [Impeller] add test that demonstrates that VVL failures are fatal. (flutter/engine#51525) 2024-03-20 skia-flutter-autoroll@skia.org Roll Skia from 4543913c6243 to ecfbdc3df797 (2 revisions) (flutter/engine#51555) 2024-03-20 34871572+gmackall@users.noreply.github.com Upgrade to gradle 8.3 (flutter/engine#51422) 2024-03-20 34871572+gmackall@users.noreply.github.com Add even more logging for UnsatisfiedLinkError (flutter/engine#51554) 2024-03-20 skia-flutter-autoroll@skia.org Roll Skia from 80e713052b7a to 4543913c6243 (2 revisions) (flutter/engine#51553) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/f803f2adec54...1b52f57ca07c 2024-03-20 34871572+gmackall@users.noreply.github.com Add more logging for UnsatisfiedLinkError (flutter/engine#51534) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
auto-submit[bot] authored
Reverts: flutter/flutter#145376 Initiated by: loic-sharma Reason for reverting: It caused the following post-submit failures: 1. https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8752928710548811665/+/u/run_run_release_test_windows/stdout 2. https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8752927564747697169/+/u/run_run_release_test_windows/stdout Original PR Author: guidezpl Reviewed By: {loic-sharma} This change reverts the following previous change: Reland #128236, reverted in https://github.com/flutter/flutter/pull/143125 and https://github.com/flutter/flutter/pull/145261. This PR contains 3 additional commits, fixing post-submit tests on Android and Windows. ## Original description Improves the build output: 1. Gives confirmation that the build succeeded, in green 1. Gives the path to the built executable, without a trailing period to make it slightly easier to cmd/ctrl+open 1. Gives the size of the built executable (when the built executable is self contained) ### `apk`, `appbundle` <img width="607" alt="image" src="https://github.com/flutter/flutter/assets/6655696/ecc52abe-cd2e-4116-b22a-8385ae3e980d"> <img width="634" alt="image" src="https://github.com/flutter/flutter/assets/6655696/8af8bd33-c0bd-4215-9a06-9652ee019436"> ### `macos`, `ios`, `ipa` Build executables are self-contained and use a newly introduced `OperatingSystemUtils.getDirectorySize`. <img width="514" alt="image" src="https://github.com/flutter/flutter/assets/6655696/b5918a69-3959-4417-9205-4f501d185257"> <img width="581" alt="image" src="https://github.com/flutter/flutter/assets/6655696/d72fd420-18cf-4470-9e4b-b6ac10fbcd50"> <img width="616" alt="image" src="https://github.com/flutter/flutter/assets/6655696/5f235ce1-252a-4c13-898f-139f6c7bc698"> ### `windows`, `linux`, and `web` Build executables aren't self-contained, and folder size can sometimes overestimate distribution size, therefore their size isn't mentioned (see discussion below). <img width="647" alt="image" src="https://github.com/flutter/flutter/assets/6655696/7179e771-1eb7-48f6-b770-975bc073437b"> <img width="658" alt="image" src="https://github.com/flutter/flutter/assets/6655696/a6801cab-7b5a-4975-a406-f4c9fa44d7a2"> <img width="608" alt="image" src="https://github.com/flutter/flutter/assets/6655696/ee7c4125-a273-4a65-95d7-ab441edf8ac5"> ### Size reporting When applicable, the printed size matches the OS reported size. - macOS <img width="391" alt="image" src="https://github.com/flutter/flutter/assets/6655696/881cbfb1-d355-444b-ab44-c1a6343190ce"> - Windows <img width="338" alt="image" src="https://github.com/flutter/flutter/assets/6655696/3b806def-3d15-48a9-8a25-df200d6feef7"> - Linux <img width="320" alt="image" src="https://github.com/flutter/flutter/assets/6655696/89a4aa3d-2148-4f3b-b231-f93a057fee2b"> ## Related issues Part of #120127 Fixes https://github.com/flutter/flutter/issues/121401
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/fc2b7a9076b4...f803f2adec54 2024-03-20 skia-flutter-autoroll@skia.org Roll Skia from 2a6d55ab7a0b to 80e713052b7a (3 revisions) (flutter/engine#51551) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Pierre-Louis authored
Reland #128236, reverted in https://github.com/flutter/flutter/pull/143125 and https://github.com/flutter/flutter/pull/145261. This PR contains 3 additional commits, fixing post-submit tests on Android and Windows. ## Original description Improves the build output: 1. Gives confirmation that the build succeeded, in green 1. Gives the path to the built executable, without a trailing period to make it slightly easier to cmd/ctrl+open 1. Gives the size of the built executable (when the built executable is self contained) ### `apk`, `appbundle` <img width="607" alt="image" src="https://github.com/flutter/flutter/assets/6655696/ecc52abe-cd2e-4116-b22a-8385ae3e980d"> <img width="634" alt="image" src="https://github.com/flutter/flutter/assets/6655696/8af8bd33-c0bd-4215-9a06-9652ee019436"> ### `macos`, `ios`, `ipa` Build executables are self-contained and use a newly introduced `OperatingSystemUtils.getDirectorySize`. <img width="514" alt="image" src="https://github.com/flutter/flutter/assets/6655696/b5918a69-3959-4417-9205-4f501d185257"> <img width="581" alt="image" src="https://github.com/flutter/flutter/assets/6655696/d72fd420-18cf-4470-9e4b-b6ac10fbcd50"> <img width="616" alt="image" src="https://github.com/flutter/flutter/assets/6655696/5f235ce1-252a-4c13-898f-139f6c7bc698"> ### `windows`, `linux`, and `web` Build executables aren't self-contained, and folder size can sometimes overestimate distribution size, therefore their size isn't mentioned (see discussion below). <img width="647" alt="image" src="https://github.com/flutter/flutter/assets/6655696/7179e771-1eb7-48f6-b770-975bc073437b"> <img width="658" alt="image" src="https://github.com/flutter/flutter/assets/6655696/a6801cab-7b5a-4975-a406-f4c9fa44d7a2"> <img width="608" alt="image" src="https://github.com/flutter/flutter/assets/6655696/ee7c4125-a273-4a65-95d7-ab441edf8ac5"> ### Size reporting When applicable, the printed size matches the OS reported size. - macOS <img width="391" alt="image" src="https://github.com/flutter/flutter/assets/6655696/881cbfb1-d355-444b-ab44-c1a6343190ce"> - Windows <img width="338" alt="image" src="https://github.com/flutter/flutter/assets/6655696/3b806def-3d15-48a9-8a25-df200d6feef7"> - Linux <img width="320" alt="image" src="https://github.com/flutter/flutter/assets/6655696/89a4aa3d-2148-4f3b-b231-f93a057fee2b"> ## Related issues Part of #120127 Fixes https://github.com/flutter/flutter/issues/121401
-
engine-flutter-autoroll authored
https://github.com/flutter/packages/compare/a2f4ce0a5057...23e56af4a622 2024-03-19 43054281+camsim99@users.noreply.github.com [camerax] Update README to encourage users to opt in (flutter/packages#6352) 2024-03-19 dawidope@gmail.com [flutter_markdown] Allow for custom block element (flutter/packages#5815) 2024-03-19 10687576+bparrishMines@users.noreply.github.com [pigeon] Adds Dart implementation of ProxyApi (flutter/packages#6043) 2024-03-19 43054281+camsim99@users.noreply.github.com [camerax] Implements `setFocusMode` (flutter/packages#6176) 2024-03-19 engine-flutter-autoroll@skia.org Roll Flutter from f217fc17 to d31a85ba (23 revisions) (flutter/packages#6356) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/883adfe2ef61...fc2b7a9076b4 2024-03-20 skia-flutter-autoroll@skia.org Roll Skia from 885e8984707a to 2a6d55ab7a0b (1 revision) (flutter/engine#51550) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/f42fc937028c...883adfe2ef61 2024-03-20 skia-flutter-autoroll@skia.org Roll Skia from 6439105e49b2 to 885e8984707a (1 revision) (flutter/engine#51549) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/32ae508316a6...f42fc937028c 2024-03-20 skia-flutter-autoroll@skia.org Roll Skia from 8c8d0977c850 to 6439105e49b2 (1 revision) (flutter/engine#51548) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/1e89d04c6b52...32ae508316a6 2024-03-20 skia-flutter-autoroll@skia.org Roll Skia from 4dbd8f8986b7 to 8c8d0977c850 (2 revisions) (flutter/engine#51547) 2024-03-20 skia-flutter-autoroll@skia.org Roll Dart SDK from 253535f51966 to 1fec62355504 (1 revision) (flutter/engine#51546) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/e96b2b0047f7...1e89d04c6b52 2024-03-20 skia-flutter-autoroll@skia.org Roll Skia from 40729167b5cc to 4dbd8f8986b7 (2 revisions) (flutter/engine#51545) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/24b84203f6cc...e96b2b0047f7 2024-03-20 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from ppkQSDakw0QcsVt8u... to uINhDrQ3fkTE08_he... (flutter/engine#51544) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from ppkQSDakw0Qc to uINhDrQ3fkTE If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/3f67bc531eef...24b84203f6cc 2024-03-20 skia-flutter-autoroll@skia.org Roll Dart SDK from 7885a3fa6bfd to 253535f51966 (2 revisions) (flutter/engine#51542) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/00bfdb580b1b...3f67bc531eef 2024-03-19 skia-flutter-autoroll@skia.org Roll Skia from 0b3bd42131fe to 40729167b5cc (4 revisions) (flutter/engine#51539) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/dce639a4c453...00bfdb580b1b 2024-03-19 yjbanov@google.com [web] include the hint field in semantics labels (flutter/engine#51529) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
- 19 Mar, 2024 21 commits
-
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/bd3a9241c2c5...dce639a4c453 2024-03-19 skia-flutter-autoroll@skia.org Roll Skia from f67715b35713 to 0b3bd42131fe (12 revisions) (flutter/engine#51530) 2024-03-19 15619084+vashworth@users.noreply.github.com Regenerate FlutterMacOS.xcframework when sources of dependencies change (flutter/engine#51396) 2024-03-19 skia-flutter-autoroll@skia.org Roll Dart SDK from 7c64e31f4c3e to 7885a3fa6bfd (1 revision) (flutter/engine#51528) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/bacb027aa824...bd3a9241c2c5 2024-03-19 jacksongardner@google.com Fix slash in chromium path. (flutter/engine#51527) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Lau Ching Jun authored
A ProxiedDevice has two port forwarder, one to forward remote host port and another to forward remote device port. During an attach workflow, the port was forwarded by the latter. Update ProxiedDDS to make sure that it works in such case.
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/7095e6a4a643...bacb027aa824 2024-03-19 68449066+zijiehe-google-com@users.noreply.github.com [Fuchsia] Remove the legacy tools/fuchsia/target_api_level file (flutter/engine#51497) 2024-03-19 Breakthrough@users.noreply.github.com Update fuchsia_libs.gni (flutter/engine#51447) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/59138d5f8e88...7095e6a4a643 2024-03-19 skia-flutter-autoroll@skia.org Roll Skia from 02544e4d532a to f67715b35713 (1 revision) (flutter/engine#51522) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
hangyu authored
Add a `minTileHeight` to ListTile widget so its height can be customized to less than the default height. (#145244) fixes: https://github.com/flutter/flutter/issues/145369
-
Mitchell Goodwin authored
Fixes #138270. Moves the majority of the logic of MaterialStateProperties down to the widgets layer, then has the existing Material classes pull from the widgets versions.
-
goodmost authored
fix some comments
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/7ea6b003ffeb...59138d5f8e88 2024-03-19 skia-flutter-autoroll@skia.org Roll Dart SDK from 91dc69b6e337 to 7c64e31f4c3e (1 revision) (flutter/engine#51521) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/packages/compare/a757073ac4ea...a2f4ce0a5057 2024-03-18 49699333+dependabot[bot]@users.noreply.github.com [sign_in]: Bump com.google.android.gms:play-services-auth from 20.7.0 to 21.0.0 in /packages/google_sign_in/google_sign_in_android/android (flutter/packages#6159) 2024-03-18 engine-flutter-autoroll@skia.org Roll Flutter from 7c860ddf to f217fc17 (9 revisions) (flutter/packages#6350) 2024-03-18 16229121+leiatfly@users.noreply.github.com [flutter_markdown] Adds onSelectionChanged in Markdown (flutter/packages#6169) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/d8fbcfbd799c...7ea6b003ffeb 2024-03-19 skia-flutter-autoroll@skia.org Roll Skia from 5437dfce1c10 to 02544e4d532a (1 revision) (flutter/engine#51520) 2024-03-19 skia-flutter-autoroll@skia.org Roll Skia from e8822d85af59 to 5437dfce1c10 (1 revision) (flutter/engine#51518) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/4cec701f4635...d8fbcfbd799c 2024-03-19 skia-flutter-autoroll@skia.org Roll Skia from 0319ad036fdf to e8822d85af59 (1 revision) (flutter/engine#51517) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/c9fbe6bab899...4cec701f4635 2024-03-19 skia-flutter-autoroll@skia.org Roll Skia from 9dc3a597c6af to 0319ad036fdf (1 revision) (flutter/engine#51516) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/de6b8f49b849...c9fbe6bab899 2024-03-19 skia-flutter-autoroll@skia.org Roll Dart SDK from 3e64b8fcbfb7 to 91dc69b6e337 (1 revision) (flutter/engine#51515) 2024-03-19 skia-flutter-autoroll@skia.org Roll Skia from 62f3d0cbb9c8 to 9dc3a597c6af (1 revision) (flutter/engine#51514) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Bruno Leroux authored
## Description The PR updates `SingleActivator` in order to add a parameter for specifying that a shortcut depends on <kbd>NumLock</kbd> key state. Somewhat similarly to what is possible with common modifiers expect that a boolean is not enough in this case because: by default, a shortcut should ignore the <kbd>NumLock</kbd> state and it should be possible to define shortcuts that require <kbd>NumLock</kbd> to be locked and other that require it to be unlocked. @gspencergoog I considered defining a new `ShortcutActivator` implementation for this, but I thinks that adding the feature directly to `SingleActivator` results in a cleaner API. ## Related Issue Fixes https://github.com/flutter/flutter/issues/145144 Preparation for https://github.com/flutter/flutter/issues/144936 ## Tests Adds 3 tests.
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/59519ceee30a...de6b8f49b849 2024-03-19 skia-flutter-autoroll@skia.org Roll Skia from 726cccdbfd3d to 62f3d0cbb9c8 (2 revisions) (flutter/engine#51513) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/ac8f1f233d6f...59519ceee30a 2024-03-19 49699333+dependabot[bot]@users.noreply.github.com Bump actions/checkout from 4.1.1 to 4.1.2 (flutter/engine#51512) 2024-03-19 skia-flutter-autoroll@skia.org Roll Skia from 86de9a698b76 to 726cccdbfd3d (1 revision) (flutter/engine#51511) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/4a86b5b17c39...ac8f1f233d6f 2024-03-19 skia-flutter-autoroll@skia.org Roll Skia from f5d824314bf7 to 86de9a698b76 (2 revisions) (flutter/engine#51510) 2024-03-19 chinmaygarde@google.com Add missing license blocks. (flutter/engine#51496) 2024-03-19 skia-flutter-autoroll@skia.org Roll Dart SDK from f874a4976038 to 3e64b8fcbfb7 (1 revision) (flutter/engine#51509) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/c0d1b0d5d43f...4a86b5b17c39 2024-03-19 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from I5fL_9DJQBS1Bydbz... to ppkQSDakw0QcsVt8u... (flutter/engine#51507) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from I5fL_9DJQBS1 to ppkQSDakw0Qc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/3d909f14118e...c0d1b0d5d43f 2024-03-19 skia-flutter-autoroll@skia.org Roll Skia from 2f07d8e1829b to f5d824314bf7 (1 revision) (flutter/engine#51506) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/0ee413ee276a...3d909f14118e 2024-03-19 skia-flutter-autoroll@skia.org Roll Skia from 7e207af2200b to 2f07d8e1829b (1 revision) (flutter/engine#51505) 2024-03-18 skia-flutter-autoroll@skia.org Roll Skia from 9950dc8ec6fd to 7e207af2200b (4 revisions) (flutter/engine#51502) 2024-03-18 skia-flutter-autoroll@skia.org Roll Dart SDK from 47ab7cca8a83 to f874a4976038 (1 revision) (flutter/engine#51501) 2024-03-18 ian@hixie.ch More renderdoc_frame_capture.md updates (flutter/engine#51499) 2024-03-18 chinmaygarde@google.com [Impeller] Allow identifying device driver and vendor information. (flutter/engine#51498) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-