- 28 Jul, 2023 2 commits
-
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/01bb0a3ef922...0713d91c2e64 2023-07-27 skia-flutter-autoroll@skia.org Roll Skia from 100d67ed0b61 to 5403af73dfef (4 revisions) (flutter/engine#44088) 2023-07-27 skia-flutter-autoroll@skia.org Roll Skia from d3a7efb77af3 to 100d67ed0b61 (1 revision) (flutter/engine#44086) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/196474bd96b0...01bb0a3ef922 2023-07-27 skia-flutter-autoroll@skia.org Roll ANGLE from d5ddb710e5bd to 179924cbfaf3 (3 revisions) (flutter/engine#44085) 2023-07-27 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from FwIA6BaHtZg2mRS-0... to wgkZmRBHTT7DehhUL... (flutter/engine#44084) 2023-07-27 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from EpwAiaHKf6M6Yejtk... to e_QdQPRjE5lCfa2Hy... (flutter/engine#44083) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from FwIA6BaHtZg2 to wgkZmRBHTT7D fuchsia/sdk/core/mac-amd64 from EpwAiaHKf6M6 to e_QdQPRjE5lC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
- 27 Jul, 2023 17 commits
-
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/284771da323c...196474bd96b0 2023-07-27 skia-flutter-autoroll@skia.org Roll Skia from 20108acef7d2 to d3a7efb77af3 (2 revisions) (flutter/engine#44082) 2023-07-27 rmolivares@renzo-olivares.dev [iOS] TextInputPlugin should batch TextEditingDeltas and dispatch on the next runLoop (flutter/engine#43267) 2023-07-27 skia-flutter-autoroll@skia.org Roll Skia from b522808eb0af to 20108acef7d2 (3 revisions) (flutter/engine#44079) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Jonah Williams authored
Fixes https://github.com/flutter/flutter/issues/130524 loadBuffer was superseded by loadImage
-
David authored
The PR fixes template app documentation
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/9a935ecbf73a...284771da323c 2023-07-27 jonahwilliams@google.com Revert "[engine] disable picture complexity raster caching" (flutter/engine#44026) 2023-07-27 jonahwilliams@google.com [Impeller] Move glyph atlas state from context into lazy glyph atlas. (flutter/engine#43748) 2023-07-27 ian@hixie.ch Hide some log lines from release builds (flutter/engine#44073) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/f3317dbab388...9a935ecbf73a 2023-07-27 skia-flutter-autoroll@skia.org Roll Skia from 26ec2772960b to b522808eb0af (1 revision) (flutter/engine#44075) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
🐛 Alex Li authoredImproves #119596. The tests remain valid, so no tests were updated in the request. This does not resolve issue #128932, it's handled by another part of the code.
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/08050cdecf94...f3317dbab388 2023-07-27 skia-flutter-autoroll@skia.org Roll Dart SDK from dcbaffbd09dd to e851b8e49ade (2 revisions) (flutter/engine#44072) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Qun Cheng authored
This PR is to skip some unit tests in order to merging an [engine change](https://github.com/flutter/engine/pull/43983).
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/9b14c382eebf...08050cdecf94 2023-07-27 skia-flutter-autoroll@skia.org Roll Skia from 90048a938eb5 to 26ec2772960b (2 revisions) (flutter/engine#44070) 2023-07-27 skia-flutter-autoroll@skia.org Roll ANGLE from 8aa3ca9d177c to d5ddb710e5bd (1 revision) (flutter/engine#44069) 2023-07-27 30870216+gaaclarke@users.noreply.github.com [Impeller] trimmed 3 bytes off of each Glyph (flutter/engine#44054) 2023-07-27 skia-flutter-autoroll@skia.org Roll Skia from 6571d88db5b3 to 90048a938eb5 (1 revision) (flutter/engine#44066) 2023-07-27 skia-flutter-autoroll@skia.org Roll ANGLE from af5bf5b8245e to 8aa3ca9d177c (1 revision) (flutter/engine#44065) 2023-07-27 skia-flutter-autoroll@skia.org Roll Dart SDK from b6747a06be06 to dcbaffbd09dd (1 revision) (flutter/engine#44064) 2023-07-27 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from pgJmG2-qZVMzlMuq8... to EpwAiaHKf6M6Yejtk... (flutter/engine#44063) 2023-07-27 skia-flutter-autoroll@skia.org Roll Skia from 26ed0d2ab04c to 6571d88db5b3 (1 revision) (flutter/engine#44062) 2023-07-27 skia-flutter-autoroll@skia.org Roll Skia from e85c64d63787 to 26ed0d2ab04c (3 revisions) (flutter/engine#44061) 2023-07-27 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from DOxjABQZ-mA_9Lllw... to FwIA6BaHtZg2mRS-0... (flutter/engine#44060) 2023-07-27 jason-simmons@users.noreply.github.com Ignore the NOTICE.fuchsia file in the new license script (flutter/engine#44021) 2023-07-27 dnfield@google.com Embed a license readme in every zip archive (flutter/engine#43974) 2023-07-27 skia-flutter-autoroll@skia.org Roll Skia from 750d7f8ed4d7 to e85c64d63787 (4 revisions) (flutter/engine#44056) 2023-07-27 skia-flutter-autoroll@skia.org Roll Dart SDK from 8961d36eaa0c to b6747a06be06 (1 revision) (flutter/engine#44053) 2023-07-26 skia-flutter-autoroll@skia.org Roll ANGLE from 451b3c31a1fa to af5bf5b8245e (1 revision) (flutter/engine#44050) 2023-07-26 skia-flutter-autoroll@skia.org Roll Skia from fdf224be4f98 to 750d7f8ed4d7 (3 revisions) (flutter/engine#44049) 2023-07-26 skia-flutter-autoroll@skia.org Roll Dart SDK from b5710782b91c to 8961d36eaa0c (1 revision) (flutter/engine#44048) 2023-07-26 skia-flutter-autoroll@skia.org Roll Skia from 990aa6016ff6 to fdf224be4f98 (3 revisions) (flutter/engine#44046) 2023-07-26 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from d6O9t74z-k2svOmvz... to pgJmG2-qZVMzlMuq8... (flutter/engine#44045) 2023-07-26 skia-flutter-autoroll@skia.org Roll ANGLE from 58cb5c8396a3 to 451b3c31a1fa (1 revision) (flutter/engine#44044) 2023-07-26 skia-flutter-autoroll@skia.org Roll Skia from d76a9c3bb3fd to 990aa6016ff6 (4 revisions) (flutter/engine#44043) 2023-07-26 skia-flutter-autoroll@skia.org Roll Skia from ca48e45a0262 to d76a9c3bb3fd (1 revision) (flutter/engine#44042) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from DOxjABQZ-mA_ to FwIA6BaHtZg2 fuchsia/sdk/core/mac-amd64 from d6O9t74z-k2s to EpwAiaHKf6M6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/packages/compare/a99fc8765de9...f4ae9336ebb7 2023-07-27 engine-flutter-autoroll@skia.org Manual roll Flutter from bae1ac2f to 61fd11db (7 revisions) (flutter/packages#4572) 2023-07-26 engine-flutter-autoroll@skia.org Roll Flutter from 9def8f6b to bae1ac2f (27 revisions) (flutter/packages#4570) 2023-07-26 60025677+sdoshi983@users.noreply.github.com [go_router] fix(docs): improve docs and fix typo (flutter/packages#4414) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Jason Simmons authored
Dart SDK 3.2.x requires a new version of the dart_internal package.
-
Seiya Kokushi authored
Can configure modal barriers in Flutter's built-in dialogs.
-
Daco Harkes authored
Fixes: * https://github.com/flutter/flutter/issues/131261
-
keyonghan authored
This PR add instructions to separate DeviceLab tasks to build and test model.
-
Ian Hickson authored
Fixes https://github.com/flutter/flutter/issues/7037
-
Chris Evans authored
Pragma will allow future proofing Dart snapshot utilities to work by preserving the names of important classes used in platform channel communication @Hixie
-
- 26 Jul, 2023 21 commits
-
-
Loïc Sharma authored
The desktop team uses the [`a: desktop`](https://github.com/flutter/engine/pulls?q=is%3Aopen+label%3A%22affects%3A+desktop%22+sort%3Aupdated-desc) label to [triage](https://github.com/flutter/flutter/wiki/Triage#desktop-platforms-team-team-desktop) pull requests.
-
Ian Hickson authored
This primarily implements DecorationImage.lerp(). It also makes some minor tweaks, the main one of which is defering to dart:ui for `clampDouble` instead of duplicating it in package:foundation. Fixes https://github.com/flutter/flutter/issues/12452 This was first landed in https://github.com/flutter/flutter/pull/130533 and reverted in https://github.com/flutter/flutter/pull/131347.
-
Kate Lovett authored
These tweaks came from https://github.com/flutter/packages/pull/4536 - The TwoDimensionalChildBuilderDelegate asserts that maxXIndex and maxYIndex are null or >= 0 - The TwoDimensionalChildDelegate setter in RenderTwoDimensionalViewport has a covariant to allow type safety for subclasses of RenderTwoDimensionalViewport implementing with other subclasses of TwoDimensionalChildDelegate I'd like to cherry pick this so https://github.com/flutter/packages/pull/4536 will not have to wait for it to reach stable.
-
Loïc Sharma authored
Reverts flutter/flutter#131292 This PR is affected by https://g-issues.skia.org/issues/40045533. See @Piinks's [explanation](https://discord.com/channels/608014603317936148/613398423093116959/1133885989358678076): > The mirror is probably out of sync. The failing commit introduced new changes, but they have not been updated yet. I would revert the PR until we can check the mirror. Last week it went 2+ hours out of sync so rerunning it may not green the tree for a while.
-
Qun Cheng authored
Updated golden tests in * ink_sparkle_test.dart * material_test.dart * page_test.dart * progress_indicator_test.dart to have M2 and M3 versions. More info in #127064
-
Loïc Sharma authored
Reverts flutter/flutter#131102 as it closed the tree due to `Linux web_benchmarks_skwasm` failures. The test seems to be timing out without completing. Example failure: https://ci.chromium.org/ui/p/flutter/builders/prod/Linux%20web_benchmarks_skwasm/1/overview
-
Ian Hickson authored
Reverts flutter/flutter#130533 Tree breakage.
-
Ian Hickson authored
This primarily implements DecorationImage.lerp(). It also makes some minor tweaks, the main one of which is defering to dart:ui for `clampDouble` instead of duplicating it in package:foundation. Fixes https://github.com/flutter/flutter/issues/12452
-
Ian Hickson authored
Closes https://github.com/flutter/flutter/issues/6100.
-
Jackson Gardner authored
We've decided to use the `--omit-type-checks` flag for our dart2wasm benchmarks. Right now, many of the benchmark results are dominated by type checks and most of what we are actually trying to measure get drowned out in the noise.
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/ba83c144f84e...faf1121d010c 2023-07-26 skia-flutter-autoroll@skia.org Roll Skia from 5ace549dfae6 to ca48e45a0262 (4 revisions) (flutter/engine#44038) 2023-07-26 mdebbar@google.com [web] Provide convenient default factories for platform views (flutter/engine#43828) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/packages/compare/406eac1ad976...a99fc8765de9 2023-07-26 stuartmorgan@google.com [tool/ci] Add iOS/macOS and Dart support to `fetch-deps` (flutter/packages#4562) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Xilai Zhang authored
Reverts flutter/flutter#129274 temporarily putting up a revert in case a fix is difficult context: [b/293202068](http://b/293202068) youtube integration tests failed
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/89203002f455...ba83c144f84e 2023-07-26 skia-flutter-autoroll@skia.org Roll Skia from 826e38ba8db3 to 5ace549dfae6 (2 revisions) (flutter/engine#44034) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/b3cd1c599abe...89203002f455 2023-07-26 skia-flutter-autoroll@skia.org Roll ANGLE from a09773110c4a to 58cb5c8396a3 (1 revision) (flutter/engine#44033) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/4bdceccff964...b3cd1c599abe 2023-07-26 leroux_bruno@yahoo.fr [macOS] Return keyboard pressed state (flutter/engine#42878) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/df12fff329a1...4bdceccff964 2023-07-26 dnfield@google.com [Impeller] Remove duplicated code. (flutter/engine#44024) 2023-07-26 bdero@google.com [Impeller] Only strip the translation from backdrop filter effect transforms. (flutter/engine#44029) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/43f727e4748a...df12fff329a1 2023-07-26 ditman@gmail.com [web] Preserve canvaskit variant during tests. (flutter/engine#43868) 2023-07-26 skia-flutter-autoroll@skia.org Roll Skia from 28773cec6e8d to 826e38ba8db3 (5 revisions) (flutter/engine#44031) 2023-07-26 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from 0StTjIqUxGkc3nOWT... to d6O9t74z-k2svOmvz... (flutter/engine#44030) Also rolling transitive DEPS: fuchsia/sdk/core/mac-amd64 from 0StTjIqUxGkc to d6O9t74z-k2s If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/7f3b0d6b7250...43f727e4748a 2023-07-26 skia-flutter-autoroll@skia.org Roll ANGLE from 84f5295c9782 to a09773110c4a (1 revision) (flutter/engine#44028) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/db711f14842b...7f3b0d6b7250 2023-07-26 jacksongardner@google.com Roll fallback fonts. (flutter/engine#44000) 2023-07-26 skia-flutter-autoroll@skia.org Roll Skia from 12d41b6f66ed to 28773cec6e8d (2 revisions) (flutter/engine#44011) 2023-07-26 paulberry@google.com Prepare flutter engine for enabling private final field promotion. (flutter/engine#43959) 2023-07-26 skia-flutter-autoroll@skia.org Manual roll Dart SDK from 61ab5422fb7b to b1e82e2e55b2 (3 revisions) (flutter/engine#44018) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Caffeinix authored
The Apple Human Interface Guidelines give a specific ordering of the symbols used as modifier keys in menu shortcuts. These guidelines are encoded into the native Cocoa or UIKit menu classes, and are intended to ensure that symbols are always aligned into columns of like symbols and do not move around in the case of dynamic menu items (for example, holding Option will transform certain menu items into different versions that take the Option key, so the Option key symbol appears to the left of most other symbols to avoid reordering). The Material spec says to use symbols for modifier keys on Mac and iOS, as this is what users there are familiar with. It stands to reason that we should follow the platform guidelines fully, so this changes the MenuItemButton class to honor the HIG-compliant symbol ordering on Mac and iOS. Fixed: #129308
-