- 20 Aug, 2020 3 commits
-
-
Ming Lyu (CareF) authored
-
Christopher Fujino authored
-
Todd Volkert authored
* (insert|move|remove)ChildRenderObject Deprecation: Step 1 This deprecates the following methods: * RenderObjectElement.insertChildRenderObject * RenderObjectElement.moveChildRenderObject * RenderObjectElement.removeChildRenderObject ...and replaces them with the following methods: * RenderObjectElement.insertRenderObjectChild * RenderObjectElement.moveRenderObjectChild * RenderObjectElement.removeRenderObjectChild The reason for the deprecation is to provide the `oldSlot` argument to the `moveRenderObjectChild` method (such an argument was missing from the now-deprecated `moveChildRenderObject` method) and the `slot` argument to the `removeRenderObjectChild` method (such an argument was missing from the now-deprecated `removeChildRenderObject` method). While no argument was added to `insertRenderObjectChild`, the name change (and corresponding deprecation) was made to maintain naming parity with the other two methods. This initial step does not update or remove any of the `slotToChild` patterns that exist in the framework. This work is being separated into two commits in case something needs to be reverted to minimize the scope of each commit. See https://github.com/flutter/flutter/issues/63269 for more info
-
- 19 Aug, 2020 37 commits
-
-
Jonah Williams authored
Update to latest dwds, file-nullsafety, and process-nullsafety for #62886
-
chunhtai authored
-
Jimmy Robert authored
-
engine-flutter-autoroll authored
-
Jonah Williams authored
-
Greg Spencer authored
This standardizes the handling of nullability for the LogicalKeyboardKey.keyLabel and RawKeyEventData.keyLabel accessors so that they are non-nullable, but can be empty. Before this change, the keyLabel could be either null or an empty string to indicate that there wasn't a label, which makes it harder to test for, since both need to be checked for. Since an empty string is sufficient, there is no need for it to be nullable. Also, in raw_keyboard.dart, the web and Windows implementations wouldn't accept null values for parameters in the Map coming from the message, but tests were supplying null for some of them. This makes web and Windows creation of events match the other platforms, and makes the migration of tests to non-nullability easier.
-
Jonah Williams authored
Like Android/iOS, only enable --null-assertions if asked. Previously this was enabled by default for web, but in general this has proved to be too breaking to enable by default. #61042
-
Tong Wu authored
-
Jonah Williams authored
Attempt to simplify the Android SDK interface ahead of refactoring it. The locateAndroidSdk static method is called at startup to locate the android SDK, returning null if it cannot be found. These helper methods attempted to first look up the AndroidSDK if it was already null - which could only cover the case where someone installed the Android SDK while flutter was running (possibly through an IDE)
-
Zachary Anderson authored
-
Justin McCandless authored
-
engine-flutter-autoroll authored
-
Darren Austin authored
-
Mouad Debbar authored
-
Rami authored
-
Yuqian Li authored
-
Jonah Williams authored
Reland of acdb909f with fixes to semantics.dart #61042
-
Yuqian Li authored
These tests look quite stable for the last 10 runs.
-
engine-flutter-autoroll authored
-
Masayuki Ono (mono) authored
-
Tong Wu authored
-
Jonah Williams authored
-
Rami authored
-
LongCatIsLooong authored
-
Justin McCandless authored
-
godofredoc authored
Bug: https://github.com/flutter/flutter/issues/64121
-
Michael Goderbauer authored
-
Jenn Magder authored
This reverts commit acdb909f.
-
Tong Wu authored
-
Michael Goderbauer authored
-
Jonah Williams authored
-
xster authored
-
Michael Goderbauer authored
-
Jenn Magder authored
-
Ming Lyu (CareF) authored
-
godofredoc authored
-
Jonah Williams authored
-