Commits · 1f07909c4d390c42026e0cd19b5c1dfe4b43e1ff · abdullh.alsoleman / Front-End

06 Dec, 2023 10 commits

Roll Packages from 4e7f160127ed to ca16173e67e4 (3 revisions) (#139661) · 1f07909c

engine-flutter-autoroll authored Dec 06, 2023

https://github.com/flutter/packages/compare/4e7f160127ed...ca16173e67e4

2023-12-05 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Bump actions/labeler from 4.3.0 to 5.0.0" (flutter/packages#5579)
2023-12-05 49699333+dependabot[bot]@users.noreply.github.com Bump actions/labeler from 4.3.0 to 5.0.0 (flutter/packages#5568)
2023-12-05 36861262+QuncCccccc@users.noreply.github.com [file_selector] Remove deprecated `primary` and `onPrimary` references from `ElevatedButton.styleFrom` (flutter/packages#5566)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

1f07909c

Update `Tooltip` tests for Material 3 (#139145) · 3c8700c2
Taha Tesser authored Dec 06, 2023
```
Updated unit tests for `Tooltip` to have M2 and M3 versions.

More info in #139076
```
3c8700c2

Fix `DatePicker` Dialog content not visible on lower text scale (#139236) · 2f95a5a3

Taha Tesser authored Dec 06, 2023

fixes [`DatePicker` dialog contents are hidden when using smaller text size](https://github.com/flutter/flutter/issues/139120)

### Description
- Fixed `DatePicker` dialog contents are hidden when using smaller text size.
- Add golden tests

### Golden Test (Before)

| `TextScale - 0.88` | `TextScale - 1.0` | `TextScale - 2.0` | 
| --------------- |  --------------- |  --------------- | 
|   <img src="https://github.com/flutter/flutter/assets/48603081/9f301c5d-3acd-4a9f-8fb7-aa7b2e9553a2"> |  <img src="https://github.com/flutter/flutter/assets/48603081/0496cf1a-5086-4cb1-ad3f-256f34346920"> | <img src="https://github.com/flutter/flutter/assets/48603081/2d1e1892-435a-4938-a7fc-2ffa4684828b"> | 

### Golden Test (After)

| `TextScale - 0.88` | `TextScale - 1.0` | `TextScale - 2.0` | 
| --------------- |  --------------- |  --------------- | 
|   <img src="https://github.com/flutter/flutter/assets/48603081/8fb922b7-0f2c-4f08-a091-b359a01e3600"> |  <img src="https://github.com/flutter/flutter/assets/48603081/59933cbf-49ef-46fb-98b5-217db2cc0ee7"> | <img src="https://github.com/flutter/flutter/assets/48603081/fd2501cb-511c-4b57-a4eb-f583af60aed7"> |

2f95a5a3

Roll Flutter Engine from 6e0ad1b16698 to 273a604d0854 (1 revision) (#139647) · 92c2cadc

engine-flutter-autoroll authored Dec 06, 2023

https://github.com/flutter/engine/compare/6e0ad1b16698...273a604d0854

2023-12-06 skia-flutter-autoroll@skia.org Roll Dart SDK from 9e54241e915a to 691e4650ce91 (1 revision) (flutter/engine#48725)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

92c2cadc

Roll Flutter Engine from 695851108953 to 6e0ad1b16698 (2 revisions) (#139638) · b6e04d58

engine-flutter-autoroll authored Dec 06, 2023

https://github.com/flutter/engine/compare/695851108953...6e0ad1b16698

2023-12-06 skia-flutter-autoroll@skia.org Roll Skia from 3043b8051f15 to afa75c6cf697 (1 revision) (flutter/engine#48722)
2023-12-06 skia-flutter-autoroll@skia.org Roll Skia from cd23ebc87188 to 3043b8051f15 (1 revision) (flutter/engine#48716)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

b6e04d58

Roll Flutter Engine from 899b88afc5f9 to 695851108953 (2 revisions) (#139625) · 42eeee8b

engine-flutter-autoroll authored Dec 06, 2023

https://github.com/flutter/engine/compare/899b88afc5f9...695851108953

2023-12-06 skia-flutter-autoroll@skia.org Roll Skia from 5f54e9f84cff to cd23ebc87188 (1 revision) (flutter/engine#48714)
2023-12-06 skia-flutter-autoroll@skia.org Roll Dart SDK from c3bd23e62ece to 9e54241e915a (1 revision) (flutter/engine#48715)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

42eeee8b

Roll Flutter Engine from fe96317750ff to 899b88afc5f9 (1 revision) (#139621) · bea04f63

engine-flutter-autoroll authored Dec 06, 2023

https://github.com/flutter/engine/compare/fe96317750ff...899b88afc5f9

2023-12-06 skia-flutter-autoroll@skia.org Roll Dart SDK from d8efef525ce1 to c3bd23e62ece (1 revision) (flutter/engine#48710)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

bea04f63

Roll Flutter Engine from 3e661e0a58cc to fe96317750ff (2 revisions) (#139612) · a0f42655

engine-flutter-autoroll authored Dec 06, 2023

https://github.com/flutter/engine/compare/3e661e0a58cc...fe96317750ff

2023-12-06 jonahwilliams@google.com [Impeller] Vulkan framebuffer fetch via VK_ARM_RASTERIZATION_ORDER_ATTACHMENT_ACCESS (flutter/engine#48458)
2023-12-06 godofredoc@google.com Remove fuchsia v1 builder. (flutter/engine#48703)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

a0f42655

Roll Flutter Engine from 647cf405f3dc to 3e661e0a58cc (3 revisions) (#139609) · 36444bcd

engine-flutter-autoroll authored Dec 06, 2023

https://github.com/flutter/engine/compare/647cf405f3dc...3e661e0a58cc

2023-12-05 jason-simmons@users.noreply.github.com [Impeller] Declare specialization constants as floats. (flutter/engine#48644)
2023-12-05 102626803+drewroengoogle@users.noreply.github.com Fix labeler not actually doing any labeling (flutter/engine#48701)
2023-12-05 dnfield@google.com Roll abseil to d07bb1bc8e59b37204d457ee365b52b0d11feec0 (flutter/engine#48700)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

36444bcd

Add linked dart doc for Display on media query. (#139587) · e15cb7f8

Reid Baker authored Dec 06, 2023

FlutterView.display.size tells you the resolution of the display on supported platforms. FlutterView.physicalSize tells you the view size, which may be different from the display. This can help you tell if you are being letterboxed on android.

https://medium.com/flutter/developing-flutter-apps-for-large-screens-53b7b0e17f10

Related to [flutter/website/9896](https://github.com/flutter/website/issues/9896)

e15cb7f8

05 Dec, 2023 25 commits

Roll Flutter Engine from c49b861832d3 to 647cf405f3dc (1 revision) (#139598) · 4a4801de

engine-flutter-autoroll authored Dec 05, 2023

https://github.com/flutter/engine/compare/c49b861832d3...647cf405f3dc

2023-12-05 skia-flutter-autoroll@skia.org Roll Dart SDK from 8bfec2c7ed43 to d8efef525ce1 (1 revision) (flutter/engine#48697)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

4a4801de

Fix labeler not actually doing any labeling (#139596) · e69024d6

Drew Roen authored Dec 05, 2023

https://github.com/flutter/flutter/issues/139511

The initial formatting that landed just prevented it from failing, but it turns out the new format is completely overhauled.

e69024d6

Roll Flutter Engine from 96604392231a to c49b861832d3 (3 revisions) (#139595) · 5bce16de

engine-flutter-autoroll authored Dec 05, 2023

https://github.com/flutter/engine/compare/96604392231a...c49b861832d3

2023-12-05 chinmaygarde@google.com Avoid non-const sizes in VLAs. (flutter/engine#48693)
2023-12-05 jonahwilliams@google.com [Impeller] Prefer moving vertex buffer, place on command instead of binding object. (flutter/engine#48630)
2023-12-05 skia-flutter-autoroll@skia.org Roll Skia from c759bbf16310 to 5f54e9f84cff (3 revisions) (flutter/engine#48692)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

5bce16de

Roll Flutter Engine from cfdaecc2d2b7 to 96604392231a (1 revision) (#139586) · 4ea7a980

engine-flutter-autoroll authored Dec 05, 2023

https://github.com/flutter/engine/compare/cfdaecc2d2b7...96604392231a

2023-12-05 skia-flutter-autoroll@skia.org Roll Skia from c0ad3e9bdec0 to c759bbf16310 (1 revision) (flutter/engine#48689)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

4ea7a980

Roll pub packages (#139510) · 935c8e8e
flutter-pub-roller-bot authored Dec 05, 2023
```
This PR was generated by `flutter update-packages --force-upgrade`.
```
935c8e8e

Roll Flutter Engine from 7133378566d1 to cfdaecc2d2b7 (7 revisions) (#139583) · 1c1b2bff

engine-flutter-autoroll authored Dec 05, 2023

https://github.com/flutter/engine/compare/7133378566d1...cfdaecc2d2b7

2023-12-05 jonnywang@google.com A11y enabled state (flutter/engine#48653)
2023-12-05 skia-flutter-autoroll@skia.org Roll Skia from bf1db1c75704 to c0ad3e9bdec0 (1 revision) (flutter/engine#48685)
2023-12-05 30870216+gaaclarke@users.noreply.github.com [Impeller] started taking into account integer gaps in blur sigma, turned on linear filter (flutter/engine#48651)
2023-12-05 skia-flutter-autoroll@skia.org Roll Dart SDK from 21574eae3a69 to 8bfec2c7ed43 (2 revisions) (flutter/engine#48683)
2023-12-05 102626803+drewroengoogle@users.noreply.github.com Update labeler to 5.0.0, fix yaml format for labeler 5.0.0 (flutter/engine#48682)
2023-12-05 jonahwilliams@google.com [Impeller] Make Entity move only, simplify construction of geometry/filter contents. (flutter/engine#48596)
2023-12-05 jonahwilliams@google.com [Impeller] Delete tessellation control/eval shader support. (flutter/engine#48649)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

1c1b2bff

Support for dismissDirection property in SnackBarTheme (#139068) · af61c6c7

Shanmugam authored Dec 05, 2023

This PR introduces a new feature that allows users to configure the 'dismissDirection' in SnackBarTheme. This enhancement provides users with the flexibility to set the 'dismissDirection' property in the ThemeData, rather than having to apply it each time when initializing a snack bar. This streamlines the process and makes it more convenient for users to manage and customize the behavior of snack bars within their applications.

Fixes #139012

af61c6c7

Roll Flutter Engine from e6b872b01fde to 7133378566d1 (2 revisions) (#139575) · 88d65375

engine-flutter-autoroll authored Dec 05, 2023

https://github.com/flutter/engine/compare/e6b872b01fde...7133378566d1

2023-12-05 skia-flutter-autoroll@skia.org Roll Skia from 7901100ba2d9 to bf1db1c75704 (2 revisions) (flutter/engine#48680)
2023-12-05 103135467+sealesj@users.noreply.github.com Use flutter mirrors for non-Google github origin deps (flutter/engine#48642)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

88d65375

Update generate_gradle_lockfiles script to represent newer templates, and run it on dev/ (#135175) · 4ce5421c

Gray Mackall authored Dec 05, 2023

Upgrades agp versions and lockfiles for `dev/`. Also changes the lockfile generation script to represent the newer form of the `settings.gradle` template, and therefore also propagates these changes.

~~Potentially related to https://github.com/flutter/flutter/issues/134419~~, but worth doing anyways. (not actually related)

4ce5421c

Roll Flutter Engine from 39ae00bf5328 to e6b872b01fde (2 revisions) (#139573) · 6099aef1

engine-flutter-autoroll authored Dec 05, 2023

https://github.com/flutter/engine/compare/39ae00bf5328...e6b872b01fde

2023-12-05 jonahwilliams@google.com [Impeller] Render emoji shadows with correct colors. (flutter/engine#48593)
2023-12-05 jonahwilliams@google.com [Impeller] Document what some of this shader metadata is. (flutter/engine#48647)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

6099aef1

Move docs to use their own recipe. (#139521) · ff881bad

godofredoc authored Dec 05, 2023

This is part of the deprecation of adhoc tests.

Bug: https://github.com/flutter/flutter/issues/139153

ff881bad

Removed deprecated NavigatorState.focusScopeNode (#139260) · 40405706

Kate Lovett authored Dec 05, 2023

Part of https://github.com/flutter/flutter/issues/139243

Deprecated in https://github.com/flutter/flutter/pull/109702

The replacement for focusScopeNode is focusNode.enclosingScope

40405706

Remove stray print (#139550) · 12aa1987
Ian Hickson authored Dec 05, 2023
```
It's making the tests have a lot of logspam.
```
12aa1987

Roll Flutter Engine from 78584fec8e52 to 39ae00bf5328 (2 revisions) (#139570) · 66da20a4

engine-flutter-autoroll authored Dec 05, 2023

https://github.com/flutter/engine/compare/78584fec8e52...39ae00bf5328

2023-12-05 skia-flutter-autoroll@skia.org Roll Skia from 3040f78eeb71 to 7901100ba2d9 (3 revisions) (flutter/engine#48677)
2023-12-05 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Bump actions/labeler from 4.3.0 to 5.0.0" (flutter/engine#48676)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

66da20a4

Update labeler version, fix yaml to work with v5 (#139564) · a82ae232

Drew Roen authored Dec 05, 2023

This fixes https://github.com/flutter/flutter/issues/139511

* A bug has been fixed with `sync-labels`, meaning this needs to be a boolean now. Setting to `true` to match v4 logic.
* in `labeler.yml`, all labels must be a list of globs, so updated them all to be a list of `any`.
* Update the version to v5

This is a little annoying to test, since the way github actions works means that changes to workflows aren't run until after they are merged. A workaround is I forked these labeler changes to a new branch in my own repo and created a PR to merge to that branch, seen here: https://github.com/drewroengoogle/flutter/actions/runs/7102118110/job/19331743809?pr=2. Note the step `Run actions/labeler@8558fd74291d67161a8a78ce36a881fa63b766a9` which ensures we are running on the latest labeler version in that check.

a82ae232

Roll Packages from 5d9874f69bce to 4e7f160127ed (4 revisions) (#139565) · ea97fc48

engine-flutter-autoroll authored Dec 05, 2023

https://github.com/flutter/packages/compare/5d9874f69bce...4e7f160127ed

2023-12-04 737941+loic-sharma@users.noreply.github.com [ci] Add Windows Arm64 stable build-only test (flutter/packages#5533)
2023-12-04 stuartmorgan@google.com [various] Update mockito to 5.4.3 (flutter/packages#5530)
2023-12-04 43759233+kenzieschmoll@users.noreply.github.com Add an optional parameter `initialPage` to `serveWebBenchmark` (flutter/packages#5538)
2023-12-04 engine-flutter-autoroll@skia.org Roll Flutter from d861ce49 to f35d049e (7 revisions) (flutter/packages#5564)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

ea97fc48

Roll Flutter Engine from 72d6a42f74b1 to 78584fec8e52 (1 revision) (#139548) · 315a8f4c

engine-flutter-autoroll authored Dec 05, 2023

https://github.com/flutter/engine/compare/72d6a42f74b1...78584fec8e52

2023-12-05 skia-flutter-autoroll@skia.org Roll Skia from a998afefb1b0 to 3040f78eeb71 (1 revision) (flutter/engine#48663)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

315a8f4c

Send an event when proxied DDS creates a connection. (#139530) · 7a9adfd1
Lau Ching Jun authored Dec 05, 2023
```
The event allows tools to listen and connect to the original DDS port.
```
7a9adfd1

Roll Flutter Engine from 2923201bc337 to 72d6a42f74b1 (3 revisions) (#139547) · c396011e

engine-flutter-autoroll authored Dec 05, 2023

https://github.com/flutter/engine/compare/2923201bc337...72d6a42f74b1

2023-12-05 49699333+dependabot[bot]@users.noreply.github.com Bump actions/labeler from 4.3.0 to 5.0.0 (flutter/engine#48662)
2023-12-05 skia-flutter-autoroll@skia.org Roll Skia from de49aeaa8224 to a998afefb1b0 (1 revision) (flutter/engine#48660)
2023-12-05 skia-flutter-autoroll@skia.org Roll Skia from d37625f80ac0 to de49aeaa8224 (1 revision) (flutter/engine#48658)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

c396011e

Make `handleJsonEvent` public so that it can be overridden internally. (#139531) · 63c58a33
Lau Ching Jun authored Dec 05, 2023

63c58a33

Roll Flutter Engine from f43ef6cbddb0 to 2923201bc337 (2 revisions) (#139540) · 2c613504

engine-flutter-autoroll authored Dec 05, 2023

https://github.com/flutter/engine/compare/f43ef6cbddb0...2923201bc337

2023-12-05 chinmaygarde@google.com [Impeller] Remove duplicate entity test suite instantiations. (flutter/engine#48654)
2023-12-05 skia-flutter-autoroll@skia.org Roll Dart SDK from 9c74645153ca to 21574eae3a69 (1 revision) (flutter/engine#48655)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

2c613504

Roll Flutter Engine from de0ba840339c to f43ef6cbddb0 (5 revisions) (#139536) · bfaacd5e

engine-flutter-autoroll authored Dec 05, 2023

https://github.com/flutter/engine/compare/de0ba840339c...f43ef6cbddb0

2023-12-05 skia-flutter-autoroll@skia.org Roll Dart SDK from a1b67665b3a3 to 9c74645153ca (1 revision) (flutter/engine#48648)
2023-12-05 jonahwilliams@google.com [Impeller] Remove impeller::Path copy constructor. (flutter/engine#48616)
2023-12-04 jonahwilliams@google.com [Impeller] Move BufferView/Texture/Sampler when binding. (flutter/engine#48628)
2023-12-04 skia-flutter-autoroll@skia.org Roll Skia from cbd2cf40d63b to d37625f80ac0 (1 revision) (flutter/engine#48643)
2023-12-04 jiahaog@users.noreply.github.com Add `flutter` prefix to import (flutter/engine#48617)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

bfaacd5e

Reverts "Bump actions/labeler from 4.3.0 to 5.0.0" (#139534) · b278f0f1

auto-submit[bot] authored Dec 05, 2023

Reverts flutter/flutter#139506
Initiated by: godofredoc
This change reverts the following previous change:
Original Description:
Bumps [actions/labeler](https://github.com/actions/labeler) from 4.3.0 to 5.0.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/actions/labeler/releases">actions/labeler's releases</a>.</em></p>
<blockquote>
<h2>v5.0.0</h2>
<h2>What's Changed</h2>
<p>This release contains the following breaking changes:</p>
<ol>
<li>
<p>The ability to apply labels based on the names of base and/or head branches was added (<a href="https://redirect.github.com/actions/labeler/issues/186">#186</a> and <a href="https://redirect.github.com/actions/labeler/issues/54">#54</a>). The match object for changed files was expanded with new combinations in order to make it more intuitive and flexible (<a href="https://redirect.github.com/actions/labeler/issues/423">#423</a> and <a href="https://redirect.github.com/actions/labeler/issues/101">#101</a>). As a result, the configuration file structure was significantly redesigned and is not compatible with the structure of the previous version. Please read the <a href="https://github.com/actions/labeler/tree/main#pull-request-labeler">action documentation</a> to find out how to adapt your configuration files for use with the new action version.</p>
</li>
<li>
<p>The bug related to the <code>sync-labels</code> input was fixed (<a href="https://redirect.github.com/actions/labeler/issues/112">#112</a>). Now the input value is read correctly.</p>
</li>
<li>
<p>By default, <code>dot</code> input is set to <code>true</code>. Now, paths starting with a dot (e.g. <code>.github</code>) are matched by default.</p>
</li>
<li>
<p>Version 5 of this action updated the <a href="https://docs.github.com/en/actions/creating-actions/metadata-syntax-for-github-actions#runs-for-javascript-actions">runtime to Node.js 20</a>. All scripts are now run with Node.js 20 instead of Node.js 16 and are affected by any breaking changes between Node.js 16 and 20.</p>
</li>
</ol>
<p>For more information, please read the <a href="https://github.com/actions/labeler/tree/main#pull-request-labeler">action documentation</a>.</p>
<h2>New Contributors</h2>
<ul>
<li><a href="https://github.com/joshdales"><code>@joshdales</code></a> made their first contribution in <a href="https://redirect.github.com/actions/labeler/pull/203">actions/labeler#203</a></li>
<li><a href="https://github.com/dusan-trickovic"><code>@dusan-trickovic</code></a> made their first contribution in <a href="https://redirect.github.com/actions/labeler/pull/626">actions/labeler#626</a></li>
<li><a href="https://github.com/sungh0lim"><code>@sungh0lim</code></a> made their first contribution in <a href="https://redirect.github.com/actions/labeler/pull/630">actions/labeler#630</a></li>
<li><a href="https://github.com/TrianguloY"><code>@TrianguloY</code></a> made their first contribution in <a href="https://redirect.github.com/actions/labeler/pull/629">actions/labeler#629</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/actions/labeler/compare/v4...v5.0.0">https://github.com/actions/labeler/compare/v4...v5.0.0</a></p>
<h2>v5.0.0-beta.1</h2>
<h2>What's Changed</h2>
<p>In scope of this beta release, the structure of the configuration file (<code>.github/labeler.yml</code>) was changed from</p>
<pre lang="yml"><code>LabelName:
- any:
  - changed-files: ['list', 'of', 'globs']
  - base-branch: ['list', 'of', 'regexps']
  - head-branch: ['list', 'of', 'regexps']
- all:
  - changed-files: ['list', 'of', 'globs']
  - base-branch: ['list', 'of', 'regexps']
  - head-branch: ['list', 'of', 'regexps']
</code></pre>
<p>to</p>
<pre lang="yml"><code>LabelName:
- any:
  - changed-files: 
    - AnyGlobToAnyFile: ['list', 'of', 'globs']
    - AnyGlobToAllFiles: ['list', 'of', 'globs']
    - AllGlobsToAnyFile: ['list', 'of', 'globs']
    - AllGlobsToAllFiles: ['list', 'of', 'globs']
  - base-branch: ['list', 'of', 'regexps']
  - head-branch: ['list', 'of', 'regexps']
- all:
  - changed-files:
    - AnyGlobToAnyFile: ['list', 'of', 'globs']
    - AnyGlobToAllFiles: ['list', 'of', 'globs']
    - AllGlobsToAnyFile: ['list', 'of', 'globs']
&lt;/tr&gt;&lt;/table&gt; 
</code></pre>
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/actions/labeler/commit/8558fd74291d67161a8a78ce36a881fa63b766a9"><code>8558fd7</code></a> Merge pull request <a href="https://redirect.github.com/actions/labeler/issues/709">#709</a> from actions/v5.0.0-beta</li>
<li><a href="https://github.com/actions/labeler/commit/000ca75fe6c5838c790ca73b764419065c1594a6"><code>000ca75</code></a> Merge pull request <a href="https://redirect.github.com/actions/labeler/issues/700">#700</a> from MaksimZhukov/apply-suggestions-and-update-docume...</li>
<li><a href="https://github.com/actions/labeler/commit/cb66c2f0788d382da1dabd06a094c0bc6ed3e26a"><code>cb66c2f</code></a> Update dist</li>
<li><a href="https://github.com/actions/labeler/commit/9181355e36dc8e434c93ba5aaa33f699c4162f38"><code>9181355</code></a> Apply suggestions for the beta vesrion and update the documentation</li>
<li><a href="https://github.com/actions/labeler/commit/efe4c1c90edf0ec238b5ee13e66e1abcbbe7446e"><code>efe4c1c</code></a> Merge pull request <a href="https://redirect.github.com/actions/labeler/issues/699">#699</a> from MaksimZhukov/update-node-runtime-and-dependencies</li>
<li><a href="https://github.com/actions/labeler/commit/c0957ad7c30fb0638e275122d51df2330459854a"><code>c0957ad</code></a> Run Prettier</li>
<li><a href="https://github.com/actions/labeler/commit/8dc8d1842f2f3ed1cf6f4190490ad02e0a755f0c"><code>8dc8d18</code></a> Update Node.js version in reusable workflows</li>
<li><a href="https://github.com/actions/labeler/commit/d0d0bbebfbe119c8403a0e2724c5fa5b555c78b9"><code>d0d0bbe</code></a> Update documentation</li>
<li><a href="https://github.com/actions/labeler/commit/1375c42512e0b855687040307d6dcaf403da9a4e"><code>1375c42</code></a> 5.0.0</li>
<li><a href="https://github.com/actions/labeler/commit/ab7411ec21ea67102994adc0fa01b3f5cf63509f"><code>ab7411e</code></a> Change version of Node.js runtime to node20</li>
<li>Additional commits viewable in <a href="https://github.com/actions/labeler/compare/ac9175f8a1f3625fd0d4fb234536d26811351594...8558fd74291d67161a8a78ce36a881fa63b766a9">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=actions/labeler&package-manager=github_actions&previous-version=4.3.0&new-version=5.0.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

b278f0f1

Reverts "Update sync-labels to use boolean" (#139533) · 5422af74

auto-submit[bot] authored Dec 05, 2023

Reverts flutter/flutter#139516
Initiated by: godofredoc
This change reverts the following previous change:
Original Description:
https://github.com/actions/labeler/issues/112 has been fixed, and now requires boolean to be used. 

Related infra issue that this fixes: https://github.com/flutter/flutter/issues/139511

5422af74

Fix `DropdownMenu` throwing `TextEditingController` disposed error on select (#139385) · 8ec4c59e

Greg Spencer authored Dec 05, 2023

## Description

When a DropdownMenu exists within another menu and a MenuItem is selected, the `TextEditingController` of the DropdownMenu is used after it has been disposed.

This PR manages the local `TextController` instance better, making sure that the one used when building is the current one, and handling the case where the `controller` is set on the widget after initial creation.

Also, places where we were setting the text and selection separately were converted to use `TextEditingValue` and set the value atomically.

## Related Issues
 - Fixes https://github.com/flutter/flutter/issues/139266

## Tests
 - Added tests (Created by @josh-burton  in https://github.com/flutter/flutter/pull/139268 - Thanks Josh!)

8ec4c59e

04 Dec, 2023 5 commits

increase sharding of windows build tests (#139503) · 79d6781b
Christopher Fujino authored Dec 04, 2023
```
Fixes https://github.com/flutter/flutter/issues/139502
```
79d6781b

Update sync-labels to use boolean (#139516) · e1a2bb37

Drew Roen authored Dec 04, 2023

https://github.com/actions/labeler/issues/112 has been fixed, and now requires boolean to be used. 

Related infra issue that this fixes: https://github.com/flutter/flutter/issues/139511

e1a2bb37

Roll Flutter Engine from c6395d920786 to de0ba840339c (6 revisions) (#139507) · 1567a9d6

engine-flutter-autoroll authored Dec 04, 2023

https://github.com/flutter/engine/compare/c6395d920786...de0ba840339c

2023-12-04 skia-flutter-autoroll@skia.org Roll Skia from 0fe76d9ce79e to cbd2cf40d63b (1 revision) (flutter/engine#48638)
2023-12-04 dnfield@google.com Remove some trivial forward declares from Impeller (flutter/engine#48635)
2023-12-04 737941+loic-sharma@users.noreply.github.com [Windows] Decouple the GL context from the view (flutter/engine#48636)
2023-12-04 dkwingsmt@users.noreply.github.com Multiview ExternalViewEmbedder (flutter/engine#46169)
2023-12-04 skia-flutter-autoroll@skia.org Roll Dart SDK from 67f7a2c2559a to a1b67665b3a3 (1 revision) (flutter/engine#48637)
2023-12-04 skia-flutter-autoroll@skia.org Roll Skia from db4a29e0689e to 0fe76d9ce79e (5 revisions) (flutter/engine#48634)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

1567a9d6

Bump actions/labeler from 4.3.0 to 5.0.0 (#139506) · bbe980cf

dependabot[bot] authored Dec 04, 2023

Bumps [actions/labeler](https://github.com/actions/labeler) from 4.3.0 to 5.0.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/actions/labeler/releases">actions/labeler's releases</a>.</em></p>
<blockquote>
<h2>v5.0.0</h2>
<h2>What's Changed</h2>
<p>This release contains the following breaking changes:</p>
<ol>
<li>
<p>The ability to apply labels based on the names of base and/or head branches was added (<a href="https://redirect.github.com/actions/labeler/issues/186">#186</a> and <a href="https://redirect.github.com/actions/labeler/issues/54">#54</a>). The match object for changed files was expanded with new combinations in order to make it more intuitive and flexible (<a href="https://redirect.github.com/actions/labeler/issues/423">#423</a> and <a href="https://redirect.github.com/actions/labeler/issues/101">#101</a>). As a result, the configuration file structure was significantly redesigned and is not compatible with the structure of the previous version. Please read the <a href="https://github.com/actions/labeler/tree/main#pull-request-labeler">action documentation</a> to find out how to adapt your configuration files for use with the new action version.</p>
</li>
<li>
<p>The bug related to the <code>sync-labels</code> input was fixed (<a href="https://redirect.github.com/actions/labeler/issues/112">#112</a>). Now the input value is read correctly.</p>
</li>
<li>
<p>By default, <code>dot</code> input is set to <code>true</code>. Now, paths starting with a dot (e.g. <code>.github</code>) are matched by default.</p>
</li>
<li>
<p>Version 5 of this action updated the <a href="https://docs.github.com/en/actions/creating-actions/metadata-syntax-for-github-actions#runs-for-javascript-actions">runtime to Node.js 20</a>. All scripts are now run with Node.js 20 instead of Node.js 16 and are affected by any breaking changes between Node.js 16 and 20.</p>
</li>
</ol>
<p>For more information, please read the <a href="https://github.com/actions/labeler/tree/main#pull-request-labeler">action documentation</a>.</p>
<h2>New Contributors</h2>
<ul>
<li><a href="https://github.com/joshdales"><code>@âjoshdales</code></a> made their first contribution in <a href="https://redirect.github.com/actions/labeler/pull/203">actions/labeler#203</a></li>
<li><a href="https://github.com/dusan-trickovic"><code>@âdusan-trickovic</code></a> made their first contribution in <a href="https://redirect.github.com/actions/labeler/pull/626">actions/labeler#626</a></li>
<li><a href="https://github.com/sungh0lim"><code>@âsungh0lim</code></a> made their first contribution in <a href="https://redirect.github.com/actions/labeler/pull/630">actions/labeler#630</a></li>
<li><a href="https://github.com/TrianguloY"><code>@âTrianguloY</code></a> made their first contribution in <a href="https://redirect.github.com/actions/labeler/pull/629">actions/labeler#629</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/actions/labeler/compare/v4...v5.0.0">https://github.com/actions/labeler/compare/v4...v5.0.0</a></p>
<h2>v5.0.0-beta.1</h2>
<h2>What's Changed</h2>
<p>In scope of this beta release, the structure of the configuration file (<code>.github/labeler.yml</code>) was changed from</p>
<pre lang="yml"><code>LabelName:
- any:
  - changed-files: ['list', 'of', 'globs']
  - base-branch: ['list', 'of', 'regexps']
  - head-branch: ['list', 'of', 'regexps']
- all:
  - changed-files: ['list', 'of', 'globs']
  - base-branch: ['list', 'of', 'regexps']
  - head-branch: ['list', 'of', 'regexps']
</code></pre>
<p>to</p>
<pre lang="yml"><code>LabelName:
- any:
  - changed-files: 
    - AnyGlobToAnyFile: ['list', 'of', 'globs']
    - AnyGlobToAllFiles: ['list', 'of', 'globs']
    - AllGlobsToAnyFile: ['list', 'of', 'globs']
    - AllGlobsToAllFiles: ['list', 'of', 'globs']
  - base-branch: ['list', 'of', 'regexps']
  - head-branch: ['list', 'of', 'regexps']
- all:
  - changed-files:
    - AnyGlobToAnyFile: ['list', 'of', 'globs']
    - AnyGlobToAllFiles: ['list', 'of', 'globs']
    - AllGlobsToAnyFile: ['list', 'of', 'globs']
&lt;/tr&gt;&lt;/table&gt; 
</code></pre>
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/actions/labeler/commit/8558fd74291d67161a8a78ce36a881fa63b766a9"><code>8558fd7</code></a> Merge pull request <a href="https://redirect.github.com/actions/labeler/issues/709">#709</a> from actions/v5.0.0-beta</li>
<li><a href="https://github.com/actions/labeler/commit/000ca75fe6c5838c790ca73b764419065c1594a6"><code>000ca75</code></a> Merge pull request <a href="https://redirect.github.com/actions/labeler/issues/700">#700</a> from MaksimZhukov/apply-suggestions-and-update-docume...</li>
<li><a href="https://github.com/actions/labeler/commit/cb66c2f0788d382da1dabd06a094c0bc6ed3e26a"><code>cb66c2f</code></a> Update dist</li>
<li><a href="https://github.com/actions/labeler/commit/9181355e36dc8e434c93ba5aaa33f699c4162f38"><code>9181355</code></a> Apply suggestions for the beta vesrion and update the documentation</li>
<li><a href="https://github.com/actions/labeler/commit/efe4c1c90edf0ec238b5ee13e66e1abcbbe7446e"><code>efe4c1c</code></a> Merge pull request <a href="https://redirect.github.com/actions/labeler/issues/699">#699</a> from MaksimZhukov/update-node-runtime-and-dependencies</li>
<li><a href="https://github.com/actions/labeler/commit/c0957ad7c30fb0638e275122d51df2330459854a"><code>c0957ad</code></a> Run Prettier</li>
<li><a href="https://github.com/actions/labeler/commit/8dc8d1842f2f3ed1cf6f4190490ad02e0a755f0c"><code>8dc8d18</code></a> Update Node.js version in reusable workflows</li>
<li><a href="https://github.com/actions/labeler/commit/d0d0bbebfbe119c8403a0e2724c5fa5b555c78b9"><code>d0d0bbe</code></a> Update documentation</li>
<li><a href="https://github.com/actions/labeler/commit/1375c42512e0b855687040307d6dcaf403da9a4e"><code>1375c42</code></a> 5.0.0</li>
<li><a href="https://github.com/actions/labeler/commit/ab7411ec21ea67102994adc0fa01b3f5cf63509f"><code>ab7411e</code></a> Change version of Node.js runtime to node20</li>
<li>Additional commits viewable in <a href="https://github.com/actions/labeler/compare/ac9175f8a1f3625fd0d4fb234536d26811351594...8558fd74291d67161a8a78ce36a881fa63b766a9">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=actions/labeler&package-manager=github_actions&previous-version=4.3.0&new-version=5.0.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

bbe980cf

Added support for vscode and vscode-insiders installed via Flatpak (#137123) · 77503bdb

Kristijan Žic authored Dec 04, 2023

Closes #137122

<b>Before</b>
VS Code and VS Code Insiders installed via Flatpak aren't detected

<b>After</b>
```sh
[â] VS Code (version 1.82.2)
    â¢ VS Code at /var/lib/flatpak/app/com.visualstudio.code/x86_64/stable/active/files/extra/vscode
    â¢ Flutter extension version 3.74.0

[â] VS Code (version 1.84.0-insider)
    â¢ VS Code at /var/lib/flatpak/app/com.visualstudio.code.insiders/x86_64/beta/active/files/extra/vscode-insiders
    â¢ Flutter extension version 3.75.20231002
```

77503bdb