- 23 Jan, 2024 20 commits
-
-
Christopher Fujino authored
Part of https://github.com/flutter/flutter/issues/85160
-
Ian Hickson authored
This is part 1 of a broken down version of the #140101 refactor.
-
Lau Ching Jun authored
This is used when the native assets are built by a separate build system. Context: b/286799303
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/b229878c57f5...994054143fc3 2024-01-23 30870216+gaaclarke@users.noreply.github.com [Impeller] turned on validation errors for one golden image test (flutter/engine#49955) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
hangyu authored
fixes: https://github.com/flutter/flutter/issues/142012
-
Qun Cheng authored
Fixes #141347 This PR is to add a "clear text" tooltip for the clear button on `SearchAnchor`'s search view and also add a `clearButtonTooltip` entry for `material_localizations`.
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/fd0335a910b8...b229878c57f5 2024-01-23 mbrase@google.com Update buildroot for fidl_binding_deps() support in the Fuchsia SDK (flutter/engine#49909) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Michael Goderbauer authored
Fixes https://github.com/flutter/flutter/issues/141606. OverflowBar doesn't do any clipping and therefore there's no need to specify a clip behavior.
-
engine-flutter-autoroll authored
https://github.com/flutter/packages/compare/e4cbf235ec4d...841fe901fe2b 2024-01-22 katelovett@google.com [two_dimensional_scrollables] Fix TableSpanDecoration rects when axes are reversed (flutter/packages#5916) 2024-01-22 43054281+camsim99@users.noreply.github.com [most on Android] Bump compile SDK version to 34 (flutter/packages#5783) 2024-01-22 dshukertjr@gmail.com [url_launcher]: Fix a grammar error in the comments of launchUrl method (flutter/packages#5919) 2024-01-22 10687576+bparrishMines@users.noreply.github.com [webview_platform_interface] Adds WebResourceRequest to HttpResponseError (flutter/packages#5790) 2024-01-22 43054281+camsim99@users.noreply.github.com [camerax] Update `Activity` references when `ActivityAware` lifecycle methods called (flutter/packages#5784) 2024-01-22 engine-flutter-autoroll@skia.org Roll Flutter from 5dea6b99 to 3ee8ff28 (9 revisions) (flutter/packages#5955) 2024-01-22 stuartmorgan@google.com [espresso] Replace deprecated `getObservatoryUri` (flutter/packages#5788) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/d2855da628da...fd0335a910b8 2024-01-23 skia-flutter-autoroll@skia.org Roll Dart SDK from 5bd0742466d2 to 5646ac9669f8 (3 revisions) (flutter/engine#49965) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Bruno Leroux authored
## Description This PR adds the share button to text selection toolbar buttons on Android ~~and iOS~~ for `SelectableRegion` (and therefore `SelectionArea`). https://github.com/flutter/flutter/pull/139479 adds this button for `EditableText` (which is used by `TextField` and `SelectableText` but not by `SelectionArea`). **Edit**: supporting this on iOS will need more work (see https://github.com/flutter/flutter/pull/141447#issuecomment-1889942622 and https://github.com/flutter/flutter/issues/141775). ## Related Issue Follow up for https://github.com/flutter/flutter/issues/138728 ## Tests Adds 1 test.
-
David Martos authored
Relax the warning of unavailable tokens in `gen_defaults` when a default value is provided (#140872) Fixes some false positives and false negatives from the `gen_defaults` tool regarding unavailable tokens in the Material spec. Fixes #140871 # Before ![image](https://github.com/flutter/flutter/assets/22084723/eb6c43ee-d919-4203-80ee-e36869e5bbcf) # After ![image](https://github.com/flutter/flutter/assets/22084723/67093dcb-1ab0-439f-9338-a6f364d2a9e1) These new issues that are logged are being fixed in https://github.com/flutter/flutter/pull/140573 --- *If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/37f68f6fc7fc...d2855da628da 2024-01-23 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Add Mac cache_builder back into Prod" (flutter/engine#49961) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/9e582c9032e5...37f68f6fc7fc 2024-01-23 matanlurey@users.noreply.github.com Change how OpenGL textures are flipped in the Android embedder. (flutter/engine#49938) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/df6b15d35703...9e582c9032e5 2024-01-23 skia-flutter-autoroll@skia.org Roll Dart SDK from 9470ea6b00a5 to 5bd0742466d2 (1 revision) (flutter/engine#49951) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/d3dbd4225e08...df6b15d35703 2024-01-22 jonahwilliams@google.com [Impeller] dont emulate command buffers for compute on Metal/Vulkan. (flutter/engine#49922) 2024-01-22 30870216+gaaclarke@users.noreply.github.com [Impeller] fixed colorspace for metal screenshots (flutter/engine#49941) 2024-01-22 jonahwilliams@google.com [Impeller] remove frame counter that was unused in Vulkan allocator. (flutter/engine#49913) 2024-01-22 jason-simmons@users.noreply.github.com [Impeller] Create the golden test screenshotter after setting the Vulkan ICD environment variable (flutter/engine#49948) 2024-01-22 737941+loic-sharma@users.noreply.github.com [Windows] Rename and move EGL types (flutter/engine#49900) 2024-01-22 skia-flutter-autoroll@skia.org Roll Skia from fa5f2461554f to 58973cca0edd (2 revisions) (flutter/engine#49947) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Ian Hickson authored
This is part 2 of a broken down version of the #140101 refactor. This particular change wasn't in that original refactor but is a note to myself so that I remember how to test each of these changes in the future.
-
Ian Hickson authored
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/b069d7f8f1fd...d3dbd4225e08 2024-01-22 mdebbar@google.com [web] Bootstrap tests without implicit view by default (flutter/engine#48629) 2024-01-22 skia-flutter-autoroll@skia.org Roll Skia from bbb0d6feaf1c to fa5f2461554f (1 revision) (flutter/engine#49945) 2024-01-22 skia-flutter-autoroll@skia.org Roll Dart SDK from dc389e4a01f3 to 9470ea6b00a5 (1 revision) (flutter/engine#49944) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
auto-submit[bot] authored
Reverts flutter/flutter#141541 Initiated by: yusuf-goog This change reverts the following previous change: Original Description: This PR introduces the first app in this repo that fully uses Gradle Kotlin DSL. It also fixes a bug I found in the process – fields of `FlutterExtensions` must be `public`.
-
- 22 Jan, 2024 20 commits
-
-
Justin McCandless authored
Explains what a "floating cursor" is in the docs.
-
Gustl22 authored
Part of #137040 and #80374 - Rename _filterPluginsByPlatform to _createPluginMapOfPlatform - Move method in chronological order - Cleanup platform strings
-
Bartek Pacia authored
This PR introduces the first app in this repo that fully uses Gradle Kotlin DSL. It also fixes a bug I found in the process â fields of `FlutterExtensions` must be `public`.
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/b2762f410840...b069d7f8f1fd 2024-01-22 skia-flutter-autoroll@skia.org Roll Skia from cd6b0ff3596e to bbb0d6feaf1c (1 revision) (flutter/engine#49943) 2024-01-22 30870216+gaaclarke@users.noreply.github.com [Impeller] fixed CanRenderClippedRuntimeEffects for vulkan (flutter/engine#49912) 2024-01-22 737941+loic-sharma@users.noreply.github.com [Windows] Fix resize crash (flutter/engine#49935) 2024-01-22 skia-flutter-autoroll@skia.org Roll Skia from be066a6524ab to cd6b0ff3596e (3 revisions) (flutter/engine#49939) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
-
Jesús S Guerrero authored
Reverts flutter/flutter#141533 b/321743868
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/d653559ae183...b2762f410840 2024-01-22 32242716+ricardoamador@users.noreply.github.com Add Mac cache_builder back into Prod (flutter/engine#49936) 2024-01-22 skia-flutter-autoroll@skia.org Roll Skia from cc042f38288e to be066a6524ab (2 revisions) (flutter/engine#49937) 2024-01-22 bdero@google.com [Impeller] Reland: Switch from transient stencil-only to depth+stencil buffer. (flutter/engine#49838) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Matan Lurey authored
Fixes https://github.com/flutter/flutter/issues/141823 Before this change, when a test would fail, the terminal would hang (by default for 30s) until killed by the test runner. Basically, [`runZonedGuarded`](https://api.flutter.dev/flutter/dart-async/runZonedGuarded.html) _does_ document (though not clearly) that a returned future should not be awaited: ```txt The zone will always be an error-zone ([Zone.errorZone](https://api.flutter.dev/flutter/dart-async/Zone/errorZone.html)), so returning a future created inside the zone, and waiting for it outside of the zone, will risk the future not being seen to complete. ``` For example, you can see other places in Dart and Flutter that we circumvent that problem: - https://github.com/flutter/flutter/blob/5987563e4aecb34fca446ea804943bb8d27d8fcd/packages/flutter_tools/test/general.shard/base/async_guard_test.dart#L279-L306 - https://github.com/dart-lang/dartdoc/blob/b04c9c127fea5f3fdf600aa205f50d81d1c779c5/lib/src/dartdoc.dart#L258-L264 - https://github.com/flutter/engine/blob/d1afda52d254f5f1faf79e51fe430d912d6db3ee/lib/web_ui/dev/browser_process.dart#L20-L22 I'm open to suggestions on how to test this :) /cc @natebosch @jakemac53 @lrhn if you have any color commentary for us.
-
Greg Spencer authored
## Description This removes an unneeded expectation in the test for the AppLifecycleListener. It's unneeded because the test immediately resets the state anyhow. I'm removing it because the web implementation sets the value when initializing, so it's never initially null there. ## Related PR - https://github.com/flutter/engine/pull/44720#issuecomment-1898482363
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/1efe8ba6bc04...d653559ae183 2024-01-22 bdero@google.com [Impeller] Add golden for Image ColorSource effect transform. (flutter/engine#49930) 2024-01-22 skia-flutter-autoroll@skia.org Roll Skia from 9cb4de5da15a to cc042f38288e (1 revision) (flutter/engine#49934) 2024-01-22 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from p0njgljtokVLYfzqK... to uQK4l0QeH_PlZO6cF... (flutter/engine#49933) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from p0njgljtokVL to uQK4l0QeH_Pl If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Jonas Uekötter authored
It's confusing that `debugPrint` also prints in release mode, given that a lot (most?) other things prefixed with `debug` don't do anything in release mode. Therefore, this adds some documentation that this is indeed logging in release mode and adds an example how to disable this. *If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
-
Taha Tesser authored
fixes [Null-check operator on RangeSlider's _startSemanticsNode](https://github.com/flutter/flutter/issues/141953)
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/c49989292fc1...1efe8ba6bc04 2024-01-22 skia-flutter-autoroll@skia.org Roll Dart SDK from 7a91ef52d200 to dc389e4a01f3 (3 revisions) (flutter/engine#49932) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Hassan Toor authored
When a `TextField` is rendered before a `Navigator`, it breaks in semantics mode. This is because the framework generates the incorrect semantics tree (excludes the TextField) and when that tree gets sent to the engine, we don't get the signal to create the corresponding `<input>` element. This happens for a few reasons: * `ModalBarrier` uses `BlockSemantics` to drop the semantics of routes beneath the current route in `Navigator` * `ModalBarrier` mistakenly recognizes the widget outside of the `Navigator` to be its sibling * So we end up dropping the semantics node of the `TextField` rendered before it. The fix is to let `Navigator` generate a semantics node so that `ModalBarrier` doesn't mistakenly think widgets outside of `Navigator` are its siblings. `Navigator` doesn't currently do this, which causes all the nodes generated from its widget subtree to be directly attached to the parent semantics node above `Navigator` - since this is also the parent of `TextField`, it considers them siblings. Fixes https://github.com/flutter/flutter/issues/129324
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/40c5e9ce6596...c49989292fc1 2024-01-22 skia-flutter-autoroll@skia.org Roll Skia from f4b79968de2a to 9cb4de5da15a (1 revision) (flutter/engine#49931) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/packages/compare/129e08c1dff1...e4cbf235ec4d 2024-01-21 engine-flutter-autoroll@skia.org Roll Flutter from ddf60fb0 to 5dea6b99 (5 revisions) (flutter/packages#5951) 2024-01-21 stuartmorgan@google.com Update platform label rules for shared iOS/macOS (flutter/packages#5801) 2024-01-20 stuartmorgan@google.com [pigeon] Support other hosts in generated file CI checks (flutter/packages#5944) 2024-01-20 stuartmorgan@google.com [pigeon] Improve style of generated Swift code (flutter/packages#5938) 2024-01-20 engine-flutter-autoroll@skia.org Roll Flutter from 684247a3 to ddf60fb0 (12 revisions) (flutter/packages#5949) 2024-01-20 41930132+hellohuanlin@users.noreply.github.com [camera]fix a sample buffer memory leak on pause resume recording (flutter/packages#5927) 2024-01-19 magder@google.com [ci] Run Swift formatter and linter during CI formatting (flutter/packages#5928) 2024-01-19 engine-flutter-autoroll@skia.org Manual roll Flutter from f77f8243 to 684247a3 (39 revisions) (flutter/packages#5948) 2024-01-19 john@johnmccutchan.com Expose registered widget libraries and local widget library widgets. (flutter/packages#5936) 2024-01-19 49699333+dependabot[bot]@users.noreply.github.com Bump actions/upload-artifact from 4.1.0 to 4.2.0 (flutter/packages#5937) 2024-01-19 engine-flutter-autoroll@skia.org Manual roll Flutter (stable) from ef1af02aead6 to 67457e669f79 (1 revision) (flutter/packages#5932) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Tess Strickland authored
This PR adds the Dart VM `vm:platform-const-if` pragma introduced in https://github.com/dart-lang/sdk/commit/57a1168875 to the `defaultTargetPlatform` property, allowing it to be computed as if it was a constant field in non-debug AOT builds. In particular, this means that platform-specific code executed conditionally based on this property can be tree-shaken in release builds. Note that this PR changes `defaultTargetPlatform` to only allow overriding via `debugDefaultTargetPlatformOverride` in debug builds, and makes it so that compilation throws an error if code assigns to`debugDefaultTargetPlatformOverride` in other build modes. Related issue: #14233 ## Pre-launch Checklist - [X] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [X] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [X] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [X] I signed the [CLA]. - [X] I listed at least one issue that this PR fixes in the description above. - [X] I updated/added relevant documentation (doc comments with `///`). - [X] I added new tests to check the change I am making, or this PR is [test-exempt]. - [X] All existing and new tests are passing.
-
Taha Tesser authored
This updates the previous attempt https://github.com/flutter/flutter/pull/135855 and removes the complications when testing M3 ink sparkle effect. Thanks to this [PR](https://github.com/flutter/flutter/pull/138757) by @Piinks fixes [ExpansionTile InkSplash doesn't respect Shape's borderRadius](https://github.com/flutter/flutter/issues/125779) fixes [`ExpansionTile.backgroundColor` & `ExpansionTile.collapsedBackgroundColor` removes splash effect](https://github.com/flutter/flutter/issues/107113) ### Code sample <details> <summary>expand to view the code sample</summary> ```dart import 'package:flutter/material.dart'; void main() => runApp(const MyApp()); class MyApp extends StatelessWidget { const MyApp({super.key}); @override Widget build(BuildContext context) { return const MaterialApp( debugShowCheckedModeBanner: false, home: Example(), ); } } class Example extends StatelessWidget { const Example({super.key}); @override Widget build(BuildContext context) { return const Scaffold( body: Center( child: Padding( padding: EdgeInsets.symmetric(horizontal: 24.0), child: ExpansionTile( collapsedBackgroundColor: Color(0x25ff0000), backgroundColor: Color(0x250000ff), collapsedShape: RoundedRectangleBorder( borderRadius: BorderRadius.all(Radius.circular(30.0)), side: BorderSide(color: Colors.black, width: 2.0), ), shape: RoundedRectangleBorder( borderRadius: BorderRadius.all(Radius.circular(30.0)), side: BorderSide(color: Colors.black, width: 2.0), ), clipBehavior: Clip.hardEdge, title: Text('Expansion Tile'), children: <Widget>[ FlutterLogo(size: 50), FlutterLogo(size: 50), FlutterLogo(size: 50), FlutterLogo(size: 50), ], ), )), ); } } ``` </details> ### Before <img width="789" alt="Screenshot 2024-01-18 at 18 16 15" src="https://github.com/flutter/flutter/assets/48603081/8c6a6f1e-6986-4acf-8dec-e223a682c0d7"> <img width="789" alt="Screenshot 2024-01-18 at 18 16 44" src="https://github.com/flutter/flutter/assets/48603081/f55f6a26-2128-48a1-b24d-3c14e4f6ecdc"> ### After <img width="789" alt="Screenshot 2024-01-18 at 18 20 27" src="https://github.com/flutter/flutter/assets/48603081/7ec8b888-7319-460d-8488-9cd44c9246a6"> <img width="789" alt="Screenshot 2024-01-18 at 18 20 53" src="https://github.com/flutter/flutter/assets/48603081/80d66d5b-7eb2-4f47-ab4d-d7f469a731fa">
-
Daco Harkes authored
Fixes https://github.com/flutter/flutter/issues/141827 Reland: https://dart-review.googlesource.com/c/sdk/+/346960 has rolled into g3, so the imports should now resolve in g3 as well. > [!CAUTION] > _Do NOT merge if "Google Testing" bot didn't run!_ Rolls the packages from https://github.com/dart-lang/native in the native assets implementation. Most notable we're refactoring `package:native_assets_cli` for `build.dart` use. Therefore, all imports to that package for Flutter/Dart should be to the implementation internals that are no longer visible for `build.dart` writers. Hence all the import updates. No behavior in Flutter apps should change. This PR also updates the template to use the latests version of `package:native_assets_cli` which no longer exposes all the implementation details.
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/11c585f48b77...40c5e9ce6596 2024-01-22 skia-flutter-autoroll@skia.org Roll Skia from 8774ef8a314e to f4b79968de2a (1 revision) (flutter/engine#49929) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-