Commits · 1657075914d7c8498c32d8b154916febafb9e6dd · abdullh.alsoleman / Front-End

05 Dec, 2019 2 commits

Move technical_debt_cost to use a cloud vm. (#45996) · 16570759
godofredoc authored Dec 05, 2019

16570759

Overridable default platform key bindings (#45102) · f7d16161

Greg Spencer authored Dec 05, 2019

This adds actions and shortcuts arguments to WidgetsApp (and MaterialApp and CupertinoApp) to allow developers to override the default mappings on an application, and to allow for a more complex definition of the default mappings.

I've stopped using SelectAction here, in favor of using ActivateAction for all activations, but haven't removed it, to avoid a breaking change, and to allow a common base class for these types of actions. This is because some platforms use the same mapping (web) for both kinds of activations (both select and activate).

f7d16161

04 Dec, 2019 27 commits

Pre-Submit Tryjobs for Flutter Gold (#44474) · 9011cece
Kate Lovett authored Dec 04, 2019

9011cece
Remove flutterBuildPluginAsAarFeature flag (#46101) · 9e94eb93
Emmanuel Garcia authored Dec 04, 2019

9e94eb93
only run codecov on master (#46100) · d88345e7
Christopher Fujino authored Dec 04, 2019

d88345e7

Roll engine 07aab98212cb..fdaa7cf12175 (2 commits) (#46095) · f213f925

engine-flutter-autoroll authored Dec 04, 2019

git@github.com:flutter/engine.git/compare/07aab98212cb...fdaa7cf12175

git log 07aab98212cb..fdaa7cf12175 --first-parent --oneline
2019-12-04 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from OSk8h... to XCAOU... (#14128)
2019-12-04 skia-flutter-autoroll@skia.org Roll src/third_party/skia 75368c3a0290..ccca30aad770 (12 commits) (#14129)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

f213f925

Add a VisualDensity manual test (#46083) · 09927b94

Greg Spencer authored Dec 04, 2019

Adds a manual test that allows testing of density for buttons. Also updates some of the button tests to be somewhat simpler and to test the child positions in the test to make sure they are consistent.

09927b94

Update dartdoc to 0.29.2. (#46014) · 50c8e6b2
Janice Collins authored Dec 04, 2019

50c8e6b2
improve resetChanges() dartdoc (#46008) · dfc108c6
Christopher Fujino authored Dec 04, 2019

dfc108c6

07aab9821 Fix one more use of deprecated path fill type API (flutter/engine#14127) (#46092) · 19f8f497

engine-flutter-autoroll authored Dec 04, 2019


git@github.com:flutter/engine.git/compare/1cdfc99314df...07aab98212cb

git log 1cdfc99314df..07aab98212cb --first-parent --oneline
2019-12-04 brianosman@google.com Fix one more use of deprecated path fill type API (#14127)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

19f8f497

Api Samples and Diagrams for 10 more classes / functions (#45603) · 3ea8c87c

Brian Egan authored Dec 04, 2019

* Api Samples and Diagrams for the following classes and methods:

  - AlertDialog
  - SimpleDialog
  - SingleChildScrollView
  - showDatePicker
  - RichText
  - InputDecoration
  - Divider
  - StreamBuilder
  - DataTable
  - BottomSheet
    - showBottomSheet
    - showModalBottomSheet

* Update packages/flutter/lib/src/material/divider.dart
Co-Authored-By: Kate Lovett <katelovett@google.com>

* Update packages/flutter/lib/src/widgets/basic.dart
Co-Authored-By: Kate Lovett <katelovett@google.com>

* Update packages/flutter/lib/src/material/data_table.dart
Co-Authored-By: Kate Lovett <katelovett@google.com>

* Update packages/flutter/lib/src/material/bottom_sheet.dart
Co-Authored-By: Kate Lovett <katelovett@google.com>

* Update packages/flutter/lib/src/material/scaffold.dart
Co-Authored-By: Kate Lovett <katelovett@google.com>

* Move animation out of sample

* Remove "widget.size", replace with "60"

3ea8c87c

implicit-casts:false in flutter_driver (#45175) · 4956bcc2
Alexandre Ardhuin authored Dec 04, 2019
```
* implicit-casts:false in flutter_driver

* address review comments
```
4956bcc2
implicit-casts:false in flutter/lib/src/rendering (#45720) · a5f9b3b0
Alexandre Ardhuin authored Dec 04, 2019
```
* implicit-casts:false in flutter/lib/src/rendering

* address review comments
```
a5f9b3b0
implicit-casts:false in flutter/lib/src/widgets (#45728) · 166d422b
Alexandre Ardhuin authored Dec 04, 2019
```
* implicit-casts:false in flutter/lib/src/widgets

* address review comments

* address review comment
```
166d422b

1cdfc9931 Roll src/third_party/dart 19fc1016da..2a13b1fe26 (6 commits)... · 54e7b2ba

engine-flutter-autoroll authored Dec 04, 2019

1cdfc9931 Roll src/third_party/dart 19fc1016da..2a13b1fe26 (6 commits) (flutter/engine#14107) (#46059)

git@github.com:flutter/engine.git/compare/3e6d6bc612fd...1cdfc99314df

git log 3e6d6bc612fd..1cdfc99314df --first-parent --oneline
2019-12-04 bkonyi@google.com Roll src/third_party/dart 19fc1016da..2a13b1fe26 (6 commits) (#14107)

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

54e7b2ba

implicit-casts:false in flutter/lib/src/semantics (#45722) · 4049460d
Alexandre Ardhuin authored Dec 04, 2019

4049460d
implicit-casts:false in flutter/lib/src/services (#45723) · 1c7a1c38
Alexandre Ardhuin authored Dec 04, 2019

1c7a1c38

3e6d6bc61 add pointer data santizing in flutter web engine (flutter/engine#14082) (#46049) · f908e182

engine-flutter-autoroll authored Dec 04, 2019


git@github.com:flutter/engine.git/compare/90e28c027c0b...3e6d6bc612fd

git log 90e28c027c0b..3e6d6bc612fd --first-parent --oneline
2019-12-04 47866232+chunhtai@users.noreply.github.com add pointer data santizing in flutter web engine (#14082)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

f908e182

Set track color in Cupertino Switch and Adaptive Switch (#45074) · 417db34d
Sebastian Döll authored Dec 04, 2019

417db34d
[Driver] correct type for getWidgetDiagnostics (#45985) · 50532f38
Jacek Marchwicki authored Dec 04, 2019

50532f38
[flutter_tool] Do not continue with a no-op 'upgrade' (#46011) · 4484ae40
Zachary Anderson authored Dec 04, 2019

4484ae40
Ensure that docker tag is legal (#46035) · 066a992a
Todd Volkert authored Dec 04, 2019

066a992a

Re-enable hostonly tests on non-master branches (#46037) · 4c95bbd1

Todd Volkert authored Dec 04, 2019

This is a follow-on to #45455 - the test failures indicated a
real problem, so re-enabling the tests on non-master.

https://github.com/flutter/flutter/issues/45453

4c95bbd1

Add Density API to ThemeData, implement for buttons. (#43547) · 185da9b0
Greg Spencer authored Dec 04, 2019
```
* Add a density attribute to ThemeData

* Simplify tests

* Review changes (Hans)
```
185da9b0
Re-land "Add option to delay rendering the first frame (#45135)" (#45941) · 1ac17c14
Michael Goderbauer authored Dec 04, 2019

1ac17c14

Roll engine 617938024315..90e28c027c0b (3 commits) (#46043) · 1b05cb2b

engine-flutter-autoroll authored Dec 04, 2019

git@github.com:flutter/engine.git/compare/617938024315...90e28c027c0b

git log 617938024315..90e28c027c0b --first-parent --oneline
2019-12-04 bkonyi@google.com Roll src/third_party/dart 89e31069e8..19fc1016da (6 commits) (#14093)
2019-12-03 dworsham@google.com Relanding: Add Flow unittests and fixtures (#14091)
2019-12-03 bkonyi@google.com Roll src/third_party/dart a4d799c402..89e31069e8 (14 commits) (#14089)

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

1b05cb2b

Enable Android embedding v2 on the beta, dev and stable channel (#46040) · 09126abb
Emmanuel Garcia authored Dec 04, 2019

09126abb

Roll engine 1a96087747ac..617938024315 (5 commits) (#46023) · 50d81a0b

engine-flutter-autoroll authored Dec 04, 2019

git@github.com:flutter/engine.git/compare/1a96087747ac...617938024315

git log 1a96087747ac..617938024315 --first-parent --oneline
2019-12-03 caseyhillers@gmail.com Update fallback to Roboto url to be HTTPS (#14086)
2019-12-03 iska.kaushik@gmail.com Revert "Fix fml_unittests (#14062)" (#14087)
2019-12-03 liyuqian@google.com Revert PRs to unblock David and Jim's work (#14088)
2019-12-03 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from 6QxEZ... to OSk8h... (#14085)
2019-12-03 bkonyi@google.com Roll src/third_party/dart e4344a568f..a4d799c402 (7 commits) (#14083)

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

50d81a0b

Simplify logging code in flutter_driver (#45945) · 97495d89

Ian Hickson authored Dec 04, 2019

* Simplify logging code in flutter_driver

It appears nobody is benefitting from this logic, so we may as well not pay the cost.

* Make all of the driver interface public.

This is the second attempt at this; it should be better than before because the Logger interface, which conflicted in various places, no longer exists.

See #45733 for original attempt.

This reverts commit 0ce9206e (PR #45924).

97495d89

03 Dec, 2019 11 commits

Update PULL_REQUEST_TEMPLATE.md (#45944) · 2991dc28
Ian Hickson authored Dec 03, 2019
```
Update for recent changes to policies.
```
2991dc28
Start fixing docs (#45977) · b61dec79
Dan Field authored Dec 03, 2019

b61dec79
Remove record/replay/bug report functionality from the tool (#45999) · b96d818c
Jonah Williams authored Dec 03, 2019

b96d818c

1a9608774 Update to newer path fill-type API in Skia (flutter/engine#14070) (#46002) · a484db66

engine-flutter-autoroll authored Dec 03, 2019


git@github.com:flutter/engine.git/compare/faa11214c09b...1a96087747ac

git log faa11214c09b..1a96087747ac --first-parent --oneline
2019-12-03 brianosman@google.com Update to newer path fill-type API in Skia (#14070)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

a484db66

Add clip behaviour to Container (#44971) · f68cdacd
Sahand Akbarzadeh authored Dec 03, 2019

f68cdacd
Add printTrace when vscode package.json parsing fails (#45998) · c95dafc4
Jonah Williams authored Dec 03, 2019

c95dafc4
Add comments to package scheme fix (#45997) · 0dace489
Jonah Williams authored Dec 03, 2019

0dace489
Reland: Update macOS configuration settings (#45966) · 0b2bf994
Jonah Williams authored Dec 03, 2019

0b2bf994

Roll engine 8672e79af873..faa11214c09b (7 commits) (#45986) · 8e92ba07

engine-flutter-autoroll authored Dec 03, 2019

git@github.com:flutter/engine.git/compare/8672e79af873...faa11214c09b

git log 8672e79af873..faa11214c09b --first-parent --oneline
2019-12-03 liyuqian@google.com Run benchmarks in Cirrus (#13950)
2019-12-03 stuartmorgan@google.com Report backing store changes in the macOS view (#13933)
2019-12-03 franciscojma@google.com Listen to keyUp event on meta modified keys (#13984)
2019-12-02 dnfield@google.com Fix live region logic (#14081)
2019-12-02 skia-flutter-autoroll@skia.org Roll src/third_party/skia e8c96d8e6116..2792515dab7c (1 commits) (#14069)
2019-12-02 bkonyi@google.com Roll src/third_party/dart 3f32196958..e4344a568f (1 commits) (#14073)
2019-12-02 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from aVdHP... to 6QxEZ... (#14080)

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

8e92ba07

Roll engine 6c605f8a9624..8672e79af873 (2 commits) (#45918) · 7ea0d4d8

engine-flutter-autoroll authored Dec 03, 2019

git@github.com:flutter/engine.git/compare/6c605f8a9624...8672e79af873

git log 6c605f8a9624..8672e79af873 --first-parent --oneline
2019-11-28 skia-flutter-autoroll@skia.org Roll src/third_party/skia c96f5108df28..73beaaa48fcc (2 commits) (#14065)
2019-11-28 hterkelsen@users.noreply.github.com Fallback to Roboto if no suitable font is found (#14061)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC cbracken@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

7ea0d4d8

implicit-casts:false in flutter/lib/src/scheduler (#45721) · 1ae5d676
Alexandre Ardhuin authored Dec 03, 2019

1ae5d676