Commits · 14b914ab926355bf51859b69b829746a9dd4c47d · abdullh.alsoleman / Front-End

29 Feb, 2024 31 commits

Reland [a11y] Fix date picker cannot focus on the edit field (#144198) · 14b914ab

hangyu authored Feb 29, 2024

reland https://github.com/flutter/flutter/pull/143117 


fixes: https://github.com/flutter/flutter/issues/143116
fixes: https://github.com/flutter/flutter/issues/141992

## Pre-launch Checklist

- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
[Data Driven Fixes]:
https://github.com/flutter/flutter/wiki/Data-driven-Fixes

14b914ab

Reland "Use dartpad's main channel for master/main docs (#144329)" (#144431) · e41ffcb7

Michael Goderbauer authored Feb 29, 2024

Fix is in the second commit. The logic here went out of sync with the logic in the snippets generator from https://github.com/flutter/assets-for-api-docs, whose version was bumped as part of this change.

e41ffcb7

Make daemon server work on ipv6-only machines. (#144359) · f3ce9d2f
Lau Ching Jun authored Feb 29, 2024
```
Retry binding on ipv6 if binding on ipv4 failed.
```
f3ce9d2f

Remove deprecated `backgroundColor` from `ThemeData` (#144079) · ee6111a7

Qun Cheng authored Feb 29, 2024

This PR is to remove deprecated ThemeData.backgroundColor.

These parameters are made obsolete in https://github.com/flutter/flutter/pull/110162.
Part of https://github.com/flutter/flutter/issues/143956

ee6111a7

Add stateful reordering test for TwoDimensionalViewport (#142375) · 60688913

Amir Panahandeh authored Feb 29, 2024

Adds a test to validate state is preserved after reordering in `TwoDimensionalViewport` (reference: https://github.com/flutter/flutter/pull/141504#pullrequestreview-1837501775).

- Fixes #130754

60688913

Always use local CanvasKit/Skwasm in benchmarks for better hermeticity. (#144423) · 203ec8b8
Jackson Gardner authored Feb 29, 2024
```
We should avoid hitting gstatic in the benchmarks and just use local canvaskit/skwasm instead.
```
203ec8b8

Roll Flutter Engine from bb6c6a01000f to 7e8fefe4a084 (2 revisions) (#144419) · 90b956ce

engine-flutter-autoroll authored Feb 29, 2024

https://github.com/flutter/engine/compare/bb6c6a01000f...7e8fefe4a084

2024-02-29 kevmoo@users.noreply.github.com [web] Drop noisy prints from bootstrapping logic (flutter/engine#51097)
2024-02-29 jacksongardner@google.com Fix a few issues rendering text with Skwasm. (flutter/engine#51074)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

90b956ce

Fix a crash in remote device daemon. (#144358) · cfa011dd

Lau Ching Jun authored Feb 29, 2024

The daemon server is expecting the client to pass `deviceId` in `device.shutdownDartDevelopmentService` method.

https://github.com/flutter/flutter/blob/24a792dae105e281962a7e3e4c35cbfd9652ff0a/packages/flutter_tools/lib/src/commands/daemon.dart#L1239

cfa011dd

Reverts "Use dartpad's main channel for master/main docs (#144329)" (#144429) · b099bf0b

auto-submit[bot] authored Feb 29, 2024

Reverts flutter/flutter#144329
Initiated by: goderbauer
Reason for reverting: broke postsubmit doc generation.
Original PR Author: goderbauer

Reviewed By: {devoncarew, HansMuller, gspencergoog}

This change reverts the following previous change:
Original Description:
Dartpad doesn't have a "master" channel anymore, it got renamed to "main". Sadly, specifying "master" is now falling back to "stable" which breaks some of our examples in the docs that require a more current Flutter version, e.g. https://main-api.flutter.dev/flutter/material/TextButton-class.html

b099bf0b

Remove `toggleableActiveColor` from `ThemeData` (#144178) · 1349c591

Qun Cheng authored Feb 29, 2024

This PR is to remove deprecated ThemeData.toggleableActiveColor.

These parameters are made obsolete in https://github.com/flutter/flutter/pull/97972.
Part of https://github.com/flutter/flutter/pull/111080

1349c591

Add `FocusNode.focusabilityListenable` (#144280) · 726e5d28

LongCatIsLooong authored Feb 29, 2024

This is for https://github.com/flutter/flutter/issues/127803: a text field should unregister from the scribble scope, when it becomes unfocusable. 

When a `FocusNode` has listeners and its `_canRequestFocus` flag is set to true, it adds `+1` to `_focusabilityListeningDescendantCount` of all ancestors until it reaches the first ancestor with `descendantsAreFocusable = false`. When the a `FocusNode`'s `descendantsAreFocusable` changes, all listeners that contributed to its `_focusabilityListeningDescendantCount` will be notified.

726e5d28

Roll Flutter Engine from 1f24eaa4979d to bb6c6a01000f (2 revisions) (#144416) · 1abc5cdf

engine-flutter-autoroll authored Feb 29, 2024

https://github.com/flutter/engine/compare/1f24eaa4979d...bb6c6a01000f

2024-02-29 jonahwilliams@google.com [Impeller] test removal of submit batching. (flutter/engine#51094)
2024-02-29 zanderso@users.noreply.github.com Use RBE for mac_clang_tidy (flutter/engine#51083)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

1abc5cdf

[devicelab] fix motog4 tests and update comment. (#144410) · ec8fcbce

Jonah Williams authored Feb 29, 2024

Fixes https://github.com/flutter/flutter/issues/144406

The A02 have also been running Vulkan for quite a while.

ec8fcbce

Bump dartdocs to 8.0.6 (#144413) · 24a792da
Michael Goderbauer authored Feb 29, 2024

24a792da

Use dartpad's main channel for master/main docs (#144329) · 41eeb2bb

Michael Goderbauer authored Feb 29, 2024

Dartpad doesn't have a "master" channel anymore, it got renamed to "main". Sadly, specifying "master" is now falling back to "stable" which breaks some of our examples in the docs that require a more current Flutter version, e.g. https://main-api.flutter.dev/flutter/material/TextButton-class.html

41eeb2bb

Roll Flutter Engine from 7b3ef43fa7e6 to 1f24eaa4979d (2 revisions) (#144405) · bcb0f901

engine-flutter-autoroll authored Feb 29, 2024

https://github.com/flutter/engine/compare/7b3ef43fa7e6...1f24eaa4979d

2024-02-29 dnfield@google.com Reapply "Bump everything to Android 21" (#51056) (flutter/engine#51070)
2024-02-29 737941+loic-sharma@users.noreply.github.com [Windows] Add view ID runner APIs (flutter/engine#51020)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

bcb0f901

Roll Flutter Engine from 7dd404724c50 to 7b3ef43fa7e6 (1 revision) (#144399) · ab4bf7c1

engine-flutter-autoroll authored Feb 29, 2024

https://github.com/flutter/engine/compare/7dd404724c50...7b3ef43fa7e6

2024-02-29 skia-flutter-autoroll@skia.org Roll Skia from 05a8d57f0e61 to 139461270500 (1 revision) (flutter/engine#51091)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

ab4bf7c1

Roll Flutter Engine from 8179b0ed778e to 7dd404724c50 (3 revisions) (#144395) · df668ed7

engine-flutter-autoroll authored Feb 29, 2024

https://github.com/flutter/engine/compare/8179b0ed778e...7dd404724c50

2024-02-29 skia-flutter-autoroll@skia.org Roll Skia from ffbe23b3b3b9 to 05a8d57f0e61 (1 revision) (flutter/engine#51090)
2024-02-29 skia-flutter-autoroll@skia.org Roll Skia from 0d00c9f3852a to ffbe23b3b3b9 (2 revisions) (flutter/engine#51089)
2024-02-29 skia-flutter-autoroll@skia.org Roll Skia from ef2511b0a6f2 to 0d00c9f3852a (2 revisions) (flutter/engine#51086)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

df668ed7

Roll Packages from 353086c9a61e to 6d02f0359368 (14 revisions) (#144393) · 8a11703c

engine-flutter-autoroll authored Feb 29, 2024

https://github.com/flutter/packages/compare/353086c9a61e...6d02f0359368

2024-02-28 engine-flutter-autoroll@skia.org Manual roll Flutter from c30f998e to d00bfe82 (32 revisions) (flutter/packages#6222)
2024-02-28 stuartmorgan@google.com [google_maps_flutter] Add `style` to widget (flutter/packages#6192)
2024-02-28 58529443+srujzs@users.noreply.github.com Add library annotations for js interop (flutter/packages#6216)
2024-02-28 stuartmorgan@google.com [google_map_flutter] Add style to widget - platform impls (flutter/packages#6205)
2024-02-28 brackenavaron@gmail.com [google_maps_flutter_web] Migrate to package:web (flutter/packages#5254)
2024-02-28 737941+loic-sharma@users.noreply.github.com [pigeon] Remove heap allocation in generated C++ code (flutter/packages#6196)
2024-02-27 tarrinneal@gmail.com [pigeon] Allows kotlin generator to skip error class generation (flutter/packages#6183)
2024-02-27 43054281+camsim99@users.noreply.github.com [camerax] Implements `setExposureMode` (flutter/packages#6110)
2024-02-27 engine-flutter-autoroll@skia.org Roll Flutter from b77560e9 to c30f998e (12 revisions) (flutter/packages#6211)
2024-02-26 pageli328@gmail.com Add `InkResponse`, `Material` and fix `Opacity` (flutter/packages#6199)
2024-02-26 cepadilla@google.com [url_launcher] Add explicit imports of UIKit (flutter/packages#6208)
2024-02-26 737941+loic-sharma@users.noreply.github.com [pigeon] Fix tool hangs on verbose sub-processes (flutter/packages#6198)
2024-02-26 stuartmorgan@google.com [tool] Ignore GeneratedPluginRegistrant.swift for `format` (flutter/packages#6195)
2024-02-26 engine-flutter-autoroll@skia.org Roll Flutter from 1e8dd1e4 to b77560e9 (8 revisions) (flutter/packages#6207)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

8a11703c

Roll Flutter Engine from d068d980f952 to 8179b0ed778e (1 revision) (#144378) · 8fa0a208

engine-flutter-autoroll authored Feb 29, 2024

https://github.com/flutter/engine/compare/d068d980f952...8179b0ed778e

2024-02-29 matanlurey@users.noreply.github.com The `adb logcat` filtering will continue until morale improves. (flutter/engine#51069)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

8fa0a208

[flutter_tools] Update external link in Android manifest template (#144302) · e92bca3f

Bruno Leroux authored Feb 29, 2024

## Description

This PR simplifies one external link in a commented section of the Android manifest template.

## Related Issue

Fixes https://github.com/flutter/flutter/issues/144249

## Tests

Documentation only PR.

e92bca3f

Roll Flutter Engine from 232217f39c3c to d068d980f952 (1 revision) (#144369) · 62cf7cfa

engine-flutter-autoroll authored Feb 29, 2024

https://github.com/flutter/engine/compare/232217f39c3c...d068d980f952

2024-02-29 skia-flutter-autoroll@skia.org Roll Skia from f0a60bfe98e0 to ef2511b0a6f2 (2 revisions) (flutter/engine#51075)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

62cf7cfa

Roll Flutter Engine from 9e1876141be8 to 232217f39c3c (1 revision) (#144366) · 2ccf375c

engine-flutter-autoroll authored Feb 29, 2024

https://github.com/flutter/engine/compare/9e1876141be8...232217f39c3c

2024-02-29 robert.ancell@canonical.com Update Linux embedder to latest semantics API (flutter/engine#51030)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

2ccf375c

Roll Flutter Engine from 61510db94a1c to 9e1876141be8 (1 revision) (#144362) · 71bb9125

engine-flutter-autoroll authored Feb 29, 2024

https://github.com/flutter/engine/compare/61510db94a1c...9e1876141be8

2024-02-29 jonahwilliams@google.com [Impeller] switch fallback default from ImpellerVulkan to SkiaOpenGLES (flutter/engine#51071)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

71bb9125

Roll Flutter Engine from 10331db8f748 to 61510db94a1c (5 revisions) (#144355) · 52d45c41

engine-flutter-autoroll authored Feb 29, 2024

https://github.com/flutter/engine/compare/10331db8f748...61510db94a1c

2024-02-28 skia-flutter-autoroll@skia.org Roll Skia from 27171d6a9205 to f0a60bfe98e0 (4 revisions) (flutter/engine#51068)
2024-02-28 chillers@google.com Prefix flutter in flutter_vma.h import (flutter/engine#51065)
2024-02-28 jonahwilliams@google.com [Impeller] Cache entire render target and not just allocations. (flutter/engine#50990)
2024-02-28 matanlurey@users.noreply.github.com Test the `SurfaceTextureSurfaceProducer`-branch in the Android `scenario_app` (flutter/engine#51061)
2024-02-28 jacksongardner@google.com Revert "[skwasm] Clip pictures if they go beyond the bounds of the window. (#50887)" (flutter/engine#51067)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

52d45c41

Docs on the interaction between Shortcuts and text input (#144328) · ac66b295

Justin McCandless authored Feb 29, 2024

I was talking with @tvolkert about the complex behavior of Shortcuts when a text field is focused.  I created [this dartpad](https://dartpad.dev/?id=0b5c08fa85637422baa84927b7f1ee5f) to illustrate the problem, which shows a key being stolen from a text field by Shortcuts, and how to prevent that using DoNothingAndStopPropagationIntent.

This PR adds a section in the docs explaining how all of this works and how to override this "stealing" problem.

ac66b295

Use robolectric/AndroidJUnit4 for integration test tests (#144348) · 835112de

Dan Field authored Feb 29, 2024

This allows relanding https://github.com/flutter/engine/pull/51056. The patch introduced a change where a static member is initialized from `View.generateViewId()` instead of conditionally using that API. Without an implementation for that in android.jar, the test will fail. The test in here currently is using a fake implementation that creates errors seen below.

See https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8754827734484522225/+/u/run_plugin_test/stdout#L46564_2 for failure. More detailed failure information is available locally in the `build` folder:

```
Mockito cannot mock this class: class io.flutter.embedding.android.FlutterActivity.

If you're not sure why you're getting this error, please open an issue on GitHub.

Java : 17
JVM vendor name : JetBrains s.r.o.
JVM vendor version : 17.0.7+0-17.0.7b1000.6-10550314
JVM name : OpenJDK 64-Bit Server VM
JVM version : 17.0.7+0-17.0.7b1000.6-10550314
JVM info : mixed mode
OS name : Mac OS X
OS version : 14.3.1

You are seeing this disclaimer because Mockito is configured to create inlined mocks.
You can learn about inline mocks and their limitations under item #39 of the Mockito class javadoc.

Underlying exception : org.mockito.exceptions.base.MockitoException: Cannot instrument class io.flutter.embedding.android.FlutterActivity because it or one of its supertypes could not be initialized
at app//dev.flutter.plugins.integration_test.FlutterDeviceScreenshotTest.getFlutterView_returnsFlutterViewForFlutterActivity(FlutterDeviceScreenshotTest.java:32)
at java.base@17.0.7/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at java.base@17.0.7/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
at java.base@17.0.7/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
at java.base@17.0.7/java.lang.reflect.Method.invoke(Unknown Source)
at app//org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
at app//org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
at app//org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
at app//org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
at app//org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
at app//org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)
at app//org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)
at app//org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)
at app//org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63)
at app//org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
at app//org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
at app//org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
at app//org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
at app//org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)
at app//org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
at app//org.junit.runners.ParentRunner.run(ParentRunner.java:413)
at org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecutor.runTestClass(JUnitTestClassExecutor.java:110)
at org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecutor.execute(JUnitTestClassExecutor.java:58)
at org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecutor.execute(JUnitTestClassExecutor.java:38)
at org.gradle.api.internal.tasks.testing.junit.AbstractJUnitTestClassProcessor.processTestClass(AbstractJUnitTestClassProcessor.java:62)
at org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.processTestClass(SuiteTestClassProcessor.java:51)
at java.base@17.0.7/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at java.base@17.0.7/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
at java.base@17.0.7/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
at java.base@17.0.7/java.lang.reflect.Method.invoke(Unknown Source)
at org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:36)
at org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
at org.gradle.internal.dispatch.ContextClassLoaderDispatch.dispatch(ContextClassLoaderDispatch.java:33)
at org.gradle.internal.dispatch.ProxyDispatchAdapter$DispatchingInvocationHandler.invoke(ProxyDispatchAdapter.java:94)
at jdk.proxy1/jdk.proxy1.$Proxy2.processTestClass(Unknown Source)
at org.gradle.api.internal.tasks.testing.worker.TestWorker$2.run(TestWorker.java:176)
at org.gradle.api.internal.tasks.testing.worker.TestWorker.executeAndMaintainThreadName(TestWorker.java:129)
at org.gradle.api.internal.tasks.testing.worker.TestWorker.execute(TestWorker.java:100)
at org.gradle.api.internal.tasks.testing.worker.TestWorker.execute(TestWorker.java:60)
at org.gradle.process.internal.worker.child.ActionExecutionWorker.execute(ActionExecutionWorker.java:56)
at org.gradle.process.internal.worker.child.SystemApplicationClassLoaderWorker.call(SystemApplicationClassLoaderWorker.java:133)
at org.gradle.process.internal.worker.child.SystemApplicationClassLoaderWorker.call(SystemApplicationClassLoaderWorker.java:71)
at app//worker.org.gradle.process.internal.worker.GradleWorkerMain.run(GradleWorkerMain.java:69)
at app//worker.org.gradle.process.internal.worker.GradleWorkerMain.main(GradleWorkerMain.java:74)
Caused by: org.mockito.exceptions.base.MockitoException: Cannot instrument class io.flutter.embedding.android.FlutterActivity because it or one of its supertypes could not be initialized
at app//net.bytebuddy.TypeCache.findOrInsert(TypeCache.java:168)
at app//net.bytebuddy.TypeCache$WithInlineExpunction.findOrInsert(TypeCache.java:399)
at app//net.bytebuddy.TypeCache.findOrInsert(TypeCache.java:190)
at app//net.bytebuddy.TypeCache$WithInlineExpunction.findOrInsert(TypeCache.java:410)
... 44 more
Caused by: java.lang.RuntimeException: Method generateViewId in android.view.View not mocked. See http://g.co/androidstudio/not-mocked for details.
at android.view.View.generateViewId(View.java)
at io.flutter.embedding.android.FlutterActivity.<clinit>(FlutterActivity.java:218)
at java.base/java.lang.Class.forName0(Native Method)
at java.base/java.lang.Class.forName(Unknown Source)
at org.mockito.internal.creation.bytebuddy.InlineBytecodeGenerator.assureInitialization(InlineBytecodeGenerator.java:236)
at org.mockito.internal.creation.bytebuddy.InlineBytecodeGenerator.triggerRetransformation(InlineBytecodeGenerator.java:261)
at org.mockito.internal.creation.bytebuddy.InlineBytecodeGenerator.mockClass(InlineBytecodeGenerator.java:218)
at org.mockito.internal.creation.bytebuddy.TypeCachingBytecodeGenerator.lambda$mockClass$0(TypeCachingBytecodeGenerator.java:47)
at net.bytebuddy.TypeCache.findOrInsert(TypeCache.java:168)
at net.bytebuddy.TypeCache$WithInlineExpunction.findOrInsert(TypeCache.java:399)
at net.bytebuddy.TypeCache.findOrInsert(TypeCache.java:190)
at net.bytebuddy.TypeCache$WithInlineExpunction.findOrInsert(TypeCache.java:410)
at org.mockito.internal.creation.bytebuddy.TypeCachingBytecodeGenerator.mockClass(TypeCachingBytecodeGenerator.java:40)
at org.mockito.internal.creation.bytebuddy.InlineDelegateByteBuddyMockMaker.createMockType(InlineDelegateByteBuddyMockMaker.java:396)
at org.mockito.internal.creation.bytebuddy.InlineDelegateByteBuddyMockMaker.doCreateMock(InlineDelegateByteBuddyMockMaker.java:355)
at org.mockito.internal.creation.bytebuddy.InlineDelegateByteBuddyMockMaker.createMock(InlineDelegateByteBuddyMockMaker.java:334)
at org.mockito.internal.creation.bytebuddy.InlineByteBuddyMockMaker.createMock(InlineByteBuddyMockMaker.java:56)
at org.mockito.internal.util.MockUtil.createMock(MockUtil.java:99)
at org.mockito.internal.MockitoCore.mock(MockitoCore.java:88)
at org.mockito.Mockito.mock(Mockito.java:2087)
at org.mockito.Mockito.mock(Mockito.java:2002)
... 44 more
```

835112de

Reland "Cache FocusNode.enclosingScope, clean up descendantsAreFocusable (#144207)" (#144330) · dddbd047

LongCatIsLooong authored Feb 29, 2024

The [internal test failure](https://github.com/flutter/flutter/pull/144207#issuecomment-1968236339) was caused by `Focus.withExternalFocusNode` modifying the external node's attributes. The extra changes are in this commit:  https://github.com/flutter/flutter/commit/e53d98b06c6e2ae65271681c4b40b28b2d02ad04

CL with (almost) passing TGP: cl/611157582

dddbd047

Roll Flutter Engine from 455c814fe5de to 10331db8f748 (7 revisions) (#144345) · 7f65c9ef

engine-flutter-autoroll authored Feb 29, 2024

https://github.com/flutter/engine/compare/455c814fe5de...10331db8f748

2024-02-28 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from T1xAi_ww_mWEiDkVN... to ujOkbeYbrC8loPbfR... (flutter/engine#51066)
2024-02-28 chris@bracken.jp Roll abseil-cpp to 1db3bdd4eb208bef55c77f22aa94991e52225230 (flutter/engine#51062)
2024-02-28 skia-flutter-autoroll@skia.org Roll Dart SDK from 7896a944fe67 to fdf4a62bd07b (1 revision) (flutter/engine#51064)
2024-02-28 jason-simmons@users.noreply.github.com [Impeller] Mark subpass framebuffer fetch tests as unsupported on GLES (flutter/engine#50982)
2024-02-28 skia-flutter-autoroll@skia.org Roll Skia from 93f245da0097 to 27171d6a9205 (1 revision) (flutter/engine#51063)
2024-02-28 jonahwilliams@google.com [Impeller] fix render pass depth descriptor. (flutter/engine#51031)
2024-02-28 flar@google.com Make Skia object ostream operators work with unit tests (flutter/engine#51041)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from T1xAi_ww_mWE to ujOkbeYbrC8l

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

7f65c9ef

ReportTiming callback should record the sendFrameToEngine when it was scheduled (#144212) · e3160222
Tong Mu authored Feb 29, 2024
```
Fixes https://github.com/flutter/flutter/issues/144261
```
e3160222

Disable flaky golden file test (#144351) · a185ff90

Kate Lovett authored Feb 29, 2024

Filed https://github.com/flutter/flutter/issues/144350 for follow up.
This test has become flaky and is breaking the tree.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
[Data Driven Fixes]:
https://github.com/flutter/flutter/wiki/Data-driven-Fixes

a185ff90

28 Feb, 2024 9 commits

Mention SelectionArea in SelectableText docs (#143784) · e6a6a473

Justin McCandless authored Feb 28, 2024

Most users should be using SelectionArea over SelectableText, so this makes that more clear/discoverable in the docs.

e6a6a473

Bump peter-evans/create-pull-request from 6.0.0 to 6.0.1 (#144344) · 3095c116

dependabot[bot] authored Feb 28, 2024

Bumps [peter-evans/create-pull-request](https://github.com/peter-evans/create-pull-request) from 6.0.0 to 6.0.1.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/peter-evans/create-pull-request/releases">peter-evans/create-pull-request's releases</a>.</em></p>
<blockquote>
<h2>Create Pull Request v6.0.1</h2>
<p>âï¸ Fixes <a href="https://redirect.github.com/peter-evans/create-pull-request/issues/2790">an issue</a> where updating a pull request leads to the error <code>Cannot read properties of undefined (reading 'number')</code>. This was likely caused by GitHub fixing a long standing bug with an API endpoint, resulting in a breaking change.</p>
<h2>What's Changed</h2>
<ul>
<li>build(deps-dev): bump <code>@âtypes/jest</code> from 29.5.11 to 29.5.12 by <a href="https://github.com/dependabot"><code>@âdependabot</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/2730">peter-evans/create-pull-request#2730</a></li>
<li>build(deps-dev): bump prettier from 3.2.4 to 3.2.5 by <a href="https://github.com/dependabot"><code>@âdependabot</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/2731">peter-evans/create-pull-request#2731</a></li>
<li>build(deps-dev): bump <code>@âtypes/node</code> from 18.19.10 to 18.19.14 by <a href="https://github.com/dependabot"><code>@âdependabot</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/2732">peter-evans/create-pull-request#2732</a></li>
<li>build(deps): bump peter-evans/slash-command-dispatch from 3 to 4 by <a href="https://github.com/dependabot"><code>@âdependabot</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/2748">peter-evans/create-pull-request#2748</a></li>
<li>build(deps): bump peter-evans/create-pull-request from 5 to 6 by <a href="https://github.com/dependabot"><code>@âdependabot</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/2747">peter-evans/create-pull-request#2747</a></li>
<li>build(deps-dev): bump <code>@âtypes/node</code> from 18.19.14 to 18.19.15 by <a href="https://github.com/dependabot"><code>@âdependabot</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/2759">peter-evans/create-pull-request#2759</a></li>
<li>build(deps-dev): bump eslint-plugin-jest from 27.6.3 to 27.9.0 by <a href="https://github.com/dependabot"><code>@âdependabot</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/2769">peter-evans/create-pull-request#2769</a></li>
<li>build(deps-dev): bump <code>@âtypes/node</code> from 18.19.15 to 18.19.17 by <a href="https://github.com/dependabot"><code>@âdependabot</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/2768">peter-evans/create-pull-request#2768</a></li>
<li>build(deps-dev): bump <code>@âtypes/node</code> from 18.19.17 to 18.19.18 by <a href="https://github.com/dependabot"><code>@âdependabot</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/2780">peter-evans/create-pull-request#2780</a></li>
<li>build(deps-dev): bump eslint from 8.56.0 to 8.57.0 by <a href="https://github.com/dependabot"><code>@âdependabot</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/2781">peter-evans/create-pull-request#2781</a></li>
<li>fix: list pulls using the correct head format by <a href="https://github.com/peter-evans"><code>@âpeter-evans</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/2792">peter-evans/create-pull-request#2792</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/peter-evans/create-pull-request/compare/v6.0.0...v6.0.1">https://github.com/peter-evans/create-pull-request/compare/v6.0.0...v6.0.1</a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/peter-evans/create-pull-request/commit/a4f52f8033a6168103c2538976c07b467e8163bc"><code>a4f52f8</code></a> fix: list pulls using the correct head format (<a href="https://redirect.github.com/peter-evans/create-pull-request/issues/2792">#2792</a>)</li>
<li><a href="https://github.com/peter-evans/create-pull-request/commit/853c071bcf61c8762f57e59c1576d97418f495ad"><code>853c071</code></a> build(deps-dev): bump eslint from 8.56.0 to 8.57.0 (<a href="https://redirect.github.com/peter-evans/create-pull-request/issues/2781">#2781</a>)</li>
<li><a href="https://github.com/peter-evans/create-pull-request/commit/d2c126edc79e6a215930e9a6adc95b7686b84f78"><code>d2c126e</code></a> build(deps-dev): bump <code>@âtypes/node</code> from 18.19.17 to 18.19.18 (<a href="https://redirect.github.com/peter-evans/create-pull-request/issues/2780">#2780</a>)</li>
<li><a href="https://github.com/peter-evans/create-pull-request/commit/43d39c683601267cd565ea6bd727a4e92aa00852"><code>43d39c6</code></a> build(deps-dev): bump <code>@âtypes/node</code> from 18.19.15 to 18.19.17 (<a href="https://redirect.github.com/peter-evans/create-pull-request/issues/2768">#2768</a>)</li>
<li><a href="https://github.com/peter-evans/create-pull-request/commit/5a9d206da2b6452cd63eb84e2e5116ff3213e8cb"><code>5a9d206</code></a> build(deps-dev): bump eslint-plugin-jest from 27.6.3 to 27.9.0 (<a href="https://redirect.github.com/peter-evans/create-pull-request/issues/2769">#2769</a>)</li>
<li><a href="https://github.com/peter-evans/create-pull-request/commit/e0743ed96cb63913cf4be3cd1f5492df2ae1c6a4"><code>e0743ed</code></a> build(deps-dev): bump <code>@âtypes/node</code> from 18.19.14 to 18.19.15 (<a href="https://redirect.github.com/peter-evans/create-pull-request/issues/2759">#2759</a>)</li>
<li><a href="https://github.com/peter-evans/create-pull-request/commit/e1529cb8abb50dd7240e4276b5c4e705d97be7e7"><code>e1529cb</code></a> build(deps): bump peter-evans/create-pull-request from 5 to 6 (<a href="https://redirect.github.com/peter-evans/create-pull-request/issues/2747">#2747</a>)</li>
<li><a href="https://github.com/peter-evans/create-pull-request/commit/aad52e87e709ba797765001128cf194c946a457b"><code>aad52e8</code></a> build(deps): bump peter-evans/slash-command-dispatch from 3 to 4 (<a href="https://redirect.github.com/peter-evans/create-pull-request/issues/2748">#2748</a>)</li>
<li><a href="https://github.com/peter-evans/create-pull-request/commit/a64ebdd73452502a4dd07379ce8f3640dcc0d987"><code>a64ebdd</code></a> build(deps-dev): bump <code>@âtypes/node</code> from 18.19.10 to 18.19.14 (<a href="https://redirect.github.com/peter-evans/create-pull-request/issues/2732">#2732</a>)</li>
<li><a href="https://github.com/peter-evans/create-pull-request/commit/51b40aff5f23f35e5211017631b0bc1d2746beab"><code>51b40af</code></a> build(deps-dev): bump prettier from 3.2.4 to 3.2.5 (<a href="https://redirect.github.com/peter-evans/create-pull-request/issues/2731">#2731</a>)</li>
<li>Additional commits viewable in <a href="https://github.com/peter-evans/create-pull-request/compare/b1ddad2c994a25fbc81a28b3ec0e368bb2021c50...a4f52f8033a6168103c2538976c07b467e8163bc">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=peter-evans/create-pull-request&package-manager=github_actions&previous-version=6.0.0&new-version=6.0.1)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

3095c116

Reland "Reland - Introduce tone-based surfaces and accent color add-ons - Part 2" (#144273) · 0d8eafb0
Qun Cheng authored Feb 28, 2024

0d8eafb0

Remove irrelevant comment in TextPainter (#144308) · 88f75712

Tomasz Gucio authored Feb 28, 2024

This PR removes an irrelevant comment in `TextPainter` for `_computePaintOffsetFraction`. Also some typos are corrected and missing spaces/newlines added.

test-exempt: no functional change

88f75712

Roll Flutter Engine from c9381fb8ef4c to 455c814fe5de (1 revision) (#144340) · d00bfe82

engine-flutter-autoroll authored Feb 28, 2024

https://github.com/flutter/engine/compare/c9381fb8ef4c...455c814fe5de

2024-02-28 zanderso@users.noreply.github.com Revert to goma on mac_clang_tidy builder (flutter/engine#51060)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

d00bfe82

Roll Flutter Engine from 91898e397261 to c9381fb8ef4c (11 revisions) (#144338) · 82034b9a

engine-flutter-autoroll authored Feb 28, 2024

https://github.com/flutter/engine/compare/91898e397261...c9381fb8ef4c

2024-02-28 dnfield@google.com Revert "Bump everything to Android 21" (flutter/engine#51056)
2024-02-28 skia-flutter-autoroll@skia.org Roll Skia from 0c294ee206e8 to 93f245da0097 (2 revisions) (flutter/engine#51055)
2024-02-28 jonahwilliams@google.com [Android] update fallback and rendering state to combine impeller + android backend. (flutter/engine#51008)
2024-02-28 bdero@google.com [Impeller] Fix GL depth state. (flutter/engine#51040)
2024-02-28 chris@bracken.jp Roll buildroot to 7b537de78ac2239982ace130d1845374e5dcf113 (flutter/engine#51053)
2024-02-28 skia-flutter-autoroll@skia.org Roll Skia from d935943bedcd to 0c294ee206e8 (3 revisions) (flutter/engine#51051)
2024-02-28 zanderso@users.noreply.github.com When run_tests.py is in --quiet mode, write verbose logs to a file (flutter/engine#51029)
2024-02-28 skia-flutter-autoroll@skia.org Roll Skia from fe34002ee826 to d935943bedcd (1 revision) (flutter/engine#51049)
2024-02-28 dnfield@google.com Bump everything to Android 21 (flutter/engine#51032)
2024-02-28 jiahaog@users.noreply.github.com Add flutter prefix to import (flutter/engine#51042)
2024-02-28 skia-flutter-autoroll@skia.org Roll Skia from d591703635b0 to fe34002ee826 (1 revision) (flutter/engine#51048)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

82034b9a

Reland "Add FlutterMacOS.xcframework artifact (#143244)" (#144275) · 39a13539

Victoria Ashworth authored Feb 28, 2024

Reland https://github.com/flutter/flutter/pull/143244. It was reverted due to https://github.com/flutter/flutter/issues/144251, which is fixed by https://github.com/flutter/engine/pull/51023.

39a13539

[flutter_tools] Catch rpc error in render frame with raster stats (#144190) · f89b4f15

Christopher Fujino authored Feb 28, 2024

Fixes https://github.com/flutter/flutter/issues/143010. This is intended to be cherrypicked into the 3.19 and 3.20 releases.

Long-term, we should deprecate this feature: https://github.com/flutter/flutter/issues/144191

f89b4f15

🛡

️ Guard Flutter Android app by disallow task affinity by default (#144018) · 47b0ef81

Alex Li authored Feb 28, 2024

Partial resolution for #63559

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
[Data Driven Fixes]:
https://github.com/flutter/flutter/wiki/Data-driven-Fixes

47b0ef81