- 10 Jan, 2024 18 commits
-
-
Christopher Fujino authored
Fixes https://github.com/flutter/flutter/issues/139138 This had been broken since https://github.com/flutter/flutter/pull/130090 merged, however, the test happened run with flutter_tools/pubspec.yaml in the current working directory.
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/b361a60ae224...d1a2007a28b4 2024-01-10 skia-flutter-autoroll@skia.org Roll Dart SDK from efd053daa2a6 to b3d7097aa10f (1 revision) (flutter/engine#49673) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Derek Xu authored
-
stuartmorgan authored
We recently added `open` to this as part of changing all the templates, but the lock file is often quite large, and is often ancillary to the important issues details (unlike cases like code or screenshots), so it's better to leave this one collapsed by default.
-
engine-flutter-autoroll authored
https://github.com/flutter/packages/compare/09205ca19bd2...378e70006863 2024-01-09 engine-flutter-autoroll@skia.org Roll Flutter from c6ddb73f to 126302df (32 revisions) (flutter/packages#5852) 2024-01-09 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.22.12 to 3.23.0 (flutter/packages#5849) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/3269fd84460d...b361a60ae224 2024-01-10 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Migrate to Flutter mirrors for Google-owned Github repositories" (flutter/engine#49671) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/a5d446da5495...3269fd84460d 2024-01-10 skia-flutter-autoroll@skia.org Roll Skia from 51a0ad17b147 to 9271dcdade42 (1 revision) (flutter/engine#49669) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/3ccf66bed335...a5d446da5495 2024-01-10 skia-flutter-autoroll@skia.org Roll Dart SDK from d4b1939dffa6 to efd053daa2a6 (1 revision) (flutter/engine#49666) 2024-01-10 skia-flutter-autoroll@skia.org Roll Skia from ae30afc7b79a to 51a0ad17b147 (1 revision) (flutter/engine#49665) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/e57e418c02ae...3ccf66bed335 2024-01-10 skia-flutter-autoroll@skia.org Roll Skia from 2a77dffd384f to ae30afc7b79a (1 revision) (flutter/engine#49663) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/7e6f3d847e01...e57e418c02ae 2024-01-10 matanlurey@users.noreply.github.com Follow various best practices in `FlutterRenderer` (flutter/engine#49651) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/1cf2e0a603c7...7e6f3d847e01 2024-01-10 skia-flutter-autoroll@skia.org Roll Skia from 0e8023dc0a1a to 2a77dffd384f (1 revision) (flutter/engine#49662) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/32bbf8be8d2c...1cf2e0a603c7 2024-01-10 skia-flutter-autoroll@skia.org Roll Dart SDK from 727ea68c62d8 to d4b1939dffa6 (1 revision) (flutter/engine#49657) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/5b9d2132b7cd...32bbf8be8d2c 2024-01-10 skia-flutter-autoroll@skia.org Roll Skia from 4ef1837c2958 to 0e8023dc0a1a (1 revision) (flutter/engine#49655) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/941f268fc8bb...5b9d2132b7cd 2024-01-10 jacksongardner@google.com Refactor flutter.js to do dart2wasm bootstrapping and CanvasKit/Skwasm preloading. (flutter/engine#49037) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/542fea9edae4...941f268fc8bb 2024-01-09 30870216+gaaclarke@users.noreply.github.com [Impeller] made sure to scale the blur radius by the effect transform (flutter/engine#49645) 2024-01-09 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Refactors RBE support" (flutter/engine#49654) 2024-01-09 zanderso@users.noreply.github.com Refactors RBE support (flutter/engine#49416) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Igor Hnízdo authored
`NestedScrollView`'s outer scrollable jumping with `BouncingScrollPhysics` due to `double` precision errors (#138319) This PR fixes scrolling issues with `NestedScrollView` using the `BouncingScrollPhysics`. In one of the steps of the calculation, we can reach a state where the position of the inner scrollable is set to a `double` value that falls within `precisionErrorTolerance` of `0` but we were using `==` with `0` rather than checking for a precision. My posts in the linked issue show the current behavior, and how I reached to conclusion (the code in this PR). This PR only addresses the "jumping" of the outer scrollable. Fixes #136199 I have not finished a test for this since I have never done so and therefore have 0 experience writing tests in Flutter, so any help there would be appreciated. I am also not sure how to test double precision errors in general. I did run all the nested_scroll_view_tests.dart locally and there are no failures.
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/8c1501f3956d...542fea9edae4 2024-01-09 31859944+LongCatIsLooong@users.noreply.github.com Fix macOS text composing (flutter/engine#49314) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Polina Cherkasova authored
Contributes to https://github.com/flutter/devtools/issues/6909.
-
- 09 Jan, 2024 22 commits
-
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/693af0c699c5...8c1501f3956d 2024-01-09 matanlurey@users.noreply.github.com Make `shell/platform/android` IDE-friendly, and add documentation (flutter/engine#49612) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Chris Bobbe authored
Fixes #141140. This ensures that if you call `.copyWith` and pass a `debugLabel`, the `debugLabel` won't be ignored, even if the receiver (the TextStyle you're calling `.copyWith` on) doesn't have a `debugLabel`. The debugLabel field was added in #12552. I skimmed the discussion there and didn't find anything indicating that the param was being ignored on purpose. I added a test case that passes with the new code and fails with the old code.
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/a35e3b026e1d...693af0c699c5 2024-01-09 skia-flutter-autoroll@skia.org Roll Dart SDK from 721fccffc708 to 727ea68c62d8 (1 revision) (flutter/engine#49647) 2024-01-09 skia-flutter-autoroll@skia.org Roll Skia from 77534b672363 to 4ef1837c2958 (1 revision) (flutter/engine#49643) 2024-01-09 skia-flutter-autoroll@skia.org Roll Skia from 8c8be76a62c0 to 77534b672363 (1 revision) (flutter/engine#49641) 2024-01-09 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 6z4cZ6HUidtgmhvdk... to pUQrgMfXgU8RmLuL4... (flutter/engine#49640) 2024-01-09 bdero@google.com [Flutter GPU] Track HostBuffer emplacements by offset. (flutter/engine#49618) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from 6z4cZ6HUidtg to pUQrgMfXgU8R If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
stuartmorgan authored
The recently landed https://github.com/flutter/flutter/pull/140222 accidentally used the deprecated `exists?` instead of the non-deprecated `exist?` (which other code in this file is already, correctly, using). Fixes https://github.com/flutter/flutter/issues/141167
-
Kevin Moore authored
Replace `as Map<Object?, Object?>` to handle nullable case Fixes runtime issue in Wasm *Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.* *List which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.* *If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
-
Polina Cherkasova authored
-
Michael Goderbauer authored
This reverts commit https://github.com/flutter/flutter/commit/d24c01bd0c41331bd17165e0173b24c5d05d7c0a. The original change was reverted because it caused some apps to get stuck on the splash screen on some phones. An investigation determined that this was due to a rounding error. Example: The device reports a physical size of 1008.0 x 2198.0 with a dpr of 1.912500023841858. Flutter would translate that to a logical size of 527.0588169589221 x 1149.2810314243163 and use that as the input for its layout algorithm. Since the constraints here are tight, the layout algorithm would determine that the resulting logical size of the root render object must be 527.0588169589221 x 1149.2810314243163. Translating this back to physical pixels by applying the dpr resulted in a physical size of 1007.9999999999999 x 2198.0 for the frame. Android now rejected that frame because it didn't match the expected size of 1008.0 x 2198.0 and since no frame had been rendered would never take down the splash screen. Prior to dynamically sized views, this wasn't an issue because we would hard-code the frame size to whatever the requested size was. Changes in this PR over the original PR: * The issue has been fixed now by constraining the calculated physical size to the input physical constraints which makes sure that we always end up with a size that is acceptable to the operating system. * The `ViewConfiguration` was refactored to use the slightly more convenient `BoxConstraints` over the `ViewConstraints` to represent constraints. Both essentially represent the same thing, but `BoxConstraints` are more powerful and we avoid a couple of translations between the two by translating the` ViewConstraints` from the `FlutterView` to `BoxConstraints` directly when the `ViewConfiguration` is created. All changes over the original PR are contained in the second commit of this PR. Fixes b/316813075 Part of https://github.com/flutter/flutter/issues/134501.
-
SharbelOkzan authored
Introduced `validateGranually` which, apart from announcing the errors to the UI, returns a `Map<Key, bool>` providing more granular validation details: The results of calling `validate` on each `FormField` and their corresponding widget keys. * related issue: #135363
-
Taha Tesser authored
fixes [`RouteObserver` example throws an error](https://github.com/flutter/flutter/issues/141078) ### Description This updates the `RouteObserver` example from snippet to Dartpad example and fixes the error when running the code snippet
-
Polina Cherkasova authored
-
Casey Hillers authored
This test doesn't support presubmit as runs a separate git clone, which won't contain the presubmit hash. Fixes https://github.com/flutter/flutter/issues/141188
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/036b39fa47fa...a35e3b026e1d 2024-01-09 john@johnmccutchan.com Simplify PlatformViewRenderTarget interface (flutter/engine#49639) 2024-01-09 skia-flutter-autoroll@skia.org Roll Skia from 05039d6ed8d8 to 8c8be76a62c0 (3 revisions) (flutter/engine#49638) 2024-01-09 zanderso@users.noreply.github.com Skip flaky test on mac in http_disallow_http_connections_test.dart (flutter/engine#49635) 2024-01-09 john@johnmccutchan.com Resize the RenderTarget before creating and passing its Surface to the VirtualDisplay (flutter/engine#49619) 2024-01-09 103135467+sealesj@users.noreply.github.com Migrate to Flutter mirrors for Google-owned Github repositories (flutter/engine#49203) 2024-01-09 skia-flutter-autoroll@skia.org Roll Skia from ee263c34e03d to 05039d6ed8d8 (2 revisions) (flutter/engine#49636) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
-
Polina Cherkasova authored
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/b3c8597df0e2...036b39fa47fa 2024-01-09 skia-flutter-autoroll@skia.org Roll Skia from f9f73082740e to ee263c34e03d (3 revisions) (flutter/engine#49631) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Nishant Kumar authored
Fixes #140574 Passes the value from `CircularProgressIndicator` to the Cupertino version so that functionality is not lost on Apple devices.
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/820645dbcc69...b3c8597df0e2 2024-01-09 skia-flutter-autoroll@skia.org Roll Skia from 665f7d51ef25 to f9f73082740e (1 revision) (flutter/engine#49630) 2024-01-09 skia-flutter-autoroll@skia.org Roll Skia from 360944e3175f to 665f7d51ef25 (2 revisions) (flutter/engine#49628) 2024-01-09 skia-flutter-autoroll@skia.org Roll Skia from 92b84715ba73 to 360944e3175f (2 revisions) (flutter/engine#49622) 2024-01-09 skia-flutter-autoroll@skia.org Roll Skia from 06404ed554e7 to 92b84715ba73 (1 revision) (flutter/engine#49620) 2024-01-09 skia-flutter-autoroll@skia.org Roll Dart SDK from e8aa66f435ae to 721fccffc708 (5 revisions) (flutter/engine#49616) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/packages/compare/5aef49b1c1d8...09205ca19bd2 2024-01-09 stuartmorgan@google.com Re-land: Enable prefer_mixin and bump plugin_platform_interface to 2.1.7 (flutter/packages#5841) 2024-01-09 stuartmorgan@google.com [ci] Exclude quick_actions from Android emulators (flutter/packages#5847) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Bruno Leroux authored
## Description This PR adds custom system-wide text selection toolbar buttons on Android for `SelectableRegion` and `SelectionArea`. https://github.com/flutter/flutter/pull/139738 adds those buttons for `EditableText` (which is used by `TextField` and `SelectableText` but not by `SelectionArea`). ## Related Issue Step 5 for https://github.com/flutter/flutter/issues/139361 ## Tests Adds 2 tests.
-
Taha Tesser authored
Updated unit tests for `Tooltip` to have M2 and M3 versions. More info in #139076
-
Taha Tesser authored
Updated unit tests for `Tooltip` to have M2 and M3 versions. More info in #139076
-
Bruno Leroux authored
## Description This PR fixes an issue related to the spell check implementation usage of Regex (searched text should be escaped). ## Related Issue Fixes https://github.com/flutter/flutter/issues/136032. ## Tests Adds 1 test.
-
