Commits · 0dc3b072c195f3f61d5686c45a1e9dd32f0d85b1 · abdullh.alsoleman / Front-End

20 Dec, 2023 9 commits

Roll Packages from be52ac86bb4f to dc5b267f3cd1 (5 revisions) (#140450) · 0dc3b072

engine-flutter-autoroll authored Dec 20, 2023

https://github.com/flutter/packages/compare/be52ac86bb4f...dc5b267f3cd1

2023-12-20 engine-flutter-autoroll@skia.org Roll Flutter from 0eb78813 to da0cd696 (15 revisions) (flutter/packages#5729)
2023-12-20 49699333+dependabot[bot]@users.noreply.github.com [webview]: Bump androidx.annotation:annotation from 1.7.0 to 1.7.1 in /packages/webview_flutter/webview_flutter_android/android (flutter/packages#5702)
2023-12-19 jsharp83@gmail.com [webview_flutter] Implement platform interface for JavaScript dialog (flutter/packages#5670)
2023-12-19 JeroenWeener@users.noreply.github.com [webview_flutter] Support for handling basic authentication requests (iOS) (flutter/packages#5455)
2023-12-19 engine-flutter-autoroll@skia.org Roll Flutter from cdc83e5e to 0eb78813 (17 revisions) (flutter/packages#5722)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

0dc3b072

_TabBarViewState should not recreate page controller (#135500) · 0d90014b

Bruno Leroux authored Dec 20, 2023

## Description

This PR replaces the unconditional instantiation of `PageController` in `_TabBarViewState.didChangeDependencies` as suggested in https://github.com/flutter/flutter/pull/134091#discussion_r1319177744.

## Related Issue

Fixes https://github.com/flutter/flutter/issues/134253.

## Tests

Adds 1 test.

0d90014b

Revert automated changes made to deprecated settings.gradle (plugins.each) (#140037) · da0cd696

Gustl22 authored Dec 20, 2023

Restore testing deprecated settings.gradle (plugins.each).

Updated presumably by accident in #83067

Split from #137115
See also https://github.com/flutter/flutter/pull/137115#issuecomment-1781909865

da0cd696

[github actions] change minimal example workflow to be manually dispatched (#140435) · 62d69996
Xilai Zhang authored Dec 20, 2023
```
This would allow easier testing of the minimal example.

Might need Github Admin power to trigger the manual dispatches.
```
62d69996

Make `TextSpan` hit testing precise. (#139717) · ea5b9728

LongCatIsLooong authored Dec 20, 2023

Fixes https://github.com/flutter/flutter/issues/131435, #104594, #43400
Needs https://github.com/flutter/engine/pull/48774 (to fix the web test failure).

Currently the method we use for text span hit testing `TextPainter.getPositionForOffset` always returns the closest `TextPosition`, even when the given offset is far away from the text.

The new TextPaintes method tells you the layout bounds (`width = letterspacing / 2 + x_advance + letterspacing / 2`, `height = font ascent + font descent`) of a character, the PR changes the hit testing implementation such that a TextSpan is only considered hit if the point-down event landed in one of it's character's layout bounds.

Potential issues:

1. In theory since the text is baseline aligned, we should use the max ascent and max descent of each character to calculate the height of the text span's hit-test region, in case some characters in the span have to fall back to a different font, but that will be slower and it typically doesn't make a huge difference.

This is a breaking change. It also introduces a new finder and a new method `WidgetTester.tapOnText`: `await tester.tapOnText('string to match')` for ease of migration.

ea5b9728

[github actions] add minimal workflow to test token (#140363) · e86b8258

Xilai Zhang authored Dec 20, 2023

Add a workflow that simply:
1. checkout repo
2. write a file
3. create a PR

This is used to verify the permissions and validity of the github token we use to create PR.
context: https://chat.google.com/room/AAAAc_4rqiI/Ck593Sg7mvs

If we think the triggering condition is complicated, I can also change this workflow to be manual dispatch, to make it truly minimal.

e86b8258

Roll Flutter Engine from 5279873a8635 to c70f0a495ace (2 revisions) (#140431) · 18db55b4

engine-flutter-autoroll authored Dec 20, 2023

https://github.com/flutter/engine/compare/5279873a8635...c70f0a495ace

2023-12-19 skia-flutter-autoroll@skia.org Roll Skia from 48f959a857da to d0f09ad481f7 (3 revisions) (flutter/engine#49264)
2023-12-19 dkwingsmt@users.noreply.github.com Revert "Reland 2: Multiview Pipeline (#47239)" (flutter/engine#49238)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

18db55b4

Roll Flutter Engine from df1593e96a6b to 5279873a8635 (2 revisions) (#140428) · 0ae92601

engine-flutter-autoroll authored Dec 20, 2023

https://github.com/flutter/engine/compare/df1593e96a6b...5279873a8635

2023-12-19 skia-flutter-autoroll@skia.org Roll Dart SDK from e8cdc554c598 to 4c59838945d9 (2 revisions) (flutter/engine#49261)
2023-12-19 flar@google.com Make sure run_tests.py runs dart tests on Skia (flutter/engine#49260)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

0ae92601

[flutter_tools] handle FileSystemException trying to delete temp directory... · ef1227f0

Christopher Fujino authored Dec 20, 2023

[flutter_tools] handle FileSystemException trying to delete temp directory from core_devices.dart (#140415)

Fixes https://github.com/flutter/flutter/issues/140416, the top crasher on stable/3.16.4

ef1227f0

19 Dec, 2023 16 commits

Move hybrid_android_views_integration_test back to Moto G4 (#140421) · ea6017de
Zachary Anderson authored Dec 19, 2023
```
Related https://github.com/flutter/flutter/issues/140420
```
ea6017de

Roll Flutter Engine from 3b156c8ce9bd to df1593e96a6b (2 revisions) (#140422) · 8316e851

engine-flutter-autoroll authored Dec 19, 2023

https://github.com/flutter/engine/compare/3b156c8ce9bd...df1593e96a6b

2023-12-19 zanderso@users.noreply.github.com Rolls clang to 725656bdd885483c39f482a01ea25d67acf39c46 (flutter/engine#49248)
2023-12-19 aam@google.com Roll dart to 3.3.0-242.0.dev (flutter/engine#49239)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

8316e851

Added onEnd callback into AnimatedSize (#139859) · 2bb19a95
Fedor Blagodyr authored Dec 19, 2023
```
close #106439
```
2bb19a95

Roll Flutter Engine from 3f45f9db4471 to 3b156c8ce9bd (1 revision) (#140413) · 5a5683dd

engine-flutter-autoroll authored Dec 19, 2023

https://github.com/flutter/engine/compare/3f45f9db4471...3b156c8ce9bd

2023-12-19 skia-flutter-autoroll@skia.org Roll Skia from df1a7ccbdc97 to 48f959a857da (1 revision) (flutter/engine#49255)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

5a5683dd

Roll Flutter Engine from 187334c39b44 to 3f45f9db4471 (3 revisions) (#140412) · 1fd5d87e

engine-flutter-autoroll authored Dec 19, 2023

https://github.com/flutter/engine/compare/187334c39b44...3f45f9db4471

2023-12-19 skia-flutter-autoroll@skia.org Roll Skia from 541f16af8b3e to df1a7ccbdc97 (3 revisions) (flutter/engine#49250)
2023-12-19 skia-flutter-autoroll@skia.org Roll Skia from 0d39fb28b32d to 541f16af8b3e (1 revision) (flutter/engine#49246)
2023-12-19 john@johnmccutchan.com Use new SurfaceProducer external texture class for rendering platform views (flutter/engine#49201)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

1fd5d87e

Remove workarounds for `plugin_lint_mac` needed for older version of Cocoapods (#140395) · 6981fe6f

Victoria Ashworth authored Dec 19, 2023

CI has been updated to Cocoapods 1.13, which fixes previous issues with the `plugin_lint_mac` test. Remove workarounds added previously.

Fixes https://github.com/flutter/flutter/issues/125812.

See also https://github.com/flutter/flutter/issues/133584.

6981fe6f

Roll Flutter Engine from b87a782ce3a3 to 187334c39b44 (2 revisions) (#140398) · b14d7452

engine-flutter-autoroll authored Dec 19, 2023

https://github.com/flutter/engine/compare/b87a782ce3a3...187334c39b44

2023-12-19 skia-flutter-autoroll@skia.org Roll Skia from 22dad95c218f to 0d39fb28b32d (2 revisions) (flutter/engine#49241)
2023-12-19 skia-flutter-autoroll@skia.org Roll Skia from 6496c9c5866a to 22dad95c218f (4 revisions) (flutter/engine#49237)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

b14d7452

Roll Flutter Engine from 1d5a141917fa to b87a782ce3a3 (1 revision) (#140390) · 837ba409

engine-flutter-autoroll authored Dec 19, 2023

https://github.com/flutter/engine/compare/1d5a141917fa...b87a782ce3a3

2023-12-19 skia-flutter-autoroll@skia.org Roll Skia from ed0148ab400d to 6496c9c5866a (6 revisions) (flutter/engine#49234)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

837ba409

Shift some Linux-hosted tests on moto g4 to pixel 7 (#140389) · 0eb78813
Zachary Anderson authored Dec 19, 2023

0eb78813

Reland "Warn when Gradle plugins are applied using the legacy apply script method (#140103) · a1e1dc3f

Bartek Pacia authored Dec 19, 2023

> This PR relands #139690 which was reverted in #140102

This PR adds a deprecation message when Android build is using the legacy "apply script method" way of applying Flutter's Gradle plugins (that is: [`flutter.gradle`](https://github.com/flutter/flutter/blob/3.16.0/packages/flutter_tools/gradle/flutter.gradle) and [`app_plugin_loader.gradle`](https://github.com/flutter/flutter/blob/3.16.0/packages/flutter_tools/gradle/app_plugin_loader.gradle)).

See also:
- #121541
  - in particular https://github.com/flutter/flutter/issues/121541#issuecomment-1836947311
- #135392
  - and PR that add the migration guide: [#9857](https://github.com/flutter/website/pull/9857)

- I think either `logger.error` or `logger.quiet` must be used, because all other error levels are not shown during `flutter build apk` (and that's what most people use).

a1e1dc3f

Roll Packages from d7dee796f3c8 to be52ac86bb4f (1 revision) (#140386) · df678135

engine-flutter-autoroll authored Dec 19, 2023

https://github.com/flutter/packages/compare/d7dee796f3c8...be52ac86bb4f

2023-12-18 engine-flutter-autoroll@skia.org Roll Flutter from 2407f699 to cdc83e5e (28 revisions) (flutter/packages#5715)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

df678135

Roll Flutter Engine from bde7c612f6ba to 1d5a141917fa (3 revisions) (#140371) · bbfe177d

engine-flutter-autoroll authored Dec 19, 2023

https://github.com/flutter/engine/compare/bde7c612f6ba...1d5a141917fa

2023-12-19 skia-flutter-autoroll@skia.org Roll Skia from c12c2a174327 to ed0148ab400d (1 revision) (flutter/engine#49222)
2023-12-19 49699333+dependabot[bot]@users.noreply.github.com Bump actions/upload-artifact from 3.1.3 to 4.0.0 (flutter/engine#49220)
2023-12-19 skia-flutter-autoroll@skia.org Roll Skia from 27ab8a8d2a0d to c12c2a174327 (1 revision) (flutter/engine#49218)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

bbfe177d

Roll Flutter Engine from 42af8f106206 to bde7c612f6ba (2 revisions) (#140367) · 51633fe9

engine-flutter-autoroll authored Dec 19, 2023

https://github.com/flutter/engine/compare/42af8f106206...bde7c612f6ba

2023-12-19 academy3746@gmail.com Makes PlatformViewsController view to use tracked event's action & pointer count (flutter/engine#47424)
2023-12-19 skia-flutter-autoroll@skia.org Roll Skia from 37a60129e019 to 27ab8a8d2a0d (1 revision) (flutter/engine#49213)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

51633fe9

Roll Flutter Engine from bbfee6f59b42 to 42af8f106206 (1 revision) (#140362) · 2ed0df84

engine-flutter-autoroll authored Dec 19, 2023

https://github.com/flutter/engine/compare/bbfee6f59b42...42af8f106206

2023-12-19 skia-flutter-autoroll@skia.org Roll Skia from e5b0cdc11992 to 37a60129e019 (1 revision) (flutter/engine#49212)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

2ed0df84

Upgrade to version of leak tracker that does not depend on test_widgets. (#140247) · 6368d656
Polina Cherkasova authored Dec 19, 2023
```
Contributes to: https://github.com/flutter/flutter/issues/135856
```
6368d656

Roll Flutter Engine from 632103f787ba to bbfee6f59b42 (4 revisions) (#140359) · cc4b3293

engine-flutter-autoroll authored Dec 19, 2023

https://github.com/flutter/engine/compare/632103f787ba...bbfee6f59b42

2023-12-19 skia-flutter-autoroll@skia.org Roll Skia from fff421ff633e to e5b0cdc11992 (4 revisions) (flutter/engine#49210)
2023-12-19 skia-flutter-autoroll@skia.org Roll Skia from 63bed826008e to fff421ff633e (1 revision) (flutter/engine#49208)
2023-12-19 godofredoc@google.com Double timeout on mac builds. (flutter/engine#49205)
2023-12-18 flar@google.com [Impeller] Make Rect origin and size fields private (flutter/engine#49168)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

cc4b3293

18 Dec, 2023 13 commits

Roll Flutter Engine from 92d88c7e4e9a to 632103f787ba (9 revisions) (#140350) · 0d775705

engine-flutter-autoroll authored Dec 18, 2023

https://github.com/flutter/engine/compare/92d88c7e4e9a...632103f787ba

2023-12-18 matej.knopp@gmail.com Convert chromium wheel delta to physical pixels on macOS (flutter/engine#49028)
2023-12-18 skia-flutter-autoroll@skia.org Roll Skia from 3de801338767 to 63bed826008e (1 revision) (flutter/engine#49200)
2023-12-18 skia-flutter-autoroll@skia.org Roll Dart SDK from ff7e92c7886d to b21443096387 (1 revision) (flutter/engine#49199)
2023-12-18 skia-flutter-autoroll@skia.org Roll Skia from 83f8fe8bbcee to 3de801338767 (2 revisions) (flutter/engine#49195)
2023-12-18 skia-flutter-autoroll@skia.org Roll Skia from 10e7ee119ea9 to 83f8fe8bbcee (1 revision) (flutter/engine#49193)
2023-12-18 barpac02@gmail.com Delete `SemanticsUpdateBuilderNew` and all references and usages (flutter/engine#49139)
2023-12-18 chinmaygarde@google.com Opt into unstable libcxx ABI and add a custom namespace. (flutter/engine#49002)
2023-12-18 skia-flutter-autoroll@skia.org Roll Skia from 4b2639427e7e to 10e7ee119ea9 (10 revisions) (flutter/engine#49191)
2023-12-18 skia-flutter-autoroll@skia.org Roll Dart SDK from e1a26302800d to ff7e92c7886d (1 revision) (flutter/engine#49185)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

0d775705

SemanticsProperties: default `identifier` and `tooltip` to null (#140283) · a4388773
Bartek Pacia authored Dec 18, 2023
```
This PR applies [the suggestion made here](https://github.com/flutter/devtools/pull/6942#issuecomment-1852773200).
```
a4388773

Document difference between softWrap and maxLine (#139363) · b893884f

Simon Friis Vindum authored Dec 18, 2023

This PR fixes #13631 through documentation as suggested in https://github.com/flutter/flutter/issues/13631#issuecomment-354902727.

Since the documentation additions rely on new screenshots this PR will be accompanied by a PR in the assets repository.

b893884f

Roll Flutter Engine from 2dc18738167e to 92d88c7e4e9a (1 revision) (#140332) · 008ecd8c

engine-flutter-autoroll authored Dec 18, 2023

https://github.com/flutter/engine/compare/2dc18738167e...92d88c7e4e9a

2023-12-18 skia-flutter-autoroll@skia.org Roll Skia from 290fefdef726 to 4b2639427e7e (1 revision) (flutter/engine#49183)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

008ecd8c

Only run dart files as a test in the Android preview tools test shard (#140099) · bdfb56ce

Gray Mackall authored Dec 18, 2023

I added a README at the end of https://github.com/flutter/flutter/pull/131901 and did not realize that it was being run as a test, [leading to test failures (of course)](https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8761789207346423409/+/u/run_test.dart_for_android_preview_tool_integration_tests_shard_and_subshard_None/test_stdout). This makes it so we only run dart files as dart tests.

bdfb56ce

Roll Flutter Engine from e4fa972d70cb to 2dc18738167e (1 revision) (#140328) · a17e2e08

engine-flutter-autoroll authored Dec 18, 2023

https://github.com/flutter/engine/compare/e4fa972d70cb...2dc18738167e

2023-12-18 skia-flutter-autoroll@skia.org Roll Skia from 276075b97567 to 290fefdef726 (1 revision) (flutter/engine#49180)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

a17e2e08

Roll Flutter Engine from d7f0803dd6af to e4fa972d70cb (1 revision) (#140324) · 7b7aa6a9

engine-flutter-autoroll authored Dec 18, 2023

https://github.com/flutter/engine/compare/d7f0803dd6af...e4fa972d70cb

2023-12-18 mdebbar@google.com [web] Set cursor property on body (flutter/engine#49098)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

7b7aa6a9

Roll Packages from 3f2e16bf2b17 to d7dee796f3c8 (5 revisions) (#140322) · 63753d4a

engine-flutter-autoroll authored Dec 18, 2023

https://github.com/flutter/packages/compare/3f2e16bf2b17...d7dee796f3c8

2023-12-16 tarrinneal@gmail.com Remove flutter api named and optional parameters (flutter/packages#5689)
2023-12-15 engine-flutter-autoroll@skia.org Manual roll Flutter (stable) from b0366e0a3f08 to 2e9cb0aa71a3 (4 revisions) (flutter/packages#5692)
2023-12-15 mikemcguiness@protonmail.com [extension_google_sign_in_as_googleapis_auth] Adopt code excerpts in â¦ (flutter/packages#5496)
2023-12-15 engine-flutter-autoroll@skia.org Roll Flutter from a51e33ac to 2407f699 (30 revisions) (flutter/packages#5691)
2023-12-15 davidmartos96@gmail.com [google_sign_in_ios] Move pigeon as a dev dependency (flutter/packages#5685)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

63753d4a

Roll Flutter Engine from 7f1a81d5545a to d7f0803dd6af (2 revisions) (#140320) · 83236fdf

engine-flutter-autoroll authored Dec 18, 2023

https://github.com/flutter/engine/compare/7f1a81d5545a...d7f0803dd6af

2023-12-18 skia-flutter-autoroll@skia.org Roll Skia from 74e6a355f208 to 276075b97567 (1 revision) (flutter/engine#49177)
2023-12-18 skia-flutter-autoroll@skia.org Roll Dart SDK from c8106261c9cd to e1a26302800d (1 revision) (flutter/engine#49178)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

83236fdf

Roll Flutter Engine from b3de65a6d3ea to 7f1a81d5545a (1 revision) (#140309) · cdc83e5e

engine-flutter-autoroll authored Dec 18, 2023

https://github.com/flutter/engine/compare/b3de65a6d3ea...7f1a81d5545a

2023-12-18 skia-flutter-autoroll@skia.org Roll Skia from d4b1cc5122f9 to 74e6a355f208 (1 revision) (flutter/engine#49171)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

cdc83e5e

refactored cli tool ipa method name to support --export-options-plist (#138555) · 4659b0c4

raphire08 authored Dec 18, 2023

This PR changes the way the IPA method is read in the run command for `build ipa` command. If export options plist argument is provided it takes method name from plist, otherwise it uses the method name from export method argument.

*List which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.*
fixes [#122179](https://github.com/flutter/flutter/issues/122179)

4659b0c4

Restore and fix flavors_test_macos (#139841) · f8b97486

Andrew Kolos authored Dec 18, 2023

Partially resolves[^1] https://github.com/flutter/flutter/issues/139774.

Effectively reverts https://github.com/flutter/flutter/pull/125581.

The main change here is that I deleted and recreated the macos Xcode project for this integration test (hence the large diff). I tried fixing the existing project first, but it was set up quite differently, andâfor whatever reasonâthe integration test would get stuck trying to load `dev/integration_tests/flavors/integration_test/integration_test.dart`.

I verified that this works locally, but I don't know if it's possible to run this on the devicelab try pool to verify that it works on devicelab hardware.

[^1]: I would not close the issue until 1) this PR lands, 2) the integration test consistently passes on CI, and 3) macOS support for flavors is publicly documented.

f8b97486

Roll Flutter Engine from 626c93260f79 to b3de65a6d3ea (1 revision) (#140308) · 79bc6ded

engine-flutter-autoroll authored Dec 18, 2023

https://github.com/flutter/engine/compare/626c93260f79...b3de65a6d3ea

2023-12-18 skia-flutter-autoroll@skia.org Roll Skia from e40b61c3dfef to d4b1cc5122f9 (2 revisions) (flutter/engine#49169)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

79bc6ded

17 Dec, 2023 2 commits

Roll Flutter Engine from f9c7aa27f13a to 626c93260f79 (1 revision) (#140291) · 32d42b63

engine-flutter-autoroll authored Dec 17, 2023

https://github.com/flutter/engine/compare/f9c7aa27f13a...626c93260f79

2023-12-17 skia-flutter-autoroll@skia.org Roll Skia from 6598d8b28c51 to e40b61c3dfef (1 revision) (flutter/engine#49154)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

32d42b63

Roll Flutter Engine from 726a137e3f99 to f9c7aa27f13a (1 revision) (#140289) · b167f065

engine-flutter-autoroll authored Dec 17, 2023

https://github.com/flutter/engine/compare/726a137e3f99...f9c7aa27f13a

2023-12-17 skia-flutter-autoroll@skia.org Roll Skia from 49cfb91d353f to 6598d8b28c51 (1 revision) (flutter/engine#49153)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

b167f065