- 03 Jan, 2024 25 commits
-
-
yim authored
This PR changes the regular cursor to a floating cursor when a long press occurs. This is a new feature. Fixes #89228
-
Furkan Acar authored
fixes https://github.com/flutter/flutter/issues/138289 --- SegmentedButtom.styleFrom has been added to the segment button, so there is no longer any need to the button style from the beginning. It works like ElevatedButton.styleFrom only I added selectedForegroundColor, selectedBackgroundColor. In this way, the user will be able to change the color first without checking the MaterialState states. I added tests of the same controls. #129215 I opened this problem myself, but I was rejected because I handled too many items in a PR. For now, I wrote a structure that only handles MaterialStates instead of users. old (still avaliable) <img width="626" alt="image" src="https://github.com/flutter/flutter/assets/65075121/9446b13b-c355-4d20-bda2-c47a23d42d4f"> new (just an option for developer) <img width="483" alt="image" src="https://github.com/flutter/flutter/assets/65075121/0a645257-4c83-4029-9484-bd746c02265f"> ### Code sample <details> <summary>expand to view the code sample</summary> ```dart import 'package:flutter/material.dart'; /// Flutter code sample for [SegmentedButton]. void main() { runApp(const SegmentedButtonApp()); } enum Calendar { day, week, month, year } class SegmentedButtonApp extends StatefulWidget { const SegmentedButtonApp({super.key}); @override State<SegmentedButtonApp> createState() => _SegmentedButtonAppState(); } class _SegmentedButtonAppState extends State<SegmentedButtonApp> { Calendar calendarView = Calendar.day; @override Widget build(BuildContext context) { return MaterialApp( theme: ThemeData(useMaterial3: true), home: Scaffold( body: Center( child: SegmentedButton<Calendar>( style: SegmentedButton.styleFrom( foregroundColor: Colors.amber, visualDensity: VisualDensity.comfortable, ), // style: const ButtonStyle( // foregroundColor: MaterialStatePropertyAll<Color>(Colors.deepPurple), // visualDensity: VisualDensity.comfortable, // ), segments: const <ButtonSegment<Calendar>>[ ButtonSegment<Calendar>( value: Calendar.day, label: Text('Day'), icon: Icon(Icons.calendar_view_day)), ButtonSegment<Calendar>( value: Calendar.week, label: Text('Week'), icon: Icon(Icons.calendar_view_week)), ButtonSegment<Calendar>( value: Calendar.month, label: Text('Month'), icon: Icon(Icons.calendar_view_month)), ButtonSegment<Calendar>( value: Calendar.year, label: Text('Year'), icon: Icon(Icons.calendar_today)), ], selected: <Calendar>{calendarView}, onSelectionChanged: (Set<Calendar> newSelection) { setState(() { calendarView = newSelection.first; }); }, ), ), ), ); } } ``` </details>
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/c62bcff5b809...bf979d220283 2024-01-03 john@johnmccutchan.com Fix a crash in the new SurfaceProducer external texture (flutter/engine#49496) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Polina Cherkasova authored
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/98b72c7ffe71...c62bcff5b809 2024-01-03 jonahwilliams@google.com [Impeller] Disable compute for Vulkan. (flutter/engine#49463) 2024-01-03 dkwingsmt@users.noreply.github.com Revert skiping illegal render in Dart (flutter/engine#49473) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Jonah Williams authored
This allows unit tests to use the impeller backend, which can be useful for Scubas/golden tests.
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/cf7536964a2f...98b72c7ffe71 2024-01-03 skia-flutter-autoroll@skia.org Roll Skia from 9e8069bba51d to 1144b7950404 (1 revision) (flutter/engine#49494) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Ann Marie Mossman authored
https://github.com/flutter/flutter/issues/1670 Note: This PR replaces the the original PR (https://github.com/flutter/flutter/pull/138240) that got into a state where a rebase was not possible and made it difficult to determine what was causing unrelated test failures.
-
lsaudon authored
Reference: [author:lsaudon](https://github.com/flutter/flutter/issues?q=author%3Alsaudon)
-
Elliott Brooks authored
Added a minimal wiki page about how to use the `update-packages` tool: https://github.com/flutter/flutter/wiki/Updating-dependencies-in-Flutter This PR adds a link to that wiki page at the top of each pubspec.yaml file
-
Flutter GitHub Bot authored
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY. { "name": "Linux_pixel_7pro native_assets_android" } --> The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Linux_pixel_7pro%20native_assets_android%22). This test can be marked as unflaky.
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/3b6edee0f8f7...cf7536964a2f 2024-01-03 skia-flutter-autoroll@skia.org Roll Skia from a9db1213b179 to 9e8069bba51d (18 revisions) (flutter/engine#49490) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/packages/compare/fa74d3e1e71a...bbb41347518e 2024-01-02 43054281+camsim99@users.noreply.github.com [camerax] Implement `lockCaptureOrientation` & `unlockCaptureOrientation` (flutter/packages#5285) 2024-01-02 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.22.11 to 3.22.12 (flutter/packages#5738) 2024-01-02 chillers@google.com Add Flutter CI Status badge to README (flutter/packages#5733) 2023-12-26 49699333+dependabot[bot]@users.noreply.github.com [path_provider]: Bump androidx.annotation:annotation from 1.7.0 to 1.7.1 in /packages/path_provider/path_provider_android/android (flutter/packages#5709) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/3a7aa01b0a7d...3b6edee0f8f7 2024-01-03 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Roll Dart SDK from 7e9f7eab80d3 to c5a75ac9057c (1 revision)" (flutter/engine#49491) 2024-01-03 skia-flutter-autoroll@skia.org Roll Skia from 4b16117e94b2 to a9db1213b179 (1 revision) (flutter/engine#49487) 2024-01-03 dnfield@google.com [Impeller] Allow multiple --runtime-stage-* parameters to impellerc (flutter/engine#49475) 2024-01-03 skia-flutter-autoroll@skia.org Roll Dart SDK from 7e9f7eab80d3 to c5a75ac9057c (1 revision) (flutter/engine#49478) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Jack Gibbons authored
Pass key into _BottomNavigationTile Adding a optional key parameter to BottomNavigationBarItem to be passed through to _BottomNavigationTile. This will allow easier testing in some scenarios, and fix the splash appearing on the wrong tile. https://github.com/flutter/flutter/issues/139615 https://github.com/flutter/flutter/issues/34833
-
Flutter GitHub Bot authored
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY. { "name": "Linux_android hybrid_android_views_integration_test" } --> The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Linux_android%20hybrid_android_views_integration_test%22). This test can be marked as unflaky.
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/e95e12368a42...3a7aa01b0a7d 2024-01-02 jonahwilliams@google.com [Impeller] add doc on iOS flamegraph capture. (flutter/engine#49469) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Satsrag authored
For https://github.com/flutter/flutter/issues/125875 and https://github.com/flutter/engine/pull/45522 According to [this discussion](https://github.com/flutter/flutter/pull/139446#discussion_r1424776370), Just added `forceMultiline` to JSON on `_configurationToJson`. @LongCatIsLooong @Renzo-Olivares
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/b5e79bd249b8...e95e12368a42 2024-01-02 737941+loic-sharma@users.noreply.github.com Revert "Reland "[Windows] Move to FlutterCompositor for rendering" (flutter/engine#49461) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
John McCutchan authored
This is a reland of https://github.com/flutter/flutter/pull/140806 which had an issue with package versions.
-
Jenn Magder authored
Reland https://github.com/flutter/flutter/pull/140478 with `ios_content_validation_test` test fix. ``` [ios_content_validation_test] Process terminated with exit code 0. Task result: { "success": true, "data": null, "detailFiles": [], "benchmarkScoreKeys": [], "reason": "success" } ``` __________ 1. Change templates to `IPHONEOS_DEPLOYMENT_TARGET`, `MinimumOSVersion`, and Podfile `platform :ios` to 12.0. 2. Add migrator for Podfile part to migrate `platform :ios, '11.0'` -> `platform :ios, '12.0'` 3. Compile with `-miphoneos-version-min=12.0` 4. Run the migrator on all example apps and integration tests. See also https://github.com/flutter/flutter/pull/62902 and https://github.com/flutter/flutter/pull/85174 and https://github.com/flutter/flutter/pull/101963 Fixes https://github.com/flutter/flutter/issues/136060
-
David Iglesias authored
This enables multi-view apps to start with zero views.
-
Andrew Kolos authored
Fixes https://github.com/flutter/flutter/issues/140665 by replacing use of `setUpAll` and `teardownAll` with `setUp` and `teardown` respectively. My theory has to how this issue happened (and how this PR fixes it) is that `setUpAll` is not guaranteed to run after any `setUp` in any parent test groups. However, `setUp` is guaranteed to run after any set-up callbacks in parent groups. From the [documentation](https://api.flutter.dev/flutter/flutter_test/setUp.html): > If this is called within a test group, it applies only to tests in that group. The body will be run after any set-up callbacks in parent groups or at the top level. Meanwhile, [`setUpAll`](https://api.flutter.dev/flutter/flutter_test/setUpAll.html) has a weaker documented guarantee that applies only to other `setUpAll` calls: > If this is called within a test group, The body will run before all tests in that group. It will be run after any [setUpAll](https://api.flutter.dev/flutter/flutter_test/setUpAll.html) callbacks in parent groups or at the top level. It won't be run if none of the tests in the group are run.
-
LongCatIsLooong authored
Fixes #139196
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/b02d59a2a607...b5e79bd249b8 2024-01-02 dnfield@google.com Start wiring up fragment program for OpenGLES (flutter/engine#49347) 2024-01-02 skia-flutter-autoroll@skia.org Roll Dart SDK from 014514e3e5b9 to 7e9f7eab80d3 (2 revisions) (flutter/engine#49471) 2024-01-02 yjbanov@google.com [web] make TextStyle implementations consistent (flutter/engine#49465) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
- 02 Jan, 2024 15 commits
-
-
auto-submit[bot] authored
Reverts flutter/flutter#140806 Initiated by: zanderso This change reverts the following previous change: Original Description: This is an integration test associated with https://github.com/flutter/engine/pull/49268
-
John McCutchan authored
This is an integration test associated with https://github.com/flutter/engine/pull/49268
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/9d89f8727976...b02d59a2a607 2024-01-02 john@johnmccutchan.com Android Platform Views support Verified Input Events (flutter/engine#49268) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/a06926d05d2b...9d89f8727976 2024-01-02 30870216+gaaclarke@users.noreply.github.com [Impeller] new blur: implemented ping ponging (flutter/engine#49252) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Polina Cherkasova authored
-
auto-submit[bot] authored
Reverts flutter/flutter#140478 Initiated by: loic-sharma This change reverts the following previous change: Original Description: 1. Change templates to `IPHONEOS_DEPLOYMENT_TARGET`, `MinimumOSVersion`, and Podfile `platform :ios` to 12.0. 2. Add migrator for Podfile part to migrate `platform :ios, '11.0'` -> `platform :ios, '12.0'` 3. Compile with `-miphoneos-version-min=12.0` 4. Run the migrator on all example apps and integration tests. See also https://github.com/flutter/flutter/pull/62902 and https://github.com/flutter/flutter/pull/85174 and https://github.com/flutter/flutter/pull/101963 Fixes https://github.com/flutter/flutter/issues/136060
-
LongCatIsLooong authored
Fixes https://github.com/flutter/flutter/issues/131435, https://github.com/flutter/flutter/issues/104594, https://github.com/flutter/flutter/issues/43400 Currently the method we use for text span hit testing `TextPainter.getPositionForOffset` always returns the closest `TextPosition`, even when the given offset is far away from the text. The new TextPaintes method tells you the layout bounds `(width = letterspacing / 2 + x_advance + letterspacing / 2, height = font ascent + font descent)` of a character, the PR changes the hit testing implementation such that a TextSpan is only considered hit if the point-down event landed in one of its character's layout bounds. Potential issues: In theory since the text is baseline aligned, we should use the max ascent and max descent of each character to calculate the height of the text span's hit-test region, in case some characters in the span have to fall back to a different font, but that will be slower and it typically doesn't make a huge difference. This is a breaking change.
-
Elliott Brooks authored
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/194d90de78cc...a06926d05d2b 2024-01-02 dnfield@google.com Make sure to finish the suite if all tests are skipped (flutter/engine#49339) 2024-01-02 26625149+0xZOne@users.noreply.github.com Fix NPE when platform plugin delegate is null (flutter/engine#49391) 2024-01-02 26625149+0xZOne@users.noreply.github.com Add try-with-resource support to TraceSection (flutter/engine#49445) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Jenn Magder authored
1. Change templates to `IPHONEOS_DEPLOYMENT_TARGET`, `MinimumOSVersion`, and Podfile `platform :ios` to 12.0. 2. Add migrator for Podfile part to migrate `platform :ios, '11.0'` -> `platform :ios, '12.0'` 3. Compile with `-miphoneos-version-min=12.0` 4. Run the migrator on all example apps and integration tests. See also https://github.com/flutter/flutter/pull/62902 and https://github.com/flutter/flutter/pull/85174 and https://github.com/flutter/flutter/pull/101963 Fixes https://github.com/flutter/flutter/issues/136060
-
shirne authored
*Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.* *List which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.* *If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
-
Dan Field authored
Reverts flutter/flutter#123828 Fixes https://github.com/flutter/flutter/issues/140523
-
Polina Cherkasova authored
Contributes to https://github.com/flutter/flutter/issues/140622
-
Polina Cherkasova authored
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/9e03a57cde8a...194d90de78cc 2024-01-02 skia-flutter-autoroll@skia.org Roll Dart SDK from 54ae19428139 to 014514e3e5b9 (1 revision) (flutter/engine#49458) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-