1. 09 Jun, 2023 10 commits
    • William Hesse's avatar
      [testing] Make the FLUTTER_STORAGE_BASE_URL warning non-fatal (#128335) · 0d39f646
      William Hesse authored
      Presubmit testing and CI testing of Flutter using a custom storage location for engine artifacts must be able to use the --fatal-warnings flag without failing due to the custom artifact location.
      
      This change adds an option that makes this warning non-fatal. The new --no-fatal-storage-url-warning flag makes the --fatal-warnings flag ignore the warning that a custom artifact download URL is being used by setting the environment variable FLUTTER_STORAGE_BASE_URL.
      
      Bug: #127683
      
      - [X ] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
      - [X ] I read the [Tree Hygiene] wiki page, which explains my responsibilities.
      - [X ] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
      - [X ] I signed the [CLA].
      - [X ] I listed at least one issue that this PR fixes in the description above.
      - [X ] I updated/added relevant documentation (doc comments with `///`).
      0d39f646
    • Danny Tuppeny's avatar
      [flutter_tools] [DAP] Don't try to restart/reload if app hasn't started yet (#128267) · 46007d61
      Danny Tuppeny authored
      The editor is set to hot-reload-on-save by default so saving while the debug session is starting currently prints an error:
      
      Failed to Hot Reload: app 'null' not found
      
      ![image](https://github.com/flutter/flutter/assets/1078012/a125b455-a46d-4993-98d8-5d8ae7237a00)
      
      This change skips the call to `app.restart` if the app hasn't started yet to avoid printing an error.
      46007d61
    • engine-flutter-autoroll's avatar
      Roll Flutter Engine from 8f9e608d39ab to cb93477008d6 (3 revisions) (#128568) · 6d4c4d75
      engine-flutter-autoroll authored
      https://github.com/flutter/engine/compare/8f9e608d39ab...cb93477008d6
      
      2023-06-09 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from lPCv1NshK-tvjtLgC... to xqQPG9jnWgD1Dj3FL... (flutter/engine#42694)
      2023-06-09 skia-flutter-autoroll@skia.org Roll ANGLE from d8339e78db54 to 8a62b4c44fc9 (1 revision) (flutter/engine#42691)
      2023-06-09 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from ukXXOXtI7uRIukzF5... to romfKfKwgjzAXQSxt... (flutter/engine#42689)
      
      Also rolling transitive DEPS:
        fuchsia/sdk/core/linux-amd64 from lPCv1NshK-tv to xqQPG9jnWgD1
        fuchsia/sdk/core/mac-amd64 from ukXXOXtI7uRI to romfKfKwgjzA
      
      If this roll has caused a breakage, revert this CL and stop the roller
      using the controls here:
      https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
      Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
      is aware of the problem.
      
      To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
      
      To report a problem with the AutoRoller itself, please file a bug:
      https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
      
      Documentation for the AutoRoller is here:
      https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
      6d4c4d75
    • Taha Tesser's avatar
    • Taha Tesser's avatar
      Fix `showBottomSheet` doesn't remove scrim when draggable sheet is dismissed (#128455) · 8600eb12
      Taha Tesser authored
      fixes https://github.com/flutter/flutter/issues/128367
      
      <details> 
      <summary>code sample</summary> 
      
      ```dart
      import 'package:flutter/material.dart';
      
      void main() => runApp(const MyApp());
      
      class MyApp extends StatelessWidget {
        const MyApp({super.key});
      
        @override
        Widget build(BuildContext context) {
          return MaterialApp(
            debugShowCheckedModeBanner: false,
            theme: ThemeData(useMaterial3: true),
            home: Scaffold(
              floatingActionButton: Builder(
                builder: (BuildContext context) => FloatingActionButton(
                  child: const Icon(Icons.add),
                  onPressed: () {
                    Scaffold.of(context).showBottomSheet<void>(
                      (_) {
                        return DraggableScrollableSheet(
                          expand: false,
                          builder: (_, ScrollController scrollController) =>
                              ListView.builder(
                            controller: scrollController,
                            itemCount: 25,
                            itemBuilder: (BuildContext context, int index) {
                              return ListTile(
                                title: Text('Item $index - tap to close'),
                                onTap: () {
                                  Navigator.of(context).pop();
                                },
                              );
                            },
                          ),
                        );
                      },
                    );
                  },
                ),
              ),
            ),
          );
        }
      }
      ``` 
      	
      </details>
      
      ### Before
      
      https://github.com/flutter/flutter/assets/48603081/fa87feb9-54f2-4e50-bf71-c81d9e54ff61
      
      ### After 
      
      https://github.com/flutter/flutter/assets/48603081/7d192059-7600-4d65-ae84-6321f3598133
      8600eb12
    • engine-flutter-autoroll's avatar
      Manual roll Flutter Engine from a5f7d5d75ff2 to 8f9e608d39ab (31 revisions) (#128554) · 80b9ac2c
      engine-flutter-autoroll authored
      Manual roll Flutter Engine from a5f7d5d75ff2 to 8f9e608d39ab (31 revisions)
      
      Manual roll requested by zra@google.com
      
      https://github.com/flutter/engine/compare/a5f7d5d75ff2...8f9e608d39ab
      
      2023-06-09 zanderso@users.noreply.github.com Revert Dart to 3.1.0-180.0.dev (flutter/engine#42688)
      2023-06-09 mk12360@gmail.com [fuchsia] Bump the target API level to 12, and pass it to fidlc (flutter/engine#42667)
      2023-06-09 bdero@google.com [Impeller] Add tests for foreground blends with mask blurs (flutter/engine#42687)
      2023-06-09 godofredoc@google.com Document the use of realm in archives. (flutter/engine#42682)
      2023-06-09 skia-flutter-autoroll@skia.org Roll ANGLE from 76b0e7f38b44 to d8339e78db54 (1 revision) (flutter/engine#42684)
      2023-06-08 godofredoc@google.com Prevent double upload of benchmarks. (flutter/engine#42683)
      2023-06-08 skia-flutter-autoroll@skia.org Roll ANGLE from 5215293366f0 to 76b0e7f38b44 (2 revisions) (flutter/engine#42680)
      2023-06-08 godofredoc@google.com Remove all the uses of master branch in the .ci.yaml file. (flutter/engine#42679)
      2023-06-08 godofredoc@google.com Replace benchmarks with its v2 version. (flutter/engine#42677)
      2023-06-08 bdero@google.com [Impeller] Reorder blend filter checks to avoid unnecessary destination snapshot (flutter/engine#42678)
      2023-06-08 bdero@google.com [Impeller] Specify blend mode on blend filter commands (flutter/engine#42676)
      2023-06-08 skia-flutter-autoroll@skia.org Roll ANGLE from c49674d1565c to 5215293366f0 (1 revision) (flutter/engine#42673)
      2023-06-08 rmolivares@renzo-olivares.dev [Linux] composing delta fixes (flutter/engine#42648)
      2023-06-08 jinhe.zjh@alibaba-inc.com Fix: invalid time-point comparison between each from different clock source (flutter/engine#42409)
      2023-06-08 zanderso@users.noreply.github.com Fix license hash (flutter/engine#42675)
      2023-06-08 zanderso@users.noreply.github.com Revert Dart to 3.1.0-184.0.dev (flutter/engine#42671)
      2023-06-08 skia-flutter-autoroll@skia.org Roll ANGLE from b5d261ac5c5b to c49674d1565c (2 revisions) (flutter/engine#42670)
      2023-06-08 skia-flutter-autoroll@skia.org Roll Dart SDK from b7fe6e0c274c to 3a9145a57432 (1 revision) (flutter/engine#42668)
      2023-06-08 jonahwilliams@google.com [Impeller] sort all vertex inputs by location. (flutter/engine#42664)
      2023-06-08 skia-flutter-autoroll@skia.org Roll ANGLE from 05e087658b10 to b5d261ac5c5b (1 revision) (flutter/engine#42662)
      2023-06-08 zanderso@users.noreply.github.com Revert "[Impeller] Added a switch to turn on vulkan" (flutter/engine#42660)
      2023-06-08 skia-flutter-autoroll@skia.org Roll ANGLE from 15a29438b099 to 05e087658b10 (6 revisions) (flutter/engine#42659)
      2023-06-08 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from aMTaMP0DdKdJnxSbc... to lPCv1NshK-tvjtLgC... (flutter/engine#42658)
      2023-06-08 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from DL1QQ5eZRVNARqLx-... to ukXXOXtI7uRIukzF5... (flutter/engine#42655)
      2023-06-08 skia-flutter-autoroll@skia.org Roll Dart SDK from f0ae96d202ca to b7fe6e0c274c (1 revision) (flutter/engine#42657)
      2023-06-08 skia-flutter-autoroll@skia.org Roll Dart SDK from 9e633e463902 to f0ae96d202ca (1 revision) (flutter/engine#42651)
      2023-06-08 godofredoc@google.com Benchmarks configurations for engine v2. (flutter/engine#42622)
      2023-06-08 skia-flutter-autoroll@skia.org Roll Skia from 1a3adf848e61 to 8fdbbca7d35d (1 revision) (flutter/engine#42645)
      2023-06-08 skia-flutter-autoroll@skia.org Roll Dart SDK from bbce07ad3944 to 9e633e463902 (3 revisions) (flutter/engine#42646)
      2023-06-07 aam@google.com Roll dart to 3.1.0-180.0.dev (flutter/engine#42638)
      2023-06-07 skia-flutter-autoroll@skia.org Roll Skia from 156542f8bf13 to 1a3adf848e61 (1 revision) (flutter/engine#42644)
      
      Also rolling transitive DEPS:
        fuchsia/sdk/core/linux-amd64 from aMTaMP0DdKdJ to lPCv1NshK-tv
        fuchsia/sdk/core/mac-amd64 from DL1QQ5eZRVNA to ukXXOXtI7uRI
      
      If this roll has caused a breakage, revert this CL and stop the roller
      using the controls here:
      https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
      Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
      is aware of the problem.
      
      To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
      
      ...
      80b9ac2c
    • Chris Yang's avatar
      Revert "test owners: cyanglaz -> vashworth" (#128462) · e25eabd2
      Chris Yang authored
      Reverts flutter/flutter#127391
      
      I'm back from OOO so change the test owners back.
      e25eabd2
    • Camille Simon's avatar
      [Android] Bump integration tests using `compileSdkVersion` 31 to 33 (#128072) · 0a696980
      Camille Simon authored
      Bumps integration tests (that are not run manually only) using `compileSdkVersion` 31 to 33.
      0a696980
    • Tong Mu's avatar
      Remove single view assumption from MouseTracker, and unify its hit testing code flow (#127060) · ab3c5bfc
      Tong Mu authored
      This is a refactor to make `MouseTracker` use the same callback for both kinds of device update. Instead of using two different callbacks for the two device updating methods, `MouseTracker` now receives a hit testing callback at construction, which is the same hit testing method as the one used for other gestures.
      
      This PR not only makes the code cleaner, but also removes the single view assumption from `MouseTracker`, whose code no longer refers to `RendererBinding.renderView`. In the future, we only need to modify `hitTest` (which we will have to do to support gestures for multi-view anyway) to make mouse tracker support multi-view.
      ab3c5bfc
    • Christopher Fujino's avatar
  2. 08 Jun, 2023 20 commits
  3. 07 Jun, 2023 10 commits