Commits · 0bb9409fd0a6773424a0ce28c0eba84c7332cc1c · abdullh.alsoleman / Front-End

30 Jun, 2023 9 commits

Update `Switch` tests for M2/M3 (#129810) · 0bb9409f

Qun Cheng authored Jun 30, 2023

Updated and reorganized unit tests for `Switch` to have M2 and M3 versions.

More info in https://github.com/flutter/flutter/issues/127064

0bb9409f

Roll Flutter Engine from 099a70ebbc60 to 54b573e9c4e5 (1 revision) (#129821) · 2fefe72c

engine-flutter-autoroll authored Jun 30, 2023

https://github.com/flutter/engine/compare/099a70ebbc60...54b573e9c4e5

2023-06-30 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from nboAFpQUzwtrESDVo... to iwgWLB4KaXslnaGwK... (flutter/engine#43357)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from nboAFpQUzwtr to iwgWLB4KaXsl

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

2fefe72c

Update `SwitchListTile` tests for M2/M3 (#129809) · 2e4122cc

Qun Cheng authored Jun 30, 2023

Updated and reorganized unit tests for `SwitchListTile` to have M2 and M3 versions.

More info in https://github.com/flutter/flutter/issues/127064

2e4122cc

Fix `NavigationDrawer` selected item has wrong icon color (#129625) · 7cef9661

Taha Tesser authored Jun 30, 2023

fixes [NavigationDrawer selected item has wrong icon color [Material3 spec]](https://github.com/flutter/flutter/issues/129572)

### Description
This PR fixes a mistake in the `NavigationDrawer` defaults, where generated token value returns a `null`. 
This issue can be detected when you want to customize the selected icon color for `NavigationDrawerDestination` using a custom color scheme.

### Code sample

<details> 
<summary>expanded to view the code sample</summary> 

```dart
import 'package:flutter/material.dart';

void main() => runApp(const MyApp());

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      debugShowCheckedModeBanner: false,
      themeMode: ThemeMode.light,
      theme: ThemeData(
        colorScheme: ColorScheme.fromSeed(seedColor: Colors.blue).copyWith(
          onSecondaryContainer: Colors.red,
        ),
        useMaterial3: true,
      ),
      home: const Example(),
    );
  }
}

class Example extends StatelessWidget {
  const Example({super.key});

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: const Text('NavigationDrawer Sample'),
      ),
      drawer: const NavigationDrawer(
        children: <Widget>[
          NavigationDrawerDestination(
            icon: Icon(Icons.favorite_outline_rounded),
            label: Text('Favorite'),
            selectedIcon: Icon(Icons.favorite_rounded),
          ),
          NavigationDrawerDestination(
            icon: Icon(Icons.favorite_outline_rounded),
            label: Text('Favorite'),
          ),
        ],
      ),
    );
  }
}
``` 
	
</details>

### Before
 
<img width="1053" alt="Screenshot 2023-06-27 at 13 24 38" src="https://github.com/flutter/flutter/assets/48603081/18c13a73-688f-4586-bb60-bddef45d173f">

### After

<img width="1053" alt="Screenshot 2023-06-27 at 13 24 25" src="https://github.com/flutter/flutter/assets/48603081/8a1427c6-517f-424a-b0bd-24bad7c5fbb0">

7cef9661

Update basic_test.dart for M3 compliance (#129714) · 3a6d6615

Bruno Leroux authored Jun 30, 2023

## Description

This PR fixes two test failures in `basic_test.dart` which surfaced when switching to M3 (see https://github.com/flutter/flutter/pull/127501)

Those failures are related to M3 typography which sets line height to 1.43.

Forcing line height to 1.0 seems reasonable for these particular tests. With this change these two test are successful for both M2 and M3.

## Related Issue

fixes https://github.com/flutter/flutter/issues/129713

## Tests

Updates 2 tests.

3a6d6615

Roll Flutter Engine from d33343430f18 to 099a70ebbc60 (7 revisions) (#129818) · 7b859562

engine-flutter-autoroll authored Jun 30, 2023

https://github.com/flutter/engine/compare/d33343430f18...099a70ebbc60

2023-06-30 ditman@gmail.com [web] Add nonce configuration. (flutter/engine#42829)
2023-06-30 bdero@google.com [Impeller] Unwrap optional procs in EntityPass (flutter/engine#43352)
2023-06-30 bdero@google.com [Impeller] Assign missing user to TODO. (flutter/engine#43351)
2023-06-29 skia-flutter-autoroll@skia.org Roll Skia from a1ae27969207 to 2d05e3ec6b67 (1 revision) (flutter/engine#43350)
2023-06-29 skia-flutter-autoroll@skia.org Roll Dart SDK from ecc2440be198 to 2d98d9e27dae (1 revision) (flutter/engine#43347)
2023-06-29 jonahwilliams@google.com [Impeller] Check for lazy memory support. (flutter/engine#43339)
2023-06-29 bdero@google.com [Impeller] Remove all double empties (flutter/engine#43345)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

7b859562

Roll Flutter Engine from 68cc1a7971d5 to d33343430f18 (2 revisions) (#129801) · d605e874

engine-flutter-autoroll authored Jun 30, 2023

https://github.com/flutter/engine/compare/68cc1a7971d5...d33343430f18

2023-06-29 skia-flutter-autoroll@skia.org Roll Skia from c83f8ba23a80 to
a1ae27969207 (8 revisions) (flutter/engine#43343)
2023-06-29 tamird@google.com Remove unused constants
(flutter/engine#43344)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the
revert to ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

d605e874

Revert no-response to fork. (#129775) · 732429e3

godofredoc authored Jun 30, 2023

The core action is not scaling well for the # of Prs and bugs of the flutter project.

Bug: https://github.com/flutter/flutter/issues/129771

732429e3

Make `DropdownMenu` be able to scroll to the highlighted item when searching. (#129740) · 91cb2618

Qun Cheng authored Jun 30, 2023

Fixes #120349

This PR enables `DropdownMenu` to automatically scroll to the first matching item when `enableSearch` is true.

<details><summary>video example</summary>

https://github.com/flutter/flutter/assets/36861262/1a7a956c-c186-44ca-9a52-d94dc21cac8a

</details>

91cb2618

29 Jun, 2023 16 commits

Roll Flutter Engine from cd9ce66db14a to 68cc1a7971d5 (10 revisions) (#129799) · a2dc0ed8

engine-flutter-autoroll authored Jun 29, 2023

https://github.com/flutter/engine/compare/cd9ce66db14a...68cc1a7971d5

2023-06-29 skia-flutter-autoroll@skia.org Roll Skia from a4d0373cd414 to c83f8ba23a80 (3 revisions) (flutter/engine#43340)
2023-06-29 mdebbar@google.com [web] Move web-only initialization APIs to `dart:ui_web` (flutter/engine#43111)
2023-06-29 skia-flutter-autoroll@skia.org Roll Skia from 8ada2c4b2947 to a4d0373cd414 (14 revisions) (flutter/engine#43338)
2023-06-29 skia-flutter-autoroll@skia.org Roll Dart SDK from 656201921b30 to ecc2440be198 (1 revision) (flutter/engine#43333)
2023-06-29 skia-flutter-autoroll@skia.org Roll Skia from 0c320b3d5b64 to 8ada2c4b2947 (1 revision) (flutter/engine#43332)
2023-06-29 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from fxCNy4QivAngZXkvM... to nboAFpQUzwtrESDVo... (flutter/engine#43334)
2023-06-29 kustermann@google.com Prepare for utf8.encode() to return more precise Uint8List type (flutter/engine#43335)
2023-06-29 jason-simmons@users.noreply.github.com [Impeller] Ensure that the auto-release pool is available when the GoldenPlaygroundTestImpl is destructed (flutter/engine#43322)
2023-06-29 uysalere@gmail.com [fuchsia] Remove strict equality check for SkMatrix comparison for Flâ¦ (flutter/engine#43309)
2023-06-29 jason-simmons@users.noreply.github.com [Impeller] Add an autorelease pool to the GoldenTests fixture (flutter/engine#43323)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from fxCNy4QivAng to nboAFpQUzwtr

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

a2dc0ed8

Bump actions/labeler from 4.1.0 to 4.2.0 (#129797) · 15513f2c

dependabot[bot] authored Jun 29, 2023

Bumps [actions/labeler](https://github.com/actions/labeler) from 4.1.0 to 4.2.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/actions/labeler/releases">actions/labeler's releases</a>.</em></p>
<blockquote>
<h2>v4.2.0</h2>
<h2>What's Changed</h2>
<p>In the scope of this release, the following outputs were added by <a href="https://github.com/danielsht86"><code>@âdanielsht86</code></a> in <a href="https://redirect.github.com/actions/labeler/issues/60">#60</a>:</p>
<ul>
<li><code>new-labels</code> - a comma-separated string that contains all newly added labels.</li>
<li><code>all-labels</code> - a comma-separated string that contains all labels currently assigned to the PR.</li>
</ul>
<p>For detailed information, please refer to our <a href="https://github.com/actions/labeler/tree/0967ca812e7fdc8f5f71402a1b486d5bd061fe20#outputs">updated documentation</a>.</p>
<p>The issue of encountering an <code>HttpError: Server Error</code> when adding more than 50 labels has been successfully resolved by <a href="https://github.com/markmssd"><code>@âmarkmssd</code></a> in <a href="https://redirect.github.com/actions/labeler/issues/497">#497</a>. However, it's important to note that the GitHub API imposes a limit of 100 labels. To ensure smooth operation, a warning message that will alert you if the number of labels exceeds this limit was implemented. From this point forward, if more than 100 labels are specified, only the first 100 will be assigned.</p>
<p>The error handling for the <code>Resource not accessible by integration</code> error was added by <a href="https://github.com/jsoref"><code>@âjsoref</code></a> in <a href="https://redirect.github.com/actions/labeler/issues/405">#405</a>. Now, if the workflow is misconfigured, the labeler provides a clear warning and guidance for correction.</p>
<p>This release also includes the following changes:</p>
<ul>
<li>Warn about the limitations of GitHub tokens by <a href="https://github.com/dfandrich"><code>@âdfandrich</code></a> in <a href="https://redirect.github.com/actions/labeler/pull/491">actions/labeler#491</a></li>
<li>Improve readme by <a href="https://github.com/jsoref"><code>@âjsoref</code></a> in <a href="https://redirect.github.com/actions/labeler/pull/589">actions/labeler#589</a></li>
<li>Bump eslint-plugin-jest from 27.2.1 to 27.2.2 by <a href="https://github.com/dependabot"><code>@âdependabot</code></a> in <a href="https://redirect.github.com/actions/labeler/pull/591">actions/labeler#591</a></li>
<li>Bump eslint from 8.42.0 to 8.43.0 by <a href="https://github.com/dependabot"><code>@âdependabot</code></a> in <a href="https://redirect.github.com/actions/labeler/pull/592">actions/labeler#592</a></li>
<li>Bump <code>@âtypescript-eslint/eslint-plugin</code> from 5.60.0 to 5.60.1 by <a href="https://github.com/dependabot"><code>@âdependabot</code></a> in <a href="https://redirect.github.com/actions/labeler/pull/598">actions/labeler#598</a></li>
<li>Bump <code>@âtypescript-eslint/parser</code> from 5.60.0 to 5.60.1 by <a href="https://github.com/dependabot"><code>@âdependabot</code></a> in <a href="https://redirect.github.com/actions/labeler/pull/597">actions/labeler#597</a></li>
<li>Bump <code>@âoctokit/plugin-retry</code> from 5.0.2 to 5.0.4 by <a href="https://github.com/MaksimZhukov"><code>@âMaksimZhukov</code></a> in <a href="https://redirect.github.com/actions/labeler/pull/599">actions/labeler#599</a></li>
</ul>
<h2>New Contributors</h2>
<ul>
<li><a href="https://github.com/dfandrich"><code>@âdfandrich</code></a> made their first contribution in <a href="https://redirect.github.com/actions/labeler/pull/491">actions/labeler#491</a></li>
<li><a href="https://github.com/markmssd"><code>@âmarkmssd</code></a> made their first contribution in <a href="https://redirect.github.com/actions/labeler/pull/497">actions/labeler#497</a></li>
<li><a href="https://github.com/danielsht86"><code>@âdanielsht86</code></a> made their first contribution in <a href="https://redirect.github.com/actions/labeler/pull/60">actions/labeler#60</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/actions/labeler/compare/v4...v4.2.0">https://github.com/actions/labeler/compare/v4...v4.2.0</a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/actions/labeler/commit/0967ca812e7fdc8f5f71402a1b486d5bd061fe20"><code>0967ca8</code></a> Added output (<a href="https://redirect.github.com/actions/labeler/issues/60">#60</a>)</li>
<li><a href="https://github.com/actions/labeler/commit/375538a703ac861e63020440563422fc04246dfb"><code>375538a</code></a> Bump <code>@âoctokit/plugin-retry</code> from 5.0.2 to 5.0.4 (<a href="https://redirect.github.com/actions/labeler/issues/599">#599</a>)</li>
<li><a href="https://github.com/actions/labeler/commit/8d17e8ac4c7d8434ccc0ad5c3fdfe2f56f2b2ab3"><code>8d17e8a</code></a> Bump <code>@âtypescript-eslint/parser</code> from 5.60.0 to 5.60.1 (<a href="https://redirect.github.com/actions/labeler/issues/597">#597</a>)</li>
<li><a href="https://github.com/actions/labeler/commit/9d45a7438fdc8606099442185bbcf343459eb96f"><code>9d45a74</code></a> Bump <code>@âtypescript-eslint/eslint-plugin</code> from 5.60.0 to 5.60.1 (<a href="https://redirect.github.com/actions/labeler/issues/598">#598</a>)</li>
<li><a href="https://github.com/actions/labeler/commit/130636aba50d83a269b855d2501e05254de1eb5f"><code>130636a</code></a> Bump eslint from 8.42.0 to 8.43.0 (<a href="https://redirect.github.com/actions/labeler/issues/592">#592</a>)</li>
<li><a href="https://github.com/actions/labeler/commit/54aeabf7b5842651b41d9cd2ad20e0caa73563f2"><code>54aeabf</code></a> Bump <code>@âtypescript-eslint/parser</code> from 5.59.11 to 5.60.0 (<a href="https://redirect.github.com/actions/labeler/issues/593">#593</a>)</li>
<li><a href="https://github.com/actions/labeler/commit/899595ff0140593e7e4bfd1d60fb2a54fc949d2c"><code>899595f</code></a> Bump eslint-plugin-jest from 27.2.1 to 27.2.2 (<a href="https://redirect.github.com/actions/labeler/issues/591">#591</a>)</li>
<li><a href="https://github.com/actions/labeler/commit/8056174ee026aec2d0d5596b25946162cd4b1c58"><code>8056174</code></a> Bump <code>@âtypescript-eslint/eslint-plugin</code> from 5.59.11 to 5.60.0 (<a href="https://redirect.github.com/actions/labeler/issues/594">#594</a>)</li>
<li><a href="https://github.com/actions/labeler/commit/7a202e642846429da2c5219d2c934cbbf46a5d94"><code>7a202e6</code></a> fix: Limit number of labels added to 100 (<a href="https://redirect.github.com/actions/labeler/issues/497">#497</a>)</li>
<li><a href="https://github.com/actions/labeler/commit/b5ff161cf08995cdc0c16c4d30f62b6471eb2db2"><code>b5ff161</code></a> Explain misconfigured workflow (<a href="https://redirect.github.com/actions/labeler/issues/405">#405</a>)</li>
<li>Additional commits viewable in <a href="https://github.com/actions/labeler/compare/9fcb2c2f5584144ca754f8bfe8c6f81e77753375...0967ca812e7fdc8f5f71402a1b486d5bd061fe20">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=actions/labeler&package-manager=github_actions&previous-version=4.1.0&new-version=4.2.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

15513f2c

Roll Flutter Engine from eabb22900b44 to cd9ce66db14a (1 revision) (#129756) · afcf6742

engine-flutter-autoroll authored Jun 29, 2023

https://github.com/flutter/engine/compare/eabb22900b44...cd9ce66db14a

2023-06-29 skia-flutter-autoroll@skia.org Roll Skia from 2b30565d0173 to 0c320b3d5b64 (2 revisions) (flutter/engine#43331)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

afcf6742

Remove `@NonNull` to avoid warning (#129472) · 92969ba8

fzyzcjy authored Jun 29, 2023

Otherwise android studio complains:

> Do not use @NonNull in Kotlin; the nullability is already implied by the Kotlin type MethodCall not ending with ?

![image](https://github.com/flutter/flutter/assets/5236035/0cc2e838-dbf9-409f-8fd8-d4e006f58be6)

92969ba8

Remove use of any (#129793) · bda64b54

Ricardo Amador authored Jun 29, 2023

Remove use of any. This reverts to a previous change. Without any and the newest version this put us back to before the version change.

Restores to this change: https://github.com/flutter/flutter/commit/2be476d4015db8f6c442eefa3e9a897975407d4c
Apparently any is the cause.

I will make a separate issue to track updating of the labeler documentation.

*List which issues are fixed by this PR. You must list at least one issue.*

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*

bda64b54

Prepare for utf8.encode() to return more precise Uint8List type (#129769) · 7068a208

Martin Kustermann authored Jun 29, 2023

To avoid analyzer warnings when utf8.encode() will return the more
precise Uint8List type, we use const Utf8Encoder().convert() which
already returns Uint8List

See https://github.com/dart-lang/sdk/issues/52801

7068a208

Deletes files that should be ignored (#127984) · 7cab354d

lsaudon authored Jun 29, 2023

Some files are supposed to ignore, but don't.

- **/windows/flutter/generated_plugins.cmake
- **/linux/flutter/generated_plugin_registrant.cc
- **/linux/flutter/generated_plugin_registrant.h
- **/linux/flutter/generated_plugins.cmake
- **/windows/flutter/generated_plugin_registrant.cc
- **/windows/flutter/generated_plugin_registrant.h
- **/ios/Runner/GeneratedPluginRegistrant.h
- **/ios/Runner/GeneratedPluginRegistrant.m

*List which issues are fixed by this PR. You must list at least one issue.*

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*

7cab354d

Fix flutter_plugins by rolling revision (#129781) · 8b54878d

Christopher Fujino authored Jun 29, 2023

Fixes https://github.com/flutter/flutter/issues/129782

Linux flutter_plugins is currently broken
https://ci.chromium.org/p/flutter/builders/prod/Linux%20flutter_plugins/12884

On an analysis error that was ignored upstream in
https://github.com/flutter/packages/commit/5d6e48c3e099fa6c24f45b778f5b7cab82a7e1e8

8b54878d

Add locale-specific DateTime formatting syntax (#129573) · ff838bca

Tae Hyung Kim authored Jun 29, 2023

Based on the [message format
syntax](https://unicode-org.github.io/icu/userguide/format_parse/messages/#examples)
for
[ICU4J](https://unicode-org.github.io/icu-docs/apidoc/released/icu4j/com/ibm/icu/text/MessageFormat.html).
This adds new syntax to the current Flutter messageFormat parser which
should allow developers to add locale-specific date formatting.

## Usage example
```
  "datetimeTest": "Today is {today, date, ::yMd}",
  "@datetimeTest": {
    "placeholders": {
      "today": {
        "description": "The date placeholder",
        "type": "DateTime"
      }
    }
  }
```
compiles to
```
  String datetimeTest(DateTime today) {
    String _temp0 = intl.DateFormat.yMd(localeName).format(today);
    return 'Today is $_temp0';
  }
```

Fixes https://github.com/flutter/flutter/issues/127304.

ff838bca

Update `RadioListTile` tests to M3 (#129718) · f3a7485b

Taha Tesser authored Jun 29, 2023

This updates the `RadioListTile` test which was modified in https://github.com/flutter/flutter/pull/128839

### Description
- Update the layout to the proper order `MaterialApp` -> `Material` -> `RadioListTile`
- Add M3 overlay test. (fixed problem faced in https://github.com/flutter/flutter/pull/128839)
- Separate the M2  overlay test.

f3a7485b

Roll Flutter Engine from 7fd0e9522ea1 to eabb22900b44 (1 revision) (#129754) · cd97b439

engine-flutter-autoroll authored Jun 29, 2023

https://github.com/flutter/engine/compare/7fd0e9522ea1...eabb22900b44

2023-06-29 skia-flutter-autoroll@skia.org Roll Skia from 21feae4f3d8b to 2b30565d0173 (1 revision) (flutter/engine#43330)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

cd97b439

Roll Flutter Engine from d5c25ead07e9 to 7fd0e9522ea1 (2 revisions) (#129752) · 5951f9d9

engine-flutter-autoroll authored Jun 29, 2023

https://github.com/flutter/engine/compare/d5c25ead07e9...7fd0e9522ea1

2023-06-29 skia-flutter-autoroll@skia.org Roll Skia from 26fa4b343fd3 to 21feae4f3d8b (17 revisions) (flutter/engine#43329)
2023-06-29 skia-flutter-autoroll@skia.org Roll Dart SDK from a7151d73b88d to 656201921b30 (1 revision) (flutter/engine#43328)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

5951f9d9

Fix typos in ListTile examples. (#129606) · 87194a23

Jia Tan authored Jun 29, 2023

Fix typos.

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*

87194a23

Roll Flutter Engine from 4e49b9deb72d to d5c25ead07e9 (7 revisions) (#129750) · 328d4d48

engine-flutter-autoroll authored Jun 29, 2023

https://github.com/flutter/engine/compare/4e49b9deb72d...d5c25ead07e9

2023-06-29 jason-simmons@users.noreply.github.com [Impeller] Add a
missing method to the Context mock (flutter/engine#43326)
2023-06-29 30870216+gaaclarke@users.noreply.github.com [Impeller]
Collapse DrawRects into clear colors optimization (flutter/engine#43168)
2023-06-29 chinmaygarde@google.com [Impeller] Add trace events to Vulkan
texture and buffer lifecycle events. (flutter/engine#43321)
2023-06-29 skia-flutter-autoroll@skia.org Roll Dart SDK from
5a59cd06e49d to a7151d73b88d (2 revisions) (flutter/engine#43318)
2023-06-28 bdero@google.com [Impeller] Fix advanced CPU blend modes
(flutter/engine#43294)
2023-06-28 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from
10hNrVMjnCypybnz2... to fxCNy4QivAngZXkvM... (flutter/engine#43314)
2023-06-28 skia-flutter-autoroll@skia.org Roll Skia from 0b4f472a8c44 to
26fa4b343fd3 (2 revisions) (flutter/engine#43306)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from 10hNrVMjnCyp to fxCNy4QivAng

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the
revert to ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

328d4d48

Roll Flutter Engine from 241ca5c1d6be to 4e49b9deb72d (1 revision) (#129730) · 7b47ba1e

engine-flutter-autoroll authored Jun 29, 2023

https://github.com/flutter/engine/compare/241ca5c1d6be...4e49b9deb72d

2023-06-28 jonahwilliams@google.com [Impeller] remove redundant highp
modifiers in vertex shaders. (flutter/engine#43305)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the
revert to ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

7b47ba1e

Skwasm benchmarks. (#129681) · 1b887c72

Jackson Gardner authored Jun 29, 2023

This enables benchmarks for the Skwasm renderer, compiled with
dart2wasm.

Platform views aren't supported in Skwasm yet, so we are skipping those
benchmarks for now.

1b887c72

28 Jun, 2023 15 commits

RTL InputDecoration fix (#129661) · c7511664

Justin McCandless authored Jun 28, 2023

Fixes InputDecoration (TextField) layout when 1. RTL 2. prefixIcon and 3. left/right contentPadding is asymmetric.

c7511664

mark autoroller flaky (#129745) · c1b764a8
Christopher Fujino authored Jun 28, 2023
```
Unblock tree while I investigate: https://github.com/flutter/flutter/issues/129744
```
c1b764a8
Roll pub packages (#129380) · ba636881
Flutter GitHub Bot authored Jun 28, 2023
```
This PR was generated by `flutter update-packages --force-upgrade`.
```
ba636881
Removes deprecated APIs from AnimationBuilder (#129657) · af09b57e
pdblasi-google authored Jun 28, 2023
```
Removes deprecated APIs from AnimationBuilder.

Resolves #129653
```
af09b57e

Roll Flutter Engine from e8a1c23d66ba to 241ca5c1d6be (1 revision) (#129725) · 51bef1b6

engine-flutter-autoroll authored Jun 28, 2023

https://github.com/flutter/engine/compare/e8a1c23d66ba...241ca5c1d6be

2023-06-28 skia-flutter-autoroll@skia.org Roll Skia from 5209dc7702d0 to 0b4f472a8c44 (58 revisions) (flutter/engine#43304)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

51bef1b6

Update analysis, linter, and repo links in analysis options (#129686) · c65e9084
Parker Lougheed authored Jun 28, 2023
```
Contributes to https://github.com/dart-lang/linter/issues/4460 and https://github.com/dart-lang/site-www/issues/4499
```
c65e9084

Roll Flutter Engine from be1073aa352f to e8a1c23d66ba (1 revision) (#129723) · 73bb959a

engine-flutter-autoroll authored Jun 28, 2023

https://github.com/flutter/engine/compare/be1073aa352f...e8a1c23d66ba

2023-06-28 skia-flutter-autoroll@skia.org Roll Dart SDK from e164fdc1a3ad to 5a59cd06e49d (1 revision) (flutter/engine#43302)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

73bb959a

Dev, examples/api, etc updated for Material 3 by default (#129683) · 0d4b5ae1

Hans Muller authored Jun 28, 2023

Updated tests in dev, examples/api, and tests/widgets to ensure that
they continue to pass when the default for `ThemeData.useMaterial3` is
changed to true.

This is the final set of changes required for
https://github.com/flutter/flutter/issues/127064.

0d4b5ae1

Add `DatePickerTheme.inputDecorationTheme` for the DatePicker with input mode. (#128950) · 32fe4d7f
Taha Tesser authored Jun 28, 2023

32fe4d7f
[framework] ensure flexible space bar fades when scrolling. (#129527) · 9c963572
Jonah Williams authored Jun 28, 2023
```
This was missing the actual opacity rendering, oops
```
9c963572

Add InputDecorator.error to allow error message customization (#129275) · 8d837062

Bruno Leroux authored Jun 28, 2023

## Description

This PR is a fork of https://github.com/flutter/flutter/pull/118610 with some changes (mainly applying @justinmc comments).

~~This can be used by KishanBusa8 to update https://github.com/flutter/flutter/pull/118610 or can become a non WIP PR if KishanBusa8 does not respond or can not work on the update.~~

## Related Issue

fixes https://github.com/flutter/flutter/issues/11068

## Tests

Adds 3 tests.

8d837062

Roll Flutter Engine from b388e852be44 to be1073aa352f (1 revision) (#129712) · b6b417c2

engine-flutter-autoroll authored Jun 28, 2023

https://github.com/flutter/engine/compare/b388e852be44...be1073aa352f

2023-06-28 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from sBFKkha8HNLZpTNwv... to cytps4RRhs8-wbcVJ... (flutter/engine#43300)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from sBFKkha8HNLZ to cytps4RRhs8-

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

b6b417c2

Roll Flutter Engine from 17173994a8c2 to b388e852be44 (1 revision) (#129708) · 70b9dd70

engine-flutter-autoroll authored Jun 28, 2023

https://github.com/flutter/engine/compare/17173994a8c2...b388e852be44

2023-06-28 skia-flutter-autoroll@skia.org Roll Dart SDK from 3233ec5b6862 to e164fdc1a3ad (1 revision) (flutter/engine#43299)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

70b9dd70

[flutter roll] Revert "Fix `AnimatedList` & `AnimatedGrid` doesn't apply... · f3b0b172

Xilai Zhang authored Jun 28, 2023

[flutter roll] Revert "Fix `AnimatedList` & `AnimatedGrid` doesn't apply `MediaQuery` padding" (#129645)

Reverts flutter/flutter#129556.

Context: b/288993600

quoting, "the failure (in internal tests) appears to be due to a
workaround for the issue fixed by this pr".

f3b0b172

Roll Flutter Engine from 2f4fc4872699 to 17173994a8c2 (1 revision) (#129694) · 43bda355

engine-flutter-autoroll authored Jun 28, 2023

https://github.com/flutter/engine/compare/2f4fc4872699...17173994a8c2

2023-06-28 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from Bvv7TyHm_VHUkndFx... to 10hNrVMjnCypybnz2... (flutter/engine#43297)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from Bvv7TyHm_VHU to 10hNrVMjnCyp

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

43bda355