Commits · 05259ca938c9ea27aa551048b690d5a06371a6c0 · abdullh.alsoleman / Front-End

28 Aug, 2023 12 commits

Roll Flutter Engine from 9ab2603db24f to 91522a188bda (2 revisions) (#133462) · 05259ca9

engine-flutter-autoroll authored Aug 28, 2023

https://github.com/flutter/engine/compare/9ab2603db24f...91522a188bda

2023-08-28 skia-flutter-autoroll@skia.org Roll Skia from fe4f018ef935 to df783b542165 (1 revision) (flutter/engine#45171)
2023-08-28 skia-flutter-autoroll@skia.org Roll Skia from 0d39172f35d2 to fe4f018ef935 (1 revision) (flutter/engine#45169)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

05259ca9

FocusNode and FocusManager should dispatch creation in constructor. (#133352) · 703d60b5
Polina Cherkasova authored Aug 28, 2023

703d60b5
ShortcutManager should dispatch creation in constructor. (#133356) · cf91262f
Polina Cherkasova authored Aug 28, 2023

cf91262f
Fix stuck predictive back platform channel calls (#133368) · dfd4147c
Justin McCandless authored Aug 28, 2023
```
Fix a Google test flakiness increase.
```
dfd4147c

added option to change color of heading row(flutter#132428) (#132728) · 69f61a28

Salmanul Farisi.M authored Aug 28, 2023

Paginated datatable widget cannot give color to table header
 
fixes #132428

---------
Co-authored-by: Hans Muller <hansmuller@google.com>

69f61a28

PlatformRouteInformationProvider should dispatch creation in constructor. (#133353) · 2ea52966
Polina Cherkasova authored Aug 28, 2023

2ea52966

Roll Flutter Engine from 4924cf453398 to 9ab2603db24f (1 revision) (#133449) · 0027d18e

engine-flutter-autoroll authored Aug 28, 2023

https://github.com/flutter/engine/compare/4924cf453398...9ab2603db24f

2023-08-28 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from xRUHI4zSil6TevQTa... to u44zzvYd85WSDMpS3... (flutter/engine#45168)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from xRUHI4zSil6T to u44zzvYd85WS

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

0027d18e

Roll Flutter Engine from d89824ab018f to 4924cf453398 (1 revision) (#133447) · 83092161

engine-flutter-autoroll authored Aug 28, 2023

https://github.com/flutter/engine/compare/d89824ab018f...4924cf453398

2023-08-28 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from jnDJLdEAx34diOWFx... to AQZddYgKiWrQL8vny... (flutter/engine#45167)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from jnDJLdEAx34d to AQZddYgKiWrQ

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

83092161

Roll Flutter Engine from b26e2da130ab to d89824ab018f (2 revisions) (#133444) · 7c130039

engine-flutter-autoroll authored Aug 28, 2023

https://github.com/flutter/engine/compare/b26e2da130ab...d89824ab018f

2023-08-28 skia-flutter-autoroll@skia.org Roll Skia from 1ce3c2af0971 to 0d39172f35d2 (1 revision) (flutter/engine#45164)
2023-08-28 skia-flutter-autoroll@skia.org Manual roll Dart SDK from ab417bc74bb1 to 5d3ab5db5037 (17 revisions) (flutter/engine#45165)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

7c130039

Roll Flutter Engine from 78c26aeff3ee to b26e2da130ab (2 revisions) (#133432) · 9218f93f

engine-flutter-autoroll authored Aug 28, 2023

https://github.com/flutter/engine/compare/78c26aeff3ee...b26e2da130ab

2023-08-28 skia-flutter-autoroll@skia.org Roll Skia from 2582a06b4618 to 1ce3c2af0971 (2 revisions) (flutter/engine#45163)
2023-08-28 skia-flutter-autoroll@skia.org Roll Skia from 405c2ecb7f2a to 2582a06b4618 (1 revision) (flutter/engine#45162)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

9218f93f

Roll Flutter Engine from f8a171aa173f to 78c26aeff3ee (1 revision) (#133428) · 2e075d00

engine-flutter-autoroll authored Aug 28, 2023

https://github.com/flutter/engine/compare/f8a171aa173f...78c26aeff3ee

2023-08-28 skia-flutter-autoroll@skia.org Roll Skia from 0f9e50daa879 to 405c2ecb7f2a (1 revision) (flutter/engine#45161)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

2e075d00

Roll Flutter Engine from 0593c0455fd6 to f8a171aa173f (1 revision) (#133425) · 2660fdcf

engine-flutter-autoroll authored Aug 28, 2023

https://github.com/flutter/engine/compare/0593c0455fd6...f8a171aa173f

2023-08-27 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from 8nJB1-rSpC5L4digu... to xRUHI4zSil6TevQTa... (flutter/engine#45160)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from 8nJB1-rSpC5L to xRUHI4zSil6T

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

2660fdcf

27 Aug, 2023 4 commits

Roll Flutter Engine from fc592728a7d0 to 0593c0455fd6 (4 revisions) (#133419) · 6d22a11b

engine-flutter-autoroll authored Aug 27, 2023

https://github.com/flutter/engine/compare/fc592728a7d0...0593c0455fd6

2023-08-27 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from N-A8agqDgvTKiT2Wc... to jnDJLdEAx34diOWFx... (flutter/engine#45159)
2023-08-27 jonahwilliams@google.com [Impeller] SuboptimalKHR is not an exit condition. (flutter/engine#45157)
2023-08-27 matanlurey@users.noreply.github.com Use YAML >- to avoid strange formatting. (flutter/engine#45158)
2023-08-27 matanlurey@users.noreply.github.com [Impeller] Implement TextDecoration (i.e. dashed lines) (flutter/engine#45041)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from N-A8agqDgvTK to jnDJLdEAx34d

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

6d22a11b

Roll Flutter Engine from b4e2758d6d43 to fc592728a7d0 (1 revision) (#133410) · 3f5583c8

engine-flutter-autoroll authored Aug 27, 2023

https://github.com/flutter/engine/compare/b4e2758d6d43...fc592728a7d0

2023-08-27 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from jZgLG9jWLutILTtsL... to 8nJB1-rSpC5L4digu... (flutter/engine#45156)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from jZgLG9jWLutI to 8nJB1-rSpC5L

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

3f5583c8

Roll Flutter Engine from b5f18218969b to b4e2758d6d43 (1 revision) (#133405) · cd3aeef3

engine-flutter-autoroll authored Aug 27, 2023

https://github.com/flutter/engine/compare/b5f18218969b...b4e2758d6d43

2023-08-27 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from xYHxghcipvy5XZAK6... to N-A8agqDgvTKiT2Wc... (flutter/engine#45155)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from xYHxghcipvy5 to N-A8agqDgvTK

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

cd3aeef3

Roll Flutter Engine from 683d7dc38928 to b5f18218969b (1 revision) (#133401) · f11430cd

engine-flutter-autoroll authored Aug 27, 2023

https://github.com/flutter/engine/compare/683d7dc38928...b5f18218969b

2023-08-27 matanlurey@users.noreply.github.com Use `SkTextBlob::bounds` instead of `TextFrame::getBounds()`. (flutter/engine#45148)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

f11430cd

26 Aug, 2023 5 commits

Roll Flutter Engine from 4aaf77e33de6 to 683d7dc38928 (3 revisions) (#133393) · dbf87fc8

engine-flutter-autoroll authored Aug 26, 2023

https://github.com/flutter/engine/compare/4aaf77e33de6...683d7dc38928

2023-08-26 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from Qj4BGsKtF7EJssKIK... to jZgLG9jWLutILTtsL... (flutter/engine#45153)
2023-08-26 skia-flutter-autoroll@skia.org Roll Skia from e64e8f4094b2 to 0f9e50daa879 (2 revisions) (flutter/engine#45152)
2023-08-26 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from IYiIm4zYdKPYfpOIG... to xYHxghcipvy5XZAK6... (flutter/engine#45151)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from IYiIm4zYdKPY to xYHxghcipvy5
fuchsia/sdk/core/mac-amd64 from Qj4BGsKtF7EJ to jZgLG9jWLutI

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

dbf87fc8

Roll Flutter Engine from c9b584d59219 to 4aaf77e33de6 (2 revisions) (#133389) · 26972de9

engine-flutter-autoroll authored Aug 26, 2023

https://github.com/flutter/engine/compare/c9b584d59219...4aaf77e33de6

2023-08-26 jonahwilliams@google.com Revert "[Impeller] DlAiksCanvas as a DlCanvas wrapper for impeller::Canvas" (flutter/engine#45149)
2023-08-26 dnfield@google.com [Impeller] DlAiksCanvas as a DlCanvas wrapper for impeller::Canvas (flutter/engine#45131)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

26972de9

Roll Flutter Engine from e280ed21f923 to c9b584d59219 (1 revision) (#133380) · 229b74d9

engine-flutter-autoroll authored Aug 26, 2023

https://github.com/flutter/engine/compare/e280ed21f923...c9b584d59219

2023-08-26 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from u8ovJYTk3nN78xF4X... to IYiIm4zYdKPYfpOIG... (flutter/engine#45138)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from u8ovJYTk3nN7 to IYiIm4zYdKPY

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

229b74d9

Roll Flutter Engine from 63fdf8a6701c to e280ed21f923 (3 revisions) (#133378) · 95161d86

engine-flutter-autoroll authored Aug 26, 2023

https://github.com/flutter/engine/compare/63fdf8a6701c...e280ed21f923

2023-08-26 skia-flutter-autoroll@skia.org Roll Skia from ac39b12fd835 to e64e8f4094b2 (1 revision) (flutter/engine#45136)
2023-08-26 skia-flutter-autoroll@skia.org Roll Skia from e67d9439a8c4 to ac39b12fd835 (1 revision) (flutter/engine#45133)
2023-08-25 skia-flutter-autoroll@skia.org Roll Skia from 40f4e01fca40 to e67d9439a8c4 (4 revisions) (flutter/engine#45132)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

95161d86

_SelectableFragment should dispatch creation in constructor. (#133351) · 343000b6
Polina Cherkasova authored Aug 26, 2023

343000b6

25 Aug, 2023 19 commits

Roll Flutter Engine from 53595c937df1 to 63fdf8a6701c (1 revision) (#133366) · 305c4db6

engine-flutter-autoroll authored Aug 25, 2023

https://github.com/flutter/engine/compare/53595c937df1...63fdf8a6701c

2023-08-25 bdero@google.com [Impeller] Reland debug captures and inspector. (flutter/engine#45094)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

305c4db6

Roll Flutter Engine from 1ec7b89f3a6b to 53595c937df1 (4 revisions) (#133362) · 1b40f05a

engine-flutter-autoroll authored Aug 25, 2023

https://github.com/flutter/engine/compare/1ec7b89f3a6b...53595c937df1

2023-08-25 bdero@google.com [Impeller] Fix mask blurs and the Gaussian blur coverage hint. (flutter/engine#45079)
2023-08-25 ychris@google.com ios: remove shared_application and support app extension build (flutter/engine#44732)
2023-08-25 skia-flutter-autoroll@skia.org Roll Skia from 76672468e8d7 to 40f4e01fca40 (3 revisions) (flutter/engine#45126)
2023-08-25 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from 4LHUJjNlDT21v_pdT... to Qj4BGsKtF7EJssKIK... (flutter/engine#45127)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from 4LHUJjNlDT21 to Qj4BGsKtF7EJ

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

1b40f05a

Roll Flutter Engine from 1471967afb9b to 1ec7b89f3a6b (6 revisions) (#133355) · d966f11f

engine-flutter-autoroll authored Aug 25, 2023

https://github.com/flutter/engine/compare/1471967afb9b...1ec7b89f3a6b

2023-08-25 zanderso@users.noreply.github.com Remove --enable-software-rendering from iOS scenario tests (flutter/engine#45093)
2023-08-25 skia-flutter-autoroll@skia.org Roll Skia from 56bb647a49ac to 76672468e8d7 (3 revisions) (flutter/engine#45121)
2023-08-25 yatendraroria2001@gmail.com Fix: Complete Documentation for RasterStatus::kSkipAndRetry (flutter/engine#44880)
2023-08-25 30870216+gaaclarke@users.noreply.github.com [Impeller] Updated TextureSourceVK docs and deleted unused ivars (flutter/engine#45123)
2023-08-25 zanderso@users.noreply.github.com Revert "Fix global tests doing nothing." (flutter/engine#45125)
2023-08-25 skia-flutter-autoroll@skia.org Roll Skia from ba7c5258d2b4 to 56bb647a49ac (3 revisions) (flutter/engine#45118)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

d966f11f

Fix locking to work with flutter and dart running simultaneously (#133350) · c4e1a1b3
Ian Hickson authored Aug 25, 2023

c4e1a1b3

Adds callback onWillAcceptWithDetails in DragTarget. (#131545) · 347f7bac

Chinmoy authored Aug 25, 2023

This PR adds onWillAcceptWithDetails callback to DragTarget to get information about offset.

Fixes: #131378 

This PR is subject to changes based on #131542

347f7bac

Remove deprecated onPlatformMessage from TestWindow and TestPlatformDispatcher (#133183) · 72bd3602
Kate Lovett authored Aug 25, 2023

72bd3602
Remove deprecated androidOverscrollIndicator from ScrollBehaviors (#133181) · 721016c1
Kate Lovett authored Aug 25, 2023

721016c1
Add an example showing how to use a MatrixTransition. (#132874) · 40af7db6
gmilou authored Aug 25, 2023

40af7db6

Roll Flutter Engine from 3dcd2179336d to 1471967afb9b (3 revisions) (#133342) · cd03eabd

engine-flutter-autoroll authored Aug 25, 2023

https://github.com/flutter/engine/compare/3dcd2179336d...1471967afb9b

2023-08-25 reidbaker@google.com Update gradle to 7.5.1 (flutter/engine#45113)
2023-08-25 ychris@google.com Ignore unguarded-availability for unit test (flutter/engine#44852)
2023-08-25 jonahwilliams@google.com [Impeller] avoid hashing and std::vector growth when binding descriptor sets. (flutter/engine#45070)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

cd03eabd

Roll Flutter Engine from 33fca02451ef to 3dcd2179336d (3 revisions) (#133340) · 284dfce7

engine-flutter-autoroll authored Aug 25, 2023

https://github.com/flutter/engine/compare/33fca02451ef...3dcd2179336d

2023-08-25 skia-flutter-autoroll@skia.org Roll Skia from 4b30261160a2 to ba7c5258d2b4 (5 revisions) (flutter/engine#45116)
2023-08-25 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from R_deCnScH70FbSeii... to u8ovJYTk3nN78xF4X... (flutter/engine#45115)
2023-08-25 gspencergoog@users.noreply.github.com Add quotes around Doxygen configuration values (flutter/engine#45087)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from R_deCnScH70F to u8ovJYTk3nN7

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

284dfce7

Update flutter packages to pick up latest vm_service (#133335) · 61d9f556
Kenzie Davisson authored Aug 25, 2023
```
Generated by running `flutter update-packages --force-upgrade`
```
61d9f556

Roll Flutter Engine from 00f532dcaef4 to 33fca02451ef (1 revision) (#133337) · b66fb2a4

engine-flutter-autoroll authored Aug 25, 2023

https://github.com/flutter/engine/compare/00f532dcaef4...33fca02451ef

2023-08-25 jonahwilliams@google.com [Impeller] fix validation warning on iOS/macOS when compiling external texture shader. (flutter/engine#45080)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

b66fb2a4

Roll Flutter Engine from cb58abd77326 to 00f532dcaef4 (3 revisions) (#133333) · db22617b

engine-flutter-autoroll authored Aug 25, 2023

https://github.com/flutter/engine/compare/cb58abd77326...00f532dcaef4

2023-08-25 godofredoc@google.com Remove cirrus build badge (flutter/engine#45103)
2023-08-25 skia-flutter-autoroll@skia.org Roll Skia from 8a26fe31389d to 4b30261160a2 (1 revision) (flutter/engine#45109)
2023-08-25 godofredoc@google.com Fix global tests doing nothing. (flutter/engine#45097)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

db22617b

Fix `PopupMenuItem` with a `ListTile` doesn't use the correct style. (#133141) · ea005219

Taha Tesser authored Aug 25, 2023

fixes [`PopupMenuItem` with a `ListTile`  doesn't use the correct text style.](https://github.com/flutter/flutter/issues/133138)

### Description

This fixes an issue text style issue for `PopupMenuItem` with a `ListTile` (for an elaborate popup menu) 

https://api.flutter.dev/flutter/material/PopupMenuItem-class.html

<details> 
<summary>expand to view the code sample</summary> 

```dart
import 'package:flutter/material.dart';

/// Flutter code sample for [PopupMenuButton].

// This is the type used by the popup menu below.
enum SampleItem { itemOne, itemTwo, itemThree }

void main() => runApp(const PopupMenuApp());

class PopupMenuApp extends StatelessWidget {
  const PopupMenuApp({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      theme: ThemeData(
        useMaterial3: true,
        textTheme: const TextTheme(
          labelLarge: TextStyle(
            fontStyle: FontStyle.italic,
            fontWeight: FontWeight.bold,
          ),
        ),
      ),
      home: const PopupMenuExample(),
    );
  }
}

class PopupMenuExample extends StatefulWidget {
  const PopupMenuExample({super.key});

  @override
  State<PopupMenuExample> createState() => _PopupMenuExampleState();
}

class _PopupMenuExampleState extends State<PopupMenuExample> {
  SampleItem? selectedMenu;

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      body: Center(
        child: SizedBox(
          width: 300,
          height: 130,
          child: Align(
            alignment: Alignment.topLeft,
            child: PopupMenuButton<SampleItem>(
              initialValue: selectedMenu,
              // Callback that sets the selected popup menu item.
              onSelected: (SampleItem item) {
                setState(() {
                  selectedMenu = item;
                });
              },
              itemBuilder: (BuildContext context) =>
                  <PopupMenuEntry<SampleItem>>[
                const PopupMenuItem<SampleItem>(
                  value: SampleItem.itemOne,
                  child: Text('PopupMenuItem'),
                ),
                const CheckedPopupMenuItem<SampleItem>(
                  checked: true,
                  value: SampleItem.itemTwo,
                  child: Text('CheckedPopupMenuItem'),
                ),
                const PopupMenuItem<SampleItem>(
                  value: SampleItem.itemOne,
                  child: ListTile(
                    leading: Icon(Icons.cloud),
                    title: Text('ListTile'),
                    contentPadding: EdgeInsets.zero,
                    trailing: Icon(Icons.arrow_right_rounded),
                  ),
                ),
              ],
            ),
          ),
        ),
      ),
    );
  }
}
``` 

</details>

### Before

![Screenshot 2023-08-23 at 14 08 48](https://github.com/flutter/flutter/assets/48603081/434ac95e-2981-4ab5-9843-939b39d771a2)

### After

![Screenshot 2023-08-23 at 14 08 32](https://github.com/flutter/flutter/assets/48603081/f6aba7e0-3d03-454f-8e0b-c031492f3f2d)

ea005219

Fix `Chip.shape`'s side is not used when provided in Material 3 (#132941) · 612117a6

Taha Tesser authored Aug 25, 2023

fixes [Chip border side color not working in Material3](https://github.com/flutter/flutter/issues/132922)

### Code sample

<details> 
<summary>expand to view the code sample</summary> 

```dart
import 'package:flutter/material.dart';

void main() {
  runApp(const MyApp());
}

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      theme: ThemeData(
        useMaterial3: true,
        chipTheme: const ChipThemeData(
            // shape: RoundedRectangleBorder(
            //   side: BorderSide(color: Colors.amber),
            //   borderRadius: BorderRadius.all(Radius.circular(12)),
            // ),
            // side: BorderSide(color: Colors.red),
            ),
      ),
      home: const Example(),
    );
  }
}

class Example extends StatelessWidget {
  const Example({super.key});

  @override
  Widget build(BuildContext context) {
    return const Scaffold(
      body: Center(
        child: RawChip(
          shape: RoundedRectangleBorder(
            side: BorderSide(color: Colors.amber),
            borderRadius: BorderRadius.all(Radius.circular(12)),
          ),
          // side: BorderSide(color: Colors.red),
          label: Text('Chip'),
        ),
      ),
    );
  }
}

``` 

</details>

---

### Before

When `RawChip.shape` is provided with a `BorderSide`.

```dart
      body: Center(
        child: RawChip(
          shape: RoundedRectangleBorder(
            side: BorderSide(color: Colors.amber),
            borderRadius: BorderRadius.all(Radius.circular(12)),
          ),
          label: Text('Chip'),
        ),
      ),
```

![Screenshot 2023-08-24 at 17 54 54](https://github.com/flutter/flutter/assets/48603081/89e2c9b5-44c2-432e-97ff-8bb95b0d0fb1)

When `RawChip.shape` is provided with a `BorderSide` and also `RawChip.side` is provided. The  `RawChip.side` overrides the shape's side.

```dart
      body: Center(
        child: RawChip(
          shape: RoundedRectangleBorder(
            side: BorderSide(color: Colors.amber),
            borderRadius: BorderRadius.all(Radius.circular(12)),
          ),
          side: BorderSide(color: Colors.red),
          label: Text('Chip'),
        ),
      ),
```

![Screenshot 2023-08-24 at 17 55 37](https://github.com/flutter/flutter/assets/48603081/938803cc-d514-464b-b06b-e4841b9ad040)

---

### After

When `RawChip.shape` is provided with a `BorderSide`.

```dart
      body: Center(
        child: RawChip(
          shape: RoundedRectangleBorder(
            side: BorderSide(color: Colors.amber),
            borderRadius: BorderRadius.all(Radius.circular(12)),
          ),
          label: Text('Chip'),
        ),
      ),
```

![Screenshot 2023-08-24 at 17 51 29](https://github.com/flutter/flutter/assets/48603081/d6fcaaa9-8f5d-4180-ad14-062dd459ec45)

When `RawChip.shape` is provided with a `BorderSide` and also `RawChip.side` is provided. The  `RawChip.side` overrides the shape's side.

```dart
      body: Center(
        child: RawChip(
          shape: RoundedRectangleBorder(
            side: BorderSide(color: Colors.amber),
            borderRadius: BorderRadius.all(Radius.circular(12)),
          ),
          side: BorderSide(color: Colors.red),
          label: Text('Chip'),
        ),
      ),
```

![Screenshot 2023-08-24 at 17 52 31](https://github.com/flutter/flutter/assets/48603081/3fa46341-43f0-4fe7-a922-f1d8ba34028c)

---

612117a6

Dispose overlay entries (#132826) · 5c17a37b
Tomasz Gucio authored Aug 25, 2023

5c17a37b

Roll Flutter Engine from 0f8962208a44 to cb58abd77326 (3 revisions) (#133320) · 901a392a

engine-flutter-autoroll authored Aug 25, 2023

https://github.com/flutter/engine/compare/0f8962208a44...cb58abd77326

2023-08-25 skia-flutter-autoroll@skia.org Roll Skia from f867f82cc758 to 8a26fe31389d (1 revision) (flutter/engine#45104)
2023-08-25 skia-flutter-autoroll@skia.org Roll Skia from 5a1b6567544c to f867f82cc758 (2 revisions) (flutter/engine#45102)
2023-08-25 ian@hixie.ch FontVariation.lerp, custom FontVariation constructors, and more documentation (flutter/engine#45030)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

901a392a

Roll Flutter Engine from 09e620d26834 to 0f8962208a44 (2 revisions) (#133309) · 3c1dd2f9

engine-flutter-autoroll authored Aug 25, 2023

https://github.com/flutter/engine/compare/09e620d26834...0f8962208a44

2023-08-25 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from jkVyhV_xfb8Mv43xj... to 4LHUJjNlDT21v_pdT... (flutter/engine#45100)
2023-08-25 skia-flutter-autoroll@skia.org Roll Skia from 1428f16fc0de to 5a1b6567544c (1 revision) (flutter/engine#45099)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from jkVyhV_xfb8M to 4LHUJjNlDT21

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

3c1dd2f9

Roll Flutter Engine from 9bcefc74b772 to 09e620d26834 (1 revision) (#133307) · 9ab8d27a

engine-flutter-autoroll authored Aug 25, 2023

https://github.com/flutter/engine/compare/9bcefc74b772...09e620d26834

2023-08-25 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 0kEa4JczTMD0Xus08... to R_deCnScH70FbSeii... (flutter/engine#45096)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from 0kEa4JczTMD0 to R_deCnScH70F

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

9ab8d27a