Commits · 042c0366c9a9687be15bd79f9cfbab73a85dbe65 · abdullh.alsoleman / Front-End

22 Jun, 2023 12 commits

Remove unnecessary variable `_hasPrimaryFocus` (#129066) · 042c0366

Ahmed Elsayed authored Jun 22, 2023

`_hasPrimaryFocus` variable and its related code is no longer needed after using `InkWell` for `DropdownButton` at https://github.com/flutter/flutter/pull/95906

042c0366

Fix Material 3 Scrollable `TabBar` (#125974) · 32fde139

Taha Tesser authored Jun 22, 2023

fix https://github.com/flutter/flutter/issues/117722

### Description
1. Fix the divider doesn't stretch to take all the available width in the scrollable tab bar in M3
2. Add `dividerHeight` property.
3. Update the default tab alignment for the scrollable tab bar to match the specs (this is backward compatible for M2 with the new `tabAlignment` property).

### Bug (default tab alignment)

![Screenshot 2023-05-05 at 19 04 40](https://user-images.githubusercontent.com/48603081/236509483-1d03af21-a764-4776-acef-2126560f0d51.png)

### Fix (default tab alignment)

![Screenshot 2023-05-05 at 19 04 15](https://user-images.githubusercontent.com/48603081/236509513-2426d456-c54f-42bd-9545-a14dc6ee7e69.png)

### Code sample

<details> 
<summary>code sample</summary> 

```dart
import 'package:flutter/material.dart';

/// Flutter code sample for [TabBar].

void main() => runApp(const TabBarApp());

class TabBarApp extends StatelessWidget {
  const TabBarApp({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      theme: ThemeData(
        //  tabBarTheme: const TabBarTheme(tabAlignment: TabAlignment.start),
          useMaterial3: true,
      ),
      home: const TabBarExample(),
    );
  }
}

class TabBarExample extends StatefulWidget {
  const TabBarExample({super.key});

  @override
  State<TabBarExample> createState() => _TabBarExampleState();
}

class _TabBarExampleState extends State<TabBarExample> {
  bool rtl = false;

  @override
  Widget build(BuildContext context) {
    return DefaultTabController(
      initialIndex: 1,
      length: 3,
      child: Directionality(
        textDirection:  rtl ? TextDirection.rtl : TextDirection.ltr,
        child: Scaffold(
          appBar: AppBar(
            title: const Text('TabBar Sample'),
          ),
          body: const Column(
            children: <Widget>[
              Text('Scrollable-TabAlignment.start'),
              TabBar(
                isScrollable: true,
                tabAlignment: TabAlignment.start,
                tabs: <Widget>[
                  Tab(
                    icon: Icon(Icons.cloud_outlined),
                  ),
                  Tab(
                    icon: Icon(Icons.beach_access_sharp),
                  ),
                  Tab(
                    icon: Icon(Icons.brightness_5_sharp),
                  ),
                ],
              ),
              Text('Scrollable-TabAlignment.startOffset'),
              TabBar(
                isScrollable: true,
                tabAlignment: TabAlignment.startOffset,
                tabs: <Widget>[
                  Tab(
                    icon: Icon(Icons.cloud_outlined),
                  ),
                  Tab(
                    icon: Icon(Icons.beach_access_sharp),
                  ),
                  Tab(
                    icon: Icon(Icons.brightness_5_sharp),
                  ),
                ],
              ),
              Text('Scrollable-TabAlignment.center'),
              TabBar(
                isScrollable: true,
                tabAlignment: TabAlignment.center,
                tabs: <Widget>[
                  Tab(
                    icon: Icon(Icons.cloud_outlined),
                  ),
                  Tab(
                    icon: Icon(Icons.beach_access_sharp),
                  ),
                  Tab(
                    icon: Icon(Icons.brightness_5_sharp),
                  ),
                ],
              ),
              Spacer(),
              Text('Non-scrollable-TabAlignment.fill'),
              TabBar(
                tabAlignment: TabAlignment.fill,
                tabs: <Widget>[
                  Tab(
                    icon: Icon(Icons.cloud_outlined),
                  ),
                  Tab(
                    icon: Icon(Icons.beach_access_sharp),
                  ),
                  Tab(
                    icon: Icon(Icons.brightness_5_sharp),
                  ),
                ],
              ),
              Text('Non-scrollable-TabAlignment.center'),
              TabBar(
                tabAlignment: TabAlignment.center,
                tabs: <Widget>[
                  Tab(
                    icon: Icon(Icons.cloud_outlined),
                  ),
                  Tab(
                    icon: Icon(Icons.beach_access_sharp),
                  ),
                  Tab(
                    icon: Icon(Icons.brightness_5_sharp),
                  ),
                ],
              ),
              Spacer(),
            ],
          ),
          floatingActionButton: FloatingActionButton.extended(
            onPressed: () {
              setState(() {
                rtl = !rtl;
              });
            },
            label: const Text('Switch Direction'),
            icon: const Icon(Icons.swap_horiz),
          ),
        ),
      ),
    );
  }
}
``` 
	
</details>

![Screenshot 2023-06-06 at 18 06 12](https://github.com/flutter/flutter/assets/48603081/5ee5386d-cc64-4025-a020-ed2222cb6031)

32fde139

Fix: Closing bottom sheet and removing FAB cause assertion failure (#128566) · 0da8012c
Masatoshi Tsushima authored Jun 22, 2023
```
Fixes #128562
```
0da8012c

Add `InputDecorationTheme.merge` (#129011) · 2e05371c

Taha Tesser authored Jun 22, 2023

fixes [[Proposal] `InputDecorationTheme.merge()`](https://github.com/flutter/flutter/issues/125471)

2e05371c

Roll Packages from 9af50d46e5d1 to 95bc1c6db547 (6 revisions) (#129351) · 419bf816

engine-flutter-autoroll authored Jun 22, 2023

https://github.com/flutter/packages/compare/9af50d46e5d1...95bc1c6db547

2023-06-22 stuartmorgan@google.com [ci] Switch analyze tests to LUCI (flutter/packages#4264)
2023-06-22 ditman@gmail.com Roll Flutter from fc8856eb to c40baf47 (57 revisions) (flutter/packages#4270)
2023-06-22 stuartmorgan@google.com [ci] Add LUCI version of build-all for Android (flutter/packages#4236)
2023-06-21 47866232+chunhtai@users.noreply.github.com [go_router] Adds parent navigator key to ShellRoute and StatefulShellâ¦ (flutter/packages#4201)
2023-06-21 stuartmorgan@google.com [pigeon] Add macOS Obj-C support (flutter/packages#4267)
2023-06-21 stuartmorgan@google.com [tools] Fix format instructions (flutter/packages#4259)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

419bf816

Prevent crashes on range errors when selecting device (#129290) · 18b94b7f

Elias Yishak authored Jun 22, 2023

Prevent the cli from crashing when a user selects a number that is not valid for `flutter run` device selection

Fixes issue:
- https://github.com/flutter/flutter/issues/129191

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*

18b94b7f

Revert "Roll Flutter Engine from 703c9a14ac7f to 8cc6d6d5efdb (1 revision)" (#129353) · 7c259dea

Zachary Anderson authored Jun 22, 2023

Reverts flutter/flutter#129339

Reverting for a crasher: https://ci.chromium.org/ui/p/flutter/builders/prod/Linux_android%20animated_blur_backdrop_filter_perf__timeline_summary/1120/overview

7c259dea

Roll Flutter Engine from 703c9a14ac7f to 8cc6d6d5efdb (1 revision) (#129339) · a2739c09

engine-flutter-autoroll authored Jun 22, 2023

https://github.com/flutter/engine/compare/703c9a14ac7f...8cc6d6d5efdb

2023-06-22 bdero@google.com [Impeller] Correctly compute UVs in texture fill (flutter/engine#43028)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

a2739c09

Roll Flutter Engine from d9530e2b87de to 703c9a14ac7f (1 revision) (#129337) · 70c25d4e

engine-flutter-autoroll authored Jun 22, 2023

https://github.com/flutter/engine/compare/d9530e2b87de...703c9a14ac7f

2023-06-22 skia-flutter-autoroll@skia.org Roll Skia from 076e7c004d20 to 71047dca9f77 (1 revision) (flutter/engine#43071)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

70c25d4e

Roll Flutter Engine from c6251a69a09a to d9530e2b87de (1 revision) (#129334) · 15d594c2

engine-flutter-autoroll authored Jun 22, 2023

https://github.com/flutter/engine/compare/c6251a69a09a...d9530e2b87de

2023-06-22 dnfield@google.com [Impeller] Fix up coverage hints for blending/vertices, fix TiledTextureContents::RenderToSnapshot (flutter/engine#43017)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

15d594c2

Roll Flutter Engine from 08aaa88bf67f to c6251a69a09a (10 revisions) (#129331) · c83dce98

engine-flutter-autoroll authored Jun 22, 2023

https://github.com/flutter/engine/compare/08aaa88bf67f...c6251a69a09a

2023-06-22 tamird@google.com Remove process-local tempfs (flutter/engine#43056)
2023-06-22 skia-flutter-autoroll@skia.org Roll Skia from 0185ce148be9 to 076e7c004d20 (2 revisions) (flutter/engine#43069)
2023-06-22 skia-flutter-autoroll@skia.org Roll Skia from 96d6135e9ee8 to 0185ce148be9 (4 revisions) (flutter/engine#43068)
2023-06-22 bdero@google.com [Impeller] Uniquely label subpasses and root blit (flutter/engine#43015)
2023-06-22 bdero@google.com [Impeller] Add Rect::Project (flutter/engine#43026)
2023-06-21 skia-flutter-autoroll@skia.org Roll Skia from 32e953e71266 to 96d6135e9ee8 (1 revision) (flutter/engine#43067)
2023-06-21 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from ct6r5YjdG2xpZPhkT... to QtQznuUmHMTyORqxJ... (flutter/engine#43065)
2023-06-21 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 4mkuVtlGBaumKSe8x... to 7EZeNE4aGd29VfDly... (flutter/engine#43066)
2023-06-21 skia-flutter-autoroll@skia.org Roll ANGLE from 3a3a3c655a96 to ac263582dda4 (60 revisions) (flutter/engine#43062)
2023-06-21 skia-flutter-autoroll@skia.org Roll Skia from 7eeb94b1e778 to 32e953e71266 (17 revisions) (flutter/engine#43064)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from 4mkuVtlGBaum to 7EZeNE4aGd29
fuchsia/sdk/core/mac-amd64 from ct6r5YjdG2xp to QtQznuUmHMTy

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

c83dce98

Manual roll of packages to 9af50d46e5d118fd8bc6a7b38bae748bf7877c58 (#129328) · b19ebcd1
Jason Simmons authored Jun 22, 2023
```
Required to fix an analyzer error that is blocking the engine roller
```
b19ebcd1

21 Jun, 2023 20 commits

Roll Flutter Engine from 090fae83548a to 08aaa88bf67f (3 revisions) (#129306) · ae1e6f70

engine-flutter-autoroll authored Jun 21, 2023

https://github.com/flutter/engine/compare/090fae83548a...08aaa88bf67f

2023-06-21 mark@lazycat.hu Enabling pre-push checks on Windows (flutter/engine#36123)
2023-06-21 godofredoc@google.com Document the use of contexts on engine_v2 tests. (flutter/engine#43013)
2023-06-21 godofredoc@google.com Generate treemap. (flutter/engine#43029)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

ae1e6f70

[framework,web] add FlutterTimeline and semantics benchmarks that use it (#128366) · 07772a3d

Yegor authored Jun 21, 2023

## FlutterTimeline

Add a new class `FlutterTimeline` that's a drop-in replacement for `Timeline` from `dart:developer`. In addition to forwarding invocations of `startSync`, `finishSync`, `timeSync`, and `instantSync` to `dart:developer`, provides the following extra methods that make is easy to collect timings for code blocks on a frame-by-frame basis:

* `debugCollect()` - aggregates timings since the last reset, or since the app launched.
* `debugReset()` - forgets all data collected since the previous reset, or since the app launched. This allows clearing data from previous frames so timings can be attributed to the current frame.
* `now` - this was enhanced so that it works on the web by calling `window.performance.now` (in `Timeline` this is a noop in Dart web compilers).
* `collectionEnabled` - a field that controls whether `FlutterTimeline` stores timings in memory. By default this is disabled to avoid unexpected overhead (although the class is designed for minimal and predictable overhead). Specific benchmarks can enable collection to report to Skia Perf.

## Semantics benchmarks

Add `BenchMaterial3Semantics` that benchmarks the cost of semantics when constructing a screen full of Material 3 widgets from nothing. It is expected that semantics will have non-trivial cost in this case, but we should strive to keep it much lower than the rendering cost. This is the case already. This benchmark shows that the cost of semantics is <10%.

Add `BenchMaterial3ScrollSemantics` that benchmarks the cost of scrolling a previously constructed screen full of Material 3 widgets. The expectation should be that semantics will have trivial cost, since we're just shifting some widgets around. As of today, the numbers are not great, with semantics taking >50% of frame time, which is what prompted this PR in the first place. As we optimize this, we want to see this number improve.

07772a3d

Roll pub packages (#128966) · 22005779
Flutter GitHub Bot authored Jun 21, 2023
```
This PR was generated by `flutter update-packages --force-upgrade`.
```
22005779
Remove incorrect non-nullable assumption from `ShapeDecoration.lerp` (#129298) · 28ca523a
Pierre-Louis authored Jun 21, 2023
```
Fixes https://github.com/flutter/flutter/issues/129299
```
28ca523a
Gracefully handle negative position in getWordAtOffset (#128464) · 16eb4f2c
Justin McCandless authored Jun 21, 2023
```
Should fix an unreproducible crash in text editing and track it with an assertion.
```
16eb4f2c
[flutter_tools] add a gradle error handler for could not open cache directory (#129222) · 5cef69dd
Christopher Fujino authored Jun 21, 2023
```
Works around part of https://github.com/flutter/flutter/issues/128866
```
5cef69dd

Roll Flutter Engine from f973fb4636d3 to 090fae83548a (5 revisions) (#129293) · d2c4b5a1

engine-flutter-autoroll authored Jun 21, 2023

https://github.com/flutter/engine/compare/f973fb4636d3...090fae83548a

2023-06-21 skia-flutter-autoroll@skia.org Roll Skia from c983b97d03a8 to 7eeb94b1e778 (4 revisions) (flutter/engine#43045)
2023-06-21 godofredoc@google.com Move android emulator tests to v2. (flutter/engine#43008)
2023-06-21 skia-flutter-autoroll@skia.org Roll Skia from 65f30e5804c7 to c983b97d03a8 (2 revisions) (flutter/engine#43044)
2023-06-21 skia-flutter-autoroll@skia.org Roll Skia from 7121db7c6dc2 to 65f30e5804c7 (3 revisions) (flutter/engine#43043)
2023-06-21 skia-flutter-autoroll@skia.org Roll Dart SDK from 178d3d1184cb to 88fa9330633e (1 revision) (flutter/engine#43041)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

d2c4b5a1

Selection area right click behavior should match native (#128224) · b36ef583

Renzo Olivares authored Jun 21, 2023

This change updates `SelectableRegion`s right-click gesture to match native platform behavior.

Before: Right-click gesture selects word at position and opens context menu (All Platforms)
After: 
- Linux, toggles context menu on/off, and collapses selection when click was not on an active selection (uncollapsed).
- Windows, Android, Fuchsia, shows context menu at right-clicked position (unless the click is at an active selection).
- macOS, toggles the context menu if right click was at the same position as the previous / or selects word at position and opens context menu.
- iOS, selects word at position and opens context menu.

This change also prevents the `copy` menu button from being shown when there is a collapsed selection (nothing to copy).

Fixes #117561

b36ef583

Roll Packages from 6e1918fa166c to 0fdf05f51029 (8 revisions) (#129286) · c40baf47

engine-flutter-autoroll authored Jun 21, 2023

https://github.com/flutter/packages/compare/6e1918fa166c...0fdf05f51029

2023-06-21 34871572+gmackall@users.noreply.github.com [image_picker_android] Modify FileUtils.getBaseName to return the whole filename when it contains no period (flutter/packages#4237)
2023-06-21 stuartmorgan@google.com [tools] Add mockito support to update-dependency (flutter/packages#4260)
2023-06-21 49699333+dependabot[bot]@users.noreply.github.com Bump actions/checkout from 3.5.2 to 3.5.3 (flutter/packages#4185)
2023-06-21 49699333+dependabot[bot]@users.noreply.github.com [image_picker]: Bump org.jetbrains.kotlin:kotlin-bom from 1.8.21 to 1.8.22 in /packages/image_picker/image_picker_android/android (flutter/packages#4190)
2023-06-20 49699333+dependabot[bot]@users.noreply.github.com Bump actions/labeler from 4.0.3 to 4.1.0 (flutter/packages#4145)
2023-06-20 stuartmorgan@google.com [ci] Add LUCI version of the analyze tasks (flutter/packages#4253)
2023-06-20 49699333+dependabot[bot]@users.noreply.github.com [in_app_pur]: Bump org.jetbrains.kotlin:kotlin-bom from 1.8.21 to 1.8.22 in /packages/in_app_purchase/in_app_purchase_android/android (flutter/packages#4193)
2023-06-20 stuartmorgan@google.com [ci] Switch Linux and web build-all to LUCI (flutter/packages#4252)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

c40baf47

move test ownership from zanderso -> tools team (#129199) · 8af21e0e

Christopher Fujino authored Jun 21, 2023

Move more test ownership from zanderso to the tools team. This file is used by the flaky issue bot to comment weekly on test shards that flake > 2%. The owner of the shard will be @'d on the issue. It is their responsibility to investigate and triage (potentially re-prioritizing, the bot will initially assign it p1).

8af21e0e

Refactor `Analytics` global getter to point to context only (#129196) · 5d8cc978

Elias Yishak authored Jun 21, 2023

Refactor the globals getter for `Analytics` to be in the context instead of having a default fallback. The current state of the tool creates a new instance every time `globals.analytics` was called

Addresses issue:
- https://github.com/flutter/flutter/issues/128535

5d8cc978

Roll Flutter Engine from cfbd3652532d to f973fb4636d3 (1 revision) (#129253) · b83f762d

engine-flutter-autoroll authored Jun 21, 2023

https://github.com/flutter/engine/compare/cfbd3652532d...f973fb4636d3

2023-06-21 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 41wcREjd9roHDS1jM... to 4mkuVtlGBaumKSe8x... (flutter/engine#43038)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from 41wcREjd9roH to 4mkuVtlGBaum

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

b83f762d

Roll Flutter Engine from 059643dcc8e3 to cfbd3652532d (1 revision) (#129243) · 66f47e94

engine-flutter-autoroll authored Jun 21, 2023

https://github.com/flutter/engine/compare/059643dcc8e3...cfbd3652532d

2023-06-21 skia-flutter-autoroll@skia.org Roll Skia from a6412350122e to 7121db7c6dc2 (3 revisions) (flutter/engine#43037)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

66f47e94

Roll Flutter Engine from 5313ca367549 to 059643dcc8e3 (1 revision) (#129240) · e5559b9c

engine-flutter-autoroll authored Jun 21, 2023

https://github.com/flutter/engine/compare/5313ca367549...059643dcc8e3

2023-06-21 skia-flutter-autoroll@skia.org Roll Skia from efc045c15fdd to a6412350122e (2 revisions) (flutter/engine#43036)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

e5559b9c

Roll Flutter Engine from 946f523859fe to 5313ca367549 (2 revisions) (#129234) · f5203cb6

engine-flutter-autoroll authored Jun 21, 2023

https://github.com/flutter/engine/compare/946f523859fe...5313ca367549

2023-06-21 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from fdtK_FqpscIVvbb_j... to ct6r5YjdG2xpZPhkT... (flutter/engine#43035)
2023-06-21 leroux_bruno@yahoo.fr [Android] Return the keyboard pressed state (flutter/engine#42758)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from fdtK_FqpscIV to ct6r5YjdG2xp

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

f5203cb6

Roll Flutter Engine from e5a860c5479c to 946f523859fe (2 revisions) (#129232) · 88d6539e

engine-flutter-autoroll authored Jun 21, 2023

https://github.com/flutter/engine/compare/e5a860c5479c...946f523859fe

2023-06-21 skia-flutter-autoroll@skia.org Roll Dart SDK from 493133372cac to 178d3d1184cb (1 revision) (flutter/engine#43032)
2023-06-21 skia-flutter-autoroll@skia.org Roll Skia from cc164404690f to efc045c15fdd (1 revision) (flutter/engine#43027)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

88d6539e

Relax `OverlayPortal` asserts (#129053) · 04ff86f0

LongCatIsLooong authored Jun 21, 2023

Fixes https://github.com/flutter/flutter/issues/129025

Also 
- simplifies OverlayPortal code a bit and adds an assert.
-  `Tooltip` shouldn't rebuild when hiding/showing the tooltip

04ff86f0

Roll Flutter Engine from adfc3af300a9 to e5a860c5479c (3 revisions) (#129228) · 99aaff53

engine-flutter-autoroll authored Jun 21, 2023

https://github.com/flutter/engine/compare/adfc3af300a9...e5a860c5479c

2023-06-21 jason-simmons@users.noreply.github.com Implement the APNG_DISPOSE_OP_BACKGROUND disposal method in the animated PNG decoder (flutter/engine#42933)
2023-06-21 skia-flutter-autoroll@skia.org Roll Skia from 13d83a6912ce to cc164404690f (1 revision) (flutter/engine#43024)
2023-06-20 tamird@google.com Roll buildroot to 6e71c38443c0bf9d8954c87bf69bb4e019f44f94 (flutter/engine#43019)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

99aaff53

Move all the firebase lab device configs to .ci.yaml. (#129219) · dffef271
godofredoc authored Jun 21, 2023
```
Bug: https://github.com/flutter/flutter/issues/129211
```
dffef271

Roll Flutter Engine from 7d4abb81ccd1 to adfc3af300a9 (2 revisions) (#129225) · 325b7b38

engine-flutter-autoroll authored Jun 21, 2023

https://github.com/flutter/engine/compare/7d4abb81ccd1...adfc3af300a9

2023-06-20 skia-flutter-autoroll@skia.org Roll Dart SDK from 219b3198373c to 493133372cac (2 revisions) (flutter/engine#43021)
2023-06-20 skia-flutter-autoroll@skia.org Roll Skia from 0b88d9031cd2 to 13d83a6912ce (4 revisions) (flutter/engine#43020)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

325b7b38

20 Jun, 2023 8 commits

update resolution-aware asset docs links (#128769) · e1e45ca3
Andrew Kolos authored Jun 20, 2023
```
Updates some doc comment links.

Fixes https://github.com/flutter/flutter/issues/128139
```
e1e45ca3
Fix: Magnifier appears and won't dismiss (#128545) · 40b4bc99
Justin McCandless authored Jun 20, 2023
```
Fixes a bug when tapping near certain TextFields.
```
40b4bc99

DecoratedSliver (#127823) · 541fdd60

Tae Hyung Kim authored Jun 20, 2023

This is a second attempt to merge #107269. Currently I've fixed two of the issues:
1. Fixed horizontal scrollview by using a switch statement to consider vertical/horizontal case.
2. Fixed issue of `paintExtent` not being the right extent for painting. Rather using a `scrollExtent` for the main axis length of the decoration box and painting it offsetted by the `scrollOffset`.
3. If the sliver child has inifinite scrollExtent, then we only draw the decoration down to the bottom of the `cacheExtent`. The developer is expected to ensure that the border does not creep up above the cache area.

This PR includes a test that checks that the correct rectangle is drawn at a certain scrollOffset for both the horizontal and vertical case which should be sufficient for checking that `SliverDecoration` works properly now.

Fixes https://github.com/flutter/flutter/issues/107498.

541fdd60

Roll Flutter Engine from 666244148e89 to 7d4abb81ccd1 (1 revision) (#129217) · 08561958

engine-flutter-autoroll authored Jun 20, 2023

https://github.com/flutter/engine/compare/666244148e89...7d4abb81ccd1

2023-06-20 skia-flutter-autoroll@skia.org Roll Skia from d56841344bbe to 0b88d9031cd2 (3 revisions) (flutter/engine#43018)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

08561958

Roll Flutter Engine from 06d0c08460e5 to 666244148e89 (2 revisions) (#129208) · 83f8b2e6

engine-flutter-autoroll authored Jun 20, 2023

https://github.com/flutter/engine/compare/06d0c08460e5...666244148e89

2023-06-20 skia-flutter-autoroll@skia.org Roll Skia from 9f8b501ca68c to d56841344bbe (5 revisions) (flutter/engine#43016)
2023-06-20 skia-flutter-autoroll@skia.org Roll Skia from 0b26ffb4efe0 to 9f8b501ca68c (10 revisions) (flutter/engine#43012)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

83f8b2e6

fixed PreferredSize constuctor invocations (#128181) · b733901d

Md. Yeasin Sheikh authored Jun 20, 2023

This PR changes the `PreferredSize` constructor parameter positioning to cover the constructor invocations. It helps on auto-complete and suggestion. 

*List which issues are fixed by this PR. You must list at least one issue.*
Fixes #128178

b733901d

Roll Flutter Engine from 1c16af76ca26 to 06d0c08460e5 (3 revisions) (#129200) · 3b013b7b

engine-flutter-autoroll authored Jun 20, 2023

https://github.com/flutter/engine/compare/1c16af76ca26...06d0c08460e5

2023-06-20 jason-simmons@users.noreply.github.com A few minor cleanups of the MultiFrameCodec (flutter/engine#42935)
2023-06-20 jonahwilliams@google.com [Impeller] use pixel format in construction of initial PSO objects, set default sample count to 4. (flutter/engine#42972)
2023-06-20 skia-flutter-autoroll@skia.org Roll Dart SDK from dc6691ef755c to 219b3198373c (1 revision) (flutter/engine#43005)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

3b013b7b

Roll Flutter Engine from ec64672afd91 to 1c16af76ca26 (1 revision) (#129197) · 3bbd9b37

engine-flutter-autoroll authored Jun 20, 2023

https://github.com/flutter/engine/compare/ec64672afd91...1c16af76ca26

2023-06-20 5236035+fzyzcjy@users.noreply.github.com Differentiate two `EncodeCommandsInReactor` with the same name (flutter/engine#42992)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

3bbd9b37