Commits · 02c0abbbd6fb6eba288b9af37d3cd01f70097cfc · abdullh.alsoleman / Front-End

26 Jun, 2023 13 commits

Roll Flutter Engine from 4032a9bc964e to f2d70cc809cd (4 revisions) (#129574) · 02c0abbb

engine-flutter-autoroll authored Jun 26, 2023

https://github.com/flutter/engine/compare/4032a9bc964e...f2d70cc809cd

2023-06-26 skia-flutter-autoroll@skia.org Roll Skia from 46dcf29e5dfe to 632fa401098d (5 revisions) (flutter/engine#43204)
2023-06-26 godofredoc@google.com Revert "Remove master mirroring workflow." (flutter/engine#43206)
2023-06-26 jonahwilliams@google.com [Impeller] opt srgb to linear into f16 (flutter/engine#43182)
2023-06-26 skia-flutter-autoroll@skia.org Roll ANGLE from 764f31be3228 to f6c7dc891859 (1 revision) (flutter/engine#43203)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

02c0abbb

Bump ossf/scorecard-action from 2.1.3 to 2.2.0 (#129453) · 96a2c053

dependabot[bot] authored Jun 26, 2023

Bumps [ossf/scorecard-action](https://github.com/ossf/scorecard-action) from 2.1.3 to 2.2.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/ossf/scorecard-action/releases">ossf/scorecard-action's releases</a>.</em></p>
<blockquote>
<h2>v2.2.0</h2>
<h2>What's Changed</h2>
<ul>
<li>🌱 Bump github.com/ossf/scorecard/v4 from v4.10.5 to v4.11.0 by <a href="https://github.com/spencerschrock"><code>@âspencerschrock</code></a> in <a href="https://redirect.github.com/ossf/scorecard-action/pull/1192">ossf/scorecard-action#1192</a></li>
</ul>
<h2>Scorecard Result Viewer</h2>
<p>Thanks to contributions from <a href="https://github.com/cynthia-sg"><code>@âcynthia-sg</code></a> and <a href="https://github.com/tegioz"><code>@âtegioz</code></a> at <a href="https://github.com/cncf/clomonitor">CLOMonitor</a>, there is a new Scorecard Result visualization page at <code>https://securityscorecards.dev/viewer/?uri=&lt;project-url&gt;</code>.</p>
<ul>
<li><a href="https://redirect.github.com/ossf/scorecard-webapp/pull/406">ossf/scorecard-webapp#406</a></li>
<li><a href="https://redirect.github.com/ossf/scorecard-webapp/pull/422">ossf/scorecard-webapp#422</a></li>
</ul>
<p>As an example, you can see our own score visualized <a href="https://securityscorecards.dev/viewer/?uri=github.com/ossf/scorecard">here</a>
Checkout our <a href="https://github.com/ossf/scorecard-action/blob/08b4669551908b1024bb425080c797723083c031/README.md#scorecard-badge">README</a> to learn how to link your README badge to the new visualization page.</p>
<h2>Publishing Results</h2>
<p>This release contains two fixes which will improve the user experience when <code>publish_results</code> is <code>true</code></p>
<ul>
<li>Runs that fail our <a href="https://github.com/ossf/scorecard-action/blob/08b4669551908b1024bb425080c797723083c031/README.md#workflow-restrictions">workflow restrictions</a> will fail with a 400 response indicating the problem, instead of a vague 500 status. (<a href="https://redirect.github.com/ossf/scorecard-action/pull/1156">ossf/scorecard-action#1156</a>, resolved <a href="https://redirect.github.com/ossf/scorecard-action/issues/1150">ossf/scorecard-action#1150</a>)</li>
<li>Scorecard action will retry when signing results and submitting them to our web API. This should help with flakiness from connection failures. (<a href="https://redirect.github.com/ossf/scorecard-action/pull/1191">ossf/scorecard-action#1191</a>)</li>
</ul>
<h2>Docs</h2>
<ul>
<li>ð Update README to accept fine-grained tokens by <a href="https://github.com/pnacht"><code>@âpnacht</code></a> in <a href="https://redirect.github.com/ossf/scorecard-action/pull/1175">ossf/scorecard-action#1175</a></li>
<li>ð Update installation instructions to match current GitHub UI  by <a href="https://github.com/joycebrum"><code>@âjoycebrum</code></a> in <a href="https://redirect.github.com/ossf/scorecard-action/pull/1153">ossf/scorecard-action#1153</a></li>
<li>ð Document the GitHub action workflow restrictions when publishing results. by <a href="https://github.com/spencerschrock"><code>@âspencerschrock</code></a> in</li>
</ul>
<h2>New Contributors</h2>
<ul>
<li><a href="https://github.com/bobcallaway"><code>@âbobcallaway</code></a> made their first contribution in <a href="https://redirect.github.com/ossf/scorecard-action/pull/1140">ossf/scorecard-action#1140</a></li>
<li><a href="https://github.com/pnacht"><code>@âpnacht</code></a> made their first contribution in <a href="https://redirect.github.com/ossf/scorecard-action/pull/1175">ossf/scorecard-action#1175</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/ossf/scorecard-action/compare/v2.1.3...v2.2.0">https://github.com/ossf/scorecard-action/compare/v2.1.3...v2.2.0</a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/ossf/scorecard-action/commit/08b4669551908b1024bb425080c797723083c031"><code>08b4669</code></a> 🌱 Bump docker tag to for v2.2.0 release. (<a href="https://redirect.github.com/ossf/scorecard-action/issues/1194">#1194</a>)</li>
<li><a href="https://github.com/ossf/scorecard-action/commit/3c7470f58c4371d8ac58beaeeacf771227d63ce8"><code>3c7470f</code></a> 📖 Update README badge link to use new uri param. (<a href="https://redirect.github.com/ossf/scorecard-action/issues/1185">#1185</a>)</li>
<li><a href="https://github.com/ossf/scorecard-action/commit/a164dbc12a66d9fae8ec379fff6ba200da366366"><code>a164dbc</code></a> 🌱 Bump github.com/ossf/scorecard/v4 from v4.10.5 to v4.11.0 (<a href="https://redirect.github.com/ossf/scorecard-action/issues/1192">#1192</a>)</li>
<li><a href="https://github.com/ossf/scorecard-action/commit/597960e1d95e5c741af238a819f03655e2fa43b8"><code>597960e</code></a> 📖 Update README to accept fine-grained tokens (<a href="https://redirect.github.com/ossf/scorecard-action/issues/1175">#1175</a>)</li>
<li><a href="https://github.com/ossf/scorecard-action/commit/8808ed28c3b8ba5a7d8059bd0360d8374ff6adb3"><code>8808ed2</code></a> 🌱 Retry external network calls when publishing results (<a href="https://redirect.github.com/ossf/scorecard-action/issues/1191">#1191</a>)</li>
<li><a href="https://github.com/ossf/scorecard-action/commit/0eed6cb5da014387b234df059cd4a2db5dbe9e1f"><code>0eed6cb</code></a> 🌱 Bump golang.org/x/net from 0.10.0 to 0.11.0</li>
<li><a href="https://github.com/ossf/scorecard-action/commit/6c6335c126308fd03da1c3bb267c1ebc3a34db0c"><code>6c6335c</code></a> 🌱 Bump github/codeql-action from 2.3.6 to 2.20.0</li>
<li><a href="https://github.com/ossf/scorecard-action/commit/7f1baf380a4f4418b4864d5a57bee1beba03e2eb"><code>7f1baf3</code></a> 📖 Switch recommended badge link to the new viewer. (<a href="https://redirect.github.com/ossf/scorecard-action/issues/1176">#1176</a>)</li>
<li><a href="https://github.com/ossf/scorecard-action/commit/df98bbc13d1c3001cc90b8a2791ffde7ba29f061"><code>df98bbc</code></a> 🌱 Bump actions/checkout from 3.5.2 to 3.5.3</li>
<li><a href="https://github.com/ossf/scorecard-action/commit/75886d414a5cd048874360697f1e8edb5b1e55ca"><code>75886d4</code></a> 🌱 Bump golangci/golangci-lint-action from 3.5.0 to 3.6.0 (<a href="https://redirect.github.com/ossf/scorecard-action/issues/1172">#1172</a>)</li>
<li>Additional commits viewable in <a href="https://github.com/ossf/scorecard-action/compare/80e868c13c90f172d68d1f4501dee99e2479f7af...08b4669551908b1024bb425080c797723083c031">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=ossf/scorecard-action&package-manager=github_actions&previous-version=2.1.3&new-version=2.2.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

96a2c053

Roll Flutter Engine from 63582320d20e to 4032a9bc964e (2 revisions) (#129569) · 7dd5c76d

engine-flutter-autoroll authored Jun 26, 2023

https://github.com/flutter/engine/compare/63582320d20e...4032a9bc964e

2023-06-26 jonahwilliams@google.com [Impeller] use default precision specifiers. (flutter/engine#43183)
2023-06-26 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from GkEyRw1Q2qLZWxitD... to ytzCCSvHY1lHWEDM9... (flutter/engine#43200)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from GkEyRw1Q2qLZ to ytzCCSvHY1lH

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

7dd5c76d

Updated TextMagnifierExampleApp to M3 (#129381) · 548fe147
Hans Muller authored Jun 26, 2023

548fe147

Roll Flutter Engine from debee7cece49 to 63582320d20e (3 revisions) (#129563) · cef9a8c5

engine-flutter-autoroll authored Jun 26, 2023

https://github.com/flutter/engine/compare/debee7cece49...63582320d20e

2023-06-26 skia-flutter-autoroll@skia.org Roll ANGLE from 7169dc5fe003 to 764f31be3228 (1 revision) (flutter/engine#43199)
2023-06-26 skia-flutter-autoroll@skia.org Roll Skia from 6d89bc1acb7e to 46dcf29e5dfe (2 revisions) (flutter/engine#43197)
2023-06-26 matej.knopp@gmail.com Implement union and intersection for DlRegion (flutter/engine#42620)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

cef9a8c5

Fix `AnimatedList` & `AnimatedGrid` doesn't apply `MediaQuery` padding (#129556) · c8e42b47

Taha Tesser authored Jun 26, 2023

fixes [AnimatedList does not take SafeArea into account when building the list ](https://github.com/flutter/flutter/issues/129539)

### Description
This PR fixes an issue for `AnimatedList` & `AnimatedGrid` where `MediaQuery` padding isn't applied. See the [source](https://github.com/flutter/flutter/blob/a20db068dd9f72e2e4a35a3ce64f22d47b3d20f7/packages/flutter/lib/src/widgets/scroll_view.dart#L803-L833).

While the  `ListView` or `GridView` applies `MediaQuery` padding to its inner `SliverPadding`.  This is missing from `AnimatedList` & `AnimatedGrid`.

![Digram of ListView applying MediaQuery padding](https://github.com/flutter/flutter/assets/48603081/01917900-cd26-4ca1-8e51-b7dcd1241471)

The fix applies  `MediaQuery` padding to the inner `SliverPadding` in `AnimatedList` & `AnimatedGrid`.

![Digram of AnimatedList & AnimatedGrid applying MediaQuery padding](https://github.com/flutter/flutter/assets/48603081/75d0a0ad-539c-485e-b3c1-770ee187086b)

### Code sample
<details> 
<summary>expand to view the code sample</summary> 

```dart
import 'package:flutter/material.dart';

void main() => runApp(const MyApp());

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      debugShowCheckedModeBanner: false,
      theme: ThemeData(useMaterial3: true),
      home: const Example(),
    );
  }
}

class Example extends StatelessWidget {
  const Example({super.key});

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: const Text('Sample'),
      ),
      body: Row(
        children: <Widget>[
          Expanded(
            child: Column(
              children: <Widget>[
                const Text('ListView'),
                Expanded(
                  child: ListView.builder(
                    itemCount: 50,
                    itemBuilder: (_, int index) {
                      return ColoredBox(
                        color: Theme.of(context).colorScheme.primaryContainer,
                        child: Center(
                          child: Text('$index', textAlign: TextAlign.center),
                        ),
                      );
                    },
                  ),
                ),
              ],
            ),
          ),
          const VerticalDivider(width: 4),
          Expanded(
            child: Column(
              children: <Widget>[
                const Text('AnimatedList'),
                Expanded(
                  child: AnimatedList(
                    initialItemCount: 50,
                    itemBuilder: (_, int index, __) {
                      return ColoredBox(
                        color: Theme.of(context).colorScheme.primaryContainer,
                        child: Center(
                          child: Text('$index', textAlign: TextAlign.center),
                        ),
                      );
                    },
                  ),
                ),
              ],
            ),
          ),
          const VerticalDivider(width: 4),
          Expanded(
              child: Column(
            children: <Widget>[
              const Text('AnimatedGrid'),
              Expanded(
                child: AnimatedGrid(
                  initialItemCount: 50,
                  gridDelegate: const SliverGridDelegateWithFixedCrossAxisCount(
                    crossAxisCount: 2,
                  ),
                  itemBuilder: (_, int index, __) {
                    return ColoredBox(
                      color: Theme.of(context).colorScheme.primaryContainer,
                      child: Center(
                        child: Text('$index', textAlign: TextAlign.center),
                      ),
                    );
                  },
                ),
              ),
            ],
          ))
        ],
      ),
    );
  }
}

``` 
	
</details>

### Before
![Before preview image](https://github.com/flutter/flutter/assets/48603081/73954a8a-9d1d-4b9e-b6a3-cae8071f3462)

### After
![After preview image](https://github.com/flutter/flutter/assets/48603081/9f1dc48a-622f-4402-8d5e-8e6e3e150165)

c8e42b47

Process only specific labels. (#129475) · bac05895
godofredoc authored Jun 26, 2023
```
To avoid trying to process all the open bugs in flutter/flutter.
```
bac05895

Roll Packages from d041934b296d to 6b70804799a9 (7 revisions) (#129559) · 4871391d

engine-flutter-autoroll authored Jun 26, 2023

https://github.com/flutter/packages/compare/d041934b296d...6b70804799a9

2023-06-23 47866232+chunhtai@users.noreply.github.com [go_router] Reduces excessive rebuilds due to inherited look up. (flutter/packages#4227)
2023-06-23 stuartmorgan@google.com [image_picker] Update to 1.0 (flutter/packages#4285)
2023-06-23 stuartmorgan@google.com [tool] Consider comment-only changes to be dev-only (flutter/packages#4279)
2023-06-23 stuartmorgan@google.com [ci] Switch to LUCI for Android build-all (flutter/packages#4274)
2023-06-23 stuartmorgan@google.com [file_selector] Add file group to save return value (flutter/packages#4222)
2023-06-23 47866232+chunhtai@users.noreply.github.com [go_router] Adds onException to GoRouter constructor. (flutter/packages#4216)
2023-06-23 stuartmorgan@google.com [file_selector] Add file group to save return value - implementations (flutter/packages#4273)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

4871391d

Make bug templates more consistent (#129460) · a20db068

Ian Hickson authored Jun 26, 2023

* remove trailing periods in template titles
* tweak the design doc template a little based on testing it out

a20db068

Roll Flutter Engine from be46101e952d to debee7cece49 (1 revision) (#129544) · da2b8723

engine-flutter-autoroll authored Jun 26, 2023

https://github.com/flutter/engine/compare/be46101e952d...debee7cece49

2023-06-26 skia-flutter-autoroll@skia.org Roll Skia from 5ea08db08587 to 6d89bc1acb7e (2 revisions) (flutter/engine#43194)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

da2b8723

Roll Flutter Engine from 88ff46e1efc1 to be46101e952d (2 revisions) (#129540) · fde39063

engine-flutter-autoroll authored Jun 26, 2023

https://github.com/flutter/engine/compare/88ff46e1efc1...be46101e952d

2023-06-26 skia-flutter-autoroll@skia.org Roll Skia from a20d58872fbe to 5ea08db08587 (1 revision) (flutter/engine#43193)
2023-06-26 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from XnZWRj5iNXgOHlVNi... to 3Y8TbEFhQUKOJBLQ4... (flutter/engine#43192)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from XnZWRj5iNXgO to 3Y8TbEFhQUKO

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

fde39063

Roll Flutter Engine from 317673b3278a to 88ff46e1efc1 (1 revision) (#129534) · c7f82a1c

engine-flutter-autoroll authored Jun 26, 2023

https://github.com/flutter/engine/compare/317673b3278a...88ff46e1efc1

2023-06-26 robert.ancell@canonical.com Allow event channels to reuse names (flutter/engine#41837)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

c7f82a1c

Roll Flutter Engine from 593e1d9a9cf5 to 317673b3278a (3 revisions) (#129531) · 8b6e1fde

engine-flutter-autoroll authored Jun 26, 2023

https://github.com/flutter/engine/compare/593e1d9a9cf5...317673b3278a

2023-06-25 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from uh5om9qyypCToIllT... to GkEyRw1Q2qLZWxitD... (flutter/engine#43190)
2023-06-25 skia-flutter-autoroll@skia.org Roll Skia from 7866f2c6ba52 to a20d58872fbe (1 revision) (flutter/engine#43191)
2023-06-25 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from w-DJY4dBZWS7lxsxE... to XnZWRj5iNXgOHlVNi... (flutter/engine#43188)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from w-DJY4dBZWS7 to XnZWRj5iNXgO
fuchsia/sdk/core/mac-amd64 from uh5om9qyypCT to GkEyRw1Q2qLZ

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

8b6e1fde

25 Jun, 2023 4 commits

Roll Flutter Engine from 5178e8ab7764 to 593e1d9a9cf5 (1 revision) (#129514) · b2e95013

engine-flutter-autoroll authored Jun 25, 2023

https://github.com/flutter/engine/compare/5178e8ab7764...593e1d9a9cf5

2023-06-25 skia-flutter-autoroll@skia.org Roll Skia from 18a947ed2253 to 7866f2c6ba52 (1 revision) (flutter/engine#43187)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

b2e95013

Roll Flutter Engine from 100f6fc854b4 to 5178e8ab7764 (1 revision) (#129508) · 42d2c2d5

engine-flutter-autoroll authored Jun 25, 2023

https://github.com/flutter/engine/compare/100f6fc854b4...5178e8ab7764

2023-06-25 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from N0MQ5J5y_hQoiOYs9... to uh5om9qyypCToIllT... (flutter/engine#43185)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from N0MQ5J5y_hQo to uh5om9qyypCT

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

42d2c2d5

Roll Flutter Engine from a9f446e25f0c to 100f6fc854b4 (1 revision) (#129498) · 176f7e63

engine-flutter-autoroll authored Jun 25, 2023

https://github.com/flutter/engine/compare/a9f446e25f0c...100f6fc854b4

2023-06-25 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from bjQLnDu32Oj0KUbrW... to w-DJY4dBZWS7lxsxE... (flutter/engine#43184)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from bjQLnDu32Oj0 to w-DJY4dBZWS7

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

176f7e63

Roll Flutter Engine from 5b1b98305768 to a9f446e25f0c (1 revision) (#129495) · c0f76fc9

engine-flutter-autoroll authored Jun 25, 2023

https://github.com/flutter/engine/compare/5b1b98305768...a9f446e25f0c

2023-06-24 bdero@google.com [Impeller] Supply surface cull rect for Vulkan & GLES dispatchers (flutter/engine#43152)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

c0f76fc9

24 Jun, 2023 12 commits

Roll Flutter Engine from 72c902ce3b81 to 5b1b98305768 (2 revisions) (#129493) · c442c6d4

engine-flutter-autoroll authored Jun 24, 2023

https://github.com/flutter/engine/compare/72c902ce3b81...5b1b98305768

2023-06-24 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from JF0sJRpJH8KiyyqrR... to N0MQ5J5y_hQoiOYs9... (flutter/engine#43180)
2023-06-24 bdero@google.com [Impeller] Disable blending for Source blend mode (flutter/engine#43162)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from JF0sJRpJH8Ki to N0MQ5J5y_hQo

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

c442c6d4

Roll Flutter Engine from f2976add9414 to 72c902ce3b81 (1 revision) (#129489) · 96a9773d

engine-flutter-autoroll authored Jun 24, 2023

https://github.com/flutter/engine/compare/f2976add9414...72c902ce3b81

2023-06-24 skia-flutter-autoroll@skia.org Roll Skia from 1826cbacd4da to 18a947ed2253 (1 revision) (flutter/engine#43178)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

96a9773d

Roll Flutter Engine from 76a5e971dc09 to f2976add9414 (1 revision) (#129487) · 6855b527

engine-flutter-autoroll authored Jun 24, 2023

https://github.com/flutter/engine/compare/76a5e971dc09...f2976add9414

2023-06-24 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from b5PDBUm8Hfx-y9Hsp... to bjQLnDu32Oj0KUbrW... (flutter/engine#43177)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from b5PDBUm8Hfx- to bjQLnDu32Oj0

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

6855b527

Roll Flutter Engine from 79fd6beea087 to 76a5e971dc09 (1 revision) (#129483) · fd9d13c2

engine-flutter-autoroll authored Jun 24, 2023

https://github.com/flutter/engine/compare/79fd6beea087...76a5e971dc09

2023-06-24 skia-flutter-autoroll@skia.org Roll Skia from 050d2ad6dda3 to 1826cbacd4da (2 revisions) (flutter/engine#43175)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

fd9d13c2

Roll Flutter Engine from 30ac9107f2f9 to 79fd6beea087 (1 revision) (#129479) · afa4cf7e

engine-flutter-autoroll authored Jun 24, 2023

https://github.com/flutter/engine/compare/30ac9107f2f9...79fd6beea087

2023-06-24 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from w-tUP3Ia2kfAaFNW1... to JF0sJRpJH8KiyyqrR... (flutter/engine#43174)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from w-tUP3Ia2kfA to JF0sJRpJH8Ki

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

afa4cf7e

Roll Flutter Engine from ee65380bf3fd to 30ac9107f2f9 (1 revision) (#129476) · cc76ed95

engine-flutter-autoroll authored Jun 24, 2023

https://github.com/flutter/engine/compare/ee65380bf3fd...30ac9107f2f9

2023-06-24 skia-flutter-autoroll@skia.org Roll Skia from ef64a8c132c4 to 050d2ad6dda3 (2 revisions) (flutter/engine#43171)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

cc76ed95

Roll Flutter Engine from 240a86f40781 to ee65380bf3fd (2 revisions) (#129474) · a8c68425

engine-flutter-autoroll authored Jun 24, 2023

https://github.com/flutter/engine/compare/240a86f40781...ee65380bf3fd

2023-06-24 skia-flutter-autoroll@skia.org Roll ANGLE from f834ba7fdab9 to 7169dc5fe003 (1 revision) (flutter/engine#43169)
2023-06-24 skia-flutter-autoroll@skia.org Roll Skia from 3d9732b86456 to ef64a8c132c4 (6 revisions) (flutter/engine#43170)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

a8c68425

Fix issues with no response bot. (#129470) · 0f006ea0
godofredoc authored Jun 24, 2023
```
This is also increasing the number of items to be evaluated on each iteration.
```
0f006ea0

Roll Flutter Engine from 5e6dcf959ea0 to 240a86f40781 (1 revision) (#129473) · e058ceb6

engine-flutter-autoroll authored Jun 24, 2023

https://github.com/flutter/engine/compare/5e6dcf959ea0...240a86f40781

2023-06-24 godofredoc@google.com Add docs for magic variables. (flutter/engine#43121)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

e058ceb6

Roll Flutter Engine from 550bfedc8760 to 5e6dcf959ea0 (1 revision) (#129468) · 1d5aeea4

engine-flutter-autoroll authored Jun 24, 2023

https://github.com/flutter/engine/compare/550bfedc8760...5e6dcf959ea0

2023-06-24 skia-flutter-autoroll@skia.org Roll Skia from 8818761fbc84 to 3d9732b86456 (4 revisions) (flutter/engine#43167)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

1d5aeea4

Roll Flutter Engine from c1abd1f17ab1 to 550bfedc8760 (3 revisions) (#129466) · c39bc1d9

engine-flutter-autoroll authored Jun 24, 2023

https://github.com/flutter/engine/compare/c1abd1f17ab1...550bfedc8760

2023-06-23 bdero@google.com [Impeller] Label present waiter command buffer in SurfaceMTL (flutter/engine#43165)
2023-06-23 tamird@google.com Add tmp storage capability to flutter runner (flutter/engine#43157)
2023-06-23 skia-flutter-autoroll@skia.org Roll Skia from c53a952a2dab to 8818761fbc84 (5 revisions) (flutter/engine#43164)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

c39bc1d9

[devicelab] Add platform view scroll benchmarks for Impeller on Android (#129455) · b898d1d2
Brandon DeRosier authored Jun 24, 2023
```
For tracking perf improvements with changes like
https://github.com/flutter/engine/pull/43152.
```
b898d1d2

23 Jun, 2023 11 commits

Roll Flutter Engine from eca910dd5e3f to c1abd1f17ab1 (3 revisions) (#129456) · 813fc3bb

engine-flutter-autoroll authored Jun 23, 2023

https://github.com/flutter/engine/compare/eca910dd5e3f...c1abd1f17ab1

2023-06-23 skia-flutter-autoroll@skia.org Roll ANGLE from 566f1ee4657c to f834ba7fdab9 (1 revision) (flutter/engine#43158)
2023-06-23 skia-flutter-autoroll@skia.org Roll Skia from d53ea1557b35 to c53a952a2dab (1 revision) (flutter/engine#43156)
2023-06-23 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from VSKvLPB4DCIDvXzOA... to b5PDBUm8Hfx-y9Hsp... (flutter/engine#43155)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from VSKvLPB4DCID to b5PDBUm8Hfx-

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

813fc3bb

Roll Flutter Engine from f8a39cb4dc56 to eca910dd5e3f (3 revisions) (#129451) · be803a7d

engine-flutter-autoroll authored Jun 23, 2023

https://github.com/flutter/engine/compare/f8a39cb4dc56...eca910dd5e3f

2023-06-23 110993981+htoor3@users.noreply.github.com [web] - Fix for Safari partially autofilling form (flutter/engine#43058)
2023-06-23 skia-flutter-autoroll@skia.org Roll ANGLE from bc2d5ed01f27 to 566f1ee4657c (1 revision) (flutter/engine#43154)
2023-06-23 skia-flutter-autoroll@skia.org Roll Skia from 7b6aae68a11f to d53ea1557b35 (1 revision) (flutter/engine#43153)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

be803a7d

Roll Flutter Engine from 74ef61859bdc to f8a39cb4dc56 (2 revisions) (#129445) · 80f8bf11

engine-flutter-autoroll authored Jun 23, 2023

https://github.com/flutter/engine/compare/74ef61859bdc...f8a39cb4dc56

2023-06-23 skia-flutter-autoroll@skia.org Roll ANGLE from 2e285bb591f7 to bc2d5ed01f27 (1 revision) (flutter/engine#43151)
2023-06-23 chinmaygarde@google.com [Impeller] FenceWaiterVK: Move potentially slow calls out of wait set mutex critical section. (flutter/engine#43131)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

80f8bf11

Add CallbackShortcuts widget of the week video (#129296) · e1e2ebd1
Loïc Sharma authored Jun 23, 2023

e1e2ebd1

Roll Flutter Engine from 060cd9c17df3 to 74ef61859bdc (3 revisions) (#129444) · b136f5f9

engine-flutter-autoroll authored Jun 23, 2023

https://github.com/flutter/engine/compare/060cd9c17df3...74ef61859bdc

2023-06-23 godofredoc@google.com Remove master mirroring workflow. (flutter/engine#42681)
2023-06-23 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from 07vKo_Vaiy_Vw2xxb... to w-tUP3Ia2kfAaFNW1... (flutter/engine#43148)
2023-06-23 skia-flutter-autoroll@skia.org Roll Skia from 9635d54210dc to 7b6aae68a11f (5 revisions) (flutter/engine#43147)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from 07vKo_Vaiy_V to w-tUP3Ia2kfA

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

b136f5f9

Roll Flutter Engine from cd30a48ef889 to 060cd9c17df3 (3 revisions) (#129440) · fb90a49e

engine-flutter-autoroll authored Jun 23, 2023

https://github.com/flutter/engine/compare/cd30a48ef889...060cd9c17df3

2023-06-23 chillers@google.com [impeller] Explicitly cast enum class to int before passing it to a formatted string (flutter/engine#43139)
2023-06-23 54558023+keyonghan@users.noreply.github.com Add osx_sdk context to mac_clang_tidy (flutter/engine#43115)
2023-06-23 jonahwilliams@google.com [Impeller] re-enable buffer to texture blit Vulkan. (flutter/engine#43129)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

fb90a49e

Roll Flutter Engine from 27f3498286ff to cd30a48ef889 (4 revisions) (#129437) · 935652c3

engine-flutter-autoroll authored Jun 23, 2023

https://github.com/flutter/engine/compare/27f3498286ff...cd30a48ef889

2023-06-23 skia-flutter-autoroll@skia.org Roll Skia from 04fa1c1ef69c to 9635d54210dc (2 revisions) (flutter/engine#43145)
2023-06-23 skia-flutter-autoroll@skia.org Roll ANGLE from 9211ebf1f2ac to 2e285bb591f7 (1 revision) (flutter/engine#43144)
2023-06-23 34871572+gmackall@users.noreply.github.com Add a note in ImeSyncDeferringInsetsCallback explaining the reason behind capturing the latest final inset state (flutter/engine#43109)
2023-06-23 skia-flutter-autoroll@skia.org Roll Skia from 6ab865ee1f65 to 04fa1c1ef69c (1 revision) (flutter/engine#43141)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

935652c3

Add a devicelab test to recipes cq. (#129411) · 929468e1

godofredoc authored Jun 23, 2023

This is to ensure the devicelab_drone recipe is tested on presubmit.

Bug: https://github.com/flutter/flutter/issues/126111

929468e1

fix: Inconsistency of SelectionArea when scrolling (#128765) · a9164a4d

Paurakh Sharma Humagain authored Jun 23, 2023

This PR fixes inconsistency of SelectionArea when scrolling by removing the `_clearSelection` on `longPressUpdate` gesture. This in turn makes the selection UX much better.

*List which issues are fixed by this PR. You must list at least one issue.*
Fixes: https://github.com/flutter/flutter/issues/120892

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*

a9164a4d

Run misc test shard when examples/api/** change (#129433) · 309e5017

Kate Lovett authored Jun 23, 2023

Fixes https://github.com/flutter/flutter/issues/129390

Found in https://github.com/flutter/flutter/pull/129381, changing sample code in `examples/api` did not trigger the misc test shard that executes the tests for `examples/api`.

309e5017

Bump ubuntu from `b795f8e` to `db8bf6f` in /dev/ci/docker_linux (#128740) · fcb54add

dependabot[bot] authored Jun 23, 2023

Bumps ubuntu from `b795f8e` to `db8bf6f`.

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=ubuntu&package-manager=docker&previous-version=focal&new-version=focal)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

fcb54add