Unverified Commit fbe9ff33 authored by Jason Simmons's avatar Jason Simmons Committed by GitHub

Disable an inaccurate test assertion that will be fixed by an engine roll (#119653)

https://skia-review.googlesource.com/c/skia/+/619838 fixes a bug in
SkParagraph.  One of the selectable region tests relies on the old
behavior.

After that Skia change rolls into the framework, the update to the test
in https://github.com/flutter/flutter/pull/118902 should be landed.
parent 60c1f293
......@@ -842,7 +842,8 @@ void main() {
// Add a little offset to cross the boundary between paragraph 2 and 3.
await gesture.moveTo(textOffsetToPosition(paragraph3, 6) + const Offset(0, 1));
expect(paragraph1.selections[0], const TextSelection(baseOffset: 2, extentOffset: 12));
expect(paragraph2.selections[0], const TextSelection(baseOffset: 0, extentOffset: 8));
// TODO(jsimmons): reenable this with updated expectations after https://skia-review.googlesource.com/c/skia/+/619838 lands
//expect(paragraph2.selections[0], const TextSelection(baseOffset: 0, extentOffset: 8));
expect(paragraph3.selections[0], const TextSelection(baseOffset: 0, extentOffset: 6));
await gesture.up();
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment