Reverts "Changing `TextPainter.getOffsetForCaret` implementation to remove the...

Reverts "Changing `TextPainter.getOffsetForCaret` implementation to remove the logarithmic search (#143281)" (#143801)

Reverts flutter/flutter#143281

Initiated by: LongCatIsLooong

Reason for reverting: https://github.com/flutter/flutter/issues/143797

Original PR Author: LongCatIsLooong

Reviewed By: {justinmc, jason-simmons}

This change reverts the following previous change:
Original Description:
The behavior largely remains the same, except:

1. The EOT cursor `(textLength, downstream)` for text ending in the opposite writing direction as the paragraph is now placed at the visual end of the last line. 
  For example, in a LTR paragraph, the EOT cursor for `aA` (lowercase for LTR and uppercase for RTL) is placed to the right of the line: `aA|` (it was `a|A` before). 
  This matches the behavior of most applications that do logical order arrow key navigation instead of visual order navigation. 
  And it makes the navigation order consistent for `aA\naA`:
```
  |aA    =>  aA|  => aA|  => aA  => aA   => aA 
   aA        aA      aA     |aA     aA|     aA|     
   (1)       (2)     (3)    (4)    (5)      (6)
```
This is indeed still pretty confusing as (2) and (3), as well as (5) and (6) are hard to distinguish (when the I beam has a large width they are actually visually distinguishable -- they use the same anchor but one gets painted to the left and the other to the right. I noticed that emacs does the same). 
But logical order navigation will always be confusing in bidi text, in one way or another.

Interestingly there are 3 different behaviors I've observed in chrome:
- the chrome download dialog (which I think uses GTK text widgets but not sure which version) gives me 2 cursors when navigating bidi text, and 
- its HTML fields only show one, and presumably they place the I beam at the **trailing edge** of the character (which makes more sense for backspacing I guess). 
- On the other hand, its (new) omnibar seems to use visual order arrow navigation

Side note: we may need to update the "tap to place the caret here" logic to handle the case where the tap lands outside of the text and the text ends in the opposite writing direction. 

2. Removed the logarithmic search. The same could be done using the characters package but when glyphInfo tells you about the baseline location in the future we probably don't need the `getBoxesForRange` call. This should fix https://github.com/flutter/flutter/issues/123424.

## Internal Tests

This is going to change the image output of some internal golden tests. I'm planning to merge https://github.com/flutter/flutter/pull/143281 before this to avoid updating the same golden files twice for invalid selections.

examples/api/test/widgets/text_magnifier/text_magnifier.0_test.dart

@@ -46,9 +46,8 @@ void main() {
   const Duration durationBetweenActions = Duration(milliseconds: 20);
   const String defaultText = 'I am a magnifier, fear me!';
 
-  Future<void> showMagnifier(WidgetTester tester, int textOffset) async {
-    assert(textOffset >= 0);
-    final Offset tapOffset = _textOffsetToPosition(tester, textOffset);
+  Future<void> showMagnifier(WidgetTester tester, String characterToTapOn) async {
+    final Offset tapOffset = _textOffsetToPosition(tester, defaultText.indexOf(characterToTapOn));
 
     // Double tap 'Magnifier' word to show the selection handles.
     final TestGesture testGesture = await tester.startGesture(tapOffset);
@@ -60,11 +59,11 @@ void main() {
     await testGesture.up();
     await tester.pumpAndSettle();
 
-    final TextEditingController controller = tester
+    final TextSelection selection = tester
         .firstWidget<TextField>(find.byType(TextField))
-      .controller!;
+        .controller!
+        .selection;
 
-    final TextSelection selection = controller.selection;
     final RenderEditable renderEditable = _findRenderEditable(tester);
     final List<TextSelectionPoint> endpoints = _globalize(
       renderEditable.getEndpointsForSelection(selection),
@@ -87,7 +86,7 @@ void main() {
   testWidgets('should show custom magnifier on drag', (WidgetTester tester) async {
     await tester.pumpWidget(const example.TextMagnifierExampleApp(text: defaultText));
 
-    await showMagnifier(tester, defaultText.indexOf('e'));
+    await showMagnifier(tester, 'e');
     expect(find.byType(example.CustomMagnifier), findsOneWidget);
 
     await expectLater(
@@ -97,15 +96,16 @@ void main() {
   }, variant: const TargetPlatformVariant(<TargetPlatform>{ TargetPlatform.iOS, TargetPlatform.android }));
 
 
-  testWidgets('should show custom magnifier in RTL', (WidgetTester tester) async {
-    const String text = 'أثارت زر';
-    const String textToTapOn = 'ت';
+  for (final TextDirection textDirection in TextDirection.values) {
+    testWidgets('should show custom magnifier in $textDirection', (WidgetTester tester) async {
+      final String text = textDirection == TextDirection.rtl ? 'أثارت زر' : defaultText;
+      final String textToTapOn = textDirection == TextDirection.rtl ? 'ت' : 'e';
 
-    await tester.pumpWidget(const example.TextMagnifierExampleApp(textDirection: TextDirection.rtl, text: text));
+      await tester.pumpWidget(example.TextMagnifierExampleApp(textDirection: textDirection, text: text));
 
-    await showMagnifier(tester, text.indexOf(textToTapOn));
+      await showMagnifier(tester, textToTapOn);
 
       expect(find.byType(example.CustomMagnifier), findsOneWidget);
     });
-
+  }
 }

packages/flutter/test/cupertino/text_field_test.dart

@@ -6941,7 +6941,7 @@ void main() {
       // the arrow should not point exactly to the caret because the caret is
       // too close to the right.
       controller.dispose();
-      controller = TextEditingController(text: 'a' * 200);
+      controller = TextEditingController(text: List<String>.filled(200, 'a').join());
       await tester.pumpWidget(
         CupertinoApp(
           debugShowCheckedModeBanner: false,
@@ -7002,7 +7002,7 @@ void main() {
       // Normal centered collapsed selection. The toolbar arrow should point down, and
       // it should point exactly to the caret.
       controller.dispose();
-      controller = TextEditingController(text: 'a' * 200);
+      controller = TextEditingController(text: List<String>.filled(200, 'a').join());
       addTearDown(controller.dispose);
       await tester.pumpWidget(
         CupertinoApp(

packages/flutter/test/material/text_field_test.dart

@@ -15222,8 +15222,6 @@ void main() {
     bool isWide = false;
     const double wideWidth = 300.0;
     const double narrowWidth = 200.0;
-    const TextStyle style = TextStyle(fontSize: 10, height: 1.0, letterSpacing: 0.0, wordSpacing: 0.0);
-    const double caretWidth = 2.0;
     final TextEditingController controller = _textEditingController();
     await tester.pumpWidget(
       boilerplate(
@@ -15236,7 +15234,6 @@ void main() {
                 key: textFieldKey,
                 controller: controller,
                 textDirection: TextDirection.rtl,
-                style: style,
               ),
             );
           },
@@ -15253,17 +15250,15 @@ void main() {
     expect(inputWidth, narrowWidth);
     expect(cursorRight, inputWidth - kCaretGap);
 
-    const String text = '12345';
-    // After entering some text, the cursor is placed to the left of the text
-    // because the paragraph's writing direction is RTL.
-    await tester.enterText(find.byType(TextField), text);
+    // After entering some text, the cursor remains on the right of the input.
+    await tester.enterText(find.byType(TextField), '12345');
     await tester.pump();
     editable = findRenderEditable(tester);
     cursorRight = editable.getLocalRectForCaret(
       TextPosition(offset: controller.value.text.length),
     ).topRight.dx;
     inputWidth = editable.size.width;
-    expect(cursorRight, inputWidth - kCaretGap - text.length * 10 - caretWidth);
+    expect(cursorRight, inputWidth - kCaretGap);
 
     // Since increasing the width of the input moves its right edge further to
     // the right, the cursor has followed this change and still appears on the
@@ -15278,7 +15273,7 @@ void main() {
     ).topRight.dx;
     inputWidth = editable.size.width;
     expect(inputWidth, wideWidth);
-    expect(cursorRight, inputWidth - kCaretGap - text.length * 10 - caretWidth);
+    expect(cursorRight, inputWidth - kCaretGap);
   });
 
   testWidgets('Text selection menu hides after select all on desktop', (WidgetTester tester) async {

packages/flutter/test/painting/text_painter_rtl_test.dart

@@ -301,9 +301,9 @@ void main() {
       painter.getOffsetForCaret(const TextPosition(offset: 2, affinity: TextAffinity.upstream), Rect.zero),
       const Offset(0.0, 10.0),
     );
-    expect( // To the right of the Alef
+    expect( // after the Alef
       painter.getOffsetForCaret(const TextPosition(offset: 2), Rect.zero),
-      const Offset(10.0, 10.0),
+      const Offset(0.0, 10.0),
     );
 
     expect(

packages/flutter/test/widgets/editable_text_cursor_test.dart

@@ -976,7 +976,7 @@ void main() {
     expect(find.byType(EditableText), paints
       ..rrect(
         rrect: RRect.fromRectAndRadius(
-          const Rect.fromLTWH(193.83334350585938, -0.916666666666668, 3.0, 20.0),
+          const Rect.fromLTRB(193.83334350585938, -0.916666666666668, 196.83334350585938, 19.083333969116211),
           const Radius.circular(1.0),
         ),
         color: const Color(0xbf2196f3),
@@ -994,7 +994,7 @@ void main() {
     expect(find.byType(EditableText), paints
       ..rrect(
         rrect: RRect.fromRectAndRadius(
-          const Rect.fromLTWH(719.3333333333333, -0.9166666666666679, 2.0, 18.0),
+          const Rect.fromLTRB(719.3333333333333, -0.9166666666666679, 721.3333333333333, 17.083333333333332),
           const Radius.circular(2.0),
         ),
         color: const Color(0xff999999),