Unverified Commit f945079c authored by Christopher Fujino's avatar Christopher Fujino Committed by GitHub

remove fallback code for ios/usb artifacts (#39585)

parent b2da79ce
...@@ -39,14 +39,8 @@ class IOSDeploy { ...@@ -39,14 +39,8 @@ class IOSDeploy {
@required List<String> launchArguments, @required List<String> launchArguments,
}) async { }) async {
final String iosDeployPath = artifacts.getArtifactPath(Artifact.iosDeploy, platform: TargetPlatform.ios); final String iosDeployPath = artifacts.getArtifactPath(Artifact.iosDeploy, platform: TargetPlatform.ios);
// TODO(fujino): remove fallback once g3 updated
const List<String> fallbackIosDeployPath = <String>[
'/usr/bin/env',
'ios-deploy',
];
final List<String> commandList = iosDeployPath != null ? <String>[iosDeployPath] : fallbackIosDeployPath;
final List<String> launchCommand = <String>[ final List<String> launchCommand = <String>[
...commandList, iosDeployPath,
'--id', '--id',
deviceId, deviceId,
'--bundle', '--bundle',
...@@ -135,11 +129,11 @@ class IOSDevice extends Device { ...@@ -135,11 +129,11 @@ class IOSDevice extends Device {
_installerPath = artifacts.getArtifactPath( _installerPath = artifacts.getArtifactPath(
Artifact.ideviceinstaller, Artifact.ideviceinstaller,
platform: TargetPlatform.ios, platform: TargetPlatform.ios,
) ?? 'ideviceinstaller'; // TODO(fujino): remove fallback once g3 updated );
_iproxyPath = artifacts.getArtifactPath( _iproxyPath = artifacts.getArtifactPath(
Artifact.iproxy, Artifact.iproxy,
platform: TargetPlatform.ios platform: TargetPlatform.ios
) ?? 'iproxy'; // TODO(fujino): remove fallback once g3 updated );
} }
String _installerPath; String _installerPath;
......
...@@ -94,17 +94,12 @@ class LockdownReturnCode { ...@@ -94,17 +94,12 @@ class LockdownReturnCode {
class IMobileDevice { class IMobileDevice {
IMobileDevice() IMobileDevice()
: _ideviceIdPath = artifacts.getArtifactPath(Artifact.ideviceId, platform: TargetPlatform.ios) : _ideviceIdPath = artifacts.getArtifactPath(Artifact.ideviceId, platform: TargetPlatform.ios),
?? 'idevice_id', // TODO(fujino): remove fallback once g3 updated _ideviceinfoPath = artifacts.getArtifactPath(Artifact.ideviceinfo, platform: TargetPlatform.ios),
_ideviceinfoPath = artifacts.getArtifactPath(Artifact.ideviceinfo, platform: TargetPlatform.ios) _idevicenamePath = artifacts.getArtifactPath(Artifact.idevicename, platform: TargetPlatform.ios),
?? 'ideviceinfo', // TODO(fujino): remove fallback once g3 updated _idevicesyslogPath = artifacts.getArtifactPath(Artifact.idevicesyslog, platform: TargetPlatform.ios),
_idevicenamePath = artifacts.getArtifactPath(Artifact.idevicename, platform: TargetPlatform.ios) _idevicescreenshotPath = artifacts.getArtifactPath(Artifact.idevicescreenshot, platform: TargetPlatform.ios);
?? 'idevicename', // TODO(fujino): remove fallback once g3 updated
_idevicesyslogPath = artifacts.getArtifactPath(Artifact.idevicesyslog, platform: TargetPlatform.ios)
?? 'idevicesyslog', // TODO(fujino): remove fallback once g3 updated
_idevicescreenshotPath = artifacts.getArtifactPath(Artifact.idevicescreenshot, platform: TargetPlatform.ios)
?? 'idevicescreenshot' { // TODO(fujino): remove fallback once g3 updated
}
final String _ideviceIdPath; final String _ideviceIdPath;
final String _ideviceinfoPath; final String _ideviceinfoPath;
final String _idevicenamePath; final String _idevicenamePath;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment