Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
f8a5baf3
Unverified
Commit
f8a5baf3
authored
Oct 15, 2019
by
Jonah Williams
Committed by
GitHub
Oct 15, 2019
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Dont close debug connection on exit (#42655)
parent
0dce0c6e
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
4 additions
and
2 deletions
+4
-2
resident_web_runner.dart
...utter_tools/lib/src/build_runner/resident_web_runner.dart
+0
-1
resident_web_runner_test.dart
...er_tools/test/general.shard/resident_web_runner_test.dart
+4
-1
No files found.
packages/flutter_tools/lib/src/build_runner/resident_web_runner.dart
View file @
f8a5baf3
...
@@ -108,7 +108,6 @@ class ResidentWebRunner extends ResidentRunner {
...
@@ -108,7 +108,6 @@ class ResidentWebRunner extends ResidentRunner {
if
(
_exited
)
{
if
(
_exited
)
{
return
;
return
;
}
}
await
_connectionResult
?.
debugConnection
?.
close
();
await
_stdOutSub
?.
cancel
();
await
_stdOutSub
?.
cancel
();
await
_webFs
?.
stop
();
await
_webFs
?.
stop
();
await
device
.
stopApp
(
null
);
await
device
.
stopApp
(
null
);
...
...
packages/flutter_tools/test/general.shard/resident_web_runner_test.dart
View file @
f8a5baf3
...
@@ -431,11 +431,12 @@ void main() {
...
@@ -431,11 +431,12 @@ void main() {
test
(
'cleanup of resources is safe to call multiple times'
,
()
=>
testbed
.
run
(()
async
{
test
(
'cleanup of resources is safe to call multiple times'
,
()
=>
testbed
.
run
(()
async
{
_setupMocks
();
_setupMocks
();
bool
debugClosed
=
false
;
bool
debugClosed
=
false
;
when
(
mock
DebugConnection
.
close
(
)).
thenAnswer
((
Invocation
invocation
)
async
{
when
(
mock
WebDevice
.
stopApp
(
any
)).
thenAnswer
((
Invocation
invocation
)
async
{
if
(
debugClosed
)
{
if
(
debugClosed
)
{
throw
StateError
(
'debug connection closed twice'
);
throw
StateError
(
'debug connection closed twice'
);
}
}
debugClosed
=
true
;
debugClosed
=
true
;
return
true
;
});
});
final
Completer
<
DebugConnectionInfo
>
connectionInfoCompleter
=
Completer
<
DebugConnectionInfo
>();
final
Completer
<
DebugConnectionInfo
>
connectionInfoCompleter
=
Completer
<
DebugConnectionInfo
>();
unawaited
(
residentWebRunner
.
run
(
unawaited
(
residentWebRunner
.
run
(
...
@@ -445,6 +446,8 @@ void main() {
...
@@ -445,6 +446,8 @@ void main() {
await
residentWebRunner
.
exit
();
await
residentWebRunner
.
exit
();
await
residentWebRunner
.
exit
();
await
residentWebRunner
.
exit
();
verifyNever
(
mockDebugConnection
.
close
());
}));
}));
test
(
'Prints target and device name on run'
,
()
=>
testbed
.
run
(()
async
{
test
(
'Prints target and device name on run'
,
()
=>
testbed
.
run
(()
async
{
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment