Unverified Commit f685568d authored by Chris Bracken's avatar Chris Bracken Committed by GitHub

Update a TODO with issue number (#17494)

Further digging revealed that the reason --no-sim-use-hardfp was
required to be specified explicitly was that Android engine gen_snapshot
binaries are built on Windows with target_os=win.
parent e8d99d12
...@@ -224,7 +224,7 @@ class AOTSnapshotter { ...@@ -224,7 +224,7 @@ class AOTSnapshotter {
if (platform == TargetPlatform.android_arm || iosArch == IOSArch.armv7) { if (platform == TargetPlatform.android_arm || iosArch == IOSArch.armv7) {
// Use softfp for Android armv7 devices. // Use softfp for Android armv7 devices.
// Note that this is the default for armv7 iOS builds, but harmless to set. // Note that this is the default for armv7 iOS builds, but harmless to set.
// TODO(cbracken) use TargetPlatform-specific gen_snapshot for Android so that this is defaulted. // TODO(cbracken) eliminate this when we fix https://github.com/flutter/flutter/issues/17489
genSnapshotArgs.add('--no-sim-use-hardfp'); genSnapshotArgs.add('--no-sim-use-hardfp');
// Not supported by the Pixel in 32-bit mode. // Not supported by the Pixel in 32-bit mode.
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment