Unverified Commit f5eb12cd authored by Jonah Williams's avatar Jonah Williams Committed by GitHub

filter error message from skip build script checks (#39558)

parent a3e37939
...@@ -301,6 +301,11 @@ class WebFs { ...@@ -301,6 +301,11 @@ class WebFs {
class BuildDaemonCreator { class BuildDaemonCreator {
const BuildDaemonCreator(); const BuildDaemonCreator();
// TODO(jonahwilliams): find a way to get build checks working for flutter for web.
static const String _ignoredLine1 = 'Warning: Interpreting this as package URI';
static const String _ignoredLine2 = 'build_script.dart was not found in the asset graph, incremental builds will not work';
static const String _ignoredLine3 = 'have your dependencies specified fully in your pubspec.yaml';
/// Start a build daemon and register the web targets. /// Start a build daemon and register the web targets.
Future<BuildDaemonClient> startBuildDaemon(String workingDirectory, {bool release = false, bool profile = false }) async { Future<BuildDaemonClient> startBuildDaemon(String workingDirectory, {bool release = false, bool profile = false }) async {
try { try {
...@@ -360,9 +365,10 @@ class BuildDaemonCreator { ...@@ -360,9 +365,10 @@ class BuildDaemonCreator {
switch (serverLog.level) { switch (serverLog.level) {
case Level.SEVERE: case Level.SEVERE:
case Level.SHOUT: case Level.SHOUT:
// This message is always returned once since we're running the // Ignore certain non-actionable messages on startup.
// build script from source. if (serverLog.message.contains(_ignoredLine1) ||
if (serverLog.message.contains('Warning: Interpreting this as package URI')) { serverLog.message.contains(_ignoredLine2) ||
serverLog.message.contains(_ignoredLine3)) {
return; return;
} }
printError(serverLog.message); printError(serverLog.message);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment