Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
f44b277f
Unverified
Commit
f44b277f
authored
Oct 03, 2018
by
jslavitz
Committed by
GitHub
Oct 03, 2018
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Custom offset functionality for Popup Menu Button (#22534)
* Adds offset functionality to popup menu * Adds a test
parent
aa6a27e8
Changes
2
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
48 additions
and
1 deletion
+48
-1
popup_menu.dart
packages/flutter/lib/src/material/popup_menu.dart
+9
-1
popup_menu_test.dart
packages/flutter/test/material/popup_menu_test.dart
+39
-0
No files found.
packages/flutter/lib/src/material/popup_menu.dart
View file @
f44b277f
...
@@ -820,7 +820,9 @@ class PopupMenuButton<T> extends StatefulWidget {
...
@@ -820,7 +820,9 @@ class PopupMenuButton<T> extends StatefulWidget {
this
.
padding
=
const
EdgeInsets
.
all
(
8.0
),
this
.
padding
=
const
EdgeInsets
.
all
(
8.0
),
this
.
child
,
this
.
child
,
this
.
icon
,
this
.
icon
,
this
.
offset
=
Offset
.
zero
,
})
:
assert
(
itemBuilder
!=
null
),
})
:
assert
(
itemBuilder
!=
null
),
assert
(
offset
!=
null
),
assert
(!(
child
!=
null
&&
icon
!=
null
)),
// fails if passed both parameters
assert
(!(
child
!=
null
&&
icon
!=
null
)),
// fails if passed both parameters
super
(
key:
key
);
super
(
key:
key
);
...
@@ -864,6 +866,12 @@ class PopupMenuButton<T> extends StatefulWidget {
...
@@ -864,6 +866,12 @@ class PopupMenuButton<T> extends StatefulWidget {
/// If provided, the icon used for this button.
/// If provided, the icon used for this button.
final
Icon
icon
;
final
Icon
icon
;
/// The offset applied to the Popup Menu Button.
///
/// When not set, the Popup Menu Button will be positioned directly next to
/// the button that was used to create it.
final
Offset
offset
;
@override
@override
_PopupMenuButtonState
<
T
>
createState
()
=>
_PopupMenuButtonState
<
T
>();
_PopupMenuButtonState
<
T
>
createState
()
=>
_PopupMenuButtonState
<
T
>();
}
}
...
@@ -874,7 +882,7 @@ class _PopupMenuButtonState<T> extends State<PopupMenuButton<T>> {
...
@@ -874,7 +882,7 @@ class _PopupMenuButtonState<T> extends State<PopupMenuButton<T>> {
final
RenderBox
overlay
=
Overlay
.
of
(
context
).
context
.
findRenderObject
();
final
RenderBox
overlay
=
Overlay
.
of
(
context
).
context
.
findRenderObject
();
final
RelativeRect
position
=
RelativeRect
.
fromRect
(
final
RelativeRect
position
=
RelativeRect
.
fromRect
(
Rect
.
fromPoints
(
Rect
.
fromPoints
(
button
.
localToGlobal
(
Offset
.
zero
,
ancestor:
overlay
),
button
.
localToGlobal
(
widget
.
offset
,
ancestor:
overlay
),
button
.
localToGlobal
(
button
.
size
.
bottomRight
(
Offset
.
zero
),
ancestor:
overlay
),
button
.
localToGlobal
(
button
.
size
.
bottomRight
(
Offset
.
zero
),
ancestor:
overlay
),
),
),
Offset
.
zero
&
overlay
.
size
,
Offset
.
zero
&
overlay
.
size
,
...
...
packages/flutter/test/material/popup_menu_test.dart
View file @
f44b277f
...
@@ -430,6 +430,45 @@ void main() {
...
@@ -430,6 +430,45 @@ void main() {
expect
(
MediaQuery
.
of
(
popupContext
).
padding
,
EdgeInsets
.
zero
);
expect
(
MediaQuery
.
of
(
popupContext
).
padding
,
EdgeInsets
.
zero
);
});
});
testWidgets
(
'Popup Menu Offset Test'
,
(
WidgetTester
tester
)
async
{
const
Offset
offset
=
Offset
(
100.0
,
100.0
);
final
PopupMenuButton
<
int
>
popupMenuButton
=
PopupMenuButton
<
int
>(
offset:
offset
,
itemBuilder:
(
BuildContext
context
)
{
return
<
PopupMenuItem
<
int
>>[
PopupMenuItem
<
int
>(
value:
1
,
child:
Builder
(
builder:
(
BuildContext
context
)
{
return
const
Text
(
'AAA'
);
},
),
),
];
},
);
await
tester
.
pumpWidget
(
MaterialApp
(
home:
Scaffold
(
body:
Center
(
child:
Material
(
child:
popupMenuButton
,
),
)
),
),
);
await
tester
.
tap
(
find
.
byType
(
IconButton
));
await
tester
.
pumpAndSettle
();
// The position is different than the offset because the default position isn't at the origin.
expect
(
tester
.
getTopLeft
(
find
.
byWidgetPredicate
((
Widget
w
)
=>
'
${w.runtimeType}
'
==
'_PopupMenu<int>'
)),
const
Offset
(
364.0
,
324.0
));
});
testWidgets
(
'open PopupMenu has correct semantics'
,
(
WidgetTester
tester
)
async
{
testWidgets
(
'open PopupMenu has correct semantics'
,
(
WidgetTester
tester
)
async
{
final
SemanticsTester
semantics
=
SemanticsTester
(
tester
);
final
SemanticsTester
semantics
=
SemanticsTester
(
tester
);
await
tester
.
pumpWidget
(
MaterialApp
(
await
tester
.
pumpWidget
(
MaterialApp
(
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment