Remove codesign command from conductor. (#141044)

Codesigning is now automated and the codesigning tests have been migrated to shard tests.

dev/conductor/README.md

@@ -90,13 +90,6 @@ Once a PR is opened, the user must validate CI builds. If there are regressions
 output of the failing test), then the user must fix these tests in their local
 checkout and push their changes again.
 
-### Codesign Engine Binaries
-
-The user must validate post-submit CI builds for their merged engine PR have
-passed. A link to the web dashboard is available via `conductor status`. Once
-the post-submit CI builds have all passed, the user must codesign engine
-binaries for the **merged** engine commit.
-
 ### Apply Framework Cherrypicks
 
 The tool will attempt to auto-apply all framework cherrypicks. However, any

dev/conductor/core/bin/cli.dart

@@ -46,10 +46,6 @@ Future<void> main(List<String> args) async {
   )).trim();
 
   <Command<void>>[
-    CodesignCommand(
-      checkouts: checkouts,
-      flutterRoot: _localFlutterRoot,
-    ),
     StatusCommand(
       checkouts: checkouts,
     ),

dev/conductor/core/lib/conductor_core.dart

@@ -6,7 +6,6 @@
 
 export 'src/candidates.dart';
 export 'src/clean.dart';
-export 'src/codesign.dart';
 export 'src/git.dart';
 export 'src/globals.dart';
 export 'src/next.dart' hide kStateOption, kYesFlag;

dev/conductor/core/test/codesign_integration_test.dart

-// Copyright 2014 The Flutter Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-// This test clones the framework and downloads pre-built binaries; it sometimes
-// times out with the default 5 minutes: https://github.com/flutter/flutter/issues/100937
-@Timeout(Duration(minutes: 10))
-library;
-
-import 'package:args/command_runner.dart';
-import 'package:conductor_core/src/codesign.dart' show CodesignCommand;
-import 'package:conductor_core/src/globals.dart';
-import 'package:conductor_core/src/repository.dart' show Checkouts, FrameworkRepository;
-import 'package:file/file.dart';
-import 'package:file/local.dart';
-import 'package:platform/platform.dart';
-import 'package:process/process.dart';
-
-import './common.dart';
-
-/// Verify all binaries in the Flutter cache are expected by Conductor.
-void main() {
-  test(
-      'validate the expected binaries from the conductor codesign command are present in the cache',
-      () async {
-    const Platform platform = LocalPlatform();
-    const FileSystem fileSystem = LocalFileSystem();
-    final Directory tempDir = fileSystem.systemTempDirectory.createTempSync('flutter_conductor_integration_test.');
-    const ProcessManager processManager = LocalProcessManager();
-    final TestStdio stdio = TestStdio(verbose: true);
-    final Checkouts checkouts = Checkouts(
-      fileSystem: fileSystem,
-      parentDirectory: tempDir,
-      platform: platform,
-      processManager: processManager,
-      stdio: stdio,
-    );
-
-    final Directory flutterRoot = _flutterRootFromDartBinary(
-      fileSystem.file(platform.executable),
-    );
-
-    final String currentHead = (processManager.runSync(
-      <String>['git', 'rev-parse', 'HEAD'],
-      workingDirectory: flutterRoot.path,
-    ).stdout as String).trim();
-
-    final FrameworkRepository framework = FrameworkRepository.localRepoAsUpstream(
-      checkouts,
-      upstreamPath: flutterRoot.path,
-      initialRef: currentHead,
-    );
-    final CommandRunner<void> runner = CommandRunner<void>('codesign-test', '');
-    runner.addCommand(
-      CodesignCommand(
-        checkouts: checkouts,
-        framework: framework,
-        flutterRoot: flutterRoot,
-      ),
-    );
-
-    try {
-      await runner.run(<String>[
-        'codesign',
-        '--verify',
-        // Only verify if the correct binaries are in the cache
-        '--no-signatures',
-      ]);
-    } on ConductorException catch (e) {
-      print(stdio.error);
-      print(_fixItInstructions);
-      fail(e.message);
-    } on Exception {
-      print('stdout:\n${stdio.stdout}');
-      print('stderr:\n${stdio.error}');
-      rethrow;
-    }
-  }, onPlatform: <String, dynamic>{
-    'windows': const Skip('codesign command is only supported on macos'),
-    'linux': const Skip('codesign command is only supported on macos'),
-  });
-}
-
-Directory _flutterRootFromDartBinary(File dartBinary) {
-  final Directory flutterDartSdkDir = dartBinary.parent.parent;
-  final Directory flutterCache = flutterDartSdkDir.parent;
-  final Directory flutterSdkDir = flutterCache.parent.parent;
-  return flutterSdkDir;
-}
-
-const String _fixItInstructions = '''
-Codesign integration test failed.
-
-This means that the binary files found in the Flutter cache do not match those
-expected by the conductor tool (either an expected file was not found in the
-cache or an unexpected file was found in the cache).
-
-This usually happens either during an engine roll or a change to the caching
-logic in flutter_tools. If this is a valid change, then the conductor source
-code should be updated, specifically either the [binariesWithEntitlements] or
-[binariesWithoutEntitlements] lists, depending on if the file should have macOS
-entitlements applied during codesigning.
-''';