Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
f0ecfff3
Unverified
Commit
f0ecfff3
authored
Oct 23, 2020
by
Jonah Williams
Committed by
GitHub
Oct 23, 2020
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
[devicelab] mark twc as flaky and fix flutter test perf (#68895)
parent
cb67513f
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
9 additions
and
5 deletions
+9
-5
flutter_test_performance.dart
dev/devicelab/bin/tasks/flutter_test_performance.dart
+6
-5
manifest.yaml
dev/devicelab/manifest.yaml
+3
-0
No files found.
dev/devicelab/bin/tasks/flutter_test_performance.dart
View file @
f0ecfff3
...
...
@@ -37,10 +37,11 @@ enum TestStep {
testPassed
,
}
Future
<
int
>
runTest
({
bool
coverage
=
false
})
async
{
Future
<
int
>
runTest
({
bool
coverage
=
false
,
bool
noPub
=
false
})
async
{
final
Stopwatch
clock
=
Stopwatch
()..
start
();
final
List
<
String
>
arguments
=
flutterCommandArgs
(
'test'
,
<
String
>[
if
(
coverage
)
'--coverage'
,
if
(
noPub
)
'--no-pub'
,
path
.
join
(
'flutter_test'
,
'trivial_widget_test.dart'
),
]);
final
Process
analysis
=
await
startProcess
(
...
...
@@ -107,21 +108,21 @@ void main() {
final
String
originalSource
=
await
nodeSourceFile
.
readAsString
();
try
{
await
runTest
();
// first number is meaningless; could have had to build the tool, run pub get, have a cache, etc
final
int
withoutChange
=
await
runTest
();
// run test again with no change
final
int
withoutChange
=
await
runTest
(
noPub:
true
);
// run test again with no change
await
nodeSourceFile
.
writeAsString
(
// only change implementation
originalSource
.
replaceAll
(
'_owner'
,
'_xyzzy'
)
);
final
int
implementationChange
=
await
runTest
();
// run test again with implementation changed
final
int
implementationChange
=
await
runTest
(
noPub:
true
);
// run test again with implementation changed
await
nodeSourceFile
.
writeAsString
(
// change interface as well
originalSource
.
replaceAll
(
'_owner'
,
'_xyzzy'
)
.
replaceAll
(
'owner'
,
'_owner'
)
.
replaceAll
(
'_xyzzy'
,
'owner'
)
);
final
int
interfaceChange
=
await
runTest
();
// run test again with interface changed
final
int
interfaceChange
=
await
runTest
(
noPub:
true
);
// run test again with interface changed
// run test with coverage enabled.
final
int
withCoverage
=
await
runTest
(
coverage:
true
);
final
int
withCoverage
=
await
runTest
(
coverage:
true
,
noPub:
true
);
final
Map
<
String
,
dynamic
>
data
=
<
String
,
dynamic
>{
'without_change_elapsed_time_ms'
:
withoutChange
,
'implementation_change_elapsed_time_ms'
:
implementationChange
,
...
...
dev/devicelab/manifest.yaml
View file @
f0ecfff3
...
...
@@ -428,6 +428,7 @@ tasks:
Verifies that track-widget-creation can be enabled and disabled.
stage
:
devicelab
required_agent_capabilities
:
[
"
mac/android"
]
flaky
:
true
android_defines_test
:
description
:
>
...
...
@@ -647,6 +648,7 @@ tasks:
Verifies that track-widget-creation can be enabled and disabled.
stage
:
devicelab_ios
required_agent_capabilities
:
[
"
mac/ios"
]
flaky
:
true
macos_chrome_dev_mode
:
description
:
>
...
...
@@ -913,6 +915,7 @@ tasks:
Verifies that track-widget-creation can be enabled and disabled.
stage
:
devicelab
required_agent_capabilities
:
[
"
linux-vm"
]
flaky
:
true
# android_splash_screen_integration_test:
# description: >
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment