Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
f04508a4
Unverified
Commit
f04508a4
authored
Jun 25, 2021
by
Jonah Williams
Committed by
GitHub
Jun 25, 2021
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
[flutter_tools] dont use SETLOCAL ENABLEDELAYEDEXPANSION unecessarily (#85288)
parent
d7d11c52
Changes
4
Hide whitespace changes
Inline
Side-by-side
Showing
4 changed files
with
29 additions
and
4 deletions
+29
-4
dart.bat
bin/dart.bat
+0
-2
flutter.bat
bin/flutter.bat
+0
-2
variable_expansion_windows.dart
...ls/test/integration.shard/variable_expansion_windows.dart
+8
-0
variable_expansion_windows_test.dart
...st/integration.shard/variable_expansion_windows_test.dart
+21
-0
No files found.
bin/dart.bat
View file @
f04508a4
...
...
@@ -11,8 +11,6 @@ REM work across all platforms!
REM
REM --------------------------------------------------------------------------
SETLOCAL ENABLEDELAYEDEXPANSION
FOR %%i IN ("%~dp0..") DO SET FLUTTER_ROOT=%%~fi
REM Include shared scripts in shared.bat
...
...
bin/flutter.bat
View file @
f04508a4
...
...
@@ -11,8 +11,6 @@ REM work across all platforms!
REM
REM --------------------------------------------------------------------------
SETLOCAL ENABLEDELAYEDEXPANSION
FOR %%i IN ("%~dp0..") DO SET FLUTTER_ROOT=%%~fi
REM If available, add location of bundled mingit to PATH
...
...
packages/flutter_tools/test/integration.shard/variable_expansion_windows.dart
0 → 100644
View file @
f04508a4
// Copyright 2014 The Flutter Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
// Not a test file, invoked by `variable_expansion_windows_test.dart`.
void
main
(
List
<
String
>
args
)
{
print
(
'args:
$args
'
);
}
packages/flutter_tools/test/integration.shard/variable_expansion_windows_test.dart
0 → 100644
View file @
f04508a4
// Copyright 2014 The Flutter Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
// @dart = 2.8
import
'package:flutter_tools/src/base/io.dart'
;
import
'../src/common.dart'
;
import
'test_utils.dart'
;
void
main
(
)
{
// Regression test for https://github.com/flutter/flutter/issues/84270 .
testWithoutContext
(
'dart command will expand variables on windows'
,
()
async
{
final
ProcessResult
result
=
await
processManager
.
run
(<
String
>[
fileSystem
.
path
.
join
(
getFlutterRoot
(),
'bin'
,
'dart'
),
fileSystem
.
path
.
join
(
getFlutterRoot
(),
'packages'
,
'flutter_tools'
,
'test'
,
'integration.shard'
,
'variable_expansion_windows.dart'
),
'"^(?!Golden).+"'
,
]);
expect
(
result
.
stdout
,
contains
(
'args: ["(?!Golden).+"]'
));
},
skip:
!
platform
.
isWindows
);
}
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment