Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
ef20f726
Unverified
Commit
ef20f726
authored
May 11, 2018
by
Hans Muller
Committed by
GitHub
May 11, 2018
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Gallery a11y fix: give the categories and demos pages "route" scope (#17516)
parent
6c8d5f1b
Changes
1
Show whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
59 additions
and
47 deletions
+59
-47
home.dart
examples/flutter_gallery/lib/gallery/home.dart
+59
-47
No files found.
examples/flutter_gallery/lib/gallery/home.dart
View file @
ef20f726
...
@@ -109,7 +109,12 @@ class _CategoriesPage extends StatelessWidget {
...
@@ -109,7 +109,12 @@ class _CategoriesPage extends StatelessWidget {
final
List
<
GalleryDemoCategory
>
categoriesList
=
categories
.
toList
();
final
List
<
GalleryDemoCategory
>
categoriesList
=
categories
.
toList
();
final
int
columnCount
=
(
MediaQuery
.
of
(
context
).
orientation
==
Orientation
.
portrait
)
?
2
:
3
;
final
int
columnCount
=
(
MediaQuery
.
of
(
context
).
orientation
==
Orientation
.
portrait
)
?
2
:
3
;
return
new
SingleChildScrollView
(
return
new
Semantics
(
scopesRoute:
true
,
namesRoute:
true
,
label:
'categories'
,
explicitChildNodes:
true
,
child:
new
SingleChildScrollView
(
key:
const
PageStorageKey
<
String
>(
'categories'
),
key:
const
PageStorageKey
<
String
>(
'categories'
),
child:
new
LayoutBuilder
(
child:
new
LayoutBuilder
(
builder:
(
BuildContext
context
,
BoxConstraints
constraints
)
{
builder:
(
BuildContext
context
,
BoxConstraints
constraints
)
{
...
@@ -151,6 +156,7 @@ class _CategoriesPage extends StatelessWidget {
...
@@ -151,6 +156,7 @@ class _CategoriesPage extends StatelessWidget {
);
);
},
},
),
),
),
);
);
}
}
}
}
...
@@ -240,6 +246,11 @@ class _DemosPage extends StatelessWidget {
...
@@ -240,6 +246,11 @@ class _DemosPage extends StatelessWidget {
Widget
build
(
BuildContext
context
)
{
Widget
build
(
BuildContext
context
)
{
return
new
KeyedSubtree
(
return
new
KeyedSubtree
(
key:
const
ValueKey
<
String
>(
'GalleryDemoList'
),
// So the tests can find this ListView
key:
const
ValueKey
<
String
>(
'GalleryDemoList'
),
// So the tests can find this ListView
child:
new
Semantics
(
scopesRoute:
true
,
namesRoute:
true
,
label:
category
.
name
,
explicitChildNodes:
true
,
child:
new
ListView
(
child:
new
ListView
(
key:
new
PageStorageKey
<
String
>(
category
.
name
),
key:
new
PageStorageKey
<
String
>(
category
.
name
),
padding:
const
EdgeInsets
.
only
(
top:
8.0
),
padding:
const
EdgeInsets
.
only
(
top:
8.0
),
...
@@ -247,6 +258,7 @@ class _DemosPage extends StatelessWidget {
...
@@ -247,6 +258,7 @@ class _DemosPage extends StatelessWidget {
return
new
_DemoItem
(
demo:
demo
);
return
new
_DemoItem
(
demo:
demo
);
}).
toList
(),
}).
toList
(),
),
),
),
);
);
}
}
}
}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment