New Heroes (#8112)

examples/stocks/lib/stock_symbol_viewer.dart

@@ -81,7 +81,6 @@ class StockSymbolPage extends StatelessWidget {
               stock: stock,
               arrow: new Hero(
                 tag: stock,
-                turns: 2,
                 child: new StockArrow(percentChange: stock.percentChange)
               )
             )

packages/flutter/test/widgets/heroes_test.dart

@@ -357,4 +357,36 @@ void main() {
     // TODO(ianh): once https://github.com/flutter/flutter/issues/5631 is fixed, remove this line:
     await tester.pump(const Duration(hours: 1));
   });
+
+  testWidgets('One route, two heroes, same tag, throws', (WidgetTester tester) async {
+    await tester.pumpWidget(new MaterialApp(
+      home: new Material(
+        child: new ListView(
+          children: <Widget>[
+            new Hero(tag: 'a', child: new Text('a')),
+            new Hero(tag: 'a', child: new Text('a too')),
+            new Builder(
+              builder: (BuildContext context) {
+                return new FlatButton(
+                  child: new Text('push'),
+                  onPressed: () {
+                    Navigator.push(context, new PageRouteBuilder<Null>(
+                      pageBuilder: (BuildContext context, Animation<double> _, Animation<double> __) {
+                        return new Text('fail');
+                      },
+                    ));
+                  },
+                );
+              },
+            ),
+          ],
+        ),
+      ),
+    ));
+
+    await tester.tap(find.text('push'));
+    await tester.pump();
+    expect(tester.takeException(), isFlutterError);
+  });
+
 }

packages/flutter/test/widgets/navigator_test.dart

@@ -148,6 +148,7 @@ void main() {
     expect(find.text('X'), findsNothing);
     expect(find.text('Y'), findsOneWidget);
 
+    await tester.pump();
     await tester.pump();
     expect(find.text('X'), findsOneWidget);
     expect(find.text('Y'), findsOneWidget);

packages/flutter/test/widgets/page_forward_transitions_test.dart

@@ -132,6 +132,8 @@ void main() {
     navigator.pop();
     expect(state(), equals('E')); // transition 1<-2 is at 1.0, just reversed
     await tester.pump();
+    await tester.pump();
+
     expect(state(), equals('BDE')); // transition 1<-2 is at 1.0
 
     await tester.pump(kFourTenthsOfTheTransitionDuration);

packages/flutter/test/widgets/page_transitions_test.dart

@@ -113,6 +113,7 @@ void main() {
     expect(Navigator.canPop(containerKey2.currentContext), isTrue);
     Navigator.pop(containerKey2.currentContext);
     await tester.pump();
+    await tester.pump();
 
     expect(find.text('Home'), isOnstage);
     expect(find.text('Settings'), isOnstage);