Commit ede72a80 authored by Sarah Zakarias's avatar Sarah Zakarias Committed by GitHub

Revert "Revert plugin use in gallery (#9838)" (#9877)

This reverts commit 4bbf158b.
parent f52cbe81
package io.flutter.examples.gallery;
import android.os.Bundle;
import io.flutter.app.FlutterActivity;
import io.flutter.plugins.PluginRegistry;
......
......@@ -2,13 +2,16 @@ package io.flutter.plugins;
import io.flutter.app.FlutterActivity;
import io.flutter.plugins.url_launcher.UrlLauncherPlugin;
/**
* Generated file. Do not edit.
*/
public class PluginRegistry {
public UrlLauncherPlugin url_launcher;
public void registerAll(FlutterActivity activity) {
url_launcher = UrlLauncherPlugin.register(activity);
}
}
......@@ -7,6 +7,8 @@
<excludeFolder url="file://$MODULE_DIR$/.pub" />
<excludeFolder url="file://$MODULE_DIR$/build" />
<excludeFolder url="file://$MODULE_DIR$/packages" />
<excludeFolder url="file://$MODULE_DIR$/test/calculator/packages" />
<excludeFolder url="file://$MODULE_DIR$/test/packages" />
</content>
<orderEntry type="sourceFolder" forTests="false" />
<orderEntry type="library" name="Dart Packages" level="project" />
......
# Uncomment this line to define a global platform for your project
# platform :ios, '9.0'
if ENV['FLUTTER_FRAMEWORK_DIR'] == nil
abort('Please set FLUTTER_FRAMEWORK_DIR to the directory containing Flutter.framework')
end
target 'Runner' do
use_frameworks!
# Pods for Runner
# Flutter Pods
pod 'Flutter', :path => ENV['FLUTTER_FRAMEWORK_DIR']
if File.exists? '../.flutter-plugins'
flutter_root = File.expand_path('..')
File.foreach('../.flutter-plugins') { |line|
plugin = line.split(pattern='=')
if plugin.length == 2
name = plugin[0].strip()
path = plugin[1].strip()
resolved_path = File.expand_path("#{path}/ios", flutter_root)
pod name, :path => resolved_path
else
puts "Invalid plugin specification: #{line}"
end
}
end
end
post_install do |installer|
installer.pods_project.targets.each do |target|
target.build_configurations.each do |config|
config.build_settings['ENABLE_BITCODE'] = 'NO'
end
end
end
......@@ -7,9 +7,11 @@
#import <Flutter/Flutter.h>
#import "UrlLauncherPlugin.h"
@interface PluginRegistry : NSObject
@property (readonly, nonatomic) UrlLauncherPlugin *url_launcher;
- (instancetype)initWithController:(FlutterViewController *)controller;
......
......@@ -8,6 +8,7 @@
- (instancetype)initWithController:(FlutterViewController *)controller {
if (self = [super init]) {
_url_launcher = [[UrlLauncherPlugin alloc] initWithController:controller];
}
return self;
}
......
......@@ -7,14 +7,15 @@ import 'dart:math' as math;
import 'package:flutter/foundation.dart' show defaultTargetPlatform, required;
import 'package:flutter/gestures.dart';
import 'package:flutter/material.dart';
import 'package:flutter/services.dart';
import 'package:url_launcher/url_launcher.dart';
class LinkTextSpan extends TextSpan {
LinkTextSpan({ TextStyle style, String url, String text }) : super(
style: style,
text: text ?? url,
recognizer: new TapGestureRecognizer()..onTap = () {
UrlLauncher.launch(url);
launch(url);
}
);
}
......@@ -203,7 +204,7 @@ class GalleryDrawer extends StatelessWidget {
leading: const Icon(Icons.report),
title: const Text('Send feedback'),
onTap: onSendFeedback ?? () {
UrlLauncher.launch('https://github.com/flutter/flutter/issues/new');
launch('https://github.com/flutter/flutter/issues/new');
},
);
......
......@@ -6,6 +6,7 @@ dependencies:
flutter:
sdk: flutter
url_launcher: ^0.3.3
# Also update dev/benchmarks/complex_layout/pubspec.yaml
flutter_gallery_assets:
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment