Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
edd46681
Unverified
Commit
edd46681
authored
Aug 11, 2022
by
Jesús S Guerrero
Committed by
GitHub
Aug 11, 2022
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Disable jank metrics for web (#109356)
parent
1dfa8477
Changes
4
Show whitespace changes
Inline
Side-by-side
Showing
4 changed files
with
12 additions
and
2 deletions
+12
-2
command_help.dart
packages/flutter_tools/lib/src/base/command_help.dart
+1
-1
resident_runner.dart
packages/flutter_tools/lib/src/resident_runner.dart
+4
-0
terminal_handler_test.dart
...utter_tools/test/general.shard/terminal_handler_test.dart
+6
-0
overall_experience_test.dart
...tools/test/integration.shard/overall_experience_test.dart
+1
-1
No files found.
packages/flutter_tools/lib/src/base/command_help.dart
View file @
edd46681
...
...
@@ -120,7 +120,7 @@ class CommandHelp {
late
final
CommandHelpOption
j
=
_makeOption
(
'j'
,
'Dump frame raster stats for the current frame.'
,
'Dump frame raster stats for the current frame.
(Unsupported for web)
'
,
);
late
final
CommandHelpOption
k
=
_makeOption
(
...
...
packages/flutter_tools/lib/src/resident_runner.dart
View file @
edd46681
...
...
@@ -701,6 +701,10 @@ abstract class ResidentHandlers {
return
false
;
}
for
(
final
FlutterDevice
?
device
in
flutterDevices
)
{
if
(
device
?.
targetPlatform
==
TargetPlatform
.
web_javascript
)
{
logger
!.
printWarning
(
'Unable to get jank metrics for web'
);
continue
;
}
final
List
<
FlutterView
>
views
=
await
device
!.
vmService
!.
getFlutterViews
();
for
(
final
FlutterView
view
in
views
)
{
final
Map
<
String
,
Object
>?
rasterData
=
...
...
packages/flutter_tools/test/general.shard/terminal_handler_test.dart
View file @
edd46681
...
...
@@ -177,6 +177,12 @@ void main() {
await
terminalHandler
.
processTerminalInput
(
'a'
);
});
testWithoutContext
(
'j unsupported jank metrics for web'
,
()
async
{
final
TerminalHandler
terminalHandler
=
setUpTerminalHandler
(<
FakeVmServiceRequest
>[],
web:
true
);
await
terminalHandler
.
processTerminalInput
(
'j'
);
expect
(
terminalHandler
.
logger
.
warningText
.
contains
(
'Unable to get jank metrics for web'
),
true
);
});
testWithoutContext
(
'a - debugToggleProfileWidgetBuilds without service protocol is skipped'
,
()
async
{
final
TerminalHandler
terminalHandler
=
setUpTerminalHandler
(<
FakeVmServiceRequest
>[],
supportsServiceProtocol:
false
);
...
...
packages/flutter_tools/test/integration.shard/overall_experience_test.dart
View file @
edd46681
...
...
@@ -612,7 +612,7 @@ void main() {
'a Toggle timeline events for all widget build methods. (debugProfileWidgetBuilds)'
,
'M Write SkSL shaders to a unique file in the project directory.'
,
'g Run source code generators.'
,
'j Dump frame raster stats for the current frame.'
,
'j Dump frame raster stats for the current frame.
(Unsupported for web)
'
,
'h Repeat this help message.'
,
'd Detach (terminate "flutter run" but leave application running).'
,
'c Clear the screen'
,
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment