Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
ec503ea9
Commit
ec503ea9
authored
Aug 27, 2015
by
Ian Fischer
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix infinite loop in sky_tool listen if you didn’t specify —local-build
parent
e30b436d
Changes
1
Show whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
43 additions
and
44 deletions
+43
-44
sky_tool
packages/flutter/lib/sky_tool
+43
-44
No files found.
packages/flutter/lib/sky_tool
View file @
ec503ea9
...
...
@@ -632,20 +632,19 @@ class StartListening(object):
]
subprocess
.
check_call
(
cmd
)
if
not
args
.
local_build
:
if
args
.
local_build
:
# Currently sending to iOS only works if you are building Sky locally
# since we aren't shipping the sky_snapshot binary yet.
continue
# Build the snapshot
# Check if we can make a snapshot
sky_snapshot_path
=
None
if
args
.
ios_sim_build_available
:
sky_snapshot_path
=
os
.
path
.
join
(
args
.
sky_src_path
,
args
.
ios_sim_debug_build_path
,
'clang_x64'
,
'sky_snapshot'
)
elif
args
.
ios_build_available
:
sky_snapshot_path
=
os
.
path
.
join
(
args
.
sky_src_path
,
args
.
ios_debug_build_path
,
'clang_x64'
,
'sky_snapshot'
)
else
:
# If there is no build available, we can't make a snapshot
continue
if
sky_snapshot_path
is
not
None
:
# If we can make a snapshot, do so and then send it to running iOS instances
cmd
=
[
sky_snapshot_path
,
'--package-root=packages'
,
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment