Unverified Commit ebfe6020 authored by Yegor's avatar Yegor Committed by GitHub

Enable more web tests; use blacklist to filter them out (#41922)

Add more web tests;use blacklist instead of whitelist
parent cf0d4979
...@@ -435,18 +435,28 @@ Future<void> _runTests() async { ...@@ -435,18 +435,28 @@ Future<void> _runTests() async {
} }
Future<void> _runWebTests() async { Future<void> _runWebTests() async {
await _runFlutterWebTest(path.join(flutterRoot, 'packages', 'flutter'), tests: <String>[ final Directory flutterPackageDir = Directory(path.join(flutterRoot, 'packages', 'flutter'));
'test/foundation/', final Directory testDir = Directory(path.join(flutterPackageDir.path, 'test'));
'test/physics/',
'test/services/', // TODO(yjbanov): we're getting rid of this blacklist as part of https://github.com/flutter/flutter/projects/60
// TODO(yjbanov): re-enable when flakiness is resolved const List<String> kBlacklist = <String>[
// 'test/rendering/', 'test/cupertino',
// 'test/painting/', 'test/examples',
// 'test/scheduler/', 'test/material',
// 'test/semantics/', 'test/painting',
// 'test/widgets/', 'test/rendering',
// 'test/material/', 'test/semantics',
]); 'test/widgets',
];
final List<String> directories = testDir
.listSync()
.whereType<Directory>()
.map<String>((Directory dir) => path.relative(dir.path, from: flutterPackageDir.path))
.where((String relativePath) => !kBlacklist.contains(relativePath))
.toList();
await _runFlutterWebTest(flutterPackageDir.path, tests: directories);
await _runFlutterWebTest(path.join(flutterRoot, 'packages', 'flutter_web_plugins'), tests: <String>['test']); await _runFlutterWebTest(path.join(flutterRoot, 'packages', 'flutter_web_plugins'), tests: <String>['test']);
} }
......
...@@ -334,7 +334,7 @@ void main() { ...@@ -334,7 +334,7 @@ void main() {
expect(startDetails, hasLength(1)); expect(startDetails, hasLength(1));
expect(updateDetails.single.globalPosition, within(distance: 0.0001, from: const Offset(400 + kTouchSlop + 3, 300 + kTouchSlop + 4))); expect(updateDetails.single.globalPosition, within(distance: 0.0001, from: const Offset(400 + kTouchSlop + 3, 300 + kTouchSlop + 4)));
expect(updateDetails.single.delta, within(distance: 0.1, from: const Offset(5, 0.0))); // sqrt(3^2 + 4^2) expect(updateDetails.single.delta, within(distance: 0.1, from: const Offset(5, 0.0))); // sqrt(3^2 + 4^2)
expect(updateDetails.single.primaryDelta, within(distance: 0.1, from: 5.0)); // sqrt(3^2 + 4^2) expect(updateDetails.single.primaryDelta, within<double>(distance: 0.1, from: 5.0)); // sqrt(3^2 + 4^2)
}); });
}); });
...@@ -662,7 +662,7 @@ void main() { ...@@ -662,7 +662,7 @@ void main() {
expect(startDetails, hasLength(1)); expect(startDetails, hasLength(1));
expect(updateDetails.single.globalPosition, within(distance: 0.0001, from: const Offset(400 + kTouchSlop - 4, 300 + kTouchSlop + 3))); expect(updateDetails.single.globalPosition, within(distance: 0.0001, from: const Offset(400 + kTouchSlop - 4, 300 + kTouchSlop + 3)));
expect(updateDetails.single.delta, within(distance: 0.1, from: const Offset(0.0, 5.0))); // sqrt(3^2 + 4^2) expect(updateDetails.single.delta, within(distance: 0.1, from: const Offset(0.0, 5.0))); // sqrt(3^2 + 4^2)
expect(updateDetails.single.primaryDelta, within(distance: 0.1, from: 5.0)); // sqrt(3^2 + 4^2) expect(updateDetails.single.primaryDelta, within<double>(distance: 0.1, from: 5.0)); // sqrt(3^2 + 4^2)
}); });
}); });
} }
...@@ -1026,8 +1026,8 @@ double _sizeDistance(Size a, Size b) { ...@@ -1026,8 +1026,8 @@ double _sizeDistance(Size a, Size b) {
/// The distance is computed by a [DistanceFunction]. /// The distance is computed by a [DistanceFunction].
/// ///
/// If `distanceFunction` is null, a standard distance function is used for the /// If `distanceFunction` is null, a standard distance function is used for the
/// `runtimeType` of the `from` argument. Standard functions are defined for /// `T` generic argument. Standard functions are defined for the following
/// the following types: /// types:
/// ///
/// * [Color], whose distance is the maximum component-wise delta. /// * [Color], whose distance is the maximum component-wise delta.
/// * [Offset], whose distance is the Euclidean distance computed using the /// * [Offset], whose distance is the Euclidean distance computed using the
...@@ -1050,7 +1050,7 @@ Matcher within<T>({ ...@@ -1050,7 +1050,7 @@ Matcher within<T>({
@required T from, @required T from,
DistanceFunction<T> distanceFunction, DistanceFunction<T> distanceFunction,
}) { }) {
distanceFunction ??= _kStandardDistanceFunctions[from.runtimeType]; distanceFunction ??= _kStandardDistanceFunctions[T];
if (distanceFunction == null) { if (distanceFunction == null) {
throw ArgumentError( throw ArgumentError(
......
...@@ -154,10 +154,6 @@ class ChromeLauncher { ...@@ -154,10 +154,6 @@ class ChromeLauncher {
return chrome; return chrome;
} }
/// Connects to an instance of Chrome with an open debug port.
static Future<Chrome> fromExisting(int port) async =>
_connect(Chrome._(port, ChromeConnection('localhost', port)), false);
static Future<Chrome> get connectedInstance => _currentCompleter.future; static Future<Chrome> get connectedInstance => _currentCompleter.future;
/// Returns the full URL of the Chrome remote debugger for the main page. /// Returns the full URL of the Chrome remote debugger for the main page.
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment