Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
ea4d969e
Unverified
Commit
ea4d969e
authored
Feb 14, 2020
by
Jonah Williams
Committed by
GitHub
Feb 14, 2020
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
[flutter_tools] move dwds imports to not require g3 visibility (#50823)
parent
08c83591
Changes
7
Show whitespace changes
Inline
Side-by-side
Showing
7 changed files
with
11 additions
and
8 deletions
+11
-8
devfs_web.dart
packages/flutter_tools/lib/src/build_runner/devfs_web.dart
+2
-2
resident_web_runner.dart
...utter_tools/lib/src/build_runner/resident_web_runner.dart
+1
-1
forbidden_imports_test.dart
...tter_tools/test/general.shard/forbidden_imports_test.dart
+4
-1
resident_web_runner_cold_test.dart
...ols/test/general.shard/resident_web_runner_cold_test.dart
+1
-1
resident_web_runner_test.dart
...er_tools/test/general.shard/resident_web_runner_test.dart
+1
-1
devfs_web_test.dart
.../flutter_tools/test/general.shard/web/devfs_web_test.dart
+1
-1
web_asset_server_test.dart
...r_tools/test/general.shard/web/web_asset_server_test.dart
+1
-1
No files found.
packages/flutter_tools/lib/src/
web
/devfs_web.dart
→
packages/flutter_tools/lib/src/
build_runner
/devfs_web.dart
View file @
ea4d969e
...
@@ -29,8 +29,8 @@ import '../compile.dart';
...
@@ -29,8 +29,8 @@ import '../compile.dart';
import
'../convert.dart'
;
import
'../convert.dart'
;
import
'../devfs.dart'
;
import
'../devfs.dart'
;
import
'../globals.dart'
as
globals
;
import
'../globals.dart'
as
globals
;
import
'bootstrap.dart'
;
import
'
../web/
bootstrap.dart'
;
import
'chrome.dart'
;
import
'
../web/
chrome.dart'
;
/// A web server which handles serving JavaScript and assets.
/// A web server which handles serving JavaScript and assets.
///
///
...
...
packages/flutter_tools/lib/src/build_runner/resident_web_runner.dart
View file @
ea4d969e
...
@@ -31,9 +31,9 @@ import '../resident_runner.dart';
...
@@ -31,9 +31,9 @@ import '../resident_runner.dart';
import
'../run_hot.dart'
;
import
'../run_hot.dart'
;
import
'../web/chrome.dart'
;
import
'../web/chrome.dart'
;
import
'../web/compile.dart'
;
import
'../web/compile.dart'
;
import
'../web/devfs_web.dart'
;
import
'../web/web_device.dart'
;
import
'../web/web_device.dart'
;
import
'../web/web_runner.dart'
;
import
'../web/web_runner.dart'
;
import
'devfs_web.dart'
;
/// Injectable factory to create a [ResidentWebRunner].
/// Injectable factory to create a [ResidentWebRunner].
class
DwdsWebRunnerFactory
extends
WebRunnerFactory
{
class
DwdsWebRunnerFactory
extends
WebRunnerFactory
{
...
...
packages/flutter_tools/test/general.shard/forbidden_imports_test.dart
View file @
ea4d969e
...
@@ -158,11 +158,13 @@ void main() {
...
@@ -158,11 +158,13 @@ void main() {
}
}
});
});
test
(
'no unauthorized imports of build_runner'
,
()
{
test
(
'no unauthorized imports of build_runner
or dwds
'
,
()
{
final
List
<
String
>
whitelistedPaths
=
<
String
>[
final
List
<
String
>
whitelistedPaths
=
<
String
>[
globals
.
fs
.
path
.
join
(
flutterTools
,
'test'
,
'src'
,
'build_runner'
),
globals
.
fs
.
path
.
join
(
flutterTools
,
'test'
,
'src'
,
'build_runner'
),
globals
.
fs
.
path
.
join
(
flutterTools
,
'lib'
,
'src'
,
'build_runner'
),
globals
.
fs
.
path
.
join
(
flutterTools
,
'lib'
,
'src'
,
'build_runner'
),
globals
.
fs
.
path
.
join
(
flutterTools
,
'lib'
,
'executable.dart'
),
globals
.
fs
.
path
.
join
(
flutterTools
,
'lib'
,
'executable.dart'
),
globals
.
fs
.
path
.
join
(
flutterTools
,
'lib'
,
'devfs_web.dart'
),
globals
.
fs
.
path
.
join
(
flutterTools
,
'lib'
,
'resident_web_runner.dart'
),
];
];
bool
_isNotWhitelisted
(
FileSystemEntity
entity
)
=>
whitelistedPaths
.
every
((
String
path
)
=>
!
entity
.
path
.
contains
(
path
));
bool
_isNotWhitelisted
(
FileSystemEntity
entity
)
=>
whitelistedPaths
.
every
((
String
path
)
=>
!
entity
.
path
.
contains
(
path
));
...
@@ -177,6 +179,7 @@ void main() {
...
@@ -177,6 +179,7 @@ void main() {
if
(
line
.
startsWith
(
RegExp
(
r'import.*package:build_runner_core/build_runner_core.dart'
))
||
if
(
line
.
startsWith
(
RegExp
(
r'import.*package:build_runner_core/build_runner_core.dart'
))
||
line
.
startsWith
(
RegExp
(
r'import.*package:build_runner/build_runner.dart'
))
||
line
.
startsWith
(
RegExp
(
r'import.*package:build_runner/build_runner.dart'
))
||
line
.
startsWith
(
RegExp
(
r'import.*package:build_config/build_config.dart'
))
||
line
.
startsWith
(
RegExp
(
r'import.*package:build_config/build_config.dart'
))
||
line
.
startsWith
(
RegExp
(
r'import.*dwds:*.dart'
))
||
line
.
startsWith
(
RegExp
(
r'import.*build_runner/.*.dart'
)))
{
line
.
startsWith
(
RegExp
(
r'import.*build_runner/.*.dart'
)))
{
final
String
relativePath
=
globals
.
fs
.
path
.
relative
(
file
.
path
,
from:
flutterTools
);
final
String
relativePath
=
globals
.
fs
.
path
.
relative
(
file
.
path
,
from:
flutterTools
);
fail
(
'
$relativePath
imports a build_runner package'
);
fail
(
'
$relativePath
imports a build_runner package'
);
...
...
packages/flutter_tools/test/general.shard/resident_web_runner_cold_test.dart
View file @
ea4d969e
...
@@ -16,7 +16,7 @@ import 'package:flutter_tools/src/project.dart';
...
@@ -16,7 +16,7 @@ import 'package:flutter_tools/src/project.dart';
import
'package:flutter_tools/src/resident_runner.dart'
;
import
'package:flutter_tools/src/resident_runner.dart'
;
import
'package:flutter_tools/src/build_runner/resident_web_runner.dart'
;
import
'package:flutter_tools/src/build_runner/resident_web_runner.dart'
;
import
'package:flutter_tools/src/web/chrome.dart'
;
import
'package:flutter_tools/src/web/chrome.dart'
;
import
'package:flutter_tools/src/
web
/devfs_web.dart'
;
import
'package:flutter_tools/src/
build_runner
/devfs_web.dart'
;
import
'package:flutter_tools/src/web/web_device.dart'
;
import
'package:flutter_tools/src/web/web_device.dart'
;
import
'package:mockito/mockito.dart'
;
import
'package:mockito/mockito.dart'
;
import
'package:platform/platform.dart'
;
import
'package:platform/platform.dart'
;
...
...
packages/flutter_tools/test/general.shard/resident_web_runner_test.dart
View file @
ea4d969e
...
@@ -19,7 +19,7 @@ import 'package:flutter_tools/src/project.dart';
...
@@ -19,7 +19,7 @@ import 'package:flutter_tools/src/project.dart';
import
'package:flutter_tools/src/reporting/reporting.dart'
;
import
'package:flutter_tools/src/reporting/reporting.dart'
;
import
'package:flutter_tools/src/resident_runner.dart'
;
import
'package:flutter_tools/src/resident_runner.dart'
;
import
'package:flutter_tools/src/web/chrome.dart'
;
import
'package:flutter_tools/src/web/chrome.dart'
;
import
'package:flutter_tools/src/
web
/devfs_web.dart'
;
import
'package:flutter_tools/src/
build_runner
/devfs_web.dart'
;
import
'package:flutter_tools/src/web/web_device.dart'
;
import
'package:flutter_tools/src/web/web_device.dart'
;
import
'package:mockito/mockito.dart'
;
import
'package:mockito/mockito.dart'
;
import
'package:platform/platform.dart'
;
import
'package:platform/platform.dart'
;
...
...
packages/flutter_tools/test/general.shard/web/devfs_web_test.dart
View file @
ea4d969e
...
@@ -9,7 +9,7 @@ import 'package:flutter_tools/src/base/io.dart';
...
@@ -9,7 +9,7 @@ import 'package:flutter_tools/src/base/io.dart';
import
'package:flutter_tools/src/build_info.dart'
;
import
'package:flutter_tools/src/build_info.dart'
;
import
'package:flutter_tools/src/compile.dart'
;
import
'package:flutter_tools/src/compile.dart'
;
import
'package:flutter_tools/src/convert.dart'
;
import
'package:flutter_tools/src/convert.dart'
;
import
'package:flutter_tools/src/
web
/devfs_web.dart'
;
import
'package:flutter_tools/src/
build_runner
/devfs_web.dart'
;
import
'package:mockito/mockito.dart'
;
import
'package:mockito/mockito.dart'
;
import
'package:package_config/discovery.dart'
;
import
'package:package_config/discovery.dart'
;
import
'package:package_config/packages.dart'
;
import
'package:package_config/packages.dart'
;
...
...
packages/flutter_tools/test/general.shard/web/web_asset_server_test.dart
View file @
ea4d969e
...
@@ -4,7 +4,7 @@
...
@@ -4,7 +4,7 @@
import
'package:flutter_tools/src/base/io.dart'
;
import
'package:flutter_tools/src/base/io.dart'
;
import
'package:flutter_tools/src/globals.dart'
as
globals
;
import
'package:flutter_tools/src/globals.dart'
as
globals
;
import
'package:flutter_tools/src/
web
/devfs_web.dart'
;
import
'package:flutter_tools/src/
build_runner
/devfs_web.dart'
;
import
'package:shelf/shelf.dart'
;
import
'package:shelf/shelf.dart'
;
import
'../../src/common.dart'
;
import
'../../src/common.dart'
;
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment