Unverified Commit e8f8a82a authored by Kate Lovett's avatar Kate Lovett Committed by GitHub

Revert "Fix `DropdownButton` menu clip" (#104203)

parent 24bd28f6
...@@ -286,8 +286,6 @@ class _DropdownMenuState<T> extends State<_DropdownMenu<T>> { ...@@ -286,8 +286,6 @@ class _DropdownMenuState<T> extends State<_DropdownMenu<T>> {
namesRoute: true, namesRoute: true,
explicitChildNodes: true, explicitChildNodes: true,
label: localizations.popupMenuLabel, label: localizations.popupMenuLabel,
child: ClipRRect(
borderRadius: widget.borderRadius ?? BorderRadius.zero,
child: Material( child: Material(
type: MaterialType.transparency, type: MaterialType.transparency,
textStyle: route.style, textStyle: route.style,
...@@ -316,7 +314,6 @@ class _DropdownMenuState<T> extends State<_DropdownMenu<T>> { ...@@ -316,7 +314,6 @@ class _DropdownMenuState<T> extends State<_DropdownMenu<T>> {
), ),
), ),
), ),
),
); );
} }
} }
......
...@@ -3839,35 +3839,4 @@ void main() { ...@@ -3839,35 +3839,4 @@ void main() {
expect(tester.getBottomRight(find.text(hintText)).dx, 776.0); expect(tester.getBottomRight(find.text(hintText)).dx, 776.0);
expect(tester.getBottomRight(find.text(hintText)).dy, 350.0); expect(tester.getBottomRight(find.text(hintText)).dy, 350.0);
}); });
testWidgets('BorderRadius property clips dropdown menu', (WidgetTester tester) async {
const double radius = 20.0;
await tester.pumpWidget(
MaterialApp(
home: Scaffold(
body: Center(
child: DropdownButtonFormField<String>(
borderRadius: BorderRadius.circular(radius),
value: 'One',
items: <String>['One', 'Two', 'Three', 'Four']
.map<DropdownMenuItem<String>>((String value) {
return DropdownMenuItem<String>(
value: value,
child: Text(value),
);
}).toList(),
onChanged: (_) { },
),
),
),
),
);
await tester.tap(find.text('One'));
await tester.pumpAndSettle();
final RenderClipRRect renderClip = tester.allRenderObjects.whereType<RenderClipRRect>().first;
expect(renderClip.borderRadius, BorderRadius.circular(radius));
});
} }
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment