Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
e7b66ac7
Unverified
Commit
e7b66ac7
authored
Oct 26, 2020
by
Jonah Williams
Committed by
GitHub
Oct 26, 2020
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
[flutter_tools] do not include AS validator if android is not enabled (#69047)
parent
7a10b46e
Changes
2
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
10 additions
and
1 deletion
+10
-1
doctor.dart
packages/flutter_tools/lib/src/doctor.dart
+2
-1
doctor_test.dart
...utter_tools/test/commands.shard/hermetic/doctor_test.dart
+8
-0
No files found.
packages/flutter_tools/lib/src/doctor.dart
View file @
e7b66ac7
...
...
@@ -74,6 +74,7 @@ class _DefaultDoctorValidatorsProvider implements DoctorValidatorsProvider {
}
final
List
<
DoctorValidator
>
ideValidators
=
<
DoctorValidator
>[
if
(
androidWorkflow
.
appliesToHostPlatform
)
...
AndroidStudioValidator
.
allValidators
(
globals
.
config
,
globals
.
platform
,
globals
.
fs
,
globals
.
userMessages
),
...
IntelliJValidator
.
installedValidators
(
fileSystem:
globals
.
fs
,
...
...
packages/flutter_tools/test/commands.shard/hermetic/doctor_test.dart
View file @
e7b66ac7
...
...
@@ -6,6 +6,7 @@ import 'dart:async';
import
'package:args/command_runner.dart'
;
import
'package:file/memory.dart'
;
import
'package:flutter_tools/src/android/android_studio_validator.dart'
;
import
'package:flutter_tools/src/base/common.dart'
;
import
'package:flutter_tools/src/base/file_system.dart'
;
import
'package:flutter_tools/src/base/logger.dart'
;
...
...
@@ -673,6 +674,13 @@ void main() {
FlutterVersion:
()
=>
mockFlutterVersion
,
Doctor:
()
=>
NoOpDoctor
(),
},
initializeFlutterRoot:
false
);
testUsingContext
(
'If android workflow is disabled, AndroidStudio validator is not included'
,
()
{
expect
(
DoctorValidatorsProvider
.
defaultInstance
.
validators
,
isNot
(
contains
(
isA
<
AndroidStudioValidator
>())));
expect
(
DoctorValidatorsProvider
.
defaultInstance
.
validators
,
isNot
(
contains
(
isA
<
NoAndroidStudioValidator
>())));
},
overrides:
<
Type
,
Generator
>{
FeatureFlags:
()
=>
TestFeatureFlags
(
isAndroidEnabled:
false
),
});
}
class
NoOpDoctor
implements
Doctor
{
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment