Skip to content

F
Front-End
Unverified Commit e778686e authored by Jonah Williams's avatar Jonah Williams Committed by GitHub
Browse files
Options

Re-enable chrome dev mode tests (#43691)

parent 2637a6cb
Hide whitespace changes
Inline Side-by-side
Showing with 159 additions and 150 deletions
dev/devicelab/lib/tasks/web_dev_mode_tests.dart
View file @ e778686e
...@@ -9,155 +9,166 @@ import 'dart:io'; ...@@ -9,155 +9,166 @@ import 'dart:io';
import 'package:path/path.dart' as path; import 'package:path/path.dart' as path;
import '../framework/framework.dart'; import '../framework/framework.dart';
import '../framework/running_processes.dart';
import '../framework/utils.dart'; import '../framework/utils.dart';
final Directory _editedFlutterGalleryDir = dir(path.join(Directory.systemTemp.path, 'edited_flutter_gallery')); final Directory _editedFlutterGalleryDir = dir(path.join(Directory.systemTemp.path, 'edited_flutter_gallery'));
final Directory flutterGalleryDir = dir(path.join(flutterDirectory.path, 'examples/flutter_gallery')); final Directory flutterGalleryDir = dir(path.join(flutterDirectory.path, 'examples/flutter_gallery'));
const String kInitialStartupTime = 'InitialStartupTime';
const String kFirstRestartTime = 'FistRestartTime';
const String kFirstRecompileTime = 'FirstRecompileTime';
const String kSecondStartupTime = 'SecondStartupTime';
const String kSecondRestartTime = 'SecondRestartTime';
TaskFunction createWebDevModeTest() { TaskFunction createWebDevModeTest() {
return () async { return () async {
final List<String> options = <String>[ final List<String> options = <String>[
'--hot', '-d', 'chrome', '--verbose', '--resident', '--target=lib/main.dart', '--hot', '-d', 'web-server', '--verbose', '--resident', '--target=lib/main.dart',
]; ];
int hotRestartCount = 0; int hotRestartCount = 0;
String chromeProcessName; final Map<String, int> measurements = <String, int>{};
if (Platform.isMacOS) { await inDirectory<void>(flutterDirectory, () async {
chromeProcessName = 'Chrome'; rmTree(_editedFlutterGalleryDir);
} else if (Platform.isLinux) { mkdirs(_editedFlutterGalleryDir);
chromeProcessName = 'chrome'; recursiveCopy(flutterGalleryDir, _editedFlutterGalleryDir);
} else if (Platform.isWindows) { await inDirectory<void>(_editedFlutterGalleryDir, () async {
chromeProcessName = 'chrome.exe'; {
} final Process packagesGet = await startProcess(
final Set<String> beforeChromeProcesses = await getRunningProcesses(processName: chromeProcessName) path.join(flutterDirectory.path, 'bin', 'flutter'),
.map((RunningProcessInfo info) => info.pid) <String>['packages', 'get'],
.toSet(); environment: <String, String>{
try { 'FLUTTER_WEB': 'true',
await inDirectory<void>(flutterDirectory, () async { },
rmTree(_editedFlutterGalleryDir); );
mkdirs(_editedFlutterGalleryDir); await packagesGet.exitCode;
recursiveCopy(flutterGalleryDir, _editedFlutterGalleryDir); final Process process = await startProcess(
await inDirectory<void>(_editedFlutterGalleryDir, () async { path.join(flutterDirectory.path, 'bin', 'flutter'),
{ flutterCommandArgs('run', options),
final Process packagesGet = await startProcess( environment: <String, String>{
path.join(flutterDirectory.path, 'bin', 'flutter'), 'FLUTTER_WEB': 'true',
<String>['packages', 'get'], },
environment: <String, String>{ );
'FLUTTER_WEB': 'true',
},
);
await packagesGet.exitCode;
final Process process = await startProcess(
path.join(flutterDirectory.path, 'bin', 'flutter'),
flutterCommandArgs('run', options),
environment: <String, String>{
'FLUTTER_WEB': 'true',
},
);
final Completer<void> stdoutDone = Completer<void>(); final Completer<void> stdoutDone = Completer<void>();
final Completer<void> stderrDone = Completer<void>(); final Completer<void> stderrDone = Completer<void>();
process.stdout final Stopwatch sw = Stopwatch()..start();
.transform<String>(utf8.decoder) process.stdout
.transform<String>(const LineSplitter()) .transform<String>(utf8.decoder)
.listen((String line) { .transform<String>(const LineSplitter())
if (line.contains('To hot restart')) { .listen((String line) {
process.stdin.write('R'); if (line.contains('To hot restart')) {
} // measure clean start-up time.
if (line.contains('Restarted')) { sw.stop();
if (hotRestartCount == 0) { measurements[kInitialStartupTime] = sw.elapsedMilliseconds;
// Update the file and reload again. sw
final File appDartSource = file(path.join( ..reset()
_editedFlutterGalleryDir.path, 'lib/gallery/app.dart', ..start();
)); process.stdin.write('R');
appDartSource.writeAsStringSync( }
appDartSource.readAsStringSync().replaceFirst( if (line.contains('Recompile complete')) {
"'Flutter Gallery'", "'Updated Flutter Gallery'", if (hotRestartCount == 0) {
) measurements[kFirstRestartTime] = sw.elapsedMilliseconds;
); // Update the file and reload again.
process.stdin.writeln('R'); final File appDartSource = file(path.join(
++hotRestartCount; _editedFlutterGalleryDir.path, 'lib/gallery/app.dart',
} else { ));
// Quit after second hot restart. appDartSource.writeAsStringSync(
process.stdin.writeln('q'); appDartSource.readAsStringSync().replaceFirst(
} "'Flutter Gallery'", "'Updated Flutter Gallery'",
)
);
sw
..reset()
..start();
process.stdin.writeln('R');
++hotRestartCount;
} else {
measurements[kFirstRecompileTime] = sw.elapsedMilliseconds;
// Quit after second hot restart.
process.stdin.writeln('q');
} }
print('stdout: $line'); }
}, onDone: () { print('stdout: $line');
stdoutDone.complete(); }, onDone: () {
}); stdoutDone.complete();
process.stderr });
.transform<String>(utf8.decoder) process.stderr
.transform<String>(const LineSplitter()) .transform<String>(utf8.decoder)
.listen((String line) { .transform<String>(const LineSplitter())
print('stderr: $line'); .listen((String line) {
}, onDone: () { print('stderr: $line');
stderrDone.complete(); }, onDone: () {
}); stderrDone.complete();
});
await Future.wait<void>(<Future<void>>[ await Future.wait<void>(<Future<void>>[
stdoutDone.future, stdoutDone.future,
stderrDone.future, stderrDone.future,
]); ]);
await process.exitCode; await process.exitCode;
} }
// Start `flutter run` again to make sure it loads from the previous // Start `flutter run` again to make sure it loads from the previous
// state. dev compilers loads up from previously compiled JavaScript. // state. dev compilers loads up from previously compiled JavaScript.
{ {
final Process process = await startProcess(
path.join(flutterDirectory.path, 'bin', 'flutter'), final Stopwatch sw = Stopwatch()..start();
flutterCommandArgs('run', options), final Process process = await startProcess(
environment: <String, String>{ path.join(flutterDirectory.path, 'bin', 'flutter'),
'FLUTTER_WEB': 'true', flutterCommandArgs('run', options),
}, environment: <String, String>{
); 'FLUTTER_WEB': 'true',
final Completer<void> stdoutDone = Completer<void>(); },
final Completer<void> stderrDone = Completer<void>(); );
process.stdout final Completer<void> stdoutDone = Completer<void>();
.transform<String>(utf8.decoder) final Completer<void> stderrDone = Completer<void>();
.transform<String>(const LineSplitter()) process.stdout
.listen((String line) { .transform<String>(utf8.decoder)
if (line.contains('To hot restart')) { .transform<String>(const LineSplitter())
process.stdin.write('R'); .listen((String line) {
}
if (line.contains('Restarted')) {
process.stdin.writeln('q');
}
print('stdout: $line');
}, onDone: () {
stdoutDone.complete();
});
process.stderr
.transform<String>(utf8.decoder)
.transform<String>(const LineSplitter())
.listen((String line) {
print('stderr: $line');
}, onDone: () {
stderrDone.complete();
});
await Future.wait<void>(<Future<void>>[ if (line.contains('To hot restart')) {
stdoutDone.future, measurements[kSecondStartupTime] = sw.elapsedMilliseconds;
stderrDone.future, sw
]); ..reset()
await process.exitCode; ..start();
} process.stdin.write('R');
}); }
if (line.contains('Recompile complete')) {
measurements[kSecondRestartTime] = sw.elapsedMilliseconds;
process.stdin.writeln('q');
}
print('stdout: $line');
}, onDone: () {
stdoutDone.complete();
});
process.stderr
.transform<String>(utf8.decoder)
.transform<String>(const LineSplitter())
.listen((String line) {
print('stderr: $line');
}, onDone: () {
stderrDone.complete();
});
await Future.wait<void>(<Future<void>>[
stdoutDone.future,
stderrDone.future,
]);
await process.exitCode;
}
}); });
} finally { });
final Set<String> afterChromeProcesses = await getRunningProcesses(processName: chromeProcessName)
.map((RunningProcessInfo info) => info.pid)
.toSet();
final Set<String> newProcesses = afterChromeProcesses.difference(beforeChromeProcesses);
for (String processId in newProcesses) {
await killProcess(processId);
}
}
if (hotRestartCount != 1) { if (hotRestartCount != 1) {
return TaskResult.failure(null); return TaskResult.failure(null);
} }
return TaskResult.success(null); return TaskResult.success(measurements, benchmarkScoreKeys: <String>[
kInitialStartupTime,
kFirstRestartTime,
kFirstRecompileTime,
kSecondStartupTime,
kSecondRestartTime,
]);
}; };
} }
dev/devicelab/manifest.yaml
View file @ e778686e
...@@ -126,13 +126,12 @@ tasks: ...@@ -126,13 +126,12 @@ tasks:
stage: devicelab_win stage: devicelab_win
required_agent_capabilities: ["windows/android"] required_agent_capabilities: ["windows/android"]
# TODO(jonahwilliams): re-enable with https://github.com/flutter/flutter/issues/39597 windows_chrome_dev_mode:
# windows_chrome_dev_mode: description: >
# description: > Run flutter web on the devicelab and hot restart.
# Run flutter web on the devicelab and hot restart. stage: devicelab_win
# stage: devicelab_win required_agent_capabilities: ["windows/android"]
# required_agent_capabilities: ["windows/android"] flaky: true
# flaky: true
# Android on-device tests # Android on-device tests
...@@ -346,13 +345,12 @@ tasks: ...@@ -346,13 +345,12 @@ tasks:
stage: devicelab stage: devicelab
required_agent_capabilities: ["linux/android"] required_agent_capabilities: ["linux/android"]
# TODO(jonahwilliams): re-enable with https://github.com/flutter/flutter/issues/39597 linux_chrome_dev_mode:
# linux_chrome_dev_mode: description: >
# description: > Run flutter web on the devicelab and hot restart.
# Run flutter web on the devicelab and hot restart. stage: devicelab
# stage: devicelab required_agent_capabilities: ["linux/android"]
# required_agent_capabilities: ["linux/android"] flaky: true
# flaky: true
web_size__compile_test: web_size__compile_test:
description: > description: >
...@@ -519,12 +517,12 @@ tasks: ...@@ -519,12 +517,12 @@ tasks:
stage: devicelab_ios stage: devicelab_ios
required_agent_capabilities: ["mac/ios"] required_agent_capabilities: ["mac/ios"]
# macos_chrome_dev_mode: macos_chrome_dev_mode:
# description: > description: >
# Run flutter web on the devicelab and hot restart. Run flutter web on the devicelab and hot restart.
# stage: devicelab_ios stage: devicelab_ios
# required_agent_capabilities: ["mac/ios"] required_agent_capabilities: ["mac/ios"]
# flaky: true # marked as flaky while infra is under heavy development flaky: true # marked as flaky while infra is under heavy development
build_benchmark_ios: build_benchmark_ios:
description: > description: >
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment

HIAST - GitLab