Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
e71655b7
Unverified
Commit
e71655b7
authored
Oct 28, 2020
by
Danny Tuppeny
Committed by
GitHub
Oct 28, 2020
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Include VS Code + Android Studio URLs in the No IDE message (#69194)
parent
92d9630e
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
20 additions
and
4 deletions
+20
-4
user_messages.dart
packages/flutter_tools/lib/src/base/user_messages.dart
+5
-1
doctor.dart
packages/flutter_tools/lib/src/doctor.dart
+5
-3
doctor_test.dart
...utter_tools/test/commands.shard/hermetic/doctor_test.dart
+10
-0
No files found.
packages/flutter_tools/lib/src/base/user_messages.dart
View file @
e71655b7
...
@@ -34,7 +34,11 @@ class UserMessages {
...
@@ -34,7 +34,11 @@ class UserMessages {
// Messages used in NoIdeValidator
// Messages used in NoIdeValidator
String
get
noIdeStatusInfo
=>
'No supported IDEs installed'
;
String
get
noIdeStatusInfo
=>
'No supported IDEs installed'
;
String
get
noIdeInstallationInfo
=>
'IntelliJ - https://www.jetbrains.com/idea/'
;
List
<
String
>
get
noIdeInstallationInfo
=>
<
String
>[
'IntelliJ - https://www.jetbrains.com/idea/'
,
'Android Studio - https://developer.android.com/studio/'
,
'VS Code - https://code.visualstudio.com/'
,
];
// Messages used in IntellijValidator
// Messages used in IntellijValidator
String
intellijStatusInfo
(
String
version
)
=>
'version
$version
'
;
String
intellijStatusInfo
(
String
version
)
=>
'version
$version
'
;
...
...
packages/flutter_tools/lib/src/doctor.dart
View file @
e71655b7
...
@@ -769,9 +769,11 @@ class NoIdeValidator extends DoctorValidator {
...
@@ -769,9 +769,11 @@ class NoIdeValidator extends DoctorValidator {
@override
@override
Future
<
ValidationResult
>
validate
()
async
{
Future
<
ValidationResult
>
validate
()
async
{
return
ValidationResult
(
ValidationType
.
missing
,
<
ValidationMessage
>[
return
ValidationResult
(
ValidationMessage
(
userMessages
.
noIdeInstallationInfo
),
ValidationType
.
missing
,
],
statusInfo:
userMessages
.
noIdeStatusInfo
);
userMessages
.
noIdeInstallationInfo
.
map
((
String
ideInfo
)
=>
ValidationMessage
(
ideInfo
)).
toList
(),
statusInfo:
userMessages
.
noIdeStatusInfo
,
);
}
}
}
}
...
...
packages/flutter_tools/test/commands.shard/hermetic/doctor_test.dart
View file @
e71655b7
...
@@ -85,6 +85,16 @@ void main() {
...
@@ -85,6 +85,16 @@ void main() {
expect
(
message
.
isError
,
isFalse
);
expect
(
message
.
isError
,
isFalse
);
},
overrides:
noColorTerminalOverride
);
},
overrides:
noColorTerminalOverride
);
testUsingContext
(
'No IDE Validator includes expected installation messages'
,
()
async
{
final
ValidationResult
result
=
await
NoIdeValidator
().
validate
();
expect
(
result
.
type
,
ValidationType
.
missing
);
expect
(
result
.
messages
.
map
((
ValidationMessage
vm
)
=>
vm
.
message
),
UserMessages
().
noIdeInstallationInfo
,
);
},
overrides:
noColorTerminalOverride
);
testUsingContext
(
'vs code validator when 64bit installed'
,
()
async
{
testUsingContext
(
'vs code validator when 64bit installed'
,
()
async
{
expect
(
VsCodeValidatorTestTargets
.
installedWithExtension64bit
.
title
,
'VS Code, 64-bit edition'
);
expect
(
VsCodeValidatorTestTargets
.
installedWithExtension64bit
.
title
,
'VS Code, 64-bit edition'
);
final
ValidationResult
result
=
await
VsCodeValidatorTestTargets
.
installedWithExtension64bit
.
validate
();
final
ValidationResult
result
=
await
VsCodeValidatorTestTargets
.
installedWithExtension64bit
.
validate
();
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment