Unverified Commit e4a203b3 authored by Christopher Fujino's avatar Christopher Fujino Committed by GitHub

[flutter_tools] filter "Resolving dependencies..." from dart pub get output to...

[flutter_tools] filter "Resolving dependencies..." from dart pub get output to fix test flakiness (#111312)
parent a3c3dc86
...@@ -3126,17 +3126,26 @@ Future<void> _analyzeProject(String workingDir, { List<String> expectedFailures ...@@ -3126,17 +3126,26 @@ Future<void> _analyzeProject(String workingDir, { List<String> expectedFailures
final String lintName = lineComponents.removeLast(); final String lintName = lineComponents.removeLast();
final String location = lineComponents.removeLast(); final String location = lineComponents.removeLast();
return '$location: $lintName'; return '$location: $lintName';
// Add debugging for https://github.com/flutter/flutter/issues/111272
} on RangeError catch (err) { } on RangeError catch (err) {
fail('Received "$err" while trying to parse:\n\n$line'); throw RangeError('Received "$err" while trying to parse: "$line".');
} }
} }
final List<String> errors = const LineSplitter().convert(exec.stdout.toString()) final String stdout = exec.stdout.toString();
final List<String> errors;
try {
errors = const LineSplitter().convert(stdout)
.where((String line) { .where((String line) {
return line.trim().isNotEmpty && return line.trim().isNotEmpty &&
!line.startsWith('Analyzing') && !line.startsWith('Analyzing') &&
!line.contains('flutter pub get'); !line.contains('flutter pub get') &&
!line.contains('Resolving dependencies') &&
!line.contains('Got dependencies');
}).map(lineParser).toList(); }).map(lineParser).toList();
// Add debugging for https://github.com/flutter/flutter/issues/111272
} on RangeError catch (err) {
fail('$err\n\nComplete STDOUT was:\n\n$stdout');
}
expect(errors, unorderedEquals(expectedFailures)); expect(errors, unorderedEquals(expectedFailures));
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment