Commit e329356f authored by Brian Slesinsky's avatar Brian Slesinsky Committed by GitHub

Oops, fix code coverage (#10672)

And add comments explaining why.
parent 3528cd6f
...@@ -113,7 +113,8 @@ class _FlutterPlatform extends PlatformPlugin { ...@@ -113,7 +113,8 @@ class _FlutterPlatform extends PlatformPlugin {
@override @override
StreamChannel<dynamic> loadChannel(String testPath, TestPlatform platform) { StreamChannel<dynamic> loadChannel(String testPath, TestPlatform platform) {
if (enableObservatory || explicitDiagnosticPort != null) { // Fail if there will be a port conflict.
if (explicitObservatoryPort != null || explicitDiagnosticPort != null) {
if (_testCount > 0) if (_testCount > 0)
throwToolExit('installHook() was called with an observatory port, a diagnostic port, both, or debugger mode enabled, but then more than one test suite was run.'); throwToolExit('installHook() was called with an observatory port, a diagnostic port, both, or debugger mode enabled, but then more than one test suite was run.');
} }
......
...@@ -32,6 +32,7 @@ Future<int> runTests( ...@@ -32,6 +32,7 @@ Future<int> runTests(
testArgs.addAll(<String>['--no-color', '-rexpanded']); testArgs.addAll(<String>['--no-color', '-rexpanded']);
if (enableObservatory) { if (enableObservatory) {
// (In particular, for collecting code coverage.)
testArgs.add('--concurrency=1'); testArgs.add('--concurrency=1');
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment