Unverified Commit e2fb5cc3 authored by Darren Austin's avatar Darren Austin Committed by GitHub

Updated skipped tests for widgets directory. (#87879)

parent 11a0284a
......@@ -270,7 +270,7 @@ void main() {
expect(errorDetails.exception, isAssertionError);
const String toMatch = '... Normal element mounting (';
expect(toMatch.allMatches(errorDetails.toString()).length, 1);
}, skip: kIsWeb);
}, skip: kIsWeb); // https://github.com/flutter/flutter/issues/87875
}
class TestStatefulWidget extends StatefulWidget {
......
......@@ -1715,7 +1715,7 @@ void main() {
// On web, we don't show the Flutter toolbar and instead rely on the browser
// toolbar. Until we change that, this test should remain skipped.
}, skip: kIsWeb);
}, skip: kIsWeb); // [intended]
// The variants to test in the focus handling test.
final ValueVariant<TextInputAction> focusVariants = ValueVariant<
......@@ -3747,7 +3747,6 @@ void main() {
),
));
},
skip: isBrowser, // Related to https://github.com/flutter/flutter/issues/66089
);
testWidgets(
......@@ -3841,7 +3840,6 @@ void main() {
),
));
},
skip: isBrowser, // Related to https://github.com/flutter/flutter/issues/66089
);
testWidgets(
......@@ -4133,7 +4131,7 @@ void main() {
// On web, we don't show the Flutter toolbar and instead rely on the browser
// toolbar. Until we change that, this test should remain skipped.
}, skip: kIsWeb);
}, skip: kIsWeb); // [intended]
testWidgets('text selection handle visibility RTL', (WidgetTester tester) async {
// Text with two separate words to select.
......@@ -4195,7 +4193,7 @@ void main() {
// On web, we don't show the Flutter toolbar and instead rely on the browser
// toolbar. Until we change that, this test should remain skipped.
}, skip: kIsWeb);
}, skip: kIsWeb); // [intended]
const String testText = 'Now is the time for\n'
'all good people\n'
......@@ -4946,7 +4944,7 @@ void main() {
debugKeyEventSimulatorTransitModeOverride = null;
// On web, using keyboard for selection is handled by the browser.
}, skip: kIsWeb, variant: TargetPlatformVariant.all());
}, variant: TargetPlatformVariant.all(), skip: kIsWeb); // [intended]
testWidgets('keyboard text selection works (ui.KeyData then RawKeyEvent)', (WidgetTester tester) async {
debugKeyEventSimulatorTransitModeOverride = KeyDataTransitMode.keyDataThenRawKeyData;
......@@ -4956,7 +4954,7 @@ void main() {
debugKeyEventSimulatorTransitModeOverride = null;
// On web, using keyboard for selection is handled by the browser.
}, skip: kIsWeb, variant: TargetPlatformVariant.all());
}, variant: TargetPlatformVariant.all(), skip: kIsWeb); // [intended]
testWidgets(
'keyboard shortcuts respect read-only',
......@@ -5132,7 +5130,8 @@ void main() {
);
expect(controller.text, equals(testText), reason: 'on $platform');
},
skip: kIsWeb,
// On web, using keyboard for selection is handled by the browser.
skip: kIsWeb, // [intended]
variant: TargetPlatformVariant.all(),
);
......@@ -5299,9 +5298,12 @@ void main() {
scrollable.controller!.jumpTo(0);
await verifyVisibility(HandlePositionInViewport.rightEdge, false, HandlePositionInViewport.rightEdge, false);
},
// On web, we don't show the Flutter toolbar and instead rely on the browser
// toolbar. Until we change that, this test should remain skipped.
}, skip: kIsWeb, variant: const TargetPlatformVariant(<TargetPlatform>{ TargetPlatform.iOS, TargetPlatform.macOS }));
skip: kIsWeb, // [intended]
variant: const TargetPlatformVariant(<TargetPlatform>{ TargetPlatform.iOS, TargetPlatform.macOS })
);
testWidgets("scrolling doesn't bounce", (WidgetTester tester) async {
// 3 lines of text, where the last line overflows and requires scrolling.
......@@ -7401,7 +7403,7 @@ void main() {
}
// On web, using keyboard for selection is handled by the browser.
}, skip: kIsWeb);
}, skip: kIsWeb); // [intended]
testWidgets('navigating by word', (WidgetTester tester) async {
final TextEditingController controller = TextEditingController(text: 'word word word');
......@@ -7539,7 +7541,7 @@ void main() {
expect(controller.selection.extentOffset, 9);
// On web, using keyboard for selection is handled by the browser.
}, skip: kIsWeb, variant: TargetPlatformVariant.all());
}, variant: TargetPlatformVariant.all(), skip: kIsWeb); // [intended]
testWidgets('expanding selection to start/end', (WidgetTester tester) async {
final TextEditingController controller = TextEditingController(text: 'word word word');
......@@ -7622,8 +7624,11 @@ void main() {
reason: 'on $platform',
);
},
// On web, using keyboard for selection is handled by the browser.
}, skip: kIsWeb, variant: const TargetPlatformVariant(<TargetPlatform>{ TargetPlatform.macOS }));
skip: kIsWeb, // [intended]
variant: const TargetPlatformVariant(<TargetPlatform>{ TargetPlatform.macOS })
);
testWidgets('can change behavior by overriding text editing actions', (WidgetTester tester) async {
final TextEditingController controller = TextEditingController(text: testText);
......@@ -7706,7 +7711,7 @@ void main() {
}
// On web, using keyboard for selection is handled by the browser.
}, skip: kIsWeb);
}, skip: kIsWeb); // [intended]
testWidgets('ignore key event from web platform', (WidgetTester tester) async {
final TextEditingController controller = TextEditingController(
......@@ -7829,7 +7834,9 @@ void main() {
await tester.pump();
expect(fadeTransition.toString(), contains('DISPOSED'));
}, skip: kIsWeb);
// On web, using keyboard for selection is handled by the browser.
}, skip: kIsWeb); // [intended]
}
class UnsettableController extends TextEditingController {
......
......@@ -1585,7 +1585,7 @@ void main() {
// occur.
expect(() => element.state, throwsA(isA<TypeError>()));
expect(() => element.widget, throwsA(isA<TypeError>()));
}, skip: kIsWeb);
});
testWidgets('Deactivate and activate are called correctly', (WidgetTester tester) async {
final List<String> states = <String>[];
......
......@@ -1836,7 +1836,10 @@ Future<void> main() async {
expect(find.byKey(firstKey), isInCard);
expect(find.byKey(secondKey), isOnstage);
expect(find.byKey(secondKey), isInCard);
}, variant: TargetPlatformVariant.only(TargetPlatform.iOS), skip: kIsWeb);
},
variant: TargetPlatformVariant.only(TargetPlatform.iOS),
skip: kIsWeb, // [intended] there are no default transitions on the web.
);
testWidgets('Heroes can transition on gesture in one frame', (WidgetTester tester) async {
transitionFromUserGestures = true;
......@@ -1879,7 +1882,10 @@ Future<void> main() async {
expect(find.byKey(firstKey), isOnstage);
expect(find.byKey(firstKey), isInCard);
expect(find.byKey(secondKey), findsNothing);
}, variant: TargetPlatformVariant.only(TargetPlatform.iOS), skip: kIsWeb);
},
variant: TargetPlatformVariant.only(TargetPlatform.iOS),
skip: kIsWeb, // [intended] there are no default transitions on the web.
);
testWidgets('Heroes animate should hide destination hero and display original hero in case of dismissed', (WidgetTester tester) async {
transitionFromUserGestures = true;
......@@ -1915,7 +1921,10 @@ Future<void> main() async {
expect(find.byKey(firstKey), findsNothing);
expect(find.byKey(secondKey), isOnstage);
expect(find.byKey(secondKey), isInCard);
}, variant: TargetPlatformVariant.only(TargetPlatform.iOS), skip: kIsWeb);
},
variant: TargetPlatformVariant.only(TargetPlatform.iOS),
skip: kIsWeb, // [intended] there are no default transitions on the web.
);
testWidgets('Handles transitions when a non-default initial route is set', (WidgetTester tester) async {
await tester.pumpWidget(MaterialApp(
......
......@@ -60,7 +60,7 @@ void main() {
find.byType(ImageFiltered),
matchesGoldenFile('image_filter_matrix.png'),
);
}, skip: isBrowser); // https://github.com/flutter/flutter/issues/45213
});
testWidgets('Image filter - reuses its layer', (WidgetTester tester) async {
Future<void> pumpWithSigma(double sigma) async {
......
......@@ -1731,7 +1731,7 @@ void main() {
await _testRotatedImage(tester, true);
await _testRotatedImage(tester, false);
},
skip: kIsWeb, // https://github.com/flutter/flutter/issues/54292.
skip: kIsWeb, // https://github.com/flutter/flutter/issues/87933.
);
testWidgets(
......@@ -1782,7 +1782,7 @@ void main() {
matchesGoldenFile('transparent_image.png'),
);
},
skip: kIsWeb, // https://github.com/flutter/flutter/issues/54292.
skip: kIsWeb, // https://github.com/flutter/flutter/issues/87933.
);
testWidgets('Reports image size when painted', (WidgetTester tester) async {
......@@ -1865,7 +1865,7 @@ void main() {
// Image cache listener go away and Image stream listeners go away.
// Image is now at zero.
expect(image.debugGetOpenHandleStackTraces()!.length, 0);
}, skip: kIsWeb); // Web does not care about image handle/disposal.
}, skip: kIsWeb); // https://github.com/flutter/flutter/issues/87442
testWidgets('Keeps stream alive when ticker mode is disabled', (WidgetTester tester) async {
imageCache!.maximumSize = 0;
......
......@@ -532,6 +532,6 @@ void main() {
' constraints: BoxConstraints(w=800.0, h=400.0)\n'
' size: Size(800.0, 400.0)\n',
));
}, skip: kIsWeb);
}, skip: kIsWeb); // https://github.com/flutter/flutter/issues/87876
}
......@@ -40,7 +40,7 @@ void main() {
await tester.pumpWidget(Container());
focusNode.dispose();
}, skip: isBrowser); // This is a Fuchsia-specific test.
}, skip: isBrowser); // [intended] This is a Fuchsia-specific test.
testWidgets('Web key event', (WidgetTester tester) async {
final List<KeyEvent> events = <KeyEvent>[];
......
......@@ -310,7 +310,7 @@ void main() {
expect(log, equals(<String>['left']));
await gesture.up();
expect(log, equals(<String>['left']));
}, skip: true); // https://github.com/flutter/flutter/issues/4771
});
testWidgets('popAndPushNamed', (WidgetTester tester) async {
final Map<String, WidgetBuilder> routes = <String, WidgetBuilder>{
......
......@@ -190,5 +190,5 @@ void main() {
// empty opacity layer is sent.
final OffsetLayer offsetLayer = element.renderObject!.debugLayer! as OffsetLayer;
await offsetLayer.toImage(const Rect.fromLTRB(0.0, 0.0, 1.0, 1.0));
}, skip: isBrowser); // https://github.com/flutter/flutter/issues/42767
}, skip: isBrowser); // https://github.com/flutter/flutter/issues/49857
}
......@@ -197,7 +197,7 @@ void main() {
settingsOffset = tester.getTopLeft(find.text('Settings'));
expect(settingsOffset.dx, greaterThan(100.0));
expect(settingsOffset.dy, 100.0);
}, variant: TargetPlatformVariant.only(TargetPlatform.iOS), skip: kIsWeb);
}, variant: TargetPlatformVariant.only(TargetPlatform.iOS), skip: kIsWeb); // [intended] no default transitions on web.
testWidgets("Check back gesture doesn't start during transitions", (WidgetTester tester) async {
final GlobalKey containerKey1 = GlobalKey();
......@@ -240,7 +240,7 @@ void main() {
expect(find.text('Home'), isOnstage);
expect(find.text('Settings'), findsNothing);
}, variant: TargetPlatformVariant.only(TargetPlatform.iOS), skip: kIsWeb);
}, variant: TargetPlatformVariant.only(TargetPlatform.iOS), skip: kIsWeb); // [intended] no default transitions on web.
// Tests bug https://github.com/flutter/flutter/issues/6451
testWidgets('Check back gesture with a persistent bottom sheet showing', (WidgetTester tester) async {
......@@ -294,7 +294,7 @@ void main() {
// Sheet did not call setState (since the gesture did nothing).
expect(sheet.setStateCalled, isFalse);
}, variant: TargetPlatformVariant.only(TargetPlatform.iOS), skip: kIsWeb);
}, variant: TargetPlatformVariant.only(TargetPlatform.iOS), skip: kIsWeb); // [intended] no default transitions on web.
testWidgets('Test completed future', (WidgetTester tester) async {
final Map<String, WidgetBuilder> routes = <String, WidgetBuilder>{
......
......@@ -44,7 +44,7 @@ void main() {
await tester.pumpWidget(Container());
focusNode.dispose();
}, skip: isBrowser); // This is a Fuchsia-specific test.
}, skip: isBrowser); // [intended] This is a Fuchsia-specific test.
testWidgets('Web key event', (WidgetTester tester) async {
final List<RawKeyEvent> events = <RawKeyEvent>[];
......
......@@ -185,7 +185,7 @@ void main() {
);
}
testWidgets('can use the desktop cut/copy/paste buttons on Mac', (WidgetTester tester) async {
testWidgets('can use the desktop cut/copy/paste buttons on desktop', (WidgetTester tester) async {
final TextEditingController controller = TextEditingController(
text: 'blah1 blah2',
);
......@@ -257,7 +257,7 @@ void main() {
expect(controller.text, ' blah2blah1');
expect(controller.selection, const TextSelection(baseOffset: 0, extentOffset: 0));
expect(find.byType(CupertinoButton), findsNothing);
}, variant: const TargetPlatformVariant(<TargetPlatform>{ TargetPlatform.macOS, TargetPlatform.windows, TargetPlatform.linux }), skip: kIsWeb);
}, variant: TargetPlatformVariant.desktop(), skip: kIsWeb); // [intended] toolbar is handled by the browser.
testWidgets('has expected defaults', (WidgetTester tester) async {
await tester.pumpWidget(
......
......@@ -164,7 +164,7 @@ void main() {
),
);
expect(tester.takeException(), null);
}, skip: isBrowser); // https://github.com/flutter/flutter/issues/42086
});
testWidgets('inline widgets hitTest works with ellipsis', (WidgetTester tester) async {
// Regression test for https://github.com/flutter/flutter/issues/68559
......@@ -200,7 +200,7 @@ void main() {
await tester.tap(find.byType(Text));
expect(tester.takeException(), null);
}, skip: isBrowser); // https://github.com/flutter/flutter/issues/42086
});
testWidgets('inline widgets works with textScaleFactor', (WidgetTester tester) async {
// Regression test for https://github.com/flutter/flutter/issues/59316
......@@ -262,7 +262,7 @@ void main() {
renderText = tester.renderObject(find.byKey(key));
// The RichText in the widget span should wrap into three lines.
expect(renderText.size.height, singleLineHeight * textScaleFactor * 3);
}, skip: isBrowser); // https://github.com/flutter/flutter/issues/42086
});
testWidgets('semanticsLabel can override text label', (WidgetTester tester) async {
final SemanticsTester semantics = SemanticsTester(tester);
......@@ -714,7 +714,7 @@ void main() {
),
);
semantics.dispose();
}, skip: isBrowser); // https://github.com/flutter/flutter/issues/42086
}, skip: isBrowser); // https://github.com/flutter/flutter/issues/62945
testWidgets('inline widgets semantic nodes scale', (WidgetTester tester) async {
final SemanticsTester semantics = SemanticsTester(tester);
......@@ -794,7 +794,7 @@ void main() {
),
);
semantics.dispose();
}, skip: isBrowser); // https://github.com/flutter/flutter/issues/42086
}, skip: isBrowser); // https://github.com/flutter/flutter/issues/62945
testWidgets('Overflow is clipping correctly - short text with overflow: clip', (WidgetTester tester) async {
await _pumpTextWidget(
......@@ -817,7 +817,7 @@ void main() {
find.byType(Text),
paints..clipRect(rect: const Rect.fromLTWH(0, 0, 50, 50)),
);
}, skip: isBrowser); // https://github.com/flutter/flutter/issues/33523
}, skip: isBrowser); // https://github.com/flutter/flutter/issues/87878
testWidgets('Overflow is clipping correctly - short text with overflow: ellipsis', (WidgetTester tester) async {
await _pumpTextWidget(
......@@ -1045,7 +1045,7 @@ void main() {
),
],
)));
}, semanticsEnabled: true, skip: isBrowser); // Browser semantics have different sizes.
}, semanticsEnabled: true, skip: isBrowser); // https://github.com/flutter/flutter/issues/87877
// Regression test for https://github.com/flutter/flutter/issues/69787
testWidgets('WidgetSpans with no semantic information are elided from semantics - case 2', (WidgetTester tester) async {
......@@ -1091,7 +1091,7 @@ void main() {
ignoreRect: true,
ignoreTransform: true,
));
}, semanticsEnabled: true, skip: isBrowser); // Browser does not support widget span.
}, semanticsEnabled: true, skip: isBrowser); // https://github.com/flutter/flutter/issues/87877
// Regression test for https://github.com/flutter/flutter/issues/69787
testWidgets('WidgetSpans with no semantic information are elided from semantics - case 3', (WidgetTester tester) async {
......@@ -1149,7 +1149,7 @@ void main() {
ignoreRect: true,
ignoreTransform: true,
));
}, semanticsEnabled: true, skip: isBrowser); // Browser does not support widget span.
}, semanticsEnabled: true, skip: isBrowser); // https://github.com/flutter/flutter/issues/87877
// Regression test for https://github.com/flutter/flutter/issues/69787
testWidgets('WidgetSpans with no semantic information are elided from semantics - case 4', (WidgetTester tester) async {
......@@ -1215,7 +1215,7 @@ void main() {
ignoreRect: true,
ignoreTransform: true,
));
}, semanticsEnabled: true, skip: isBrowser); // Browser does not support widget span
}, semanticsEnabled: true, skip: isBrowser); // https://github.com/flutter/flutter/issues/87877
testWidgets('RenderParagraph intrinsic width', (WidgetTester tester) async {
await tester.pumpWidget(
......
......@@ -386,7 +386,7 @@ void main() {
await expectLater(find.byType(RepaintBoundary).first, matchesReferenceImage(imageWithCompositing));
}
},
skip: isBrowser, // due to https://github.com/flutter/flutter/issues/42767
skip: isBrowser, // due to https://github.com/flutter/flutter/issues/49857
);
testWidgets('Transform.translate with FilterQuality produces filter layer', (WidgetTester tester) async {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment