Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
e1276657
Unverified
Commit
e1276657
authored
Aug 11, 2021
by
Kate Lovett
Committed by
GitHub
Aug 11, 2021
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Update MaterialScrollBehavior.buildScrollbar for horizontal axes (#87740)
parent
64009135
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
38 additions
and
10 deletions
+38
-10
app.dart
packages/flutter/lib/src/material/app.dart
+12
-3
tabs.dart
packages/flutter/lib/src/material/tabs.dart
+10
-7
scrollbar_test.dart
packages/flutter/test/material/scrollbar_test.dart
+16
-0
No files found.
packages/flutter/lib/src/material/app.dart
View file @
e1276657
...
@@ -693,8 +693,13 @@ class MaterialApp extends StatefulWidget {
...
@@ -693,8 +693,13 @@ class MaterialApp extends StatefulWidget {
/// [GlowingOverscrollIndicator] to [Scrollable] descendants when executing on
/// [GlowingOverscrollIndicator] to [Scrollable] descendants when executing on
/// [TargetPlatform.android] and [TargetPlatform.fuchsia].
/// [TargetPlatform.android] and [TargetPlatform.fuchsia].
///
///
/// When using the desktop platform, if the [Scrollable] widget scrolls in the
/// The [buildScrollbar] function is called by the [Scrollable] to wrap with a
/// [Axis.vertical], a [Scrollbar] is applied.
/// [Scrollbar] when appropriate. On all platforms, when the Scrollable [Axis] is
/// [Axis.horizontal], an always visible Scrollbar will be applied. This is
/// because horizontal [ScrollView]s have lower discoverability as scrollable
/// content. When the Axis is [Axis.vertical] a Scrollbar is applied on
/// desktop platforms. In this vertical case, [Scrollbar.isAlwaysShown] is not
/// set and will defer to the inherited [ScrollbarTheme].
///
///
/// See also:
/// See also:
///
///
...
@@ -716,7 +721,11 @@ class MaterialScrollBehavior extends ScrollBehavior {
...
@@ -716,7 +721,11 @@ class MaterialScrollBehavior extends ScrollBehavior {
// the base class as well.
// the base class as well.
switch
(
axisDirectionToAxis
(
details
.
direction
))
{
switch
(
axisDirectionToAxis
(
details
.
direction
))
{
case
Axis
.
horizontal
:
case
Axis
.
horizontal
:
return
child
;
return
Scrollbar
(
isAlwaysShown:
true
,
controller:
details
.
controller
,
child:
child
,
);
case
Axis
.
vertical
:
case
Axis
.
vertical
:
switch
(
getPlatform
(
context
))
{
switch
(
getPlatform
(
context
))
{
case
TargetPlatform
.
linux
:
case
TargetPlatform
.
linux
:
...
...
packages/flutter/lib/src/material/tabs.dart
View file @
e1276657
...
@@ -1308,13 +1308,16 @@ class _TabBarState extends State<TabBar> {
...
@@ -1308,13 +1308,16 @@ class _TabBarState extends State<TabBar> {
if
(
widget
.
isScrollable
)
{
if
(
widget
.
isScrollable
)
{
_scrollController
??=
_TabBarScrollController
(
this
);
_scrollController
??=
_TabBarScrollController
(
this
);
tabBar
=
SingleChildScrollView
(
tabBar
=
ScrollConfiguration
(
dragStartBehavior:
widget
.
dragStartBehavior
,
behavior:
ScrollConfiguration
.
of
(
context
).
copyWith
(
scrollbars:
false
),
scrollDirection:
Axis
.
horizontal
,
child:
SingleChildScrollView
(
controller:
_scrollController
,
dragStartBehavior:
widget
.
dragStartBehavior
,
padding:
widget
.
padding
,
scrollDirection:
Axis
.
horizontal
,
physics:
widget
.
physics
,
controller:
_scrollController
,
child:
tabBar
,
padding:
widget
.
padding
,
physics:
widget
.
physics
,
child:
tabBar
,
),
);
);
}
else
if
(
widget
.
padding
!=
null
)
{
}
else
if
(
widget
.
padding
!=
null
)
{
tabBar
=
Padding
(
tabBar
=
Padding
(
...
...
packages/flutter/test/material/scrollbar_test.dart
View file @
e1276657
...
@@ -1557,4 +1557,20 @@ void main() {
...
@@ -1557,4 +1557,20 @@ void main() {
),
),
);
);
});
});
testWidgets
(
'MaterialScrollBehavior applies always shown Scrollbar to horizontal scrollables'
,
(
WidgetTester
tester
)
async
{
final
ScrollController
controller
=
ScrollController
();
await
tester
.
pumpWidget
(
MaterialApp
(
home:
SingleChildScrollView
(
scrollDirection:
Axis
.
horizontal
,
controller:
controller
,
child:
const
SizedBox
(
width:
4000.0
,
height:
4000.0
,
),
),
));
await
tester
.
pumpAndSettle
();
expect
(
find
.
byType
(
Scrollbar
),
paints
..
rect
());
});
}
}
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment