Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
dffbfebb
Unverified
Commit
dffbfebb
authored
Mar 19, 2019
by
Shi-Hao Hong
Committed by
GitHub
Mar 19, 2019
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
added friendlier error for invalid AndroidManifest.xml (#29604)
parent
8707f1f3
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
15 additions
and
1 deletion
+15
-1
application_package.dart
packages/flutter_tools/lib/src/application_package.dart
+15
-1
No files found.
packages/flutter_tools/lib/src/application_package.dart
View file @
dffbfebb
...
...
@@ -10,6 +10,7 @@ import 'package:xml/xml.dart' as xml;
import
'android/android_sdk.dart'
;
import
'android/gradle.dart'
;
import
'base/common.dart'
;
import
'base/context.dart'
;
import
'base/file_system.dart'
;
import
'base/os.dart'
show
os
;
...
...
@@ -161,7 +162,20 @@ class AndroidApk extends ApplicationPackage {
return
null
;
final
String
manifestString
=
manifest
.
readAsStringSync
();
final
xml
.
XmlDocument
document
=
xml
.
parse
(
manifestString
);
xml
.
XmlDocument
document
;
try
{
document
=
xml
.
parse
(
manifestString
);
}
on
xml
.
XmlParserException
catch
(
exception
)
{
String
manifestLocation
;
if
(
androidProject
.
isUsingGradle
)
{
manifestLocation
=
fs
.
path
.
join
(
androidProject
.
hostAppGradleRoot
.
path
,
'app'
,
'src'
,
'main'
,
'AndroidManifest.xml'
);
}
else
{
manifestLocation
=
fs
.
path
.
join
(
androidProject
.
hostAppGradleRoot
.
path
,
'AndroidManifest.xml'
);
}
printError
(
'AndroidManifest.xml is not a valid XML document.'
);
printError
(
'Please check
$manifestLocation
for errors.'
);
throwToolExit
(
'XML Parser error message:
${exception.toString()}
'
);
}
final
Iterable
<
xml
.
XmlElement
>
manifests
=
document
.
findElements
(
'manifest'
);
if
(
manifests
.
isEmpty
)
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment