Unverified Commit db5711bf authored by Ian Hickson's avatar Ian Hickson Committed by GitHub

remove obsolete todo in doubleClamp lint (#122745)

remove obsolete todo in doubleClamp lint
parent 80d6c105
......@@ -220,11 +220,11 @@ Future<void> run(List<String> arguments) async {
FeatureSet _parsingFeatureSet() => FeatureSet.latestLanguageVersion();
_Line _getLine(ParseStringResult parseResult, int offset) {
final int lineNumber =
parseResult.lineInfo.getLocation(offset).lineNumber;
final int lineNumber = parseResult.lineInfo.getLocation(offset).lineNumber;
final String content = parseResult.content.substring(
parseResult.lineInfo.getOffsetOfLine(lineNumber - 1),
parseResult.lineInfo.getOffsetOfLine(lineNumber) - 1);
parseResult.lineInfo.getOffsetOfLine(lineNumber) - 1,
);
return _Line(lineNumber, content);
}
......@@ -264,7 +264,6 @@ Future<void> verifyNoDoubleClamp(String workingDirectory) async {
_allFiles(flutterLibPath, 'dart', minimumMatches: 100);
final List<String> errors = <String>[];
await for (final File file in testFiles) {
try {
final ParseStringResult parseResult = parseFile(
featureSet: _parsingFeatureSet(),
path: file.absolute.path,
......@@ -272,19 +271,14 @@ Future<void> verifyNoDoubleClamp(String workingDirectory) async {
final _DoubleClampVisitor visitor = _DoubleClampVisitor(parseResult);
visitor.visitCompilationUnit(parseResult.unit);
for (final _Line clamp in visitor.clamps) {
errors.add('${file.path}:${clamp.line}: `clamp` method used without ignore_clamp_double_lint comment.');
}
} catch (ex) {
// TODO(gaaclarke): There is a bug with super parameter parsing on mac so
// we skip certain files until that is fixed.
// https://github.com/dart-lang/sdk/issues/49032
print('skipping ${file.path}: $ex');
errors.add('${file.path}:${clamp.line}: `clamp` method used instead of `clampDouble`.');
}
}
if (errors.isNotEmpty) {
foundError(<String>[
...errors,
'\n${bold}See: https://github.com/flutter/flutter/pull/103559',
'\n${bold}For performance reasons, we use a custom `clampDouble` function instead of using `Double.clamp`.$reset',
'\n${bold}For non-double uses of `clamp`, use `// ignore_clamp_double_lint` on the line to silence this message.$reset',
]);
}
}
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment