Remove MockFlutterVersions (#77962)

packages/flutter_tools/test/commands.shard/hermetic/build_ios_framework_test.dart

@@ -12,7 +12,6 @@ import 'package:flutter_tools/src/build_system/build_system.dart';
 import 'package:flutter_tools/src/cache.dart';
 import 'package:flutter_tools/src/commands/build_ios_framework.dart';
 import 'package:flutter_tools/src/version.dart';
-import 'package:mockito/mockito.dart';
 
 import '../../src/common.dart';
 import '../../src/context.dart';
@@ -21,8 +20,6 @@ import '../../src/fakes.dart';
 void main() {
   group('build ios-framework', () {
     MemoryFileSystem memoryFileSystem;
-    MockFlutterVersion mockFlutterVersion;
-    MockGitTagVersion mockGitTagVersion;
     Directory outputDirectory;
     FakePlatform fakePlatform;
 
@@ -33,8 +30,6 @@ void main() {
     const String storageBaseUrl = 'https://fake.googleapis.com';
     setUp(() {
       memoryFileSystem = MemoryFileSystem.test();
-      mockFlutterVersion = MockFlutterVersion();
-      mockGitTagVersion = MockGitTagVersion();
       fakePlatform = FakePlatform(
         operatingSystem: 'macos',
         environment: <String, String>{
@@ -42,7 +37,6 @@ void main() {
         },
       );
 
-      when(mockFlutterVersion.gitTagVersion).thenReturn(mockGitTagVersion);
       outputDirectory = memoryFileSystem.systemTempDirectory
           .createTempSync('flutter_build_ios_framework_test_output.')
           .childDirectory('Debug')
@@ -63,17 +57,16 @@ void main() {
         rootOverride.childDirectory('bin').childDirectory('internal').childFile('engine.version')
           ..createSync(recursive: true)
           ..writeAsStringSync(engineRevision);
-        when(mockFlutterVersion.gitTagVersion).thenReturn(mockGitTagVersion);
       });
 
       testUsingContext('version unknown', () async {
         const String frameworkVersion = '0.0.0-unknown';
-        when(mockFlutterVersion.frameworkVersion).thenReturn(frameworkVersion);
+        final FakeFlutterVersion fakeFlutterVersion = FakeFlutterVersion(frameworkVersion: frameworkVersion);
 
         final BuildIOSFrameworkCommand command = BuildIOSFrameworkCommand(
           buildSystem: TestBuildSystem.all(BuildResult(success: true)),
           platform: fakePlatform,
-          flutterVersion: mockFlutterVersion,
+          flutterVersion: fakeFlutterVersion,
           cache: cache,
           verboseHelp: false,
         );
@@ -87,18 +80,22 @@ void main() {
 
       testUsingContext('throws when not on a released version', () async {
         const String frameworkVersion = 'v1.13.10+hotfix-pre.2';
-        when(mockFlutterVersion.frameworkVersion).thenReturn(frameworkVersion);
-
-        when(mockGitTagVersion.x).thenReturn(1);
-        when(mockGitTagVersion.y).thenReturn(13);
-        when(mockGitTagVersion.z).thenReturn(10);
-        when(mockGitTagVersion.hotfix).thenReturn(13);
-        when(mockGitTagVersion.commits).thenReturn(2);
+        const GitTagVersion gitTagVersion = GitTagVersion(
+          x: 1,
+          y: 13,
+          z: 10,
+          hotfix: 13,
+          commits: 2,
+        );
+        final FakeFlutterVersion fakeFlutterVersion = FakeFlutterVersion(
+          gitTagVersion: gitTagVersion,
+          frameworkVersion: frameworkVersion,
+        );
 
         final BuildIOSFrameworkCommand command = BuildIOSFrameworkCommand(
           buildSystem: TestBuildSystem.all(BuildResult(success: true)),
           platform: fakePlatform,
-          flutterVersion: mockFlutterVersion,
+          flutterVersion: fakeFlutterVersion,
           cache: cache,
           verboseHelp: false,
         );
@@ -111,16 +108,20 @@ void main() {
       });
 
       testUsingContext('throws when license not found', () async {
-        when(mockGitTagVersion.x).thenReturn(1);
-        when(mockGitTagVersion.y).thenReturn(13);
-        when(mockGitTagVersion.z).thenReturn(10);
-        when(mockGitTagVersion.hotfix).thenReturn(13);
-        when(mockGitTagVersion.commits).thenReturn(0);
+        final FakeFlutterVersion fakeFlutterVersion = FakeFlutterVersion(
+          gitTagVersion: const GitTagVersion(
+            x: 1,
+            y: 13,
+            z: 10,
+            hotfix: 13,
+            commits: 0,
+          ),
+        );
 
         final BuildIOSFrameworkCommand command = BuildIOSFrameworkCommand(
           buildSystem: TestBuildSystem.all(BuildResult(success: true)),
           platform: fakePlatform,
-          flutterVersion: mockFlutterVersion,
+          flutterVersion: fakeFlutterVersion,
           cache: cache,
           verboseHelp: false,
         );
@@ -137,28 +138,29 @@ void main() {
         const String licenseText = 'This is the license!';
 
         setUp(() {
-          when(mockGitTagVersion.x).thenReturn(1);
-          when(mockGitTagVersion.y).thenReturn(13);
-          when(mockGitTagVersion.z).thenReturn(11);
-          when(mockGitTagVersion.hotfix).thenReturn(13);
-
-          when(mockFlutterVersion.frameworkVersion).thenReturn(frameworkVersion);
-
           cache.getLicenseFile()
             ..createSync(recursive: true)
             ..writeAsStringSync(licenseText);
         });
 
         group('on master channel', () {
-          setUp(() {
-            when(mockGitTagVersion.commits).thenReturn(100);
-          });
-
           testUsingContext('created when forced', () async {
+            const GitTagVersion gitTagVersion = GitTagVersion(
+              x: 1,
+              y: 13,
+              z: 11,
+              hotfix: 13,
+              commits: 100,
+            );
+            final FakeFlutterVersion fakeFlutterVersion = FakeFlutterVersion(
+              gitTagVersion: gitTagVersion,
+              frameworkVersion: frameworkVersion,
+            );
+
             final BuildIOSFrameworkCommand command = BuildIOSFrameworkCommand(
               buildSystem: TestBuildSystem.all(BuildResult(success: true)),
               platform: fakePlatform,
-              flutterVersion: mockFlutterVersion,
+              flutterVersion: fakeFlutterVersion,
               cache: cache,
               verboseHelp: false,
             );
@@ -173,15 +175,26 @@ void main() {
         });
 
         group('not on master channel', () {
+          FakeFlutterVersion fakeFlutterVersion;
           setUp(() {
-            when(mockGitTagVersion.commits).thenReturn(0);
+            const GitTagVersion gitTagVersion = GitTagVersion(
+              x: 1,
+              y: 13,
+              z: 11,
+              hotfix: 13,
+              commits: 0,
+            );
+            fakeFlutterVersion = FakeFlutterVersion(
+              gitTagVersion: gitTagVersion,
+              frameworkVersion: frameworkVersion,
+            );
           });
 
           testUsingContext('contains license and version', () async {
             final BuildIOSFrameworkCommand command = BuildIOSFrameworkCommand(
               buildSystem: TestBuildSystem.all(BuildResult(success: true)),
               platform: fakePlatform,
-              flutterVersion: mockFlutterVersion,
+              flutterVersion: fakeFlutterVersion,
               cache: cache,
               verboseHelp: false,
             );
@@ -201,7 +214,7 @@ void main() {
             final BuildIOSFrameworkCommand command = BuildIOSFrameworkCommand(
               buildSystem: TestBuildSystem.all(BuildResult(success: true)),
               platform: fakePlatform,
-              flutterVersion: mockFlutterVersion,
+              flutterVersion: fakeFlutterVersion,
               cache: cache,
               verboseHelp: false,
             );
@@ -219,7 +232,7 @@ void main() {
             final BuildIOSFrameworkCommand command = BuildIOSFrameworkCommand(
               buildSystem: TestBuildSystem.all(BuildResult(success: true)),
               platform: fakePlatform,
-              flutterVersion: mockFlutterVersion,
+              flutterVersion: fakeFlutterVersion,
               cache: cache,
               verboseHelp: false,
             );
@@ -237,7 +250,7 @@ void main() {
             final BuildIOSFrameworkCommand command = BuildIOSFrameworkCommand(
               buildSystem: TestBuildSystem.all(BuildResult(success: true)),
               platform: fakePlatform,
-              flutterVersion: mockFlutterVersion,
+              flutterVersion: fakeFlutterVersion,
               cache: cache,
               verboseHelp: false,
             );
@@ -255,6 +268,3 @@ void main() {
     });
   });
 }
-
-class MockFlutterVersion extends Mock implements FlutterVersion {}
-class MockGitTagVersion extends Mock implements GitTagVersion {}

packages/flutter_tools/test/general.shard/flutter_platform_test.dart

@@ -10,7 +10,7 @@ import 'package:flutter_tools/src/base/io.dart';
 import 'package:flutter_tools/src/build_info.dart';
 import 'package:flutter_tools/src/device.dart';
 import 'package:flutter_tools/src/test/flutter_platform.dart';
-import 'package:mockito/mockito.dart';
+import 'package:test/fake.dart';
 import 'package:test_core/backend.dart'; // ignore: deprecated_member_use
 
 import '../src/common.dart';
@@ -38,9 +38,9 @@ void main() {
         ),
         enableObservatory: false,
       );
-      flutterPlatform.loadChannel('test1.dart', MockSuitePlatform());
+      flutterPlatform.loadChannel('test1.dart', FakeSuitePlatform());
 
-      expect(() => flutterPlatform.loadChannel('test2.dart', MockSuitePlatform()), throwsToolExit());
+      expect(() => flutterPlatform.loadChannel('test2.dart', FakeSuitePlatform()), throwsToolExit());
     }, overrides: <Type, Generator>{
       FileSystem: () => fileSystem,
       ProcessManager: () => FakeProcessManager.any(),
@@ -54,9 +54,9 @@ void main() {
         precompiledDillPath: 'example.dill',
         enableObservatory: false,
       );
-      flutterPlatform.loadChannel('test1.dart', MockSuitePlatform());
+      flutterPlatform.loadChannel('test1.dart', FakeSuitePlatform());
 
-      expect(() => flutterPlatform.loadChannel('test2.dart', MockSuitePlatform()), throwsToolExit());
+      expect(() => flutterPlatform.loadChannel('test2.dart', FakeSuitePlatform()), throwsToolExit());
     }, overrides: <Type, Generator>{
       FileSystem: () => fileSystem,
       ProcessManager: () => FakeProcessManager.any(),
@@ -122,7 +122,7 @@ void main() {
   });
 }
 
-class MockSuitePlatform extends Mock implements SuitePlatform {}
+class FakeSuitePlatform extends Fake implements SuitePlatform {}
 
 // A FlutterPlatform with enough fields set to load and start a test.
 class TestFlutterPlatform extends FlutterPlatform {

packages/flutter_tools/test/general.shard/runner/flutter_command_test.dart

@@ -19,7 +19,6 @@ import 'package:flutter_tools/src/cache.dart';
 import 'package:flutter_tools/src/dart/pub.dart';
 import 'package:flutter_tools/src/reporting/reporting.dart';
 import 'package:flutter_tools/src/runner/flutter_command.dart';
-import 'package:flutter_tools/src/version.dart';
 import 'package:flutter_tools/src/globals.dart' as globals;
 import 'package:mockito/mockito.dart';
 
@@ -624,7 +623,6 @@ class FakeReportingNullSafetyCommand extends FlutterCommand {
   }
 }
 
-class MockVersion extends Mock implements FlutterVersion {}
 class MockProcessInfo extends Mock implements ProcessInfo {}
 class MockIoProcessSignal extends Mock implements io.ProcessSignal {}
 

packages/flutter_tools/test/src/fakes.dart

@@ -458,7 +458,8 @@ class FakeFlutterVersion implements FlutterVersion {
     this.frameworkRevision = '11111111111111111111',
     this.frameworkRevisionShort = '11111',
     this.frameworkAge = '0 hours ago',
-    this.frameworkCommitDate = '12/01/01'
+    this.frameworkCommitDate = '12/01/01',
+    this.gitTagVersion = const GitTagVersion.unknown(),
   });
 
   bool get didFetchTagsAndUpdate => _didFetchTagsAndUpdate;
@@ -500,6 +501,9 @@ class FakeFlutterVersion implements FlutterVersion {
   @override
   String get frameworkDate => frameworkCommitDate;
 
+  @override
+  final GitTagVersion gitTagVersion;
+
   @override
   void fetchTagsAndUpdate() {
     _didFetchTagsAndUpdate = true;
@@ -515,11 +519,6 @@ class FakeFlutterVersion implements FlutterVersion {
     throw UnimplementedError();
   }
 
-  @override
-  GitTagVersion get gitTagVersion {
-    throw UnimplementedError();
-  }
-
   @override
   Future<void> ensureVersionFile() async { }