Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
d637b187
Unverified
Commit
d637b187
authored
Mar 12, 2021
by
Michael Goderbauer
Committed by
GitHub
Mar 12, 2021
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
non-breaking changes for prefer_mixin lint (#77837)
parent
fa06b340
Changes
9
Show whitespace changes
Inline
Side-by-side
Showing
9 changed files
with
13 additions
and
14 deletions
+13
-14
transformations_demo_board.dart
.../lib/demo/transformations/transformations_demo_board.dart
+1
-1
slider_theme.dart
packages/flutter/lib/src/material/slider_theme.dart
+1
-1
sliver.dart
packages/flutter/lib/src/rendering/sliver.dart
+1
-2
raw_keyboard_linux.dart
packages/flutter/lib/src/services/raw_keyboard_linux.dart
+2
-2
text_input.dart
packages/flutter/lib/src/services/text_input.dart
+2
-2
scroll_metrics.dart
packages/flutter/lib/src/widgets/scroll_metrics.dart
+2
-2
editable_gesture_test.dart
packages/flutter/test/rendering/editable_gesture_test.dart
+1
-1
automatic_keep_alive_test.dart
packages/flutter/test/widgets/automatic_keep_alive_test.dart
+1
-1
_goldens_io.dart
packages/flutter_test/lib/src/_goldens_io.dart
+2
-2
No files found.
dev/integration_tests/flutter_gallery/lib/demo/transformations/transformations_demo_board.dart
View file @
d637b187
...
@@ -11,7 +11,7 @@ import 'package:vector_math/vector_math_64.dart' show Vector3;
...
@@ -11,7 +11,7 @@ import 'package:vector_math/vector_math_64.dart' show Vector3;
// The entire state of the hex board and abstraction to get information about
// The entire state of the hex board and abstraction to get information about
// it. Iterable so that all BoardPoints on the board can be iterated over.
// it. Iterable so that all BoardPoints on the board can be iterated over.
@immutable
@immutable
class
Board
extends
Object
with
IterableMixin
<
BoardPoint
?>
{
class
Board
extends
IterableMixin
<
BoardPoint
?>
{
Board
({
Board
({
required
this
.
boardRadius
,
required
this
.
boardRadius
,
required
this
.
hexagonRadius
,
required
this
.
hexagonRadius
,
...
...
packages/flutter/lib/src/material/slider_theme.dart
View file @
d637b187
...
@@ -1427,7 +1427,7 @@ abstract class RangeSliderTrackShape {
...
@@ -1427,7 +1427,7 @@ abstract class RangeSliderTrackShape {
/// rectangular edges
/// rectangular edges
/// * [RoundedRectSliderTrackShape], which is a track shape with round
/// * [RoundedRectSliderTrackShape], which is a track shape with round
/// stadium-like edges.
/// stadium-like edges.
abstract
class
BaseSliderTrackShape
{
mixin
BaseSliderTrackShape
{
/// Returns a rect that represents the track bounds that fits within the
/// Returns a rect that represents the track bounds that fits within the
/// [Slider].
/// [Slider].
///
///
...
...
packages/flutter/lib/src/rendering/sliver.dart
View file @
d637b187
...
@@ -1596,8 +1596,7 @@ abstract class RenderSliver extends RenderObject {
...
@@ -1596,8 +1596,7 @@ abstract class RenderSliver extends RenderObject {
}
}
/// Mixin for [RenderSliver] subclasses that provides some utility functions.
/// Mixin for [RenderSliver] subclasses that provides some utility functions.
abstract
class
RenderSliverHelpers
implements
RenderSliver
{
mixin
RenderSliverHelpers
implements
RenderSliver
{
bool
_getRightWayUp
(
SliverConstraints
constraints
)
{
bool
_getRightWayUp
(
SliverConstraints
constraints
)
{
assert
(
constraints
!=
null
);
assert
(
constraints
!=
null
);
assert
(
constraints
.
axisDirection
!=
null
);
assert
(
constraints
.
axisDirection
!=
null
);
...
...
packages/flutter/lib/src/services/raw_keyboard_linux.dart
View file @
d637b187
...
@@ -167,7 +167,7 @@ abstract class KeyHelper {
...
@@ -167,7 +167,7 @@ abstract class KeyHelper {
}
}
/// Helper class that uses GLFW-specific key mappings.
/// Helper class that uses GLFW-specific key mappings.
class
GLFWKeyHelper
with
KeyHelper
{
class
GLFWKeyHelper
implements
KeyHelper
{
/// This mask is used to check the [RawKeyEventDataLinux.modifiers] field to
/// This mask is used to check the [RawKeyEventDataLinux.modifiers] field to
/// test whether the CAPS LOCK modifier key is on.
/// test whether the CAPS LOCK modifier key is on.
///
///
...
@@ -304,7 +304,7 @@ class GLFWKeyHelper with KeyHelper {
...
@@ -304,7 +304,7 @@ class GLFWKeyHelper with KeyHelper {
}
}
/// Helper class that uses GTK-specific key mappings.
/// Helper class that uses GTK-specific key mappings.
class
GtkKeyHelper
with
KeyHelper
{
class
GtkKeyHelper
implements
KeyHelper
{
/// This mask is used to check the [RawKeyEventDataLinux.modifiers] field to
/// This mask is used to check the [RawKeyEventDataLinux.modifiers] field to
/// test whether one of the SHIFT modifier keys is pressed.
/// test whether one of the SHIFT modifier keys is pressed.
///
///
...
...
packages/flutter/lib/src/services/text_input.dart
View file @
d637b187
...
@@ -791,9 +791,9 @@ enum SelectionChangedCause {
...
@@ -791,9 +791,9 @@ enum SelectionChangedCause {
drag
,
drag
,
}
}
/// A
n interface
for manipulating the selection, to be used by the implementer
/// A
mixin
for manipulating the selection, to be used by the implementer
/// of the toolbar widget.
/// of the toolbar widget.
abstract
class
TextSelectionDelegate
{
mixin
TextSelectionDelegate
{
/// Gets the current text input.
/// Gets the current text input.
TextEditingValue
get
textEditingValue
;
TextEditingValue
get
textEditingValue
;
...
...
packages/flutter/lib/src/widgets/scroll_metrics.dart
View file @
d637b187
...
@@ -31,7 +31,7 @@ import 'package:flutter/rendering.dart';
...
@@ -31,7 +31,7 @@ import 'package:flutter/rendering.dart';
///
///
/// * [FixedScrollMetrics], which is an immutable object that implements this
/// * [FixedScrollMetrics], which is an immutable object that implements this
/// interface.
/// interface.
abstract
class
ScrollMetrics
{
mixin
ScrollMetrics
{
/// Creates a [ScrollMetrics] that has the same properties as this object.
/// Creates a [ScrollMetrics] that has the same properties as this object.
///
///
/// This is useful if this object is mutable, but you want to get a snapshot
/// This is useful if this object is mutable, but you want to get a snapshot
...
@@ -129,7 +129,7 @@ abstract class ScrollMetrics {
...
@@ -129,7 +129,7 @@ abstract class ScrollMetrics {
/// An immutable snapshot of values associated with a [Scrollable] viewport.
/// An immutable snapshot of values associated with a [Scrollable] viewport.
///
///
/// For details, see [ScrollMetrics], which defines this object's interfaces.
/// For details, see [ScrollMetrics], which defines this object's interfaces.
class
FixedScrollMetrics
extends
ScrollMetrics
{
class
FixedScrollMetrics
with
ScrollMetrics
{
/// Creates an immutable snapshot of values associated with a [Scrollable] viewport.
/// Creates an immutable snapshot of values associated with a [Scrollable] viewport.
FixedScrollMetrics
({
FixedScrollMetrics
({
required
double
?
minScrollExtent
,
required
double
?
minScrollExtent
,
...
...
packages/flutter/test/rendering/editable_gesture_test.dart
View file @
d637b187
...
@@ -54,7 +54,7 @@ class _GestureBindingSpy extends AutomatedTestWidgetsFlutterBinding {
...
@@ -54,7 +54,7 @@ class _GestureBindingSpy extends AutomatedTestWidgetsFlutterBinding {
PointerRouter
get
pointerRouter
=>
_testPointerRouter
;
PointerRouter
get
pointerRouter
=>
_testPointerRouter
;
}
}
class
FakeEditableTextState
extends
TextSelectionDelegate
with
Fake
{
}
class
FakeEditableTextState
extends
Fake
implements
TextSelectionDelegate
{
}
class
_PointerRouterSpy
extends
PointerRouter
{
class
_PointerRouterSpy
extends
PointerRouter
{
int
routeCount
=
0
;
int
routeCount
=
0
;
...
...
packages/flutter/test/widgets/automatic_keep_alive_test.dart
View file @
d637b187
...
@@ -598,7 +598,7 @@ class AlwaysKeepAliveRenderBoxState extends State<_AlwaysKeepAlive> with Automat
...
@@ -598,7 +598,7 @@ class AlwaysKeepAliveRenderBoxState extends State<_AlwaysKeepAlive> with Automat
}
}
}
}
abstract
class
KeepAliveParentDataMixinAlt
implements
KeepAliveParentDataMixin
{
mixin
KeepAliveParentDataMixinAlt
implements
KeepAliveParentDataMixin
{
@override
@override
bool
keptAlive
=
false
;
bool
keptAlive
=
false
;
...
...
packages/flutter_test/lib/src/_goldens_io.dart
View file @
d637b187
...
@@ -128,9 +128,9 @@ class LocalFileComparator extends GoldenFileComparator with LocalComparisonOutpu
...
@@ -128,9 +128,9 @@ class LocalFileComparator extends GoldenFileComparator with LocalComparisonOutpu
File
_getGoldenFile
(
Uri
golden
)
=>
File
(
_path
.
join
(
_path
.
fromUri
(
basedir
),
_path
.
fromUri
(
golden
.
path
)));
File
_getGoldenFile
(
Uri
golden
)
=>
File
(
_path
.
join
(
_path
.
fromUri
(
basedir
),
_path
.
fromUri
(
golden
.
path
)));
}
}
/// A
class
for use in golden file comparators that run locally and provide
/// A
mixin
for use in golden file comparators that run locally and provide
/// output.
/// output.
class
LocalComparisonOutput
{
mixin
LocalComparisonOutput
{
/// Writes out diffs from the [ComparisonResult] of a golden file test.
/// Writes out diffs from the [ComparisonResult] of a golden file test.
///
///
/// Will throw an error if a null result is provided.
/// Will throw an error if a null result is provided.
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment