Commit d5f31689 authored by Adam Barth's avatar Adam Barth

Merge pull request #192 from abarth/fix_warnings

Fix analyzer warnings
parents 4a0bdf1b 3ac4c6c9
...@@ -14,7 +14,6 @@ import 'package:sky/widgets/drawer_item.dart'; ...@@ -14,7 +14,6 @@ import 'package:sky/widgets/drawer_item.dart';
import 'package:sky/widgets/floating_action_button.dart'; import 'package:sky/widgets/floating_action_button.dart';
import 'package:sky/widgets/icon_button.dart'; import 'package:sky/widgets/icon_button.dart';
import 'package:sky/widgets/icon.dart'; import 'package:sky/widgets/icon.dart';
import 'package:sky/widgets/ink_well.dart';
import 'package:sky/widgets/material.dart'; import 'package:sky/widgets/material.dart';
import 'package:sky/widgets/navigator.dart'; import 'package:sky/widgets/navigator.dart';
import 'package:sky/widgets/scaffold.dart'; import 'package:sky/widgets/scaffold.dart';
......
...@@ -4,7 +4,6 @@ ...@@ -4,7 +4,6 @@
import 'package:sky/editing/input.dart'; import 'package:sky/editing/input.dart';
import 'package:sky/widgets/basic.dart'; import 'package:sky/widgets/basic.dart';
import 'package:sky/widgets/flat_button.dart';
import 'package:sky/widgets/icon_button.dart'; import 'package:sky/widgets/icon_button.dart';
import 'package:sky/widgets/ink_well.dart'; import 'package:sky/widgets/ink_well.dart';
import 'package:sky/widgets/material.dart'; import 'package:sky/widgets/material.dart';
......
...@@ -149,25 +149,26 @@ void doFrame(double timeStamp) { ...@@ -149,25 +149,26 @@ void doFrame(double timeStamp) {
} }
} else { } else {
assert(node is sky.Text); // assert(node is sky.Text); //
final sky.Text text = node;
if (pickThis(0.1)) { if (pickThis(0.1)) {
report("appending a new text node (ASCII)"); report("appending a new text node (ASCII)");
node.appendData(generateCharacter(0x20, 0x7F)); text.appendData(generateCharacter(0x20, 0x7F));
break; break;
} else if (pickThis(0.05)) { } else if (pickThis(0.05)) {
report("appending a new text node (Latin1)"); report("appending a new text node (Latin1)");
node.appendData(generateCharacter(0x20, 0xFF)); text.appendData(generateCharacter(0x20, 0xFF));
break; break;
} else if (pickThis(0.025)) { } else if (pickThis(0.025)) {
report("appending a new text node (BMP)"); report("appending a new text node (BMP)");
node.appendData(generateCharacter(0x20, 0xFFFF)); text.appendData(generateCharacter(0x20, 0xFFFF));
break; break;
} else if (pickThis(0.0125)) { } else if (pickThis(0.0125)) {
report("appending a new text node (Unicode)"); report("appending a new text node (Unicode)");
node.appendData(generateCharacter(0x20, 0x10FFFF)); text.appendData(generateCharacter(0x20, 0x10FFFF));
break; break;
} else if (node.length > 1 && pickThis(0.1)) { } else if (text.length > 1 && pickThis(0.1)) {
report("deleting character from Text node"); report("deleting character from Text node");
node.deleteData(random.nextInt(node.length), 1); text.deleteData(random.nextInt(text.length), 1);
break; break;
} }
} }
...@@ -178,7 +179,7 @@ void doFrame(double timeStamp) { ...@@ -178,7 +179,7 @@ void doFrame(double timeStamp) {
int count = 1; int count = 1;
while (node != null) { while (node != null) {
if (node is sky.Element && node.firstChild != null) { if (node is sky.Element && node.firstChild != null) {
node = node.firstChild; node = (node as sky.Element).firstChild;
count += 1; count += 1;
} else { } else {
while (node != null && node.nextSibling == null) while (node != null && node.nextSibling == null)
......
...@@ -20,7 +20,7 @@ void main() { ...@@ -20,7 +20,7 @@ void main() {
TextStyle style = const TextStyle(color: const Color(0xFF000000)); TextStyle style = const TextStyle(color: const Color(0xFF000000));
RenderParagraph paragraph = new RenderParagraph(new InlineStyle(style, [new InlineText("${alignItems}")])); RenderParagraph paragraph = new RenderParagraph(new InlineStyle(style, [new InlineText("${alignItems}")]));
table.add(new RenderPadding(child: paragraph, padding: new EdgeDims.only(top: 20.0))); table.add(new RenderPadding(child: paragraph, padding: new EdgeDims.only(top: 20.0)));
var row = new RenderFlex(alignItems: alignItems, baseline: TextBaseline.alphabetic); var row = new RenderFlex(alignItems: alignItems, textBaseline: TextBaseline.alphabetic);
style = new TextStyle(fontSize: 15.0, color: const Color(0xFF000000)); style = new TextStyle(fontSize: 15.0, color: const Color(0xFF000000));
row.add(new RenderDecoratedBox( row.add(new RenderDecoratedBox(
...@@ -32,7 +32,7 @@ void main() { ...@@ -32,7 +32,7 @@ void main() {
decoration: new BoxDecoration(backgroundColor: const Color(0x7FCCFFCC)), decoration: new BoxDecoration(backgroundColor: const Color(0x7FCCFFCC)),
child: new RenderParagraph(new InlineStyle(style, [new InlineText('foo foo foo')])) child: new RenderParagraph(new InlineStyle(style, [new InlineText('foo foo foo')]))
)); ));
var subrow = new RenderFlex(alignItems: alignItems, baseline: TextBaseline.alphabetic); var subrow = new RenderFlex(alignItems: alignItems, textBaseline: TextBaseline.alphabetic);
style = new TextStyle(fontSize: 25.0, color: const Color(0xFF000000)); style = new TextStyle(fontSize: 25.0, color: const Color(0xFF000000));
subrow.add(new RenderDecoratedBox( subrow.add(new RenderDecoratedBox(
decoration: new BoxDecoration(backgroundColor: const Color(0x7FCCCCFF)), decoration: new BoxDecoration(backgroundColor: const Color(0x7FCCCCFF)),
......
...@@ -45,7 +45,7 @@ class ShrinkingCard extends AnimatedComponent { ...@@ -45,7 +45,7 @@ class ShrinkingCard extends AnimatedComponent {
Function onUpdated; Function onUpdated;
Function onCompleted; Function onCompleted;
double get currentHeight => card.performance.variable.value; double get currentHeight => (card.performance.variable as AnimatedType).value;
void initState() { void initState() {
assert(card.performance != null); assert(card.performance != null);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment