Commit d59da41b authored by Adam Barth's avatar Adam Barth

Use parent consistently for parent animation

Some of the Animation classes that we converted from performances use
the term "master" to refer to the animation upon which they're based.
This patch changes them to use the term "parent", which is consistent
with the rest of the animation classes.
parent bdb52ce0
...@@ -64,8 +64,8 @@ abstract class ProxyAnimatedMixin { ...@@ -64,8 +64,8 @@ abstract class ProxyAnimatedMixin {
class ProxyAnimation extends Animation<double> class ProxyAnimation extends Animation<double>
with LazyListenerMixin, LocalPerformanceListenersMixin, LocalPerformanceStatusListenersMixin { with LazyListenerMixin, LocalPerformanceListenersMixin, LocalPerformanceStatusListenersMixin {
ProxyAnimation([Animation<double> animation]) { ProxyAnimation([Animation<double> animation]) {
_masterAnimation = animation; _parent = animation;
if (_masterAnimation == null) { if (_parent == null) {
_status = AnimationStatus.dismissed; _status = AnimationStatus.dismissed;
_direction = AnimationDirection.forward; _direction = AnimationDirection.forward;
_value = 0.0; _value = 0.0;
...@@ -76,26 +76,26 @@ class ProxyAnimation extends Animation<double> ...@@ -76,26 +76,26 @@ class ProxyAnimation extends Animation<double>
AnimationDirection _direction; AnimationDirection _direction;
double _value; double _value;
Animation<double> get masterAnimation => _masterAnimation; Animation<double> get parent => _parent;
Animation<double> _masterAnimation; Animation<double> _parent;
void set masterAnimation(Animation<double> value) { void set parent(Animation<double> value) {
if (value == _masterAnimation) if (value == _parent)
return; return;
if (_masterAnimation != null) { if (_parent != null) {
_status = _masterAnimation.status; _status = _parent.status;
_direction = _masterAnimation.direction; _direction = _parent.direction;
_value = _masterAnimation.value; _value = _parent.value;
if (isListening) if (isListening)
didStopListening(); didStopListening();
} }
_masterAnimation = value; _parent = value;
if (_masterAnimation != null) { if (_parent != null) {
if (isListening) if (isListening)
didStartListening(); didStartListening();
if (_value != _masterAnimation.value) if (_value != _parent.value)
notifyListeners(); notifyListeners();
if (_status != _masterAnimation.status) if (_status != _parent.status)
notifyStatusListeners(_masterAnimation.status); notifyStatusListeners(_parent.status);
_status = null; _status = null;
_direction = null; _direction = null;
_value = null; _value = null;
...@@ -103,54 +103,54 @@ class ProxyAnimation extends Animation<double> ...@@ -103,54 +103,54 @@ class ProxyAnimation extends Animation<double>
} }
void didStartListening() { void didStartListening() {
if (_masterAnimation != null) { if (_parent != null) {
_masterAnimation.addListener(notifyListeners); _parent.addListener(notifyListeners);
_masterAnimation.addStatusListener(notifyStatusListeners); _parent.addStatusListener(notifyStatusListeners);
} }
} }
void didStopListening() { void didStopListening() {
if (_masterAnimation != null) { if (_parent != null) {
_masterAnimation.removeListener(notifyListeners); _parent.removeListener(notifyListeners);
_masterAnimation.removeStatusListener(notifyStatusListeners); _parent.removeStatusListener(notifyStatusListeners);
} }
} }
AnimationStatus get status => _masterAnimation != null ? _masterAnimation.status : _status; AnimationStatus get status => _parent != null ? _parent.status : _status;
AnimationDirection get direction => _masterAnimation != null ? _masterAnimation.direction : _direction; AnimationDirection get direction => _parent != null ? _parent.direction : _direction;
double get value => _masterAnimation != null ? _masterAnimation.value : _value; double get value => _parent != null ? _parent.value : _value;
} }
class ReverseAnimation extends Animation<double> class ReverseAnimation extends Animation<double>
with LazyListenerMixin, LocalPerformanceStatusListenersMixin { with LazyListenerMixin, LocalPerformanceStatusListenersMixin {
ReverseAnimation(this.masterAnimation); ReverseAnimation(this.parent);
final Animation<double> masterAnimation; final Animation<double> parent;
void addListener(VoidCallback listener) { void addListener(VoidCallback listener) {
didRegisterListener(); didRegisterListener();
masterAnimation.addListener(listener); parent.addListener(listener);
} }
void removeListener(VoidCallback listener) { void removeListener(VoidCallback listener) {
masterAnimation.removeListener(listener); parent.removeListener(listener);
didUnregisterListener(); didUnregisterListener();
} }
void didStartListening() { void didStartListening() {
masterAnimation.addStatusListener(_statusChangeHandler); parent.addStatusListener(_statusChangeHandler);
} }
void didStopListening() { void didStopListening() {
masterAnimation.removeStatusListener(_statusChangeHandler); parent.removeStatusListener(_statusChangeHandler);
} }
void _statusChangeHandler(AnimationStatus status) { void _statusChangeHandler(AnimationStatus status) {
notifyStatusListeners(_reverseStatus(status)); notifyStatusListeners(_reverseStatus(status));
} }
AnimationStatus get status => _reverseStatus(masterAnimation.status); AnimationStatus get status => _reverseStatus(parent.status);
AnimationDirection get direction => _reverseDirection(masterAnimation.direction); AnimationDirection get direction => _reverseDirection(parent.direction);
double get value => 1.0 - masterAnimation.value; double get value => 1.0 - parent.value;
AnimationStatus _reverseStatus(AnimationStatus status) { AnimationStatus _reverseStatus(AnimationStatus status) {
switch (status) { switch (status) {
......
...@@ -177,7 +177,7 @@ abstract class TransitionRoute<T> extends OverlayRoute<T> { ...@@ -177,7 +177,7 @@ abstract class TransitionRoute<T> extends OverlayRoute<T> {
void _updateForwardAnimation(Route nextRoute) { void _updateForwardAnimation(Route nextRoute) {
if (nextRoute is TransitionRoute && canTransitionTo(nextRoute) && nextRoute.canTransitionFrom(this)) { if (nextRoute is TransitionRoute && canTransitionTo(nextRoute) && nextRoute.canTransitionFrom(this)) {
Animation<double> current = _forwardAnimation.masterAnimation; Animation<double> current = _forwardAnimation.parent;
if (current != null) { if (current != null) {
if (current is TrainHoppingAnimation) { if (current is TrainHoppingAnimation) {
TrainHoppingAnimation newAnimation; TrainHoppingAnimation newAnimation;
...@@ -185,22 +185,22 @@ abstract class TransitionRoute<T> extends OverlayRoute<T> { ...@@ -185,22 +185,22 @@ abstract class TransitionRoute<T> extends OverlayRoute<T> {
current.currentTrain, current.currentTrain,
nextRoute.animation, nextRoute.animation,
onSwitchedTrain: () { onSwitchedTrain: () {
assert(_forwardAnimation.masterAnimation == newAnimation); assert(_forwardAnimation.parent == newAnimation);
assert(newAnimation.currentTrain == nextRoute.animation); assert(newAnimation.currentTrain == nextRoute.animation);
_forwardAnimation.masterAnimation = newAnimation.currentTrain; _forwardAnimation.parent = newAnimation.currentTrain;
newAnimation.dispose(); newAnimation.dispose();
} }
); );
_forwardAnimation.masterAnimation = newAnimation; _forwardAnimation.parent = newAnimation;
current.dispose(); current.dispose();
} else { } else {
_forwardAnimation.masterAnimation = new TrainHoppingAnimation(current, nextRoute.animation); _forwardAnimation.parent = new TrainHoppingAnimation(current, nextRoute.animation);
} }
} else { } else {
_forwardAnimation.masterAnimation = nextRoute.animation; _forwardAnimation.parent = nextRoute.animation;
} }
} else { } else {
_forwardAnimation.masterAnimation = kAlwaysDismissedAnimation; _forwardAnimation.parent = kAlwaysDismissedAnimation;
} }
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment